71338 2011-11-01 16:40:21 -0700 Remove initErrorEvent method 2011-11-01 18:21:06 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 68791 1 dominicc dominicc abarth darin ojan webkit.review.bot oldest_to_newest 494297 0 dominicc 2011-11-01 16:40:21 -0700 Nobody uses this, so we should un-ship it. 494319 1 113260 dominicc 2011-11-01 17:08:04 -0700 Created attachment 113260 Patch 494327 2 113260 ojan 2011-11-01 17:14:52 -0700 Comment on attachment 113260 Patch Kill all the inits! 494331 3 darin 2011-11-01 17:15:34 -0700 (In reply to comment #0) > Nobody uses this, so we should un-ship it. How do we know nobody uses it? 494337 4 ojan 2011-11-01 17:20:12 -0700 (In reply to comment #3) > (In reply to comment #0) > > Nobody uses this, so we should un-ship it. > > How do we know nobody uses it? We don't know it definitively, but the init*event methods other than for mouse and key events are rarely used and they are being removed from the specs. I think there's a very low risk of sites depending on this. 494339 5 dominicc 2011-11-01 17:23:14 -0700 (In reply to comment #3) > How do we know nobody uses it? We think nobody uses it, because this search has no results: <http://codesearch.google.com/#search/&q=initErrorEvent%20lang:js&type=cs> And manually inspecting this broader set of search results didn't turn up any uses: <http://codesearch.google.com/#search/&q=initErrorEvent> Naturally this is not a 100% robust method for determining whether it is used. 494385 6 113260 webkit.review.bot 2011-11-01 18:21:01 -0700 Comment on attachment 113260 Patch Clearing flags on attachment: 113260 Committed r99021: <http://trac.webkit.org/changeset/99021> 494386 7 webkit.review.bot 2011-11-01 18:21:06 -0700 All reviewed patches have been landed. Closing bug. 113260 2011-11-01 17:08:04 -0700 2011-11-01 18:21:01 -0700 Patch bug-71338-20111101170803.patch text/plain 7342 dominicc U3VidmVyc2lvbiBSZXZpc2lvbjogOTg5OTcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA4NmNjMzkwOWMzZjFmZGJk MzIyOGJhNWFjODBkM2IxNjM2NGY5MjllLi5lYWYzMDhkMGU3M2U1ZTM5ODdmM2U2NWUwYzJjMjU2 ODg1YzMxNzdhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYgQEAKIDIwMTEtMTEtMDEgIERvbWlu aWMgQ29vbmV5ICA8ZG9taW5pY2NAY2hyb21pdW0ub3JnPgogCisgICAgICAgIFJlbW92ZSBpbml0 RXJyb3JFdmVudCBtZXRob2QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTcxMzM4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBkb20vRXJyb3JFdmVudC5jcHA6IENydXNoLgorICAgICAgICAqIGRvbS9FcnJv ckV2ZW50Lmg6IEtpbGwuCisgICAgICAgICogZG9tL0Vycm9yRXZlbnQuaWRsOiBEZXN0cm95Lgor CisyMDExLTExLTAxICBEb21pbmljIENvb25leSAgPGRvbWluaWNjQGNocm9taXVtLm9yZz4KKwog ICAgICAgICBkaXNwbGF5OiB0YWJsZS1jZWxsIGFuZCBib3gtc2l6aW5nOiBib3JkZXItYm94IGNh bGN1bGF0ZXMgY29udGVudC1ib3ggaGVpZ2h0CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD02OTQyNQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9k b20vRXJyb3JFdmVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRXJyb3JFdmVudC5jcHAKaW5k ZXggYmVlZjNmZGJkYTY3MmJmMWRlYzVhZGZmYTBiMGQ1MzljMzBlZTFkNC4uNDJjNDRmZTI0ZDk2 NjAwY2Y5OGNmOTZmNGIzYjEzZjMzNmZhMzM3ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv ZG9tL0Vycm9yRXZlbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FcnJvckV2ZW50LmNw cApAQCAtNjYsMTggKzY2LDYgQEAgRXJyb3JFdmVudDo6fkVycm9yRXZlbnQoKQogewogfQogCi12 b2lkIEVycm9yRXZlbnQ6OmluaXRFcnJvckV2ZW50KGNvbnN0IEF0b21pY1N0cmluZyYgdHlwZSwg Ym9vbCBjYW5CdWJibGUsIGJvb2wgY2FuY2VsYWJsZSwgY29uc3QgU3RyaW5nJiBtZXNzYWdlLCBj b25zdCBTdHJpbmcmIGZpbGVOYW1lLCB1bnNpZ25lZCBsaW5lTnVtYmVyKQotewotICAgIGlmIChk aXNwYXRjaGVkKCkpCi0gICAgICAgIHJldHVybjsKLQotICAgIGluaXRFdmVudCh0eXBlLCBjYW5C dWJibGUsIGNhbmNlbGFibGUpOwotCi0gICAgbV9tZXNzYWdlID0gbWVzc2FnZTsKLSAgICBtX2Zp bGVOYW1lID0gZmlsZU5hbWU7Ci0gICAgbV9saW5lTnVtYmVyID0gbGluZU51bWJlcjsKLX0KLQog Y29uc3QgQXRvbWljU3RyaW5nJiBFcnJvckV2ZW50OjppbnRlcmZhY2VOYW1lKCkgY29uc3QKIHsK ICAgICByZXR1cm4gZXZlbnROYW1lcygpLmludGVyZmFjZUZvckVycm9yRXZlbnQ7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRXJyb3JFdmVudC5oIGIvU291cmNlL1dlYkNvcmUvZG9t L0Vycm9yRXZlbnQuaAppbmRleCA4NGM5NzUwZGJjNDdiZDJmMTc3ZDMzMTViNGVjYjA0MWIyYWVj OTg1Li43ZjllNjYzNTZjYmQzODkwNzRiZjhmZDc0MDJlNWVlNTlmZmM2ZmYxIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9kb20vRXJyb3JFdmVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Rv bS9FcnJvckV2ZW50LmgKQEAgLTYwLDggKzYwLDYgQEAgcHVibGljOgogICAgIH0KICAgICB2aXJ0 dWFsIH5FcnJvckV2ZW50KCk7CiAKLSAgICB2b2lkIGluaXRFcnJvckV2ZW50KGNvbnN0IEF0b21p Y1N0cmluZyYgdHlwZSwgYm9vbCBjYW5CdWJibGUsIGJvb2wgY2FuY2VsYWJsZSwgY29uc3QgU3Ry aW5nJiBtZXNzYWdlLCBjb25zdCBTdHJpbmcmIGZpbGVOYW1lLCB1bnNpZ25lZCBsaW5lTnVtYmVy KTsKLQogICAgIGNvbnN0IFN0cmluZyYgbWVzc2FnZSgpIGNvbnN0IHsgcmV0dXJuIG1fbWVzc2Fn ZTsgfQogICAgIGNvbnN0IFN0cmluZyYgZmlsZW5hbWUoKSBjb25zdCB7IHJldHVybiBtX2ZpbGVO YW1lOyB9CiAgICAgdW5zaWduZWQgbGluZW5vKCkgY29uc3QgeyByZXR1cm4gbV9saW5lTnVtYmVy OyB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRXJyb3JFdmVudC5pZGwgYi9Tb3Vy Y2UvV2ViQ29yZS9kb20vRXJyb3JFdmVudC5pZGwKaW5kZXggNjdhZWEzZDM5YjU3ZTBiZDU5YTMw NmU0NDdlMjFlMTBiNDdmZDI4OC4uNzFiZTRhOTY1YTEzOTc1YWQ1NWVjYmU0Zjg5ZDJlZTI4NjU2 YmJkNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0Vycm9yRXZlbnQuaWRsCisrKyBi L1NvdXJjZS9XZWJDb3JlL2RvbS9FcnJvckV2ZW50LmlkbApAQCAtMzUsMTcgKzM1LDkgQEAgbW9k dWxlIGV2ZW50cyB7CiAgICAgICAgIENhbkJlQ29uc3RydWN0ZWQsCiAgICAgICAgIEN1c3RvbUNv bnN0cnVjdG9yCiAgICAgXSBFcnJvckV2ZW50IDogRXZlbnQgewotCiAgICAgICAgIHJlYWRvbmx5 IGF0dHJpYnV0ZSBET01TdHJpbmcgbWVzc2FnZTsKICAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRl IERPTVN0cmluZyBmaWxlbmFtZTsKICAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIHVuc2lnbmVk IGxvbmcgbGluZW5vOwotCi0gICAgICAgIHZvaWQgaW5pdEVycm9yRXZlbnQoaW4gW09wdGlvbmFs PUNhbGxXaXRoRGVmYXVsdFZhbHVlXSBET01TdHJpbmcgdHlwZUFyZywKLSAgICAgICAgICAgICAg ICAgICAgICAgICAgICBpbiBbT3B0aW9uYWw9Q2FsbFdpdGhEZWZhdWx0VmFsdWVdIGJvb2xlYW4g Y2FuQnViYmxlQXJnLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgIGluIFtPcHRpb25hbD1D YWxsV2l0aERlZmF1bHRWYWx1ZV0gYm9vbGVhbiBjYW5jZWxhYmxlQXJnLCAKLSAgICAgICAgICAg ICAgICAgICAgICAgICAgICBpbiBbT3B0aW9uYWw9Q2FsbFdpdGhEZWZhdWx0VmFsdWVdIERPTVN0 cmluZyBtZXNzYWdlQXJnLCAKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbiBbT3B0aW9u YWw9Q2FsbFdpdGhEZWZhdWx0VmFsdWVdIERPTVN0cmluZyBmaWxlbmFtZUFyZywgCi0gICAgICAg ICAgICAgICAgICAgICAgICAgICAgaW4gW09wdGlvbmFsPUNhbGxXaXRoRGVmYXVsdFZhbHVlXSB1 bnNpZ25lZCBsb25nIGxpbmVub0FyZyk7CiAgICAgfTsKIAogfQpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGI3ZmE0ZjE4YWE2 MTc2Y2M2NmM5YTUyMjllMjYyZTllNGU2OGRhNzMuLmM3ZjBkMTRmZmNlY2NlZDJmOTBhZTk0OWU1 Mzc1ZDA0MDc0NjM3YmMgMTAwNzU1Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMS0xMS0wMSAgRG9taW5p YyBDb29uZXkgICA8ZG9taW5pY2NAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJlbW92ZSBpbml0 RXJyb3JFdmVudCBtZXRob2QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTcxMzM4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBodHRwL3Rlc3RzL3dvcmtlcnMvd29ya2VyLWltcG9ydFNjcmlwdHNPbkVycm9y LWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvZmFzdC9kb20vV2luZG93L3dp bmRvdy1wcm9wZXJ0aWVzLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvZmFz dC9kb20vV2luZG93L3dpbmRvdy1wcm9wZXJ0aWVzLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBw bGF0Zm9ybS9xdC9mYXN0L2RvbS9XaW5kb3cvd2luZG93LXByb3BlcnRpZXMtZXhwZWN0ZWQudHh0 OgorCiAyMDExLTExLTAxICBEb21pbmljIENvb25leSAgPGRvbWluaWNjQGNocm9taXVtLm9yZz4K IAogICAgICAgICBkaXNwbGF5OiB0YWJsZS1jZWxsIGFuZCBib3gtc2l6aW5nOiBib3JkZXItYm94 IGNhbGN1bGF0ZXMgY29udGVudC1ib3ggaGVpZ2h0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9o dHRwL3Rlc3RzL3dvcmtlcnMvd29ya2VyLWltcG9ydFNjcmlwdHNPbkVycm9yLWV4cGVjdGVkLnR4 dCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvd29ya2Vycy93b3JrZXItaW1wb3J0U2NyaXB0c09u RXJyb3ItZXhwZWN0ZWQudHh0CmluZGV4IDZhMTVmZjUzYzNjMTQ4ZmE2MDliODEzNDdiMWVkOTJm NDcyMDk1MzIuLmZmN2Y3NzVmNjg2M2E0OTFlMjU2NmZmOTQwZGU5NGY2YWFiMTA5OTcgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvd29ya2Vycy93b3JrZXItaW1wb3J0U2NyaXB0 c09uRXJyb3ItZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvd29ya2Vy cy93b3JrZXItaW1wb3J0U2NyaXB0c09uRXJyb3ItZXhwZWN0ZWQudHh0CkBAIC0yOSw3ICsyOSw2 IEBAIGN1cnJlbnRUYXJnZXQ6IFtvYmplY3QgV29ya2VyXSwKIGRlZmF1bHRQcmV2ZW50ZWQ6IGZh bHNlLAogZXZlbnRQaGFzZTogMiwKIGZpbGVuYW1lOiBodHRwOi8vMTI3LjAuMC4xOjgwMDAvd29y a2Vycy9yZXNvdXJjZXMvd29ya2VyLWltcG9ydFNjcmlwdHMtZXJyb3IuanMsCi1pbml0RXJyb3JF dmVudDogZnVuY3Rpb24gaW5pdEVycm9yRXZlbnQoKSB7IFtuYXRpdmUgY29kZV0gfSwKIGluaXRF dmVudDogZnVuY3Rpb24gaW5pdEV2ZW50KCkgeyBbbmF0aXZlIGNvZGVdIH0sCiBsaW5lbm86IDIs CiBtZXNzYWdlOiBFcnJvcjogU2NyaXB0IGVycm9yLiwKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L3BsYXRmb3JtL2d0ay9mYXN0L2RvbS9XaW5kb3cvd2luZG93LXByb3BlcnRpZXMtZXhwZWN0ZWQu dHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2Zhc3QvZG9tL1dpbmRvdy93aW5kb3ctcHJv cGVydGllcy1leHBlY3RlZC50eHQKaW5kZXggNDk0Y2U2OWU2NjZmOWU5YzYzZDczNDg1ZmIzMGEz ZDViNDRjMzNlYi4uYjIyZjQxZjNjMGRmMWYwZDA3NmNjNTNiMTliMGI0MTYyNGJiZDNiOCAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2Zhc3QvZG9tL1dpbmRvdy93aW5kb3ct cHJvcGVydGllcy1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2Zh c3QvZG9tL1dpbmRvdy93aW5kb3ctcHJvcGVydGllcy1leHBlY3RlZC50eHQKQEAgLTk4NSw3ICs5 ODUsNiBAQCB3aW5kb3cuRXJyb3JFdmVudC5wcm90b3R5cGUuTU9VU0VPVVQgW251bWJlcl0KIHdp bmRvdy5FcnJvckV2ZW50LnByb3RvdHlwZS5NT1VTRU9WRVIgW251bWJlcl0KIHdpbmRvdy5FcnJv ckV2ZW50LnByb3RvdHlwZS5NT1VTRVVQIFtudW1iZXJdCiB3aW5kb3cuRXJyb3JFdmVudC5wcm90 b3R5cGUuU0VMRUNUIFtudW1iZXJdCi13aW5kb3cuRXJyb3JFdmVudC5wcm90b3R5cGUuaW5pdEVy cm9yRXZlbnQgW2Z1bmN0aW9uXQogd2luZG93LkVycm9yRXZlbnQucHJvdG90eXBlLmluaXRFdmVu dCBbZnVuY3Rpb25dCiB3aW5kb3cuRXJyb3JFdmVudC5wcm90b3R5cGUucHJldmVudERlZmF1bHQg W2Z1bmN0aW9uXQogd2luZG93LkVycm9yRXZlbnQucHJvdG90eXBlLnN0b3BJbW1lZGlhdGVQcm9w YWdhdGlvbiBbZnVuY3Rpb25dCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMv ZmFzdC9kb20vV2luZG93L3dpbmRvdy1wcm9wZXJ0aWVzLWV4cGVjdGVkLnR4dCBiL0xheW91dFRl c3RzL3BsYXRmb3JtL21hYy9mYXN0L2RvbS9XaW5kb3cvd2luZG93LXByb3BlcnRpZXMtZXhwZWN0 ZWQudHh0CmluZGV4IDhlNjU3ZTg2OWE3NTYzMmVmMWNkZjgwYTRiMWRmMjc4NjFhZDYzMjEuLjQx MjBhYjA0MmMwZWIwNjVjNDk5ZWI3M2MwNjQ1YTgzNDU2ZWNlOTMgMTAwNjQ0Ci0tLSBhL0xheW91 dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0L2RvbS9XaW5kb3cvd2luZG93LXByb3BlcnRpZXMtZXhw ZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0L2RvbS9XaW5kb3cv d2luZG93LXByb3BlcnRpZXMtZXhwZWN0ZWQudHh0CkBAIC0xMDA5LDcgKzEwMDksNiBAQCB3aW5k b3cuRXJyb3JFdmVudC5wcm90b3R5cGUuTU9VU0VPVVQgW251bWJlcl0KIHdpbmRvdy5FcnJvckV2 ZW50LnByb3RvdHlwZS5NT1VTRU9WRVIgW251bWJlcl0KIHdpbmRvdy5FcnJvckV2ZW50LnByb3Rv dHlwZS5NT1VTRVVQIFtudW1iZXJdCiB3aW5kb3cuRXJyb3JFdmVudC5wcm90b3R5cGUuU0VMRUNU IFtudW1iZXJdCi13aW5kb3cuRXJyb3JFdmVudC5wcm90b3R5cGUuaW5pdEVycm9yRXZlbnQgW2Z1 bmN0aW9uXQogd2luZG93LkVycm9yRXZlbnQucHJvdG90eXBlLmluaXRFdmVudCBbZnVuY3Rpb25d CiB3aW5kb3cuRXJyb3JFdmVudC5wcm90b3R5cGUucHJldmVudERlZmF1bHQgW2Z1bmN0aW9uXQog d2luZG93LkVycm9yRXZlbnQucHJvdG90eXBlLnN0b3BJbW1lZGlhdGVQcm9wYWdhdGlvbiBbZnVu Y3Rpb25dCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9mYXN0L2RvbS9XaW5k b3cvd2luZG93LXByb3BlcnRpZXMtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0v cXQvZmFzdC9kb20vV2luZG93L3dpbmRvdy1wcm9wZXJ0aWVzLWV4cGVjdGVkLnR4dAppbmRleCA0 ZDU1M2I5OWJkNzlkNzg4MzhjY2UyNTgzNjVjNzZlYjE4ZDMzOThmLi5mZmQwNGRlNTA5MWIxNTc1 NmRlMjNjZGQxNGIxYzJlNTFjOGJlZTIzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9xdC9mYXN0L2RvbS9XaW5kb3cvd2luZG93LXByb3BlcnRpZXMtZXhwZWN0ZWQudHh0CisrKyBi L0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L2Zhc3QvZG9tL1dpbmRvdy93aW5kb3ctcHJvcGVydGll cy1leHBlY3RlZC50eHQKQEAgLTk4MCw3ICs5ODAsNiBAQCB3aW5kb3cuRXJyb3JFdmVudC5wcm90 b3R5cGUuTU9VU0VPVVQgW251bWJlcl0KIHdpbmRvdy5FcnJvckV2ZW50LnByb3RvdHlwZS5NT1VT RU9WRVIgW251bWJlcl0KIHdpbmRvdy5FcnJvckV2ZW50LnByb3RvdHlwZS5NT1VTRVVQIFtudW1i ZXJdCiB3aW5kb3cuRXJyb3JFdmVudC5wcm90b3R5cGUuU0VMRUNUIFtudW1iZXJdCi13aW5kb3cu RXJyb3JFdmVudC5wcm90b3R5cGUuaW5pdEVycm9yRXZlbnQgW2Z1bmN0aW9uXQogd2luZG93LkVy cm9yRXZlbnQucHJvdG90eXBlLmluaXRFdmVudCBbZnVuY3Rpb25dCiB3aW5kb3cuRXJyb3JFdmVu dC5wcm90b3R5cGUucHJldmVudERlZmF1bHQgW2Z1bmN0aW9uXQogd2luZG93LkVycm9yRXZlbnQu cHJvdG90eXBlLnN0b3BJbW1lZGlhdGVQcm9wYWdhdGlvbiBbZnVuY3Rpb25dCg==