71336 2011-11-01 16:16:44 -0700 Implement __lookupGetter__/__lookupSetter__ in terms of getPropertyDescriptor 2011-11-03 10:05:20 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sam sam abarth cfleizach ojan rniwa webkit.review.bot oldest_to_newest 494270 0 sam 2011-11-01 16:16:44 -0700 Implement __lookupGetter__/__lookupSetter__ in terms of getPropertyDescriptor 494272 1 113250 sam 2011-11-01 16:23:51 -0700 Created attachment 113250 Patch 494273 2 113250 darin 2011-11-01 16:26:21 -0700 Comment on attachment 113250 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113250&action=review What’s the performance impact? > LayoutTests/ChangeLog:10 > + Update results now that __lookupGetter__/__lookupSetter__ match getOwnPropertyDescriptor. > + The failures are tracked by https://bugs.webkit.org/show_bug.cgi?id=71333. Doesn’t seem great to create new failures. 494288 3 sam 2011-11-01 16:35:11 -0700 (In reply to comment #2) > (From update of attachment 113250 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=113250&action=review > > What’s the performance impact? > > > > LayoutTests/ChangeLog:10 > > + Update results now that __lookupGetter__/__lookupSetter__ match getOwnPropertyDescriptor. > > + The failures are tracked by https://bugs.webkit.org/show_bug.cgi?id=71333. > > Doesn’t seem great to create new failures. I discussed both of these issues with Gavin, and we believe that this implementation will be a bit slower than the last one (though not much, or algorithmaclly) but it is a very infrequently used function and speeding up getPropertyDescriptor would be the preferable thing to spend out time speeding up. The failure is also not cool, but I plan to fix it soon, I just wanted to de-virtualize these two functions to make Mark Hahnenberg's life a bit easier. 494404 4 sam 2011-11-01 19:24:55 -0700 Committed r99034: <http://trac.webkit.org/changeset/99034> 495226 5 rniwa 2011-11-02 23:58:23 -0700 It appears that this patch caused platform/mac/accessibility/select-element-selection-with-optgroups.html to hit an assertion on SL: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=accessibility%2Fdeleting-iframe-destroys-axcache.html%2Cplatform%2Fmac%2Faccessibility%2Fselect-element-selection-with-optgroups.html blame list: http://trac.webkit.org/log/?verbose=on&rev=99037&stop_rev=99025 stack trace: http://build.webkit.org/results/SnowLeopard%20Intel%20Debug%20(Tests)/r99135%20(2818)/platform/mac/accessibility/select-element-selection-with-optgroups-crash-log.txt 495574 6 sam 2011-11-03 10:05:20 -0700 (In reply to comment #5) > It appears that this patch caused platform/mac/accessibility/select-element-selection-with-optgroups.html to hit an assertion on SL: > > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=accessibility%2Fdeleting-iframe-destroys-axcache.html%2Cplatform%2Fmac%2Faccessibility%2Fselect-element-selection-with-optgroups.html > > blame list: > http://trac.webkit.org/log/?verbose=on&rev=99037&stop_rev=99025 > > stack trace: > http://build.webkit.org/results/SnowLeopard%20Intel%20Debug%20(Tests)/r99135%20(2818)/platform/mac/accessibility/select-element-selection-with-optgroups-crash-log.txt This seems pretty unlikely. 113250 2011-11-01 16:23:51 -0700 2011-11-01 16:26:21 -0700 Patch bug-71336-20111101162349.patch text/plain 11901 sam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTg5OTcpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAK KzIwMTEtMTEtMDEgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBJbXBs ZW1lbnQgX19sb29rdXBHZXR0ZXJfXy9fX2xvb2t1cFNldHRlcl9fIGluIHRlcm1zIG9mIGdldFBy b3BlcnR5RGVzY3JpcHRvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NzEzMzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIGRlYnVnZ2VyL0RlYnVnZ2VyQWN0aXZhdGlvbi5jcHA6CisgICAgICAgICogZGVi dWdnZXIvRGVidWdnZXJBY3RpdmF0aW9uLmg6CisgICAgICAgIFJlbW92ZSBvdmVycmlkZXMgb2Yg bG9va3VwR2V0dGVyL2xvb2t1cFNldHRlciwgd2hpY2ggYXJlIG5vIGxvbmdlciBuZWVkZWQKKyAg ICAgICAgZHVlIHRvIGltcGxlbWVudGluZyBnZXRQcm9wZXJ0eURlc2NyaXB0b3IuCisKKyAgICAg ICAgKiBydW50aW1lL0pTT2JqZWN0LmNwcDoKKyAgICAgICAgKEpTQzo6SlNPYmplY3Q6Omxvb2t1 cEdldHRlcik6CisgICAgICAgIChKU0M6OkpTT2JqZWN0Ojpsb29rdXBTZXR0ZXIpOgorICAgICAg ICAqIHJ1bnRpbWUvSlNPYmplY3QuaDoKKyAgICAgICAgRGUtdmlydHVhbGl6ZSBsb29rdXBHZXR0 ZXIvbG9va3VwU2V0dGVyLCBhbmQgaW1wbGVtZW50IHRoZW0gaW4gdGVybXMgb2YKKyAgICAgICAg Z2V0UHJvcGVydHlEZXNjcmlwdG9yLgorCiAyMDExLTExLTAxICBYaWFuemh1IFdhbmcgIDx3YW5n eGlhbnpodUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgU3RyaW5nSW1wbDo6cmVhbGxvY2F0ZSgp IHNob3VsZCBoYXZlIGEgOC1iaXQgdmVyc2lvbgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3Jl L2RlYnVnZ2VyL0RlYnVnZ2VyQWN0aXZhdGlvbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph dmFTY3JpcHRDb3JlL2RlYnVnZ2VyL0RlYnVnZ2VyQWN0aXZhdGlvbi5jcHAJKHJldmlzaW9uIDk4 OTA4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RlYnVnZ2VyL0RlYnVnZ2VyQWN0aXZhdGlv bi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEwNCwxNCArMTA0LDQgQEAgdm9pZCBEZWJ1Z2dlckFj dGl2YXRpb246OmRlZmluZVNldHRlcihFeAogICAgIG1fYWN0aXZhdGlvbi0+ZGVmaW5lU2V0dGVy KGV4ZWMsIHByb3BlcnR5TmFtZSwgc2V0dGVyRnVuY3Rpb24sIGF0dHJpYnV0ZXMpOwogfQogCi1K U1ZhbHVlIERlYnVnZ2VyQWN0aXZhdGlvbjo6bG9va3VwR2V0dGVyKEV4ZWNTdGF0ZSogZXhlYywg Y29uc3QgSWRlbnRpZmllciYgcHJvcGVydHlOYW1lKQotewotICAgIHJldHVybiBtX2FjdGl2YXRp b24tPmxvb2t1cEdldHRlcihleGVjLCBwcm9wZXJ0eU5hbWUpOwotfQotCi1KU1ZhbHVlIERlYnVn Z2VyQWN0aXZhdGlvbjo6bG9va3VwU2V0dGVyKEV4ZWNTdGF0ZSogZXhlYywgY29uc3QgSWRlbnRp ZmllciYgcHJvcGVydHlOYW1lKQotewotICAgIHJldHVybiBtX2FjdGl2YXRpb24tPmxvb2t1cFNl dHRlcihleGVjLCBwcm9wZXJ0eU5hbWUpOwotfQotCiB9IC8vIG5hbWVzcGFjZSBKU0MKSW5kZXg6 IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZWJ1Z2dlci9EZWJ1Z2dlckFjdGl2YXRpb24uaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGVidWdnZXIvRGVidWdnZXJBY3RpdmF0 aW9uLmgJKHJldmlzaW9uIDk4OTA4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RlYnVnZ2Vy L0RlYnVnZ2VyQWN0aXZhdGlvbi5oCSh3b3JraW5nIGNvcHkpCkBAIC01MSw4ICs1MSw2IEBAIG5h bWVzcGFjZSBKU0MgewogICAgICAgICB2aXJ0dWFsIGJvb2wgZ2V0T3duUHJvcGVydHlEZXNjcmlw dG9yKEV4ZWNTdGF0ZSosIGNvbnN0IElkZW50aWZpZXImLCBQcm9wZXJ0eURlc2NyaXB0b3ImKTsK ICAgICAgICAgc3RhdGljIHZvaWQgZGVmaW5lR2V0dGVyKEpTT2JqZWN0KiwgRXhlY1N0YXRlKiwg Y29uc3QgSWRlbnRpZmllciYgcHJvcGVydHlOYW1lLCBKU09iamVjdCogZ2V0dGVyRnVuY3Rpb24s IHVuc2lnbmVkIGF0dHJpYnV0ZXMpOwogICAgICAgICB2aXJ0dWFsIHZvaWQgZGVmaW5lU2V0dGVy KEV4ZWNTdGF0ZSosIGNvbnN0IElkZW50aWZpZXImIHByb3BlcnR5TmFtZSwgSlNPYmplY3QqIHNl dHRlckZ1bmN0aW9uLCB1bnNpZ25lZCBhdHRyaWJ1dGVzKTsKLSAgICAgICAgdmlydHVhbCBKU1Zh bHVlIGxvb2t1cEdldHRlcihFeGVjU3RhdGUqLCBjb25zdCBJZGVudGlmaWVyJiBwcm9wZXJ0eU5h bWUpOwotICAgICAgICB2aXJ0dWFsIEpTVmFsdWUgbG9va3VwU2V0dGVyKEV4ZWNTdGF0ZSosIGNv bnN0IElkZW50aWZpZXImIHByb3BlcnR5TmFtZSk7CiAKICAgICAgICAgc3RhdGljIFN0cnVjdHVy ZSogY3JlYXRlU3RydWN0dXJlKEpTR2xvYmFsRGF0YSYgZ2xvYmFsRGF0YSwgSlNHbG9iYWxPYmpl Y3QqIGdsb2JhbE9iamVjdCwgSlNWYWx1ZSBwcm90b3R5cGUpIAogICAgICAgICB7CkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3QuY3BwCShyZXZpc2lvbiA5ODkw OSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0LmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtNDM0LDQwICs0MzQsMjYgQEAgdm9pZCBKU09iamVjdDo6ZGVmaW5lU2V0dGVy KEV4ZWNTdGF0ZSogZQogCiBKU1ZhbHVlIEpTT2JqZWN0Ojpsb29rdXBHZXR0ZXIoRXhlY1N0YXRl KiBleGVjLCBjb25zdCBJZGVudGlmaWVyJiBwcm9wZXJ0eU5hbWUpCiB7Ci0gICAgSlNPYmplY3Qq IG9iamVjdCA9IHRoaXM7Ci0gICAgd2hpbGUgKHRydWUpIHsKLSAgICAgICAgaWYgKEpTVmFsdWUg dmFsdWUgPSBvYmplY3QtPmdldERpcmVjdChleGVjLT5nbG9iYWxEYXRhKCksIHByb3BlcnR5TmFt ZSkpIHsKLSAgICAgICAgICAgIGlmICghdmFsdWUuaXNHZXR0ZXJTZXR0ZXIoKSkKLSAgICAgICAg ICAgICAgICByZXR1cm4ganNVbmRlZmluZWQoKTsKLSAgICAgICAgICAgIEpTT2JqZWN0KiBmdW5j dGlvbk9iamVjdCA9IGFzR2V0dGVyU2V0dGVyKHZhbHVlKS0+Z2V0dGVyKCk7Ci0gICAgICAgICAg ICBpZiAoIWZ1bmN0aW9uT2JqZWN0KQotICAgICAgICAgICAgICAgIHJldHVybiBqc1VuZGVmaW5l ZCgpOwotICAgICAgICAgICAgcmV0dXJuIGZ1bmN0aW9uT2JqZWN0OwotICAgICAgICB9CisgICAg UHJvcGVydHlEZXNjcmlwdG9yIGRlc2NyaXB0b3I7CisgICAgaWYgKCFnZXRQcm9wZXJ0eURlc2Ny aXB0b3IoZXhlYywgcHJvcGVydHlOYW1lLCBkZXNjcmlwdG9yKSkKKyAgICAgICAgcmV0dXJuIGpz VW5kZWZpbmVkKCk7CiAKLSAgICAgICAgaWYgKCFvYmplY3QtPnByb3RvdHlwZSgpIHx8ICFvYmpl Y3QtPnByb3RvdHlwZSgpLmlzT2JqZWN0KCkpCi0gICAgICAgICAgICByZXR1cm4ganNVbmRlZmlu ZWQoKTsKLSAgICAgICAgb2JqZWN0ID0gYXNPYmplY3Qob2JqZWN0LT5wcm90b3R5cGUoKSk7Ci0g ICAgfQorICAgIGlmICghZGVzY3JpcHRvci5nZXR0ZXJQcmVzZW50KCkpCisgICAgICAgIHJldHVy biBqc1VuZGVmaW5lZCgpOworCisgICAgcmV0dXJuIGRlc2NyaXB0b3IuZ2V0dGVyKCk7CiB9CiAK IEpTVmFsdWUgSlNPYmplY3Q6Omxvb2t1cFNldHRlcihFeGVjU3RhdGUqIGV4ZWMsIGNvbnN0IElk ZW50aWZpZXImIHByb3BlcnR5TmFtZSkKIHsKLSAgICBKU09iamVjdCogb2JqZWN0ID0gdGhpczsK LSAgICB3aGlsZSAodHJ1ZSkgewotICAgICAgICBpZiAoSlNWYWx1ZSB2YWx1ZSA9IG9iamVjdC0+ Z2V0RGlyZWN0KGV4ZWMtPmdsb2JhbERhdGEoKSwgcHJvcGVydHlOYW1lKSkgewotICAgICAgICAg ICAgaWYgKCF2YWx1ZS5pc0dldHRlclNldHRlcigpKQotICAgICAgICAgICAgICAgIHJldHVybiBq c1VuZGVmaW5lZCgpOwotICAgICAgICAgICAgSlNPYmplY3QqIGZ1bmN0aW9uT2JqZWN0ID0gYXNH ZXR0ZXJTZXR0ZXIodmFsdWUpLT5zZXR0ZXIoKTsKLSAgICAgICAgICAgIGlmICghZnVuY3Rpb25P YmplY3QpCi0gICAgICAgICAgICAgICAgcmV0dXJuIGpzVW5kZWZpbmVkKCk7Ci0gICAgICAgICAg ICByZXR1cm4gZnVuY3Rpb25PYmplY3Q7Ci0gICAgICAgIH0KKyAgICBQcm9wZXJ0eURlc2NyaXB0 b3IgZGVzY3JpcHRvcjsKKyAgICBpZiAoIWdldFByb3BlcnR5RGVzY3JpcHRvcihleGVjLCBwcm9w ZXJ0eU5hbWUsIGRlc2NyaXB0b3IpKQorICAgICAgICByZXR1cm4ganNVbmRlZmluZWQoKTsKIAot ICAgICAgICBpZiAoIW9iamVjdC0+cHJvdG90eXBlKCkgfHwgIW9iamVjdC0+cHJvdG90eXBlKCku aXNPYmplY3QoKSkKLSAgICAgICAgICAgIHJldHVybiBqc1VuZGVmaW5lZCgpOwotICAgICAgICBv YmplY3QgPSBhc09iamVjdChvYmplY3QtPnByb3RvdHlwZSgpKTsKLSAgICB9CisgICAgaWYgKCFk ZXNjcmlwdG9yLnNldHRlclByZXNlbnQoKSkKKyAgICAgICAgcmV0dXJuIGpzVW5kZWZpbmVkKCk7 CisgICAgCisgICAgcmV0dXJuIGRlc2NyaXB0b3Iuc2V0dGVyKCk7CiB9CiAKIGJvb2wgSlNPYmpl Y3Q6Omhhc0luc3RhbmNlKEV4ZWNTdGF0ZSogZXhlYywgSlNWYWx1ZSB2YWx1ZSwgSlNWYWx1ZSBw cm90bykKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0LmgKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3QuaAkocmV2 aXNpb24gOTg5MDkpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5o CSh3b3JraW5nIGNvcHkpCkBAIC0xODcsOCArMTg3LDggQEAgbmFtZXNwYWNlIEpTQyB7CiAKICAg ICAgICAgc3RhdGljIHZvaWQgZGVmaW5lR2V0dGVyKEpTT2JqZWN0KiwgRXhlY1N0YXRlKiwgY29u c3QgSWRlbnRpZmllciYgcHJvcGVydHlOYW1lLCBKU09iamVjdCogZ2V0dGVyRnVuY3Rpb24sIHVu c2lnbmVkIGF0dHJpYnV0ZXMgPSAwKTsKICAgICAgICAgdmlydHVhbCB2b2lkIGRlZmluZVNldHRl cihFeGVjU3RhdGUqLCBjb25zdCBJZGVudGlmaWVyJiBwcm9wZXJ0eU5hbWUsIEpTT2JqZWN0KiBz ZXR0ZXJGdW5jdGlvbiwgdW5zaWduZWQgYXR0cmlidXRlcyA9IDApOwotICAgICAgICB2aXJ0dWFs IEpTVmFsdWUgbG9va3VwR2V0dGVyKEV4ZWNTdGF0ZSosIGNvbnN0IElkZW50aWZpZXImIHByb3Bl cnR5TmFtZSk7Ci0gICAgICAgIHZpcnR1YWwgSlNWYWx1ZSBsb29rdXBTZXR0ZXIoRXhlY1N0YXRl KiwgY29uc3QgSWRlbnRpZmllciYgcHJvcGVydHlOYW1lKTsKKyAgICAgICAgSlNWYWx1ZSBsb29r dXBHZXR0ZXIoRXhlY1N0YXRlKiwgY29uc3QgSWRlbnRpZmllciYgcHJvcGVydHlOYW1lKTsKKyAg ICAgICAgSlNWYWx1ZSBsb29rdXBTZXR0ZXIoRXhlY1N0YXRlKiwgY29uc3QgSWRlbnRpZmllciYg cHJvcGVydHlOYW1lKTsKICAgICAgICAgdmlydHVhbCBib29sIGRlZmluZU93blByb3BlcnR5KEV4 ZWNTdGF0ZSosIGNvbnN0IElkZW50aWZpZXImIHByb3BlcnR5TmFtZSwgUHJvcGVydHlEZXNjcmlw dG9yJiwgYm9vbCBzaG91bGRUaHJvdyk7CiAKICAgICAgICAgYm9vbCBpc0dsb2JhbE9iamVjdCgp IGNvbnN0OwpJbmRleDogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTg5OTcpCisrKyBTb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxOCBAQAorMjAxMS0xMS0wMSAg U2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgorCisgICAgICAgIEltcGxlbWVudCBfX2xvb2t1 cEdldHRlcl9fL19fbG9va3VwU2V0dGVyX18gaW4gdGVybXMgb2YgZ2V0UHJvcGVydHlEZXNjcmlw dG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MTMz NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYmlu ZGluZ3MvanMvSlNET01XaW5kb3dDdXN0b20uY3BwOgorICAgICAgICAqIGJpbmRpbmdzL2pzL0pT RE9NV2luZG93U2hlbGwuY3BwOgorICAgICAgICAqIGJpbmRpbmdzL2pzL0pTRE9NV2luZG93U2hl bGwuaDoKKyAgICAgICAgKiBwYWdlL0RPTVdpbmRvdy5pZGw6CisgICAgICAgIFJlbW92ZSBvdmVy cmlkZXMgb2YgbG9va3VwR2V0dGVyL2xvb2t1cFNldHRlciwgd2hpY2ggYXJlIG5vIGxvbmdlciBu ZWVkZWQKKyAgICAgICAgZHVlIHRvIGltcGxlbWVudGluZyBnZXRQcm9wZXJ0eURlc2NyaXB0b3Iu CisKKwogMjAxMS0xMS0wMSAgRG9taW5pYyBDb29uZXkgIDxkb21pbmljY0BjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgZGlzcGxheTogdGFibGUtY2VsbCBhbmQgYm94LXNpemluZzogYm9yZGVyLWJv eCBjYWxjdWxhdGVzIGNvbnRlbnQtYm94IGhlaWdodApJbmRleDogU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvanMvSlNET01XaW5kb3dDdXN0b20uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL2pzL0pTRE9NV2luZG93Q3VzdG9tLmNwcAkocmV2aXNpb24gOTg5MDgpCisr KyBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTVdpbmRvd0N1c3RvbS5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTQxNCwyMiArNDE0LDYgQEAgYm9vbCBKU0RPTVdpbmRvdzo6ZGVmaW5lT3du UHJvcGVydHkoSlNDOgogICAgIHJldHVybiBCYXNlOjpkZWZpbmVPd25Qcm9wZXJ0eShleGVjLCBw cm9wZXJ0eU5hbWUsIGRlc2NyaXB0b3IsIHNob3VsZFRocm93KTsKIH0KIAotSlNWYWx1ZSBKU0RP TVdpbmRvdzo6bG9va3VwR2V0dGVyKEV4ZWNTdGF0ZSogZXhlYywgY29uc3QgSWRlbnRpZmllciYg cHJvcGVydHlOYW1lKQotewotICAgIC8vIE9ubHkgYWxsb3cgbG9va2luZy11cCBnZXR0ZXJzIGJ5 IGZyYW1lcyBpbiB0aGUgc2FtZSBvcmlnaW4uCi0gICAgaWYgKCFhbGxvd3NBY2Nlc3NGcm9tKGV4 ZWMpKQotICAgICAgICByZXR1cm4ganNVbmRlZmluZWQoKTsKLSAgICByZXR1cm4gQmFzZTo6bG9v a3VwR2V0dGVyKGV4ZWMsIHByb3BlcnR5TmFtZSk7Ci19Ci0KLUpTVmFsdWUgSlNET01XaW5kb3c6 Omxvb2t1cFNldHRlcihFeGVjU3RhdGUqIGV4ZWMsIGNvbnN0IElkZW50aWZpZXImIHByb3BlcnR5 TmFtZSkKLXsKLSAgICAvLyBPbmx5IGFsbG93IGxvb2tpbmctdXAgc2V0dGVycyBieSBmcmFtZXMg aW4gdGhlIHNhbWUgb3JpZ2luLgotICAgIGlmICghYWxsb3dzQWNjZXNzRnJvbShleGVjKSkKLSAg ICAgICAgcmV0dXJuIGpzVW5kZWZpbmVkKCk7Ci0gICAgcmV0dXJuIEJhc2U6Omxvb2t1cFNldHRl cihleGVjLCBwcm9wZXJ0eU5hbWUpOwotfQotCiAvLyBDdXN0b20gQXR0cmlidXRlcwogCiBKU1Zh bHVlIEpTRE9NV2luZG93OjpoaXN0b3J5KEV4ZWNTdGF0ZSogZXhlYykgY29uc3QKSW5kZXg6IFNv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NV2luZG93U2hlbGwuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NV2luZG93U2hlbGwuY3BwCShyZXZp c2lvbiA5ODkwOSkKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NV2luZG93U2hl bGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNDMsMTYgKzE0Myw2IEBAIHZvaWQgSlNET01XaW5k b3dTaGVsbDo6ZGVmaW5lU2V0dGVyKEV4ZWMKICAgICB3aW5kb3coKS0+ZGVmaW5lU2V0dGVyKGV4 ZWMsIHByb3BlcnR5TmFtZSwgc2V0dGVyRnVuY3Rpb24sIGF0dHJpYnV0ZXMpOwogfQogCi1KU1Zh bHVlIEpTRE9NV2luZG93U2hlbGw6Omxvb2t1cEdldHRlcihFeGVjU3RhdGUqIGV4ZWMsIGNvbnN0 IElkZW50aWZpZXImIHByb3BlcnR5TmFtZSkKLXsKLSAgICByZXR1cm4gd2luZG93KCktPmxvb2t1 cEdldHRlcihleGVjLCBwcm9wZXJ0eU5hbWUpOwotfQotCi1KU1ZhbHVlIEpTRE9NV2luZG93U2hl bGw6Omxvb2t1cFNldHRlcihFeGVjU3RhdGUqIGV4ZWMsIGNvbnN0IElkZW50aWZpZXImIHByb3Bl cnR5TmFtZSkKLXsKLSAgICByZXR1cm4gd2luZG93KCktPmxvb2t1cFNldHRlcihleGVjLCBwcm9w ZXJ0eU5hbWUpOwotfQotCiAKIC8vIC0tLS0KIC8vIEpTRE9NV2luZG93IG1ldGhvZHMKSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NV2luZG93U2hlbGwuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTVdpbmRvd1NoZWxsLmgJKHJldmlz aW9uIDk4OTA5KQorKysgU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01XaW5kb3dTaGVs bC5oCSh3b3JraW5nIGNvcHkpCkBAIC04OSw4ICs4OSw2IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsK ICAgICAgICAgc3RhdGljIHZvaWQgZGVmaW5lR2V0dGVyKEpTQzo6SlNPYmplY3QqLCBKU0M6OkV4 ZWNTdGF0ZSosIGNvbnN0IEpTQzo6SWRlbnRpZmllciYgcHJvcGVydHlOYW1lLCBKU0M6OkpTT2Jq ZWN0KiBnZXR0ZXJGdW5jdGlvbiwgdW5zaWduZWQgYXR0cmlidXRlcyk7CiAgICAgICAgIHZpcnR1 YWwgdm9pZCBkZWZpbmVTZXR0ZXIoSlNDOjpFeGVjU3RhdGUqLCBjb25zdCBKU0M6OklkZW50aWZp ZXImIHByb3BlcnR5TmFtZSwgSlNDOjpKU09iamVjdCogc2V0dGVyRnVuY3Rpb24sIHVuc2lnbmVk IGF0dHJpYnV0ZXMpOwogICAgICAgICB2aXJ0dWFsIGJvb2wgZGVmaW5lT3duUHJvcGVydHkoSlND OjpFeGVjU3RhdGUqLCBjb25zdCBKU0M6OklkZW50aWZpZXImIHByb3BlcnR5TmFtZSwgSlNDOjpQ cm9wZXJ0eURlc2NyaXB0b3ImLCBib29sIHNob3VsZFRocm93KTsKLSAgICAgICAgdmlydHVhbCBK U0M6OkpTVmFsdWUgbG9va3VwR2V0dGVyKEpTQzo6RXhlY1N0YXRlKiwgY29uc3QgSlNDOjpJZGVu dGlmaWVyJiBwcm9wZXJ0eU5hbWUpOwotICAgICAgICB2aXJ0dWFsIEpTQzo6SlNWYWx1ZSBsb29r dXBTZXR0ZXIoSlNDOjpFeGVjU3RhdGUqLCBjb25zdCBKU0M6OklkZW50aWZpZXImIHByb3BlcnR5 TmFtZSk7CiAKICAgICAgICAgUmVmUHRyPERPTVdyYXBwZXJXb3JsZD4gbV93b3JsZDsKICAgICB9 OwpJbmRleDogU291cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuaWRsCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmlkbAkocmV2aXNpb24gOTg5MDgpCisrKyBT b3VyY2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5pZGwJKHdvcmtpbmcgY29weSkKQEAgLTMzLDgg KzMzLDYgQEAgbW9kdWxlIHdpbmRvdyB7CiAgICAgICAgIEN1c3RvbURlbGV0ZVByb3BlcnR5LAog ICAgICAgICBDdXN0b21HZXRPd25Qcm9wZXJ0eVNsb3QsCiAgICAgICAgIEN1c3RvbUdldFByb3Bl cnR5TmFtZXMsCi0gICAgICAgIEN1c3RvbUxvb2t1cEdldHRlciwKLSAgICAgICAgQ3VzdG9tTG9v a3VwU2V0dGVyLAogICAgICAgICBDdXN0b21NYXJrRnVuY3Rpb24sCiAgICAgICAgIEN1c3RvbU5h dGl2ZUNvbnZlcnRlciwKICAgICAgICAgQ3VzdG9tUHV0RnVuY3Rpb24sCkluZGV4OiBMYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZp c2lvbiA5OTAwOSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAt MSwzICsxLDE0IEBACisyMDExLTExLTAxICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CisK KyAgICAgICAgSW1wbGVtZW50IF9fbG9va3VwR2V0dGVyX18vX19sb29rdXBTZXR0ZXJfXyBpbiB0 ZXJtcyBvZiBnZXRQcm9wZXJ0eURlc2NyaXB0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTcxMzM2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2RvbS9nZXR0ZXItb24td2luZG93LW9iamVjdDIt ZXhwZWN0ZWQudHh0OgorICAgICAgICBVcGRhdGUgcmVzdWx0cyBub3cgdGhhdCBfX2xvb2t1cEdl dHRlcl9fL19fbG9va3VwU2V0dGVyX18gbWF0Y2ggZ2V0T3duUHJvcGVydHlEZXNjcmlwdG9yLgor ICAgICAgICBUaGUgZmFpbHVyZXMgYXJlIHRyYWNrZWQgYnkgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTcxMzMzLgorCiAyMDExLTExLTAxICBGaWxpcCBQaXpsbyAgPGZw aXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgREZHIGlubGluaW5nIGJyZWFrcyBmdW5jdGlvbi5h cmd1bWVudHMKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9tL2dldHRlci1vbi13aW5kb3ctb2Jq ZWN0Mi1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9kb20vZ2V0 dGVyLW9uLXdpbmRvdy1vYmplY3QyLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gOTkwMDUpCisrKyBM YXlvdXRUZXN0cy9mYXN0L2RvbS9nZXR0ZXItb24td2luZG93LW9iamVjdDItZXhwZWN0ZWQudHh0 CSh3b3JraW5nIGNvcHkpCkBAIC0xMiwxMSArMTIsMTEgQEAgUEFTUyB0eXBlb2Ygd2luZG93Ll9f bG9va3VwR2V0dGVyX18oJ3gnKQogUEFTUyB0eXBlb2YgT2JqZWN0LmdldE93blByb3BlcnR5RGVz Y3JpcHRvcih3aW5kb3csICd4JykuZ2V0IGlzICd1bmRlZmluZWQnCiAKIFBBU1Mgd2luZG93Lnkg aXMgJ3dpbmRvdy55IF9fZ2V0dGVyX18nCi1QQVNTIHR5cGVvZiB3aW5kb3cuX19sb29rdXBHZXR0 ZXJfXygneScpIGlzICdmdW5jdGlvbicKK0ZBSUwgdHlwZW9mIHdpbmRvdy5fX2xvb2t1cEdldHRl cl9fKCd5Jykgc2hvdWxkIGJlIGZ1bmN0aW9uLiBXYXMgdW5kZWZpbmVkLgogRkFJTCB0eXBlb2Yg T2JqZWN0LmdldE93blByb3BlcnR5RGVzY3JpcHRvcih3aW5kb3csICd5JykuZ2V0IHNob3VsZCBi ZSBmdW5jdGlvbi4gV2FzIHVuZGVmaW5lZC4KIAogUEFTUyB3aW5kb3cueSBpcyAnd2luZG93Lnkg X19nZXR0ZXJfXycKLVBBU1MgdHlwZW9mIHdpbmRvdy5fX2xvb2t1cEdldHRlcl9fKCd5JykgaXMg J2Z1bmN0aW9uJworRkFJTCB0eXBlb2Ygd2luZG93Ll9fbG9va3VwR2V0dGVyX18oJ3knKSBzaG91 bGQgYmUgZnVuY3Rpb24uIFdhcyB1bmRlZmluZWQuCiBGQUlMIHR5cGVvZiBPYmplY3QuZ2V0T3du UHJvcGVydHlEZXNjcmlwdG9yKHdpbmRvdywgJ3knKS5nZXQgc2hvdWxkIGJlIGZ1bmN0aW9uLiBX YXMgdW5kZWZpbmVkLgogCiBQQVNTIHdpbmRvdy56IGlzIHVuZGVmaW5lZC4K