71333 2011-11-01 15:32:51 -0700 Object.getOwnPropertyDescriptor() does not retrieve the getter/setter from a property on the window that has been overridden with a getter/setter 2011-11-02 21:17:59 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 sam sam oldest_to_newest 494213 0 sam 2011-11-01 15:32:51 -0700 Object.getOwnPropertyDescriptor().get/set does not behave the same as __lookupGetter__/__lookupSetter__ on window properties. For: window.y = 1; window.__defineGetter__("y", function() { return "window.y __getter__"; }); __lookupGetter__ doesn't do the same thing as Object.getOwnPropertyDescriptor: typeof window.__lookupGetter__('y') != typeof Object.getOwnPropertyDescriptor(window, 'y').get; 494227 1 sam 2011-11-01 15:41:24 -0700 This is now tested in fast/dom/getter-on-window-object2.html. 494255 2 sam 2011-11-01 16:02:39 -0700 The real bug here is not that they behave inconsistently (that will be change shortly by implementing __lookupGetter__ in terms of Object.getOwnPropertyDescriptor()), but that Object.getOwnPropertyDescriptor() does not retrieve the getter/setter from a property on the window that has been overridden with a getter/setter. 494407 3 sam 2011-11-01 19:37:10 -0700 As of r99034, __lookupGetter__/__lookupSetter__ match Object.getOwnPropertyDescriptor, and now both are wrong. 495178 4 113426 sam 2011-11-02 20:39:16 -0700 Created attachment 113426 Patch 495183 5 sam 2011-11-02 21:17:59 -0700 Committed r99136: <http://trac.webkit.org/changeset/99136> 113426 2011-11-02 20:39:16 -0700 2011-11-02 21:13:29 -0700 Patch bug-71333-20111102203915.patch text/plain 3824 sam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTkxMzUpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAK KzIwMTEtMTEtMDIgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBPYmpl Y3QuZ2V0T3duUHJvcGVydHlEZXNjcmlwdG9yKCkgZG9lcyBub3QgcmV0cmlldmUgdGhlIGdldHRl ci9zZXR0ZXIgZnJvbSBhIHByb3BlcnR5IG9uIHRoZSB3aW5kb3cgdGhhdCBoYXMgYmVlbiBvdmVy cmlkZGVuIHdpdGggYSBnZXR0ZXIvc2V0dGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD03MTMzMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFRlc3RlZCBieSBmYXN0L2RvbS9nZXR0ZXItb24td2luZG93LW9i amVjdDIuaHRtbAorCisgICAgICAgICogcnVudGltZS9Qcm9wZXJ0eURlc2NyaXB0b3IuY3BwOgor ICAgICAgICAoSlNDOjpQcm9wZXJ0eURlc2NyaXB0b3I6OnNldERlc2NyaXB0b3IpOgorICAgICAg ICBUaGUgYXR0cmlidXRlcyByZXR1cm5lZCBmcm9tIFN0cnVjdHVyZTo6Z2V0IGRvIG5vdCBpbmNs dWRlIEdldHRlciBvciBTZXR0ZXIsIHNvCisgICAgICAgIGluc3RlYWQgY2hlY2sgaWYgdGhlIHZh bHVlIGlzIGEgR2V0dGVyU2V0dGVyIGxpa2Ugd2UgZG8gZWxzZXdoZXJlLiBJZiBpdCBpcywgdXBk YXRlCisgICAgICAgIHRoZSBkZXNjcmlwdG9yJ3MgYXR0cmlidXRlcyBhY2NvcmRpbmdseS4KKwog MjAxMS0xMS0wMiAgWXVxaWFuZyBYaWFuICA8eXVxaWFuZy54aWFuQGludGVsLmNvbT4KIAogICAg ICAgICBGdW5jdGlvblB0ciBzaG91bGQgYWNjZXB0IEZBU1RDQUxMIGZ1bmN0aW9ucyBvbiBYODYK SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1Byb3BlcnR5RGVzY3JpcHRvci5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvUHJvcGVydHlE ZXNjcmlwdG9yLmNwcAkocmV2aXNpb24gOTkxMzEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9Qcm9wZXJ0eURlc2NyaXB0b3IuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04OCwxMCAr ODgsMTcgQEAgdm9pZCBQcm9wZXJ0eURlc2NyaXB0b3I6OnNldERlc2NyaXB0b3IoSgogewogICAg IEFTU0VSVCh2YWx1ZSk7CiAgICAgbV9hdHRyaWJ1dGVzID0gYXR0cmlidXRlczsKLSAgICBpZiAo YXR0cmlidXRlcyAmIChHZXR0ZXIgfCBTZXR0ZXIpKSB7CisgICAgaWYgKHZhbHVlLmlzR2V0dGVy U2V0dGVyKCkpIHsKICAgICAgICAgR2V0dGVyU2V0dGVyKiBhY2Nlc3NvciA9IGFzR2V0dGVyU2V0 dGVyKHZhbHVlKTsKKwogICAgICAgICBtX2dldHRlciA9IGFjY2Vzc29yLT5nZXR0ZXIoKTsKKyAg ICAgICAgaWYgKG1fZ2V0dGVyKQorICAgICAgICAgICAgbV9hdHRyaWJ1dGVzIHw9IEdldHRlcjsK KwogICAgICAgICBtX3NldHRlciA9IGFjY2Vzc29yLT5zZXR0ZXIoKTsKKyAgICAgICAgaWYgKG1f c2V0dGVyKQorICAgICAgICAgICAgbV9hdHRyaWJ1dGVzIHw9IFNldHRlcjsKKwogICAgICAgICBB U1NFUlQobV9nZXR0ZXIgfHwgbV9zZXR0ZXIpOwogICAgICAgICBtX3NlZW5BdHRyaWJ1dGVzID0g RW51bWVyYWJsZVByZXNlbnQgfCBDb25maWd1cmFibGVQcmVzZW50OwogICAgICAgICBtX2F0dHJp YnV0ZXMgJj0gflJlYWRPbmx5OwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gOTkxMzUpCisrKyBMYXlvdXRU ZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMS0xMS0w MiAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgorCisgICAgICAgIE9iamVjdC5nZXRPd25Q cm9wZXJ0eURlc2NyaXB0b3IoKSBkb2VzIG5vdCByZXRyaWV2ZSB0aGUgZ2V0dGVyL3NldHRlciBm cm9tIGEgcHJvcGVydHkgb24gdGhlIHdpbmRvdyB0aGF0IGhhcyBiZWVuIG92ZXJyaWRkZW4gd2l0 aCBhIGdldHRlci9zZXR0ZXIvCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD03MTMzMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogZmFzdC9kb20vZ2V0dGVyLW9uLXdpbmRvdy1vYmplY3QyLWV4cGVjdGVkLnR4 dDoKKyAgICAgICAgVXBkYXRlIGZvciBub3cgY29ycmVjdCByZXN1bHRzLgorCiAyMDExLTExLTAy ICBFcmlrIEFydmlkc3NvbiAgPGFydkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQWRkIG5ldyBT dG9yYWdlSW5mbyB0ZXN0IHRvIHRoZSByZXNwZWN0aXZlIHNraXAgbGlzdHMuCkluZGV4OiBMYXlv dXRUZXN0cy9mYXN0L2RvbS9nZXR0ZXItb24td2luZG93LW9iamVjdDItZXhwZWN0ZWQudHh0Cj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL2dldHRlci1vbi13aW5kb3ctb2JqZWN0 Mi1leHBlY3RlZC50eHQJKHJldmlzaW9uIDk5MTMxKQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20v Z2V0dGVyLW9uLXdpbmRvdy1vYmplY3QyLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAt MTIsMTIgKzEyLDEyIEBAIFBBU1MgdHlwZW9mIHdpbmRvdy5fX2xvb2t1cEdldHRlcl9fKCd4JykK IFBBU1MgdHlwZW9mIE9iamVjdC5nZXRPd25Qcm9wZXJ0eURlc2NyaXB0b3Iod2luZG93LCAneCcp LmdldCBpcyAndW5kZWZpbmVkJwogCiBQQVNTIHdpbmRvdy55IGlzICd3aW5kb3cueSBfX2dldHRl cl9fJwotRkFJTCB0eXBlb2Ygd2luZG93Ll9fbG9va3VwR2V0dGVyX18oJ3knKSBzaG91bGQgYmUg ZnVuY3Rpb24uIFdhcyB1bmRlZmluZWQuCi1GQUlMIHR5cGVvZiBPYmplY3QuZ2V0T3duUHJvcGVy dHlEZXNjcmlwdG9yKHdpbmRvdywgJ3knKS5nZXQgc2hvdWxkIGJlIGZ1bmN0aW9uLiBXYXMgdW5k ZWZpbmVkLgorUEFTUyB0eXBlb2Ygd2luZG93Ll9fbG9va3VwR2V0dGVyX18oJ3knKSBpcyAnZnVu Y3Rpb24nCitQQVNTIHR5cGVvZiBPYmplY3QuZ2V0T3duUHJvcGVydHlEZXNjcmlwdG9yKHdpbmRv dywgJ3knKS5nZXQgaXMgJ2Z1bmN0aW9uJwogCiBQQVNTIHdpbmRvdy55IGlzICd3aW5kb3cueSBf X2dldHRlcl9fJwotRkFJTCB0eXBlb2Ygd2luZG93Ll9fbG9va3VwR2V0dGVyX18oJ3knKSBzaG91 bGQgYmUgZnVuY3Rpb24uIFdhcyB1bmRlZmluZWQuCi1GQUlMIHR5cGVvZiBPYmplY3QuZ2V0T3du UHJvcGVydHlEZXNjcmlwdG9yKHdpbmRvdywgJ3knKS5nZXQgc2hvdWxkIGJlIGZ1bmN0aW9uLiBX YXMgdW5kZWZpbmVkLgorUEFTUyB0eXBlb2Ygd2luZG93Ll9fbG9va3VwR2V0dGVyX18oJ3knKSBp cyAnZnVuY3Rpb24nCitQQVNTIHR5cGVvZiBPYmplY3QuZ2V0T3duUHJvcGVydHlEZXNjcmlwdG9y KHdpbmRvdywgJ3knKS5nZXQgaXMgJ2Z1bmN0aW9uJwogCiBQQVNTIHdpbmRvdy56IGlzIHVuZGVm aW5lZC4KIFBBU1MgdHlwZW9mIHdpbmRvdy5fX2xvb2t1cFNldHRlcl9fKCd6JykgaXMgJ2Z1bmN0 aW9uJwo=