71312 2011-11-01 13:03:05 -0700 until use_skia=1 by default on mac, default port is chromium-cg-mac 2011-11-02 09:28:04 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac All RESOLVED FIXED P2 Normal --- 1 epoger epoger abarth ojan rniwa webkit.review.bot oldest_to_newest 494083 0 epoger 2011-11-01 13:03:05 -0700 Until we finally resolve http://code.google.com/p/chromium/issues/detail?id=101731 ('re-enable use_skia by default'), rniwa has noted that we should change the default port for layout_tests on mac back to chromium-cg-mac. Otherwise, results will be compared against Skia baselines, even though the code is build with CG instead of Skia. 494084 1 113206 epoger 2011-11-01 13:06:10 -0700 Created attachment 113206 Patch 494088 2 epoger 2011-11-01 13:09:39 -0700 This patch reverts elements of *both* of the following changes, which should have been made together in the first place: http://trac.webkit.org/changeset/95850 (changed default CPU port for mac from chromium-cg-mac to chromium-mac) http://trac.webkit.org/changeset/98992 (changed default GPU port for mac from chromium-gpu-cg-mac to chromium-gpu-mac) Once we set use_skia=1 by default, we should revert this patch. 494092 3 abarth 2011-11-01 13:18:45 -0700 I'm confused. I thought we were enabling Skia by default Real Soon Now (tm). 494094 4 epoger 2011-11-01 13:22:23 -0700 (In reply to comment #3) > I'm confused. I thought we were enabling Skia by default Real Soon Now (tm). See http://code.google.com/p/chromium/issues/detail?id=101731 ... I made that change this morning, but it caused a significant performance regression so I backed it out. This patch will help deconfuse other developers (hopefully) by making the default layout_tests port match the version that gets built. 494095 5 113206 abarth 2011-11-01 13:23:04 -0700 Comment on attachment 113206 Patch Ah thanks. 494100 6 epoger 2011-11-01 13:33:32 -0700 I will commit this tomorrow morning so I can keep an eye on things... 494660 7 113206 webkit.review.bot 2011-11-02 09:28:00 -0700 Comment on attachment 113206 Patch Clearing flags on attachment: 113206 Committed r99068: <http://trac.webkit.org/changeset/99068> 494661 8 webkit.review.bot 2011-11-02 09:28:04 -0700 All reviewed patches have been landed. Closing bug. 113206 2011-11-01 13:06:10 -0700 2011-11-02 09:28:00 -0700 Patch bug-71312-20111101160609.patch text/plain 6268 epoger SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDk4OTkzKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTQgQEAKKzIwMTEtMTEtMDEgIEVsbGlvdCBQb2dlciAgPGVwb2dlckBnb29nbGUuY29tPgor CisgICAgICAgIHVudGlsIHVzZV9za2lhPTEgYnkgZGVmYXVsdCBvbiBtYWMsIGRlZmF1bHQgcG9y dCBzaG91bGQgYmUgY2hyb21pdW0tY2ctbWFjCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD03MTMxMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9j aHJvbWl1bV9ncHUucHk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMv cG9ydC9jaHJvbWl1bV9tYWMucHk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvcG9ydC9jaHJvbWl1bV9tYWNfdW5pdHRlc3QucHk6CisKIDIwMTEtMTEtMDEgIEVsbGlv dCBQb2dlciAgPGVwb2dlckBnb29nbGUuY29tPgogCiAgICAgICAgIGNocm9taXVtLWdwdSBwb3J0 IHNob3VsZCBkZWZhdWx0IHRvIGNocm9taXVtLWdwdS1tYWMsIG5vdCBjaHJvbWl1bS1ncHUtY2ct bWFjCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9t aXVtX2dwdS5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90 ZXN0cy9wb3J0L2Nocm9taXVtX2dwdS5weQkocmV2aXNpb24gOTg5OTIpCisrKyBUb29scy9TY3Jp cHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX2dwdS5weQkod29ya2luZyBj b3B5KQpAQCAtNDQsNyArNDQsNyBAQCBkZWYgZ2V0KHBsYXRmb3JtPU5vbmUsIHBvcnRfbmFtZT0n Y2hyb21pCiAgICAgICAgIGVsaWYgcGxhdGZvcm0uc3RhcnRzd2l0aCgnbGludXgnKToKICAgICAg ICAgICAgIHBvcnRfbmFtZSA9ICdjaHJvbWl1bS1ncHUtbGludXgnCiAgICAgICAgIGVsaWYgcGxh dGZvcm0gPT0gJ2Rhcndpbic6Ci0gICAgICAgICAgICBwb3J0X25hbWUgPSAnY2hyb21pdW0tZ3B1 LW1hYycKKyAgICAgICAgICAgIHBvcnRfbmFtZSA9ICdjaHJvbWl1bS1ncHUtY2ctbWFjJwogICAg ICAgICBlbHNlOgogICAgICAgICAgICAgcmFpc2UgTm90SW1wbGVtZW50ZWRFcnJvcigndW5zdXBw b3J0ZWQgcGxhdGZvcm06ICVzJyAlIHBsYXRmb3JtKQogCkluZGV4OiBUb29scy9TY3JpcHRzL3dl YmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX21hYy5weQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBU b29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX21hYy5weQko cmV2aXNpb24gOTg5OTIpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9w b3J0L2Nocm9taXVtX21hYy5weQkod29ya2luZyBjb3B5KQpAQCAtMTEyLDcgKzExMiw3IEBAIGNs YXNzIENocm9taXVtTWFjUG9ydChjaHJvbWl1bS5DaHJvbWl1bVAKICAgICBkZWYgX19pbml0X18o c2VsZiwgcG9ydF9uYW1lPU5vbmUsIG9zX3ZlcnNpb25fc3RyaW5nPU5vbmUsICoqa3dhcmdzKToK ICAgICAgICAgIyBXZSdyZSBhIGxpdHRsZSBnZW5lcmljIGhlcmUgYmVjYXVzZSB0aGlzIGNvZGUg aXMgcmV1c2VkIGJ5IHRoZQogICAgICAgICAjICdnb29nbGUtY2hyb21lJyBwb3J0IGFzIHdlbGwg YXMgdGhlICdtb2NrLScgYW5kICdkcnlydW4tJyBwb3J0cy4KLSAgICAgICAgcG9ydF9uYW1lID0g cG9ydF9uYW1lIG9yICdjaHJvbWl1bS1tYWMnCisgICAgICAgIHBvcnRfbmFtZSA9IHBvcnRfbmFt ZSBvciAnY2hyb21pdW0tY2ctbWFjJwogICAgICAgICBjaHJvbWl1bS5DaHJvbWl1bVBvcnQuX19p bml0X18oc2VsZiwgcG9ydF9uYW1lPXBvcnRfbmFtZSwgKiprd2FyZ3MpCiAgICAgICAgIGlmIHBv cnRfbmFtZS5lbmRzd2l0aCgnLW1hYycpOgogICAgICAgICAgICAgc2VsZi5fdmVyc2lvbiA9IG1h Yy5vc192ZXJzaW9uKG9zX3ZlcnNpb25fc3RyaW5nLCBzZWxmLlNVUFBPUlRFRF9PU19WRVJTSU9O UykKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21p dW1fbWFjX3VuaXR0ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv bGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fbWFjX3VuaXR0ZXN0LnB5CShyZXZpc2lvbiA5ODk5 MikKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1f bWFjX3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC01MSwyNiArNTEsMjYgQEAgY2xhc3Mg Q2hyb21pdW1NYWNQb3J0VGVzdChwb3J0X3Rlc3RjYXNlLgogCiAgICAgZGVmIHRlc3RfdmVyc2lv bnMoc2VsZik6CiAgICAgICAgIHBvcnQgPSBjaHJvbWl1bV9tYWMuQ2hyb21pdW1NYWNQb3J0KCkK LSAgICAgICAgc2VsZi5hc3NlcnRUcnVlKHBvcnQubmFtZSgpIGluICgnY2hyb21pdW0tbWFjLWxl b3BhcmQnLCAnY2hyb21pdW0tbWFjLXNub3dsZW9wYXJkJywgJ2Nocm9taXVtLW1hYy1saW9uJywg J2Nocm9taXVtLW1hYy1mdXR1cmUnKSkKKyAgICAgICAgc2VsZi5hc3NlcnRUcnVlKHBvcnQubmFt ZSgpIGluICgnY2hyb21pdW0tY2ctbWFjLWxlb3BhcmQnLCAnY2hyb21pdW0tY2ctbWFjLXNub3ds ZW9wYXJkJywgJ2Nocm9taXVtLWNnLW1hYy1saW9uJywgJ2Nocm9taXVtLWNnLW1hYy1mdXR1cmUn KSkKIAotICAgICAgICBzZWxmLmFzc2VydF9uYW1lKE5vbmUsICcxMC41LjMnLCAnY2hyb21pdW0t bWFjLWxlb3BhcmQnKQotICAgICAgICBzZWxmLmFzc2VydF9uYW1lKCdjaHJvbWl1bS1tYWMnLCAn MTAuNS4zJywgJ2Nocm9taXVtLW1hYy1sZW9wYXJkJykKLSAgICAgICAgc2VsZi5hc3NlcnRfbmFt ZSgnY2hyb21pdW0tbWFjLWxlb3BhcmQnLCAnMTAuNS4zJywgJ2Nocm9taXVtLW1hYy1sZW9wYXJk JykKLSAgICAgICAgc2VsZi5hc3NlcnRfbmFtZSgnY2hyb21pdW0tbWFjLWxlb3BhcmQnLCAnMTAu Ni4zJywgJ2Nocm9taXVtLW1hYy1sZW9wYXJkJykKLQotICAgICAgICBzZWxmLmFzc2VydF9uYW1l KE5vbmUsICcxMC42LjMnLCAnY2hyb21pdW0tbWFjLXNub3dsZW9wYXJkJykKLSAgICAgICAgc2Vs Zi5hc3NlcnRfbmFtZSgnY2hyb21pdW0tbWFjJywgJzEwLjYuMycsICdjaHJvbWl1bS1tYWMtc25v d2xlb3BhcmQnKQotICAgICAgICBzZWxmLmFzc2VydF9uYW1lKCdjaHJvbWl1bS1tYWMtc25vd2xl b3BhcmQnLCAnMTAuNS4zJywgJ2Nocm9taXVtLW1hYy1zbm93bGVvcGFyZCcpCi0gICAgICAgIHNl bGYuYXNzZXJ0X25hbWUoJ2Nocm9taXVtLW1hYy1zbm93bGVvcGFyZCcsICcxMC42LjMnLCAnY2hy b21pdW0tbWFjLXNub3dsZW9wYXJkJykKLQotICAgICAgICBzZWxmLmFzc2VydF9uYW1lKE5vbmUs ICcxMC43JywgJ2Nocm9taXVtLW1hYy1saW9uJykKLSAgICAgICAgc2VsZi5hc3NlcnRfbmFtZShO b25lLCAnMTAuNy4zJywgJ2Nocm9taXVtLW1hYy1saW9uJykKLSAgICAgICAgc2VsZi5hc3NlcnRf bmFtZShOb25lLCAnMTAuOCcsICdjaHJvbWl1bS1tYWMtZnV0dXJlJykKLSAgICAgICAgc2VsZi5h c3NlcnRfbmFtZSgnY2hyb21pdW0tbWFjJywgJzEwLjcuMycsICdjaHJvbWl1bS1tYWMtbGlvbicp Ci0gICAgICAgIHNlbGYuYXNzZXJ0X25hbWUoJ2Nocm9taXVtLW1hYy1mdXR1cmUnLCAnMTAuNC4z JywgJ2Nocm9taXVtLW1hYy1mdXR1cmUnKQotICAgICAgICBzZWxmLmFzc2VydF9uYW1lKCdjaHJv bWl1bS1tYWMtZnV0dXJlJywgJzEwLjUuMycsICdjaHJvbWl1bS1tYWMtZnV0dXJlJykKLSAgICAg ICAgc2VsZi5hc3NlcnRfbmFtZSgnY2hyb21pdW0tbWFjLWZ1dHVyZScsICcxMC42LjMnLCAnY2hy b21pdW0tbWFjLWZ1dHVyZScpCi0gICAgICAgIHNlbGYuYXNzZXJ0X25hbWUoJ2Nocm9taXVtLW1h Yy1mdXR1cmUnLCAnMTAuNy4zJywgJ2Nocm9taXVtLW1hYy1mdXR1cmUnKQorICAgICAgICBzZWxm LmFzc2VydF9uYW1lKE5vbmUsICcxMC41LjMnLCAnY2hyb21pdW0tY2ctbWFjLWxlb3BhcmQnKQor ICAgICAgICBzZWxmLmFzc2VydF9uYW1lKCdjaHJvbWl1bS1jZy1tYWMnLCAnMTAuNS4zJywgJ2No cm9taXVtLWNnLW1hYy1sZW9wYXJkJykKKyAgICAgICAgc2VsZi5hc3NlcnRfbmFtZSgnY2hyb21p dW0tY2ctbWFjLWxlb3BhcmQnLCAnMTAuNS4zJywgJ2Nocm9taXVtLWNnLW1hYy1sZW9wYXJkJykK KyAgICAgICAgc2VsZi5hc3NlcnRfbmFtZSgnY2hyb21pdW0tY2ctbWFjLWxlb3BhcmQnLCAnMTAu Ni4zJywgJ2Nocm9taXVtLWNnLW1hYy1sZW9wYXJkJykKKworICAgICAgICBzZWxmLmFzc2VydF9u YW1lKE5vbmUsICcxMC42LjMnLCAnY2hyb21pdW0tY2ctbWFjLXNub3dsZW9wYXJkJykKKyAgICAg ICAgc2VsZi5hc3NlcnRfbmFtZSgnY2hyb21pdW0tY2ctbWFjJywgJzEwLjYuMycsICdjaHJvbWl1 bS1jZy1tYWMtc25vd2xlb3BhcmQnKQorICAgICAgICBzZWxmLmFzc2VydF9uYW1lKCdjaHJvbWl1 bS1jZy1tYWMtc25vd2xlb3BhcmQnLCAnMTAuNS4zJywgJ2Nocm9taXVtLWNnLW1hYy1zbm93bGVv cGFyZCcpCisgICAgICAgIHNlbGYuYXNzZXJ0X25hbWUoJ2Nocm9taXVtLWNnLW1hYy1zbm93bGVv cGFyZCcsICcxMC42LjMnLCAnY2hyb21pdW0tY2ctbWFjLXNub3dsZW9wYXJkJykKKworICAgICAg ICBzZWxmLmFzc2VydF9uYW1lKE5vbmUsICcxMC43JywgJ2Nocm9taXVtLWNnLW1hYy1saW9uJykK KyAgICAgICAgc2VsZi5hc3NlcnRfbmFtZShOb25lLCAnMTAuNy4zJywgJ2Nocm9taXVtLWNnLW1h Yy1saW9uJykKKyAgICAgICAgc2VsZi5hc3NlcnRfbmFtZShOb25lLCAnMTAuOCcsICdjaHJvbWl1 bS1jZy1tYWMtZnV0dXJlJykKKyAgICAgICAgc2VsZi5hc3NlcnRfbmFtZSgnY2hyb21pdW0tY2ct bWFjJywgJzEwLjcuMycsICdjaHJvbWl1bS1jZy1tYWMtbGlvbicpCisgICAgICAgIHNlbGYuYXNz ZXJ0X25hbWUoJ2Nocm9taXVtLWNnLW1hYy1mdXR1cmUnLCAnMTAuNC4zJywgJ2Nocm9taXVtLWNn LW1hYy1mdXR1cmUnKQorICAgICAgICBzZWxmLmFzc2VydF9uYW1lKCdjaHJvbWl1bS1jZy1tYWMt ZnV0dXJlJywgJzEwLjUuMycsICdjaHJvbWl1bS1jZy1tYWMtZnV0dXJlJykKKyAgICAgICAgc2Vs Zi5hc3NlcnRfbmFtZSgnY2hyb21pdW0tY2ctbWFjLWZ1dHVyZScsICcxMC42LjMnLCAnY2hyb21p dW0tY2ctbWFjLWZ1dHVyZScpCisgICAgICAgIHNlbGYuYXNzZXJ0X25hbWUoJ2Nocm9taXVtLWNn LW1hYy1mdXR1cmUnLCAnMTAuNy4zJywgJ2Nocm9taXVtLWNnLW1hYy1mdXR1cmUnKQogCiAgICAg ICAgIHNlbGYuYXNzZXJ0UmFpc2VzKEFzc2VydGlvbkVycm9yLCBzZWxmLmFzc2VydF9uYW1lLCBO b25lLCAnMTAuNC4xJywgJ3Nob3VsZC1yYWlzZS1hc3NlcnRpb24tc28tdGhpcy12YWx1ZS1kb2Vz LW5vdC1tYXR0ZXInKQogCkBAIC04OSw5ICs4OSw5IEBAIGNsYXNzIENocm9taXVtTWFjUG9ydFRl c3QocG9ydF90ZXN0Y2FzZS4KICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMoJ2NwdS1jZycsIHBv cnQuZ3JhcGhpY3NfdHlwZSgpKQogICAgICAgICBwb3J0ID0gY2hyb21pdW1fbWFjLkNocm9taXVt TWFjUG9ydChwb3J0X25hbWU9J2Nocm9taXVtLW1hYycpCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1 YWxzKCdjcHUnLCBwb3J0LmdyYXBoaWNzX3R5cGUoKSkKLSAgICAgICAgIyBGb3Igbm93LCBNYWMg ZGVmYXVsdHMgdG8gY3B1IGdyYXBoaWNzIHR5cGUuCisgICAgICAgICMgRm9yIG5vdywgTWFjIGRl ZmF1bHRzIHRvIGNwdS1jZyBncmFwaGljcyB0eXBlLgogICAgICAgICBwb3J0ID0gY2hyb21pdW1f bWFjLkNocm9taXVtTWFjUG9ydCgpCi0gICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxzKCdjcHUnLCBw b3J0LmdyYXBoaWNzX3R5cGUoKSkKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMoJ2NwdS1jZycs IHBvcnQuZ3JhcGhpY3NfdHlwZSgpKQogCiAKIGlmIF9fbmFtZV9fID09ICdfX21haW5fXyc6Cg==