71302 2011-11-01 10:22:45 -0700 Web Inspector: Add advanced search shortcut to ShortcutsScreen. 2011-11-07 09:45:55 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 vsevik vsevik apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 493991 0 vsevik 2011-11-01 10:22:45 -0700 Add advanced search shortcut to ShortcutsScreen. 493995 1 113189 vsevik 2011-11-01 10:25:15 -0700 Created attachment 113189 Patch 494338 2 113189 dbates 2011-11-01 17:22:30 -0700 Comment on attachment 113189 Patch Attachment 113189 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/10148077 495262 3 113189 yurys 2011-11-03 01:32:51 -0700 Comment on attachment 113189 Patch This shortcut conflicts with "Get Into Full Screen Mode" on Mac. r- for now, let's looks for a better shortcut. 497034 4 113836 vsevik 2011-11-07 02:17:30 -0800 Created attachment 113836 Patch 497035 5 vsevik 2011-11-07 02:17:51 -0800 Changed mac shortcut to Cmd+Option+F 497106 6 113836 webkit.review.bot 2011-11-07 05:54:07 -0800 Comment on attachment 113836 Patch Rejecting attachment 113836 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: n/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/10337761 497253 7 vsevik 2011-11-07 09:45:55 -0800 Committed: http://trac.webkit.org/changeset/99416 Cleared flags and closed. 113189 2011-11-01 10:25:15 -0700 2011-11-07 02:17:23 -0800 Patch bug-71302-20111101212513.patch text/plain 2126 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogOTg5NzAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBjMzg0ZWY4Yjg3YTgzMmNi YTMwN2FjMDI4Yjg3NTQzMjg5YjhhZDViLi44Y2U1NDU3MGUyOTRjMjk0MmI4YzRkYjY2NTM0ZWM3 ZTcyNGJhYWNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMTEtMDEgIFZzZXZv bG9kIFZsYXNvdiAgPHZzZXZpa0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogQWRkIGFkdmFuY2VkIHNlYXJjaCBzaG9ydGN1dCB0byBTaG9ydGN1dHNTY3JlZW4uCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MTMwMgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogRW5nbGlzaC5scHJv ai9sb2NhbGl6ZWRTdHJpbmdzLmpzOgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvaW5z cGVjdG9yLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLl9yZWdpc3RlclNob3J0Y3V0cyk6CisK IDIwMTEtMTEtMDEgIE1pa2UgUmVlZCAgPHJlZWRAZ29vZ2xlLmNvbT4KIAogICAgICAgICBbc2tp YV0gY2FsbCByZWFkUGl4ZWxzIG9uIGNhbnZhcyBpbnN0ZWFkIG9mIGRldmljZSAod2lsbCBiZSBw cml2YXRlIG9uIGRldmljZSBzb29uKSBhbmQgY2hlY2sgZm9yIGVycm9yCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9FbmdsaXNoLmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanMgYi9Tb3VyY2Uv V2ViQ29yZS9FbmdsaXNoLmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanMKaW5kZXggYzcxM2Y4ZGRm MjA2NTRhZTVkNDVkZmRjYWZkNTYzYmZiNTZhNTdjMy4uMzZlMjUyMTZlZTFjMTlhMTNlMjIwNjNj M2YyMjczMTZhYmIyOTQzNiAxMDA2NDQKR0lUIGJpbmFyeSBwYXRjaApkZWx0YSA5MQp6Y21lQkp6 X01yfE9UIWpNNHVRIVItbCRJMnAxPm9qej52dDAldXZMVCZybDQ2QVlLa2ImZzJQaVdHQkR4PWhN VUAKVzJVSnJHKXspNmp6KSU4WUQ9fUN6Wn4qfHtTe0lLMQoKZGVsdGEgMTEKU2NtWjNxa2ZtYipP VCFqTTRnbWxnbmdoV0EKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL2luc3BlY3Rvci5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv aW5zcGVjdG9yLmpzCmluZGV4IDc2MzlhZmQ3ZmMwM2ZkNTQxNzMzNWE3YjE3YjUxMmZmMTJhMmY2 ZjQuLjRhNWE1YzFiZWZlZDY4NDk3NWRlNzBiYzE5ZDQ1ZDhjYWY1OGJmMzcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmpzCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmpzCkBAIC01NTMsNiAr NTUzLDcgQEAgV2ViSW5zcGVjdG9yLl9yZWdpc3RlclNob3J0Y3V0cyA9IGZ1bmN0aW9uKCkKICAg ICBzZWN0aW9uLmFkZFJlbGF0ZWRLZXlzKGtleXMsIFdlYkluc3BlY3Rvci5VSVN0cmluZygiTmV4 dC9wcmV2aW91cyBwYW5lbCIpKTsKICAgICBzZWN0aW9uLmFkZEtleShzaG9ydGN1dC5zaG9ydGN1 dFRvU3RyaW5nKHNob3J0Y3V0LktleXMuRXNjKSwgV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJUb2dn bGUgY29uc29sZSIpKTsKICAgICBzZWN0aW9uLmFkZEtleShzaG9ydGN1dC5zaG9ydGN1dFRvU3Ry aW5nKCJmIiwgc2hvcnRjdXQuTW9kaWZpZXJzLkN0cmxPck1ldGEpLCBXZWJJbnNwZWN0b3IuVUlT dHJpbmcoIlNlYXJjaCIpKTsKKyAgICBzZWN0aW9uLmFkZEtleShzaG9ydGN1dC5zaG9ydGN1dFRv U3RyaW5nKCJmIiwgc2hvcnRjdXQuTW9kaWZpZXJzLkN0cmxPck1ldGEgfCBzaG9ydGN1dC5Nb2Rp ZmllcnMuU2hpZnQpLCBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIlNlYXJjaCBhY3Jvc3MgYWxsIHNj cmlwdHMiKSk7CiAgICAgaWYgKFdlYkluc3BlY3Rvci5pc01hYygpKSB7CiAgICAgICAgIGtleXMg PSBbCiAgICAgICAgICAgICBzaG9ydGN1dC5zaG9ydGN1dFRvU3RyaW5nKCJnIiwgc2hvcnRjdXQu TW9kaWZpZXJzLk1ldGEpLAo= 113836 2011-11-07 02:17:30 -0800 2011-11-07 09:45:16 -0800 Patch bug-71302-20111107141728.patch text/plain 3360 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogOTkyMDgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA4YTJmMDY2YTM4ZmQ4NzQz YWQ3YjhmZGUyYTY2ZjQxNGM2NDhlZTdkLi4xZjkxNzZmY2NlNjkwZDVmNzhiZWE2ODZkZmIyNjdj ZmY1N2EzMTdlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMTEtMDcgIFZzZXZv bG9kIFZsYXNvdiAgPHZzZXZpa0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogQWRkIGFkdmFuY2VkIHNlYXJjaCBzaG9ydGN1dCB0byBTaG9ydGN1dHNTY3JlZW4uCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MTMwMgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogRW5nbGlzaC5scHJv ai9sb2NhbGl6ZWRTdHJpbmdzLmpzOgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvQWR2 YW5jZWRTZWFyY2hDb250cm9sbGVyLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkFkdmFuY2Vk U2VhcmNoQ29udHJvbGxlci5jcmVhdGVTaG9ydGN1dCk6CisgICAgICAgICogaW5zcGVjdG9yL2Zy b250LWVuZC9pbnNwZWN0b3IuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuX3JlZ2lzdGVyU2hv cnRjdXRzKToKKwogMjAxMS0xMS0wMyAgQW5kcmVhcyBLbGluZyAgPGtsaW5nQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgQ1NTUnVsZUxpc3Q6IE1vdmUgcnVsZSBvcnBoYW5pbmcgZnJvbSBkZWxldGVS dWxlKCkgb3V0IHRvIGNhbGxlcnMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9FbmdsaXNo Lmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanMgYi9Tb3VyY2UvV2ViQ29yZS9FbmdsaXNoLmxwcm9q L2xvY2FsaXplZFN0cmluZ3MuanMKaW5kZXggYzcxM2Y4ZGRmMjA2NTRhZTVkNDVkZmRjYWZkNTYz YmZiNTZhNTdjMy4uMzZlMjUyMTZlZTFjMTlhMTNlMjIwNjNjM2YyMjczMTZhYmIyOTQzNiAxMDA2 NDQKR0lUIGJpbmFyeSBwYXRjaApkZWx0YSA5MQp6Y21lQkp6X01yfE9UIWpNNHVRIVItbCRJMnAx Pm9qej52dDAldXZMVCZybDQ2QVlLa2ImZzJQaVdHQkR4PWhNVUAKVzJVSnJHKXspNmp6KSU4WUQ9 fUN6Wn4qfHtTe0lLMQoKZGVsdGEgMTEKU2NtWjNxa2ZtYipPVCFqTTRnbWxnbmdoV0EKCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0FkdmFuY2VkU2VhcmNo Q29udHJvbGxlci5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQWR2YW5j ZWRTZWFyY2hDb250cm9sbGVyLmpzCmluZGV4IDUxZmFmZWNmNTMxNjE2NTFkODEzZTVkZDBkOTRm MTljNTI5OGQzZTcuLjM2ZmVkNmFjZTBlNDM3ZjA2OTU2NDM5NDZmNDRjYzc3OGI4ODA1OTcgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQWR2YW5jZWRTZWFy Y2hDb250cm9sbGVyLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv QWR2YW5jZWRTZWFyY2hDb250cm9sbGVyLmpzCkBAIC00MSw3ICs0MSwxMCBAQCBXZWJJbnNwZWN0 b3IuQWR2YW5jZWRTZWFyY2hDb250cm9sbGVyID0gZnVuY3Rpb24oKQogCiBXZWJJbnNwZWN0b3Iu QWR2YW5jZWRTZWFyY2hDb250cm9sbGVyLmNyZWF0ZVNob3J0Y3V0ID0gZnVuY3Rpb24oKQogewot ICAgIHJldHVybiBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5tYWtlRGVzY3JpcHRvcigi ZiIsIFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0Lk1vZGlmaWVycy5DdHJsT3JNZXRhIHwg V2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQuTW9kaWZpZXJzLlNoaWZ0KTsKKyAgICBpZiAo V2ViSW5zcGVjdG9yLmlzTWFjKCkpCisgICAgICAgIHJldHVybiBXZWJJbnNwZWN0b3IuS2V5Ym9h cmRTaG9ydGN1dC5tYWtlRGVzY3JpcHRvcigiZiIsIFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0 Y3V0Lk1vZGlmaWVycy5NZXRhIHwgV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQuTW9kaWZp ZXJzLkFsdCk7CisgICAgZWxzZQorICAgICAgICByZXR1cm4gV2ViSW5zcGVjdG9yLktleWJvYXJk U2hvcnRjdXQubWFrZURlc2NyaXB0b3IoImYiLCBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1 dC5Nb2RpZmllcnMuQ3RybCB8IFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0Lk1vZGlmaWVy cy5TaGlmdCk7CiB9CiAKIFdlYkluc3BlY3Rvci5BZHZhbmNlZFNlYXJjaENvbnRyb2xsZXIucHJv dG90eXBlID0gewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC9pbnNwZWN0b3IuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3Bl Y3Rvci5qcwppbmRleCA3NjM5YWZkN2ZjMDNmZDU0MTczMzVhN2IxN2I1MTJmZjEyYTJmNmY0Li4x ZTIwZGQ0YmE5NWJjYTc4Y2VmOTdkNDI5YzcxMDY1MDkxMDAxODkwIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcworKysgYi9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcwpAQCAtNTUzLDYgKzU1Mywx MCBAQCBXZWJJbnNwZWN0b3IuX3JlZ2lzdGVyU2hvcnRjdXRzID0gZnVuY3Rpb24oKQogICAgIHNl Y3Rpb24uYWRkUmVsYXRlZEtleXMoa2V5cywgV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJOZXh0L3By ZXZpb3VzIHBhbmVsIikpOwogICAgIHNlY3Rpb24uYWRkS2V5KHNob3J0Y3V0LnNob3J0Y3V0VG9T dHJpbmcoc2hvcnRjdXQuS2V5cy5Fc2MpLCBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIlRvZ2dsZSBj b25zb2xlIikpOwogICAgIHNlY3Rpb24uYWRkS2V5KHNob3J0Y3V0LnNob3J0Y3V0VG9TdHJpbmco ImYiLCBzaG9ydGN1dC5Nb2RpZmllcnMuQ3RybE9yTWV0YSksIFdlYkluc3BlY3Rvci5VSVN0cmlu ZygiU2VhcmNoIikpOworICAgIAorICAgIHZhciBhZHZhbmNlZFNlYXJjaFNob3J0Y3V0ID0gV2Vi SW5zcGVjdG9yLkFkdmFuY2VkU2VhcmNoQ29udHJvbGxlci5jcmVhdGVTaG9ydGN1dCgpOworICAg IHNlY3Rpb24uYWRkS2V5KGFkdmFuY2VkU2VhcmNoU2hvcnRjdXQubmFtZSwgV2ViSW5zcGVjdG9y LlVJU3RyaW5nKCJTZWFyY2ggYWNyb3NzIGFsbCBzY3JpcHRzIikpOworICAgIAogICAgIGlmIChX ZWJJbnNwZWN0b3IuaXNNYWMoKSkgewogICAgICAgICBrZXlzID0gWwogICAgICAgICAgICAgc2hv cnRjdXQuc2hvcnRjdXRUb1N0cmluZygiZyIsIHNob3J0Y3V0Lk1vZGlmaWVycy5NZXRhKSwK