71289 2011-11-01 09:12:06 -0700 Crash in PDF code when script has illegal UTF-8 or UTF-16 sequences 2011-11-01 10:46:31 -0700 1 1 1 Unclassified WebKit PDF 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 darin darin ap oldest_to_newest 493925 0 darin 2011-11-01 09:12:06 -0700 Crash in PDF code when script has illegal UTF-8 or UTF-16 sequences 493926 1 113175 darin 2011-11-01 09:13:22 -0700 Created attachment 113175 Patch 493939 2 113175 darin 2011-11-01 09:28:21 -0700 Comment on attachment 113175 Patch Clearing flags on attachment: 113175 Committed r98970: <http://trac.webkit.org/changeset/98970> 493940 3 darin 2011-11-01 09:28:24 -0700 All reviewed patches have been landed. Closing bug. 493965 4 ap 2011-11-01 09:56:53 -0700 Is it correct to only support UTF-8 and UTF-16 with BOM? Where should the encoding information come from? 494011 5 darin 2011-11-01 10:46:31 -0700 (In reply to comment #4) > Is it correct to only support UTF-8 and UTF-16 with BOM? Where should the encoding information come from? That’s a good question, and it occurred to me too. But far, far less important than this bug. 113175 2011-11-01 09:13:22 -0700 2011-11-01 09:28:21 -0700 Patch bug-71289-20111101091320.patch text/plain 1971 darin SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDk4OTY5KQorKysgU291cmNlL1dlYktpdC9t YWMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMTEtMDEg IERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgorCisgICAgICAgIENyYXNoIGluIFBERiBj b2RlIHdoZW4gc2NyaXB0IGhhcyBpbGxlZ2FsIFVURi04IG9yIFVURi0xNiBzZXF1ZW5jZXMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcxMjg5CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSnVzdCBhZGRpbmcg YSBudWxsIGNoZWNrLiBJIGRvbid0IGhhdmUgYWNjZXNzIHRvIGFuIGFjdHVhbCBQREYgd2l0aAor ICAgICAgICB0aGlzIHByb2JsZW0gYnV0IGNyYXNoZXMgZnJvbSB0aGUgZmllbGQgaW5kaWNhdGUg dGhleSBleGlzdC4KKworICAgICAgICAqIFdlYlZpZXcvV2ViUERGRG9jdW1lbnRFeHRyYXMubW06 CisgICAgICAgIChhbGxTY3JpcHRzSW5QREZEb2N1bWVudCk6IFNraXAgdGhlIGNvZGUgdG8gYWRk IHRoZSBzY3JpcHQgdGV4dAorICAgICAgICB0byBhbiBhcnJheSB3aGVuIHRoZSBzY3JpcHQgaXMg bnVsbC4KKwogMjAxMS0xMC0yOCAgSm9obiBTdWxsaXZhbiAgPHN1bGxpdmFuQGFwcGxlLmNvbT4K IAogICAgICAgICBXZWJLaXQgcGFydCBvZjoKSW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL1dlYlZp ZXcvV2ViUERGRG9jdW1lbnRFeHRyYXMubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9t YWMvV2ViVmlldy9XZWJQREZEb2N1bWVudEV4dHJhcy5tbQkocmV2aXNpb24gOTg5NjkpCisrKyBT b3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlBERkRvY3VtZW50RXh0cmFzLm1tCSh3b3JraW5n IGNvcHkpCkBAIC04OSw3ICs4OSw3IEBAIE5TQXJyYXkgKmFsbFNjcmlwdHNJblBERkRvY3VtZW50 KFBERkRvY3UKICAgICBpZiAoIUNHUERGRGljdGlvbmFyeUdldERpY3Rpb25hcnkobmFtZXNEaWN0 aW9uYXJ5LCAiSmF2YVNjcmlwdCIsICZqYXZhU2NyaXB0TmFtZVRyZWUpKQogICAgICAgICByZXR1 cm4gc2NyaXB0czsKIAotICAgIC8vIFRoZSBuYW1lcyBhcmUgYXJpYnRyYXJ5LiBXZSBhcmUgb25s eSBpbnRlcmVzdGVkIGluIHRoZSB2YWx1ZXMuCisgICAgLy8gVGhlIG5hbWVzIGFyZSBhcmJpdHJh cnkuIFdlIGFyZSBvbmx5IGludGVyZXN0ZWQgaW4gdGhlIHZhbHVlcy4KICAgICBWZWN0b3I8Q0dQ REZPYmplY3RSZWY+IG9iamVjdHM7CiAgICAgZ2V0QWxsVmFsdWVzSW5QREZOYW1lVHJlZShqYXZh U2NyaXB0TmFtZVRyZWUsIG9iamVjdHMpOwogICAgIHNpemVfdCBvYmplY3RDb3VudCA9IG9iamVj dHMuc2l6ZSgpOwpAQCAtMTI1LDYgKzEyNSw5IEBAIE5TQXJyYXkgKmFsbFNjcmlwdHNJblBERkRv Y3VtZW50KFBERkRvY3UKIAogICAgICAgICBOU1N0cmluZ0VuY29kaW5nIGVuY29kaW5nID0gKGxl bmd0aCA+IDEgJiYgYnl0ZXNbMF0gPT0gMHhGRSAmJiBieXRlc1sxXSA9PSAweEZGKSA/IE5TVW5p Y29kZVN0cmluZ0VuY29kaW5nIDogTlNVVEY4U3RyaW5nRW5jb2Rpbmc7CiAgICAgICAgIE5TU3Ry aW5nICpzY3JpcHQgPSBbW05TU3RyaW5nIGFsbG9jXSBpbml0V2l0aEJ5dGVzOmJ5dGVzIGxlbmd0 aDpsZW5ndGggZW5jb2Rpbmc6ZW5jb2RpbmddOworICAgICAgICBpZiAoIXNjcmlwdCkKKyAgICAg ICAgICAgIGNvbnRpbnVlOworCiAgICAgICAgIFtzY3JpcHRzIGFkZE9iamVjdDpzY3JpcHRdOwog ICAgICAgICBbc2NyaXB0IHJlbGVhc2VdOwogICAgIH0K