71286 2011-11-01 07:56:42 -0700 chromium-gpu port should default to chromium-gpu-mac, not chromium-gpu-cg-mac 2011-11-01 12:29:11 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 epoger epoger abarth ojan webkit.review.bot oldest_to_newest 493905 0 epoger 2011-11-01 07:56:42 -0700 chromium-gpu port should default to chromium-gpu-mac, not chromium-gpu-cg-mac 493906 1 epoger 2011-11-01 07:57:32 -0700 (this should be kept in sync with what port we default to on mac, chromium-mac or chromium-cg-mac) 493907 2 113172 epoger 2011-11-01 07:59:44 -0700 Created attachment 113172 Patch 493997 3 113172 senorblanco 2011-11-01 10:25:55 -0700 Comment on attachment 113172 Patch Elliot assures me this will only affect the trybots, and not the waterfall bots, so assuming that's true, this looks good. :) r=me 493998 4 epoger 2011-11-01 10:28:01 -0700 The need for this change is to fix chromium trybot behavior as noted in http://codereview.chromium.org/8384004/ ('Set use_skia=1 by default'): currently, the trybots are evaluating webkit_tests against the "chromium-mac-snowleopard" port (i.e. Skia), but evaluating webkit_gpu_tests against the "chromium-gpu-cg-mac-snowleopard" port (CG). Note that this change will not affect the chromium.webkit waterfall, because those bots already manually specify either chromium-gpu-mac or chromium-gpu-cg-mac. 494070 5 113172 webkit.review.bot 2011-11-01 12:29:07 -0700 Comment on attachment 113172 Patch Clearing flags on attachment: 113172 Committed r98992: <http://trac.webkit.org/changeset/98992> 494071 6 webkit.review.bot 2011-11-01 12:29:11 -0700 All reviewed patches have been landed. Closing bug. 113172 2011-11-01 07:59:44 -0700 2011-11-01 12:29:07 -0700 Patch bug-71286-20111101105943.patch text/plain 1258 epoger SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDk4OTU5KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTIgQEAKKzIwMTEtMTEtMDEgIEVsbGlvdCBQb2dlciAgPGVwb2dlckBnb29nbGUuY29tPgor CisgICAgICAgIGNocm9taXVtLWdwdSBwb3J0IHNob3VsZCBkZWZhdWx0IHRvIGNocm9taXVtLWdw dS1tYWMsIG5vdCBjaHJvbWl1bS1ncHUtY2ctbWFjCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MTI4NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9y dC9jaHJvbWl1bV9ncHUucHk6CisKIDIwMTEtMTEtMDEgIEpvY2VseW4gVHVyY290dGUgIDxqb2Nl bHluLnR1cmNvdHRlQG5va2lhLmNvbT4KIAogICAgICAgICBjaGVjay13ZWJraXQtc3R5bGU6IEFs bG93IG5hbWVzIHN0YXJ0aW5nIHdpdGggIl9xXyIuCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtp dHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX2dwdS5weQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29s cy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX2dwdS5weQkocmV2 aXNpb24gOTg5NTgpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0 L2Nocm9taXVtX2dwdS5weQkod29ya2luZyBjb3B5KQpAQCAtNDQsNyArNDQsNyBAQCBkZWYgZ2V0 KHBsYXRmb3JtPU5vbmUsIHBvcnRfbmFtZT0nY2hyb21pCiAgICAgICAgIGVsaWYgcGxhdGZvcm0u c3RhcnRzd2l0aCgnbGludXgnKToKICAgICAgICAgICAgIHBvcnRfbmFtZSA9ICdjaHJvbWl1bS1n cHUtbGludXgnCiAgICAgICAgIGVsaWYgcGxhdGZvcm0gPT0gJ2Rhcndpbic6Ci0gICAgICAgICAg ICBwb3J0X25hbWUgPSAnY2hyb21pdW0tZ3B1LWNnLW1hYycKKyAgICAgICAgICAgIHBvcnRfbmFt ZSA9ICdjaHJvbWl1bS1ncHUtbWFjJwogICAgICAgICBlbHNlOgogICAgICAgICAgICAgcmFpc2Ug Tm90SW1wbGVtZW50ZWRFcnJvcigndW5zdXBwb3J0ZWQgcGxhdGZvcm06ICVzJyAlIHBsYXRmb3Jt KQogCg==