71285 2011-11-01 07:36:06 -0700 CSSRule: Devirtualize addSubresourceStyleURLs() 2011-11-01 08:24:31 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling macpherson webkit.review.bot oldest_to_newest 493897 0 kling 2011-11-01 07:36:06 -0700 SSIA 493899 1 113171 kling 2011-11-01 07:39:02 -0700 Created attachment 113171 Patch 493902 2 113171 koivisto 2011-11-01 07:53:45 -0700 Comment on attachment 113171 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113171&action=review r=me > Source/WebCore/css/CSSStyleRule.h:59 > - virtual void addSubresourceStyleURLs(ListHashSet<KURL>& urls); > + void addSubresourceStyleURLs(ListHashSet<KURL>& urls); Something like collectSubresourceURLSs would be a better name and the function should be const. For future refactoring as the name is used in many places. 493910 3 kling 2011-11-01 08:24:31 -0700 Committed r98963: <http://trac.webkit.org/changeset/98963> 113171 2011-11-01 07:39:02 -0700 2011-11-01 07:53:45 -0700 Patch bug-71285.diff text/plain 4080 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzMzVhNTVjLi4wOThhMzM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTEtMTEtMDEgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCisgICAg ICAgIENTU1J1bGU6IERldmlydHVhbGl6ZSBhZGRTdWJyZXNvdXJjZVN0eWxlVVJMcygpCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MTI4NQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1vdmUgYWRkU3VicmVz b3VyY2VTdHlsZVVSTHMoKSBpbnRvIHRoZSBydWxlcyB0aGF0IGFjdHVhbGx5IGltcGxlbWVudCBp dC4KKyAgICAgICAgQWRkIHR5cGUgY2hlY2tzIGFuZCBjYXN0cyBhdCB0aGUgKG9ubHkpIGNhbGwg c2l0ZS4KKworICAgICAgICAqIGNzcy9DU1NGb250RmFjZVJ1bGUuaDoKKyAgICAgICAgKiBjc3Mv Q1NTSW1wb3J0UnVsZS5oOgorICAgICAgICAqIGNzcy9DU1NSdWxlLmg6CisgICAgICAgICogY3Nz L0NTU1N0eWxlUnVsZS5oOgorICAgICAgICAqIGNzcy9DU1NTdHlsZVNoZWV0LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkNTU1N0eWxlU2hlZXQ6OmFkZFN1YnJlc291cmNlU3R5bGVVUkxzKToKKwog MjAxMS0xMS0wMSAgQWxleGFuZGVyIFBhdmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFdlYiBJbnNwZWN0b3I6IFtTdHlsZXNdIFN0eWxlLWJhc2VkIENTUyBwcm9wZXJ0aWVz IGFyZSBlZGl0YWJsZSBhbmQgdG9nZ2xlYWJsZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv Y3NzL0NTU0ZvbnRGYWNlUnVsZS5oIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU0ZvbnRGYWNlUnVs ZS5oCmluZGV4IGMxMmJlOWEuLjFmM2FhN2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nz cy9DU1NGb250RmFjZVJ1bGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTRm9udEZhY2VS dWxlLmgKQEAgLTQ5LDcgKzQ5LDcgQEAgcHVibGljOgogCiAgICAgdm9pZCBzZXREZWNsYXJhdGlv bihQYXNzUmVmUHRyPENTU011dGFibGVTdHlsZURlY2xhcmF0aW9uPik7CiAKLSAgICB2aXJ0dWFs IHZvaWQgYWRkU3VicmVzb3VyY2VTdHlsZVVSTHMoTGlzdEhhc2hTZXQ8S1VSTD4mIHVybHMpOwor ICAgIHZvaWQgYWRkU3VicmVzb3VyY2VTdHlsZVVSTHMoTGlzdEhhc2hTZXQ8S1VSTD4mIHVybHMp OwogCiBwcml2YXRlOgogICAgIENTU0ZvbnRGYWNlUnVsZShDU1NTdHlsZVNoZWV0KiBwYXJlbnQp OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU0ltcG9ydFJ1bGUuaCBiL1NvdXJj ZS9XZWJDb3JlL2Nzcy9DU1NJbXBvcnRSdWxlLmgKaW5kZXggNDNhNTg4NS4uNDNkODhhMCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU0ltcG9ydFJ1bGUuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9jc3MvQ1NTSW1wb3J0UnVsZS5oCkBAIC01Miw3ICs1Miw3IEBAIHB1YmxpYzoKICAg ICAvLyBOb3QgcGFydCBvZiB0aGUgQ1NTT00KICAgICBib29sIGlzTG9hZGluZygpIGNvbnN0Owog Ci0gICAgdmlydHVhbCB2b2lkIGFkZFN1YnJlc291cmNlU3R5bGVVUkxzKExpc3RIYXNoU2V0PEtV Ukw+JiB1cmxzKTsKKyAgICB2b2lkIGFkZFN1YnJlc291cmNlU3R5bGVVUkxzKExpc3RIYXNoU2V0 PEtVUkw+JiB1cmxzKTsKIAogICAgIHZvaWQgcmVxdWVzdFN0eWxlU2hlZXQoKTsKIApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1J1bGUuaCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9D U1NSdWxlLmgKaW5kZXggNGVmM2EyZS4uMjRmODRjNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvY3NzL0NTU1J1bGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUnVsZS5oCkBAIC05 NCw4ICs5NCw2IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIFN0cmluZyBjc3NUZXh0KCkgY29uc3Qg PSAwOwogICAgIHZvaWQgc2V0Q3NzVGV4dChjb25zdCBTdHJpbmcmLCBFeGNlcHRpb25Db2RlJik7 CiAKLSAgICB2aXJ0dWFsIHZvaWQgYWRkU3VicmVzb3VyY2VTdHlsZVVSTHMoTGlzdEhhc2hTZXQ8 S1VSTD4mKSB7IH0KLQogICAgIEtVUkwgYmFzZVVSTCgpIGNvbnN0CiAgICAgewogICAgICAgICBp ZiAoQ1NTU3R5bGVTaGVldCogcGFyZW50U2hlZXQgPSBwYXJlbnRTdHlsZVNoZWV0KCkpCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVSdWxlLmggYi9Tb3VyY2UvV2ViQ29y ZS9jc3MvQ1NTU3R5bGVSdWxlLmgKaW5kZXggN2IxNDM1Ny4uNjUzZTgxMiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlUnVsZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nz cy9DU1NTdHlsZVJ1bGUuaApAQCAtNTYsNyArNTYsNyBAQCBwdWJsaWM6CiAgICAgY29uc3QgQ1NT U2VsZWN0b3JMaXN0JiBzZWxlY3Rvckxpc3QoKSBjb25zdCB7IHJldHVybiBtX3NlbGVjdG9yTGlz dDsgfQogICAgIENTU011dGFibGVTdHlsZURlY2xhcmF0aW9uKiBkZWNsYXJhdGlvbigpIHsgcmV0 dXJuIG1fc3R5bGUuZ2V0KCk7IH0KIAotICAgIHZpcnR1YWwgdm9pZCBhZGRTdWJyZXNvdXJjZVN0 eWxlVVJMcyhMaXN0SGFzaFNldDxLVVJMPiYgdXJscyk7CisgICAgdm9pZCBhZGRTdWJyZXNvdXJj ZVN0eWxlVVJMcyhMaXN0SGFzaFNldDxLVVJMPiYgdXJscyk7CiAKICAgICBpbnQgc291cmNlTGlu ZSgpIHsgcmV0dXJuIG1fc291cmNlTGluZTsgfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9jc3MvQ1NTU3R5bGVTaGVldC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVTaGVl dC5jcHAKaW5kZXggYThkYjQ2OC4uMjkyY2M3NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv Y3NzL0NTU1N0eWxlU2hlZXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNo ZWV0LmNwcApAQCAtMjEsMTAgKzIxLDEyIEBACiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVk ZSAiQ1NTU3R5bGVTaGVldC5oIgogCisjaW5jbHVkZSAiQ1NTRm9udEZhY2VSdWxlLmgiCiAjaW5j bHVkZSAiQ1NTSW1wb3J0UnVsZS5oIgogI2luY2x1ZGUgIkNTU05hbWVzcGFjZS5oIgogI2luY2x1 ZGUgIkNTU1BhcnNlci5oIgogI2luY2x1ZGUgIkNTU1J1bGVMaXN0LmgiCisjaW5jbHVkZSAiQ1NT U3R5bGVSdWxlLmgiCiAjaW5jbHVkZSAiRG9jdW1lbnQuaCIKICNpbmNsdWRlICJFeGNlcHRpb25D b2RlLmgiCiAjaW5jbHVkZSAiSFRNTE5hbWVzLmgiCkBAIC0yOTYsOCArMjk4LDExIEBAIHZvaWQg Q1NTU3R5bGVTaGVldDo6YWRkU3VicmVzb3VyY2VTdHlsZVVSTHMoTGlzdEhhc2hTZXQ8S1VSTD4m IHVybHMpCiAgICAgICAgICAgICBpZiAocnVsZS0+aXNJbXBvcnRSdWxlKCkpIHsKICAgICAgICAg ICAgICAgICBpZiAoQ1NTU3R5bGVTaGVldCogcnVsZVN0eWxlU2hlZXQgPSBzdGF0aWNfY2FzdDxD U1NJbXBvcnRSdWxlKj4ocnVsZSktPnN0eWxlU2hlZXQoKSkKICAgICAgICAgICAgICAgICAgICAg c3R5bGVTaGVldFF1ZXVlLmFwcGVuZChydWxlU3R5bGVTaGVldCk7Ci0gICAgICAgICAgICB9Ci0g ICAgICAgICAgICBydWxlLT5hZGRTdWJyZXNvdXJjZVN0eWxlVVJMcyh1cmxzKTsKKyAgICAgICAg ICAgICAgICBzdGF0aWNfY2FzdDxDU1NJbXBvcnRSdWxlKj4ocnVsZSktPmFkZFN1YnJlc291cmNl U3R5bGVVUkxzKHVybHMpOworICAgICAgICAgICAgfSBlbHNlIGlmIChydWxlLT5pc0ZvbnRGYWNl UnVsZSgpKQorICAgICAgICAgICAgICAgIHN0YXRpY19jYXN0PENTU0ZvbnRGYWNlUnVsZSo+KHJ1 bGUpLT5hZGRTdWJyZXNvdXJjZVN0eWxlVVJMcyh1cmxzKTsKKyAgICAgICAgICAgIGVsc2UgaWYg KHJ1bGUtPmlzU3R5bGVSdWxlKCkgfHwgcnVsZS0+aXNQYWdlUnVsZSgpKQorICAgICAgICAgICAg ICAgIHN0YXRpY19jYXN0PENTU1N0eWxlUnVsZSo+KHJ1bGUpLT5hZGRTdWJyZXNvdXJjZVN0eWxl VVJMcyh1cmxzKTsKICAgICAgICAgfQogICAgIH0KIH0K