71271 2011-11-01 01:03:45 -0700 [Qt] Web Inspector: local inspector client UI becomes unresponsive on debugger pause during 2012-05-17 21:33:45 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All Linux RESOLVED FIXED P2 Normal --- 0 yurys webkit-unassigned abecsi apavlov bweinstein eriktsarko jarred joepeck jturcotte keishi leo loislo manuel.lazzari pfeldman pmuellr podivilov rahul.nimbalkar rik saulo timothy vsevik webkit.review.bot yurys zcrendel oldest_to_newest 493793 0 yurys 2011-11-01 01:03:45 -0700 Steps to reproduce: 1. Set a breakpoint. 2. Trigger the breakpoint. Result: Inspector UI is unresponsive. 536275 1 zcrendel 2012-01-15 11:28:19 -0800 The bug still exists. I tested it on Windows and Linux platforms. It works fine with webkit from Qt-4.7.4 but doesn't work with webkit from trunk and from Qt-4.8. I did some rough hack - removed isPaused() statement from a couple of the conditions in the following source files: WebCore/bindings/js/JSLazyEventListener.cpp (in ScriptValue ScriptController::executeScriptInWorld() func) WebCore/bindings/js/ScriptController.cpp (in JSLazyEventListener::initializeJSFunction() func) WebCore/bindings/js/JSEventListener.cpp (in JSEventListener::handleEvent() func) Just like that: if (!script->canExecuteScripts(AboutToExecuteScript))// || script->isPaused()) and then GUI becomes partially responsive. After this I did a little bit more research and have got that: when breakpoint paused - nothing changed in GUI, although "Debugger.paused" message sent to frontend page with success, but didn't executed (due to locked JS context). If you clicked on 'workers debug' combobox (or any other GUI part which interacts with backend) and then this method will be executed and GUI will be updated to paused state. Hope it can help somehow. I think that solving of this bug is very important (not just P2) - because no way to make local debug of javascript from inspector while it still there and it's very annoying for js developers who use qt-webkit. Any clues? 536279 2 zcrendel 2012-01-15 11:47:48 -0800 (In reply to comment #1) > If you clicked on 'workers debug' combobox Sorry. Ofc, I meant 'workers debug' checkbox. 536291 3 leo 2012-01-15 14:32:53 -0800 I think I have some patches that fix this bug, though they are not ready yet for upstreaming. I will try to find some time next week for the upstreaming. Here they are: 1) Updated Websocket implementation to latest spec to work against a recent chrome/webkit browser: https://gitorious.org/~lfranchi/webkit/lfranchis-qtwebkit/commit/93a72f2657c2a8bb6863d5d2ffe8ce6faedd4598 2) 2 fixes for hanging on breakpoint (one requires the above commit, but is easy enough to apply against trunk if you read the code) https://gitorious.org/~lfranchi/webkit/lfranchis-qtwebkit/commit/4e104bc438c21ef63a6a4227a142d36bf2401b2e https://gitorious.org/~lfranchi/webkit/lfranchis-qtwebkit/commit/1606e202891b856ad0fdae80288ccdbf8d6765e1 The latter two patches I hope should fix your issue. All 3 are also available as a standalone patch against qt 4.8 here: https://github.com/ariya/phantomjs/blob/master/deploy/qt48_fix_inspector.patch 536292 4 zcrendel 2012-01-15 14:35:16 -0800 (In reply to comment #3) Thanks for the answer. I saw these patches, they doesn't solve current bug, since these patches are for Remote Debug, but this bug report actually is for Local Debug problem. 536563 5 zcrendel 2012-01-16 08:17:50 -0800 (In reply to comment #1) > I did some rough hack - removed isPaused() statement from a couple of the conditions in the following source files: > > WebCore/bindings/js/JSLazyEventListener.cpp (in ScriptValue ScriptController::executeScriptInWorld() func) > WebCore/bindings/js/ScriptController.cpp (in JSLazyEventListener::initializeJSFunction() func) > WebCore/bindings/js/JSEventListener.cpp (in JSEventListener::handleEvent() func) > > Just like that: > if (!script->canExecuteScripts(AboutToExecuteScript))// || script->isPaused()) > I forgot to mention, what I also commented the following condition part: if (!scriptExecutionContext) // || scriptExecutionContext->isJSExecutionForbidden()) return; in WebCore/bindings/js/JSEventListener.cpp (void JSEventListener::handleEvent(...) func) 536587 6 zcrendel 2012-01-16 08:52:59 -0800 The above partial workaround works only on linux, on windows it still freezes the system. Anyone have any clues? 536787 7 zcrendel 2012-01-16 15:52:21 -0800 (In reply to comment #3) Thank you Leo for patches you made! We are using your patches to make remote debugging works, until local debugging will be fixed. 537153 8 leo 2012-01-17 09:24:31 -0800 Glad that works for you partially at least. I remember now also hitting issues with local debugging, but as I only needed remote debugging I didn't spend too much time on that. Next week i'll clean up my patches and see if I can get them committed upstream. 537156 9 zcrendel 2012-01-17 09:27:42 -0800 (In reply to comment #8) > Glad that works for you partially at least. I remember now also hitting issues with local debugging, but as I only needed remote debugging I didn't spend too much time on that. > > Next week i'll clean up my patches and see if I can get them committed upstream. Thanks again. Btw, it works only with last Chrome (with 'm' label in version) and only in Windows Chrome's version. Safari (on Windows and Mac) and Chrome on Mac doesn't work with patched remote debug - got 404 error and empty inspector. 537159 10 zcrendel 2012-01-17 09:30:28 -0800 I will gladly help anyone who want to fix current bug, as I'm C++/Qt programmer. Maybe some webkit's guru give any hint or direction to where dig, it will safe a lot time. 542365 11 123960 leo 2012-01-25 09:41:03 -0800 Created attachment 123960 Patch 542370 12 123960 jarred 2012-01-25 09:43:40 -0800 Comment on attachment 123960 Patch This addresses remote debugging only, when this bug is primarily referring to local debugging where the JS context seems to pause for the Inspector client in addition to the Frame that's being inspected. I suggest creating a new ticket for the remote debugger fixes. 542398 13 leo 2012-01-25 10:07:23 -0800 (In reply to comment #12) > (From update of attachment 123960 [details]) > This addresses remote debugging only, when this bug is primarily referring to local debugging where the JS context seems to pause for the Inspector client in addition to the Frame that's being inspected. I suggest creating a new ticket for the remote debugger fixes. Thanks, I obsoleted the patch. The new ticket is here: https://bugs.webkit.org/process_bug.cgi 542402 14 leo 2012-01-25 10:08:02 -0800 By that I meant here: https://bugs.webkit.org/show_bug.cgi?id=77022 557094 15 manuel.lazzari 2012-02-15 03:04:40 -0800 Not sure that what's happening in our hybrid QtWebKit app with Qt 4.8.0 compiled from source on Windows and Mac OS X is related/linked to this bug, if not please advise. When I put a breakpoint in the javascript debugger and i trigger the breakpoint the javascript execution does stop but the debugger becames unusable/broken: * the debugger does not seems to be in breakpoint (e.g. there are no stepper buttons like the "continue" button). * scrolling through the javascript code causes the code div to scroll but the line numbers do not scroll anymore. * closing the web inspector window will cause the javascript execution to continue: I suppose that the breakpoint was correctly triggered and cleared when exiting the window. 557098 16 zcrendel 2012-02-15 03:07:45 -0800 (In reply to comment #15) > Not sure that what's happening in our hybrid QtWebKit app with Qt 4.8.0 compiled from source on Windows and Mac OS X is related/linked to this bug, if not please advise. This is exactly the problem for which this bugreport was made. 557103 17 manuel.lazzari 2012-02-15 03:09:42 -0800 (In reply to comment #16) > This is exactly the problem for which this bugreport was made. Thanks, that's at least comfort me a little :) 571562 18 manuel.lazzari 2012-03-05 23:58:24 -0800 Is anyone working on this? Is there any patch or workaround? How this "remote debugging" works with Qt 4.8? 571716 19 zcrendel 2012-03-06 04:16:05 -0800 (In reply to comment #18) > Is anyone working on this? Is there any patch or workaround? How this "remote debugging" works with Qt 4.8? "remote debugging" works with Qt 4.8 well (with patched version or webkit), but local debugging still hasn't any workaround. 594506 20 saulo 2012-04-03 08:29:15 -0700 It is still broken on Qt-4.8.1. 626374 21 142441 eriktsarko 2012-05-17 01:27:46 -0700 Created attachment 142441 Patch Greetings everyone! After 3 days of debugging JavaScript debugger in QtWebkit I have found the reason of Web Inspector GUI lock when debuggee page was paused. The reason itself is quite trivial: Web Inspector front-end (also written in JavaScript) was also paused along with the debuggee page itself. I suppose that this bug has been introduced by commit a2ce7739 (qtwebkit repo) when every QWebPage being created was explicitly added to PageGroup called "Default Group". When debugger pauses page it also pauses all the pages that belong to its page group. So the Web Inspector page was paused too. The applied patch fixes this problem (I`ve tested it with Qt 4.8.1 with QtWebkit 2.2.2). 626383 22 142441 zalan 2012-05-17 01:59:39 -0700 Comment on attachment 142441 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142441&action=review Good catch! However you are missing changelog entry. Please look at the following page http://www.webkit.org/coding/contributing.html and submit your patch accordingly. > Source/WebKit/qt/WebCoreSupport/InspectorClientQt.cpp:67 > + // This leads that Web Inspector front-end is paused too leading to locked Web Inspector GUI (bugzilla ticket 71271). No need to mention the bug# in the comment. Changelog entry should have it. > Source/WebKit/qt/WebCoreSupport/InspectorClientQt.cpp:68 > + handle()->page->setGroupName("__WebInspectorPageGroup__"); I'd rather have it in InspectorClient::openInspectorFrontend() where we actually open the front end, something like m_frontendWebPage->setGroupName("group_name_comes_here"); 626416 23 142448 eriktsarko 2012-05-17 03:22:35 -0700 Created attachment 142448 Patch Zalan, I have recreated the patch according to your comments. Please review it and commit to the repo if it is ok. 626484 24 jarred 2012-05-17 05:38:53 -0700 Thanks Tsarko :) 626514 25 142448 webkit.review.bot 2012-05-17 06:25:42 -0700 Comment on attachment 142448 Patch Clearing flags on attachment: 142448 Committed r117440: <http://trac.webkit.org/changeset/117440> 626515 26 webkit.review.bot 2012-05-17 06:25:50 -0700 All reviewed patches have been landed. Closing bug. 627311 27 eriktsarko 2012-05-17 21:33:45 -0700 (In reply to comment #26) > All reviewed patches have been landed. Closing bug. Is there any chance that this fix will be merged into qtwebkit (git) repository, branch qtwebkit-2.2? 123960 2012-01-25 09:41:03 -0800 2012-01-25 10:06:20 -0800 Patch bug-71271-20120125124102.patch text/plain 2516 leo U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1ODc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0 L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IDhhNTBmNjU2Zjc1 MDA5YzBlNWJjM2YwNzNjMWI2YWE4MTBhNDBmZGUuLjhjMzg1NmRhNWMwZThmZDQzYmEyMWE5ZDFh ZTY1MzY2YzczNGIzMWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDEt MjUgIExlbyBGcmFuY2hpICA8bGZyYW5jaGlAa2RlLm9yZz4KKworICAgICAgICBbUXRdIFdlYiBJ bnNwZWN0b3I6IGluc3BlY3RvciBVSSBiZWNvbWVzIHVucmVzcG9uc2l2ZSBvbiBkZWJ1Z2dlciBw YXVzZQorCisgICAgICAgIEZpeGVzIHJlbW90ZSBpbnNwZWN0b3Igb25seS4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcxMjcxCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9JbnNw ZWN0b3JTZXJ2ZXJRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JTZXJ2ZXJSZXF1 ZXN0SGFuZGxlclF0Ojp0Y3BSZWFkeVJlYWQpOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9y U2VydmVyUmVxdWVzdEhhbmRsZXJRdDo6d2ViU29ja2V0UmVhZHlSZWFkKToKKwogMjAxMi0wMS0x NyAgVmlhdGNoZXNsYXYgT3N0YXBlbmtvICA8b3N0YXBlbmtvLnZpYXRjaGVzbGF2QG5va2lhLmNv bT4KIAogICAgICAgICBbUXRdIERlYnVnIGJ1aWxkIGZhaWxzIHdpdGggZGVidWcgcXQ1CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0luc3BlY3RvclNlcnZlclF0 LmNwcCBiL1NvdXJjZS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvSW5zcGVjdG9yU2VydmVyUXQu Y3BwCmluZGV4IGZkYzE0ZjUzMzYyOGQwMzk4YmZiYTM1OTUxNWE2MTJjYzAyNzliNmUuLjI2YzUy ZmY4OTIwY2UxYzhiYjI2NmE5YjQyYWY1YmIzNDY1NTNmNDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvSW5zcGVjdG9yU2VydmVyUXQuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvSW5zcGVjdG9yU2VydmVyUXQuY3BwCkBAIC0yMDks NyArMjA5LDcgQEAgdm9pZCBJbnNwZWN0b3JTZXJ2ZXJSZXF1ZXN0SGFuZGxlclF0Ojp0Y3BSZWFk eVJlYWQoKQogICAgICAgICAgICAgLy8gc3dpdGNoIHRvIHdlYnNvY2tldC1zdHlsZSBXZWJTb2Nr ZXRTZXJ2aWNlIG1lc3NhZ2luZwogICAgICAgICAgICAgaWYgKG1fdGNwQ29ubmVjdGlvbikgewog ICAgICAgICAgICAgICAgIG1fdGNwQ29ubmVjdGlvbi0+ZGlzY29ubmVjdChTSUdOQUwocmVhZHlS ZWFkKCkpKTsKLSAgICAgICAgICAgICAgICBjb25uZWN0KG1fdGNwQ29ubmVjdGlvbiwgU0lHTkFM KHJlYWR5UmVhZCgpKSwgU0xPVCh3ZWJTb2NrZXRSZWFkeVJlYWQoKSkpOworICAgICAgICAgICAg ICAgIGNvbm5lY3QobV90Y3BDb25uZWN0aW9uLCBTSUdOQUwocmVhZHlSZWFkKCkpLCBTTE9UKHdl YlNvY2tldFJlYWR5UmVhZCgpKSwgUXQ6OlF1ZXVlZENvbm5lY3Rpb24pOwogCiAgICAgICAgICAg ICAgICAgUUJ5dGVBcnJheSBrZXkzID0gbV90Y3BDb25uZWN0aW9uLT5yZWFkKDgpOwogCkBAIC0z NTcsNiArMzU3LDEwIEBAIHZvaWQgSW5zcGVjdG9yU2VydmVyUmVxdWVzdEhhbmRsZXJRdDo6d2Vi U29ja2V0UmVhZHlSZWFkKCkKIAogICAgICAgICBRQnl0ZUFycmF5IHBheWxvYWQgPSBtX2RhdGEu bWlkKDEsIGxlbmd0aCk7CiAKKyAgICAgICAgLy8gUmVtb3ZlIHRoaXMgV2ViU29ja2V0IG1lc3Nh Z2UgZnJvbSBtX2RhdGEgKHBheWxvYWQsIHN0YXJ0LW9mLWZyYW1lIGJ5dGUsIGVuZC1vZi1mcmFt ZSBieXRlKS4KKyAgICAgICAgLy8gVHJ1bmNhdGUgZGF0YSBiZWZvcmUgZGVsaXZlcmluZyBtZXNz YWdlIGluIGNhc2Ugb2YgcmUtZW50cmFuY3kuCisgICAgICAgIG1fZGF0YSA9IG1fZGF0YS5taWQo bGVuZ3RoICsgMik7CisgICAgICAgIAogI2lmIEVOQUJMRShJTlNQRUNUT1IpCiAgICAgICAgIGlm IChtX2luc3BlY3RvckNsaWVudCkgewogICAgICAgICAgIEluc3BlY3RvckNvbnRyb2xsZXIqIGlu c3BlY3RvckNvbnRyb2xsZXIgPSBtX2luc3BlY3RvckNsaWVudC0+bV9pbnNwZWN0ZWRXZWJQYWdl LT5kLT5wYWdlLT5pbnNwZWN0b3JDb250cm9sbGVyKCk7CkBAIC0zNjQsOCArMzY4LDYgQEAgdm9p ZCBJbnNwZWN0b3JTZXJ2ZXJSZXF1ZXN0SGFuZGxlclF0Ojp3ZWJTb2NrZXRSZWFkeVJlYWQoKQog ICAgICAgICB9CiAjZW5kaWYKIAotICAgICAgICAvLyBSZW1vdmUgdGhpcyBXZWJTb2NrZXQgbWVz c2FnZSBmcm9tIG1fZGF0YSAocGF5bG9hZCwgc3RhcnQtb2YtZnJhbWUgYnl0ZSwgZW5kLW9mLWZy YW1lIGJ5dGUpLgotICAgICAgICBtX2RhdGEgPSBtX2RhdGEubWlkKGxlbmd0aCArIDIpOwogICAg IH0KIH0KIAo= 142441 2012-05-17 01:27:46 -0700 2012-05-17 03:22:35 -0700 Patch webinspector_lock_fix.diff text/plain 1356 eriktsarko RnJvbSBhYzIwNWFkYzI5MzdjY2RkMTRjZWI1YWJlNjZmYTE1MmZjYzkxMzJhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiB5dHNhcmtvIDxlcmlrdHNhcmtvQGdvb2dsZW1haWwuY29tPgpE YXRlOiBUaHUsIDE3IE1heSAyMDEyIDExOjQ4OjQ4ICswNDAwClN1YmplY3Q6IFtQQVRDSF0gRml4 ZWQgYnVnIHdpdGggV2ViIEluc3BlY3RvciBHVUkgbG9jayB3aGVuIHBhZ2UgaXMgcGF1c2VkICho dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzEyNzEpCgotLS0KIC4uLi9X ZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvSW5zcGVjdG9yQ2xpZW50UXQuY3BwIHwgICAgNSArKysr KwogMSBmaWxlcyBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDAgZGVsZXRpb25zKC0pCgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9JbnNwZWN0b3JDbGllbnRR dC5jcHAgYi9Tb3VyY2UvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0luc3BlY3RvckNsaWVudFF0 LmNwcAppbmRleCAzNmVjNjk3Li42MWQ2MzBmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L3F0 L1dlYkNvcmVTdXBwb3J0L0luc3BlY3RvckNsaWVudFF0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 L3F0L1dlYkNvcmVTdXBwb3J0L0luc3BlY3RvckNsaWVudFF0LmNwcApAQCAtNjIsNiArNjIsMTEg QEAgcHVibGljOgogICAgIEluc3BlY3RvckNsaWVudFdlYlBhZ2UoUU9iamVjdCogcGFyZW50ID0g MCkKICAgICAgICAgOiBRV2ViUGFnZShwYXJlbnQpCiAgICAgeworICAgICAgICAvLyBXZWIgSW5z cGVjdG9yIHNob3VsZCBub3QgYmVsb25nIHRvIGFueSBvdGhlciBwYWdlIGdyb3VwcyBzaW5jZSBp dCBpcyBhIHNwZWNpYWxpemVkIGRlYnVnZ2VyIHdpbmRvdy4KKyAgICAgICAgLy8gVGhlIHJlYXNv biBmb3IgdGhpcyBjaGFuZ2UgaXMgd2hlbiBkZWJ1Z2dlciBwYXVzZXMgd2ViIHBhZ2UgaXQgcGF1 c2VzIGFsbCB0aGUgcGFnZXMgaW4gdGhlIHBhZ2UgZ3JvdXAgb2YgZGVidWdnZWUuCisgICAgICAg IC8vIFRoaXMgbGVhZHMgdGhhdCBXZWIgSW5zcGVjdG9yIGZyb250LWVuZCBpcyBwYXVzZWQgdG9v IGxlYWRpbmcgdG8gbG9ja2VkIFdlYiBJbnNwZWN0b3IgR1VJIChidWd6aWxsYSB0aWNrZXQgNzEy NzEpLgorICAgICAgICBoYW5kbGUoKS0+cGFnZS0+c2V0R3JvdXBOYW1lKCJfX1dlYkluc3BlY3Rv clBhZ2VHcm91cF9fIik7CisKICAgICAgICAgY29ubmVjdChtYWluRnJhbWUoKSwgU0lHTkFMKGph dmFTY3JpcHRXaW5kb3dPYmplY3RDbGVhcmVkKCkpLCBTTE9UKGphdmFTY3JpcHRXaW5kb3dPYmpl Y3RDbGVhcmVkKCkpKTsKICAgICB9CiAKLS0gCjEuNy40Lm1zeXNnaXQuMAoK 142448 2012-05-17 03:22:35 -0700 2012-05-17 06:25:42 -0700 Patch qtwebkit_webinspector_gui_lock_fix.patch text/plain 2349 eriktsarko RnJvbSA0NzI0NDE5MjUyNDU3MmIxZmU5MjQ4YjVmZmEyYmE3YzQzYzYyOGZhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUc2Fya28gWWFyb3NsYXYgIDxlcmlrdHNhcmtvQGdvb2dsZW1h aWwuY29tPgpEYXRlOiBUaHUsIDE3IE1heSAyMDEyIDEyOjE3OjE4ICswNDAwClN1YmplY3Q6IFtQ QVRDSF0gRml4ZWQgYnVnIHdpdGggV2ViIEluc3BlY3RvciBHVUkgbG9jayB3aGVuIGRlYnVnZ2Vl IHBhZ2UgaXMgcGF1c2VkCgotLS0KIFNvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nICAgICAgICAg ICAgICAgICAgICAgICAgIHwgICAxNCArKysrKysrKysrKysrKwogLi4uL1dlYktpdC9xdC9XZWJD b3JlU3VwcG9ydC9JbnNwZWN0b3JDbGllbnRRdC5jcHAgfCAgICAzICsrKwogMiBmaWxlcyBjaGFu Z2VkLCAxNyBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvcXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cKaW5kZXgg MDQ4NTAwZC4uYmZhNDc2NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMi0w NS0xNyAgVHNhcmtvIFlhcm9zbGF2ICA8ZXJpa3RzYXJrb0Bnb29nbGVtYWlsLmNvbT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBCdWcgNzEyNzE6IFtR dF0gV2ViIEluc3BlY3RvcjogbG9jYWwgaW5zcGVjdG9yIGNsaWVudCBVSSBiZWNvbWVzIHVucmVz cG9uc2l2ZSBvbiBkZWJ1Z2dlciBwYXVzZSBkdXJpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcxMjcxCisKKyAgICAgICAgV2ViIEluc3BlY3RvciBz aG91bGQgbm90IGJlbG9uZyB0byBhbnkgb3RoZXIgcGFnZSBncm91cHMgc2luY2UgaXQgaXMgYSBz cGVjaWFsaXplZCBkZWJ1Z2dlciB3aW5kb3cuCisgICAgICAgIFRoZSByZWFzb24gZm9yIHRoaXMg Y2hhbmdlIGlzIHdoZW4gZGVidWdnZXIgcGF1c2VzIHdlYiBwYWdlIGl0IHBhdXNlcyBhbGwgdGhl IHBhZ2VzIGluIHRoZSBwYWdlIGdyb3VwIG9mIGRlYnVnZ2VlLgorICAgICAgICBUaGlzIGxlYWRz IHRoYXQgV2ViIEluc3BlY3RvciBmcm9udC1lbmQgaXMgcGF1c2VkIHRvbyBsZWFkaW5nIHRvIGxv Y2tlZCBXZWIgSW5zcGVjdG9yIEdVSSAoYnVnemlsbGEgdGlja2V0IDcxMjcxKS4KKworICAgICAg ICAqIFdlYkNvcmVTdXBwb3J0L0luc3BlY3RvckNsaWVudFF0LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6Okluc3BlY3RvckNsaWVudFF0OjpvcGVuSW5zcGVjdG9yRnJvbnRlbmQpOgorCiAyMDEyLTA0 LTAyICBDYXNwZXIgdmFuIERvbmRlcmVuICA8Y2FzcGVyLnZhbmRvbmRlcmVuQG5va2lhLmNvbT4K IAogICAgICAgICBRdDogRG9jOiBGaXggdHlwbyB3aGljaCBtYXJrcyBkb2N1bWVudCB0byBiZSBw cmludGVkIGluIGNvbnNvbGUgZm9udC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvV2Vi Q29yZVN1cHBvcnQvSW5zcGVjdG9yQ2xpZW50UXQuY3BwIGIvU291cmNlL1dlYktpdC9xdC9XZWJD b3JlU3VwcG9ydC9JbnNwZWN0b3JDbGllbnRRdC5jcHAKaW5kZXggMzZlYzY5Ny4uNmM5MmZhMyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9JbnNwZWN0b3JDbGll bnRRdC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9JbnNwZWN0b3JD bGllbnRRdC5jcHAKQEAgLTIzNSw2ICsyMzUsOSBAQCB2b2lkIEluc3BlY3RvckNsaWVudFF0Ojpv cGVuSW5zcGVjdG9yRnJvbnRlbmQoV2ViQ29yZTo6SW5zcGVjdG9yQ29udHJvbGxlciogaW5zcAog ICAgIG1fZnJvbnRlbmRDbGllbnQgPSBuZXcgSW5zcGVjdG9yRnJvbnRlbmRDbGllbnRRdChtX2lu c3BlY3RlZFdlYlBhZ2UsIGluc3BlY3RvclZpZXcsIHRoaXMpOwogICAgIGluc3BlY3RvclZpZXct PnBhZ2UoKS0+ZC0+cGFnZS0+aW5zcGVjdG9yQ29udHJvbGxlcigpLT5zZXRJbnNwZWN0b3JGcm9u dGVuZENsaWVudChtX2Zyb250ZW5kQ2xpZW50KTsKICAgICBtX2Zyb250ZW5kV2ViUGFnZSA9IGlu c3BlY3RvclBhZ2U7CisKKyAgICAvLyBXZWIgSW5zcGVjdG9yIHNob3VsZCBub3QgYmVsb25nIHRv IGFueSBvdGhlciBwYWdlIGdyb3VwcyBzaW5jZSBpdCBpcyBhIHNwZWNpYWxpemVkIGRlYnVnZ2Vy IHdpbmRvdy4KKyAgICBtX2Zyb250ZW5kV2ViUGFnZS0+aGFuZGxlKCktPnBhZ2UtPnNldEdyb3Vw TmFtZSgiX19XZWJJbnNwZWN0b3JQYWdlR3JvdXBfXyIpOwogI2VuZGlmCiB9CiAKLS0gCjEuNy40 Lm1zeXNnaXQuMAoK