71261 2011-10-31 18:08:09 -0700 PluginProxy shouldn't use window-relative coordinates 2011-11-01 09:51:22 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 493691 0 andersca 2011-10-31 18:08:09 -0700 PluginProxy shouldn't use window-relative coordinates 493694 1 113118 andersca 2011-10-31 18:10:30 -0700 Created attachment 113118 Patch 493954 2 113118 aroben 2011-11-01 09:41:49 -0700 Comment on attachment 113118 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113118&action=review > Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp:151 > - IntRect dirtyRectInPluginCoordinates = dirtyRect; > - dirtyRectInPluginCoordinates.move(-m_frameRectInWindowCoordinates.x(), -m_frameRectInWindowCoordinates.y()); > - > - m_backingStore->paint(*graphicsContext, contentsScaleFactor(), dirtyRect.location(), dirtyRectInPluginCoordinates); > + m_backingStore->paint(*graphicsContext, contentsScaleFactor(), dirtyRect.location(), dirtyRect); If I were just to read this code change on its own, I would think that you are now passing a dirtyRect in window coordinates to paint(), since you are no longer converting to plugin coordinates. Perhaps the ChangeLog should explain that dirtyRect is now already in plugin coordinates so no conversion is necessary. 493962 3 andersca 2011-11-01 09:51:22 -0700 Committed r98972: <http://trac.webkit.org/changeset/98972> 113118 2011-10-31 18:10:30 -0700 2011-11-01 09:41:49 -0700 Patch bug-71261-20111031181017.patch text/plain 4317 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogOTg5MjgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCBiZmJiMTNlMDg2OGMxODJj MTQ0YmFmZThkMjBiNmMzYjc2MmZmZmJhLi5mMDJjODgxMmJjYWU4Nzk3YWU2ZGM2ODdmOTA2MzE2 MWVlYjQ5YjllIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjYgQEAKIDIwMTEtMTAtMzEgIEFuZGVy cyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAorICAgICAgICBQbHVnaW5Qcm94eSBz aG91bGRuJ3QgdXNlIHdpbmRvdy1yZWxhdGl2ZSBjb29yZGluYXRlcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzEyNjEKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGFuZ2UgUGx1Z2luUHJveHk6OndhbnRz V2luZG93UmVsYXRpdmVDb29yZGluYXRlcyB0byByZXR1cm4gZmFsc2UgYW5kIHJlbW92ZQorICAg ICAgICBtX2ZyYW1lUmVjdEluV2luZG93Q29vcmRpbmF0ZXMgYW5kIG1fY2xpcFJlY3RJbldpbmRv d0Nvb3JkaW5hdGVzLiBUaGlzIGlzIHlldCBhbm90aGVyIHN0ZXAKKyAgICAgICAgdG93YXJkcyBl bGltaW5hdGluZyB3aW5kb3ctcmVsYXRpdmUgY29vcmRpbmF0ZXMgd2hlcmV2ZXIgcG9zc2libGUu CisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luUHJveHkuY3BwOgorICAgICAg ICAoV2ViS2l0OjpQbHVnaW5Qcm94eTo6cGFpbnQpOgorICAgICAgICBBbHdheXMgcGFzcyB0aGUg ZGlydHkgcmVjdCBpbiBwbHVnLWluIGNvb3JkaW5hdGVzIHRvIEJhY2tpbmdTdG9yZTo6cGFpbnQu CisKKyAgICAgICAgKFdlYktpdDo6UGx1Z2luUHJveHk6OmRlcHJlY2F0ZWRHZW9tZXRyeURpZENo YW5nZSk6CisgICAgICAgIEFzc2VydCB0aGF0IHdlJ3JlIG5vdCBjYWxsaW5nIHRoaXMgYW55bW9y ZS4KKworICAgICAgICAoV2ViS2l0OjpQbHVnaW5Qcm94eTo6d2FudHNXaW5kb3dSZWxhdGl2ZUNv b3JkaW5hdGVzKToKKyAgICAgICAgUmV0dXJuIGZhbHNlLgorCisyMDExLTEwLTMxICBBbmRlcnMg Q2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKICAgICAgICAgUGx1Z2luUHJveHk6OlVw ZGF0ZSBzaG91bGQgcGFzcyB0aGUgcGFpbnRlZCByZWN0IGluIHBsdWctaW4gY29vcmRpbmF0ZXMK ICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcxMjU3CiAK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QbHVnaW5Qcm94 eS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luUHJveHkuY3Bw CmluZGV4IGVjODI2MWM0ZGE5ZTVhYzc5MTY3NDg3ZjUwNzJkYzU2MzVhMDljZmIuLjkzMTI3N2Zi MjA0NDI3MzVlZGFmNjg3NGQ2ZmMxMjJkZDBhYzZjZDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QbHVnaW5Qcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BsdWdpblByb3h5LmNwcApAQCAtMTQ4LDEwICsxNDgsNyBA QCB2b2lkIFBsdWdpblByb3h5OjpwYWludChHcmFwaGljc0NvbnRleHQqIGdyYXBoaWNzQ29udGV4 dCwgY29uc3QgSW50UmVjdCYgZGlydHlSZQogICAgICAgICBtX3BsdWdpbkJhY2tpbmdTdG9yZUNv bnRhaW5zVmFsaWREYXRhID0gdHJ1ZTsKICAgICB9CiAKLSAgICBJbnRSZWN0IGRpcnR5UmVjdElu UGx1Z2luQ29vcmRpbmF0ZXMgPSBkaXJ0eVJlY3Q7Ci0gICAgZGlydHlSZWN0SW5QbHVnaW5Db29y ZGluYXRlcy5tb3ZlKC1tX2ZyYW1lUmVjdEluV2luZG93Q29vcmRpbmF0ZXMueCgpLCAtbV9mcmFt ZVJlY3RJbldpbmRvd0Nvb3JkaW5hdGVzLnkoKSk7Ci0KLSAgICBtX2JhY2tpbmdTdG9yZS0+cGFp bnQoKmdyYXBoaWNzQ29udGV4dCwgY29udGVudHNTY2FsZUZhY3RvcigpLCBkaXJ0eVJlY3QubG9j YXRpb24oKSwgZGlydHlSZWN0SW5QbHVnaW5Db29yZGluYXRlcyk7CisgICAgbV9iYWNraW5nU3Rv cmUtPnBhaW50KCpncmFwaGljc0NvbnRleHQsIGNvbnRlbnRzU2NhbGVGYWN0b3IoKSwgZGlydHlS ZWN0LmxvY2F0aW9uKCksIGRpcnR5UmVjdCk7CiAKICAgICBpZiAobV93YWl0aW5nRm9yUGFpbnRJ blJlc3BvbnNlVG9VcGRhdGUpIHsKICAgICAgICAgbV93YWl0aW5nRm9yUGFpbnRJblJlc3BvbnNl VG9VcGRhdGUgPSBmYWxzZTsKQEAgLTIwOSwxMCArMjA2LDkgQEAgdm9pZCBQbHVnaW5Qcm94eTo6 Z2VvbWV0cnlEaWRDaGFuZ2UoKQogICAgIG1fY29ubmVjdGlvbi0+Y29ubmVjdGlvbigpLT5zZW5k KE1lc3NhZ2VzOjpQbHVnaW5Db250cm9sbGVyUHJveHk6Okdlb21ldHJ5RGlkQ2hhbmdlKG1fcGx1 Z2luU2l6ZSwgbV9jbGlwUmVjdCwgbV9wbHVnaW5Ub1Jvb3RWaWV3VHJhbnNmb3JtLCBmcmFtZVJl Y3RJbldpbmRvd0Nvb3JkaW5hdGVzLCBjb250ZW50c1NjYWxlRmFjdG9yKCksIHBsdWdpbkJhY2tp bmdTdG9yZUhhbmRsZSksIG1fcGx1Z2luSW5zdGFuY2VJRCwgQ29yZUlQQzo6RGlzcGF0Y2hNZXNz YWdlRXZlbldoZW5XYWl0aW5nRm9yU3luY1JlcGx5KTsKIH0KIAotdm9pZCBQbHVnaW5Qcm94eTo6 ZGVwcmVjYXRlZEdlb21ldHJ5RGlkQ2hhbmdlKGNvbnN0IEludFJlY3QmIGZyYW1lUmVjdEluV2lu ZG93Q29vcmRpbmF0ZXMsIGNvbnN0IEludFJlY3QmIGNsaXBSZWN0SW5XaW5kb3dDb29yZGluYXRl cykKK3ZvaWQgUGx1Z2luUHJveHk6OmRlcHJlY2F0ZWRHZW9tZXRyeURpZENoYW5nZShjb25zdCBJ bnRSZWN0JiwgY29uc3QgSW50UmVjdCYpCiB7Ci0gICAgbV9mcmFtZVJlY3RJbldpbmRvd0Nvb3Jk aW5hdGVzID0gZnJhbWVSZWN0SW5XaW5kb3dDb29yZGluYXRlczsKLSAgICBtX2NsaXBSZWN0SW5X aW5kb3dDb29yZGluYXRlcyA9IGNsaXBSZWN0SW5XaW5kb3dDb29yZGluYXRlczsKKyAgICBBU1NF UlRfTk9UX1JFQUNIRUQoKTsKIH0KIAogdm9pZCBQbHVnaW5Qcm94eTo6Z2VvbWV0cnlEaWRDaGFu Z2UoY29uc3QgSW50U2l6ZSYgcGx1Z2luU2l6ZSwgY29uc3QgSW50UmVjdCYgY2xpcFJlY3QsIGNv bnN0IEFmZmluZVRyYW5zZm9ybSYgcGx1Z2luVG9Sb290Vmlld1RyYW5zZm9ybSkKQEAgLTQxNiw3 ICs0MTIsNyBAQCBib29sIFBsdWdpblByb3h5OjpoYW5kbGVTY3JvbGwoU2Nyb2xsRGlyZWN0aW9u LCBTY3JvbGxHcmFudWxhcml0eSkKIAogYm9vbCBQbHVnaW5Qcm94eTo6d2FudHNXaW5kb3dSZWxh dGl2ZUNvb3JkaW5hdGVzKCkKIHsKLSAgICByZXR1cm4gdHJ1ZTsKKyAgICByZXR1cm4gZmFsc2U7 CiB9CiAKIFNjcm9sbGJhciogUGx1Z2luUHJveHk6Omhvcml6b250YWxTY3JvbGxiYXIoKQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BsdWdpblByb3h5Lmgg Yi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luUHJveHkuaAppbmRleCAw OWJlYTY3YTViNDg5MTgxOGU5OGM1MDA4MjQ4MzRlNWI4MGZlM2VhLi42NGUyOGY2ZGI1NzNhYzk3 MmIxYWY1ODgyYWZjZWQyMThkNzdmYTg4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL1BsdWdpbnMvUGx1Z2luUHJveHkuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL1BsdWdpbnMvUGx1Z2luUHJveHkuaApAQCAtMTQ5LDE0ICsxNDksNiBAQCBwcml2YXRlOgog ICAgIC8vIEEgdHJhbnNmb3JtIHRoYXQgY2FuIGJlIHVzZWQgdG8gY29udmVydCBmcm9tIHJvb3Qg dmlldyBjb29yZGluYXRlcyB0byBwbHVnLWluIGNvb3JkaW5hdGVzLgogICAgIFdlYkNvcmU6OkFm ZmluZVRyYW5zZm9ybSBtX3BsdWdpblRvUm9vdFZpZXdUcmFuc2Zvcm07CiAKLSAgICAvLyBGSVhN RTogR2V0IHJpZCBvZiB0aGUgd2luZG93IGNvb3JkaW5hdGUgYmFzZWQgcmVjdHMuCi0KLSAgICAv LyBUaGUgcGx1Zy1pbiByZWN0IGluIHdpbmRvdyBjb29yZGluYXRlcy4KLSAgICBXZWJDb3JlOjpJ bnRSZWN0IG1fZnJhbWVSZWN0SW5XaW5kb3dDb29yZGluYXRlczsKLQotICAgIC8vIFRoZSBwbHVn LWluIGNsaXAgcmVjdCBpbiB3aW5kb3cgY29vcmRpbmF0ZXMuCi0gICAgV2ViQ29yZTo6SW50UmVj dCBtX2NsaXBSZWN0SW5XaW5kb3dDb29yZGluYXRlczsKLQogICAgIC8vIFRoaXMgaXMgdGhlIGJh Y2tpbmcgc3RvcmUgdGhhdCB3ZSBwYWludCB3aGVuIHdlJ3JlIHRvbGQgdG8gcGFpbnQuCiAgICAg UmVmUHRyPFNoYXJlYWJsZUJpdG1hcD4gbV9iYWNraW5nU3RvcmU7CiAK