<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>71260</bug_id>
          
          <creation_ts>2011-10-31 17:58:24 -0700</creation_ts>
          <short_desc>Leaks seen in RenderFlowThread::setRegionRangeForBox on Leaks bot</short_desc>
          <delta_ts>2011-11-06 14:27:40 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc>http://build.webkit.org/LeaksViewer/?url=http%3A%2F%2Fbuild.webkit.org%2F%2Fresults%2FSnowLeopard%20Intel%20Leaks%2Fr98879%20(19849)%2F</bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar, MakingBotsRed</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>57312</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Adam Roben (:aroben)">aroben</reporter>
          <assigned_to name="Darin Adler">darin</assigned_to>
          <cc>darin</cc>
    
    <cc>hyatt</cc>
    
    <cc>mihnea</cc>
    
    <cc>mitz</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>493683</commentid>
    <comment_count>0</comment_count>
    <who name="Adam Roben (:aroben)">aroben</who>
    <bug_when>2011-10-31 17:58:24 -0700</bug_when>
    <thetext>http://build.webkit.org/LeaksViewer/?url=http%3A%2F%2Fbuild.webkit.org%2F%2Fresults%2FSnowLeopard%20Intel%20Leaks%2Fr98879%20(19849)%2F

malloc_zone_malloc &gt; malloc &gt; fastMalloc &gt; RenderFlowThread::setRegionRangeForBox

We&apos;re leaking in this function. Looks like we&apos;re allocating a new RenderRegionRange, storing it in a HashMap, and never deleting it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>493684</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2011-10-31 17:58:56 -0700</bug_when>
    <thetext>&lt;rdar://problem/10374428&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>496759</commentid>
    <comment_count>2</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2011-11-05 18:19:47 -0700</bug_when>
    <thetext>*** Bug 71620 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>496761</commentid>
    <comment_count>3</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2011-11-05 18:20:43 -0700</bug_when>
    <thetext>This is the same leak as 71259.

*** This bug has been marked as a duplicate of bug 71259 ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>496763</commentid>
    <comment_count>4</comment_count>
    <who name="Adam Roben (:aroben)">aroben</who>
    <bug_when>2011-11-05 18:22:29 -0700</bug_when>
    <thetext>How are they the same? Bug 71259 is about leaks of RenderBoxRegionInfo objects, this bug is about leaks of RenderRegionRange objects.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>496765</commentid>
    <comment_count>5</comment_count>
    <who name="Adam Roben (:aroben)">aroben</who>
    <bug_when>2011-11-05 18:23:18 -0700</bug_when>
    <thetext>I guess one of those objects could own the other…</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>496804</commentid>
    <comment_count>6</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2011-11-06 08:42:04 -0800</bug_when>
    <thetext>Adam’s right. This is not a duplicate.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>496845</commentid>
    <comment_count>7</comment_count>
    <who name="Mihnea Ovidenie">mihnea</who>
    <bug_when>2011-11-06 12:37:21 -0800</bug_when>
    <thetext>In function RenderFlowThread::removeRenderBoxRegionInfo, the RenderRegionRange* for box is removed from the map but not deleted.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>496884</commentid>
    <comment_count>8</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2011-11-06 14:24:29 -0800</bug_when>
    <thetext>Yes, you can see the patch I already posted and got reviewed to fix this in bug 71620.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>496885</commentid>
    <comment_count>9</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2011-11-06 14:27:40 -0800</bug_when>
    <thetext>Committed r99384: &lt;http://trac.webkit.org/changeset/99384&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>