71259 2011-10-31 17:57:23 -0700 Leaks seen in RenderRegion::setRenderBoxRegionInfo on Leaks bot 2011-11-07 13:15:14 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED http://build.webkit.org/LeaksViewer/?url=http%3A%2F%2Fbuild.webkit.org%2F%2Fresults%2FSnowLeopard%20Intel%20Leaks%2Fr98879%20(19849)%2F InRadar, MakingBotsRed P2 Normal --- 57312 1 aroben mihnea darin hyatt mihnea mitz simon.fraser webkit-bug-importer webkit.review.bot oldest_to_newest 493681 0 aroben 2011-10-31 17:57:23 -0700 http://build.webkit.org/LeaksViewer/?url=http%3A%2F%2Fbuild.webkit.org%2F%2Fresults%2FSnowLeopard%20Intel%20Leaks%2Fr98879%20(19849)%2F malloc_zone_malloc > malloc > fastMalloc > RenderRegion::setRenderBoxRegionInfo We're leaking in this function. Looks like we're allocating a new RenderBoxRegionInfo, storing it in a HashMap, and never deleting it. 493682 1 webkit-bug-importer 2011-10-31 17:57:35 -0700 <rdar://problem/10374417> 496762 2 darin 2011-11-05 18:20:43 -0700 *** Bug 71260 has been marked as a duplicate of this bug. *** 496791 3 mihnea 2011-11-06 01:44:14 -0800 I have taken a look at both methods RenderRegion::setRenderBoxRegionInfo and RenderFlowThread::setRegionRangeForBox. Using our current tests, i was not able to find a place where we leak in these functions and their associated data. What i have found is that in JavaScriptCore/Parser.cpp, Parser class destructor, we are not freeing the Lexer object that was allocated in the Parser ctor. I will make a patch with that fix unless there is a reason for doing that after https://bugs.webkit.org/show_bug.cgi?id=71138. 496814 4 mihnea 2011-11-06 10:29:46 -0800 Leaks are reported if one loads fast/regions/overflow-in-uniform-regions-dynamic.html. 496840 5 mihnea 2011-11-06 12:23:40 -0800 In RenderFlowThread::logicalWidthChangedInRegions, oldInfo is deleted only inside the condition: if (!newInfo || newInfo->logicalWidth() != oldInfo->logicalWidth()) { .... } Otherwise, it is left undeleted and leaked. 496844 6 mihnea 2011-11-06 12:34:23 -0800 The other leak is in function RenderRegion::removeRenderBoxRegionInfo, when the RenderBoxRegionInfo is removed from the map but not deleted. 496848 7 mihnea 2011-11-06 12:41:59 -0800 Darin, I can make a patch for this one and another for 71260 if this is ok with you. 496887 8 darin 2011-11-06 14:28:43 -0800 Sure, if you want to handle this, that’s fine. 497076 9 113846 mihnea 2011-11-07 04:51:08 -0800 Created attachment 113846 Patch 497412 10 113846 webkit.review.bot 2011-11-07 13:15:09 -0800 Comment on attachment 113846 Patch Clearing flags on attachment: 113846 Committed r99467: <http://trac.webkit.org/changeset/99467> 497413 11 webkit.review.bot 2011-11-07 13:15:14 -0800 All reviewed patches have been landed. Closing bug. 113846 2011-11-07 04:51:08 -0800 2011-11-07 13:15:09 -0800 Patch 71259.patch text/plain 2448 mihnea ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiNWQzNDcwLi5mZjBhZGVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTEtMTEtMDcgIE1paG5lYSBPdmlkZW5pZSAgPG1paG5lYUBhZG9iZS5jb20+CisKKyAg ICAgICAgTGVha3Mgc2VlbiBpbiBSZW5kZXJSZWdpb246OnNldFJlbmRlckJveFJlZ2lvbkluZm8g b24gTGVha3MgYm90CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD03MTI1OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIExlYWsgZml4ZXMgY292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICAqIHJl bmRlcmluZy9SZW5kZXJGbG93VGhyZWFkLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckZs b3dUaHJlYWQ6OmxvZ2ljYWxXaWR0aENoYW5nZWRJblJlZ2lvbnMpOgorICAgICAgICBUaGUgUmVu ZGVyQm94UmVnaW9uSW5mbyB0YWtlbiBvdXQgb2YgUmVuZGVyUmVnaW9uIG11c3QgYmUgZGVsZXRl ZCBvbiBhbGwgY29kZSBwYXRocy4KKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyUmVnaW9uLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclJlZ2lvbjo6cmVtb3ZlUmVuZGVyQm94UmVnaW9u SW5mbyk6CisgICAgICAgIFRoZSBSZW5kZXJCb3hSZWdpb25JbmZvIG1hcCBvd25zIHRoZSB2YWx1 ZXMsIHRoZXJlZm9yZSwgd2hlbiB2YWx1ZXMgYXJlIHJlbW92ZWQgZnJvbSBtYXAKKyAgICAgICAg dGhleSBtdXN0IGFsc28gYmUgZGVsZXRlZC4KKwogMjAxMS0xMS0wNyAgS2Vpc2hpIEhhdHRvcmkg IDxrZWlzaGlAd2Via2l0Lm9yZz4KIAogICAgICAgICBDaGFuZ2UgQ29sb3JDaG9vc2VyIGZyb20g c2luZ2xldG9uIHRvIG9yZGluYXJ5IG9iamVjdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckZsb3dUaHJlYWQuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckZsb3dUaHJlYWQuY3BwCmluZGV4IDU3N2U5NTYuLjBjMzNmZDcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGbG93VGhyZWFkLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmxvd1RocmVhZC5jcHAKQEAgLTY1OCwxNiArNjU4 LDE3IEBAIGJvb2wgUmVuZGVyRmxvd1RocmVhZDo6bG9naWNhbFdpZHRoQ2hhbmdlZEluUmVnaW9u cyhjb25zdCBSZW5kZXJCbG9jayogYmxvY2ssIExhCiAgICAgICAgIGlmICghb2xkSW5mbykKICAg ICAgICAgICAgIGNvbnRpbnVlOwogCisgICAgICAgIExheW91dFVuaXQgb2xkTG9naWNhbFdpZHRo ID0gb2xkSW5mby0+bG9naWNhbFdpZHRoKCk7CisgICAgICAgIGRlbGV0ZSBvbGRJbmZvOworCiAg ICAgICAgIFJlbmRlckJveFJlZ2lvbkluZm8qIG5ld0luZm8gPSBibG9jay0+cmVuZGVyQm94UmVn aW9uSW5mbyhyZWdpb24sIG9mZnNldEZyb21Mb2dpY2FsVG9wT2ZGaXJzdFBhZ2UpOwotICAgICAg ICBpZiAoIW5ld0luZm8gfHwgbmV3SW5mby0+bG9naWNhbFdpZHRoKCkgIT0gb2xkSW5mby0+bG9n aWNhbFdpZHRoKCkpIHsKLSAgICAgICAgICAgIGRlbGV0ZSBvbGRJbmZvOworICAgICAgICBpZiAo IW5ld0luZm8gfHwgbmV3SW5mby0+bG9naWNhbFdpZHRoKCkgIT0gb2xkTG9naWNhbFdpZHRoKQog ICAgICAgICAgICAgcmV0dXJuIHRydWU7Ci0gICAgICAgIH0KLSAgICAgICAgCisKICAgICAgICAg aWYgKHJlZ2lvbiA9PSBlbmRSZWdpb24pCiAgICAgICAgICAgICBicmVhazsKICAgICB9Ci0gICAg CisKICAgICByZXR1cm4gZmFsc2U7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJSZWdpb24uY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl clJlZ2lvbi5jcHAKaW5kZXggZmU2MGY2OS4uZjU3MzkzYSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlclJlZ2lvbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlclJlZ2lvbi5jcHAKQEAgLTIyNCw3ICsyMjQsNyBAQCBSZW5kZXJCb3hSZWdp b25JbmZvKiBSZW5kZXJSZWdpb246OnRha2VSZW5kZXJCb3hSZWdpb25JbmZvKGNvbnN0IFJlbmRl ckJveCogYm94KQogCiB2b2lkIFJlbmRlclJlZ2lvbjo6cmVtb3ZlUmVuZGVyQm94UmVnaW9uSW5m byhjb25zdCBSZW5kZXJCb3gqIGJveCkKIHsKLSAgICBtX3JlbmRlckJveFJlZ2lvbkluZm8ucmVt b3ZlKGJveCk7CisgICAgZGVsZXRlIG1fcmVuZGVyQm94UmVnaW9uSW5mby50YWtlKGJveCk7CiB9 CiAKIHZvaWQgUmVuZGVyUmVnaW9uOjpkZWxldGVBbGxSZW5kZXJCb3hSZWdpb25JbmZvKCkK