71257 2011-10-31 17:39:20 -0700 PluginProxy::Update should pass the painted rect in plug-in coordinates 2011-10-31 17:59:49 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 493670 0 andersca 2011-10-31 17:39:20 -0700 PluginProxy::Update should pass the painted rect in plug-in coordinates 493671 1 113116 andersca 2011-10-31 17:40:38 -0700 Created attachment 113116 Patch 493672 2 113116 aroben 2011-10-31 17:41:34 -0700 Comment on attachment 113116 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113116&action=review > Source/WebKit2/ChangeLog:4 > + PluginProxy::Update should pass the painted rect in plug-in coordinates > + https://bugs.webkit.org/show_bug.cgi?id=71257 Can you explain why doing it the new way is better? 493685 3 andersca 2011-10-31 17:59:49 -0700 Committed r98928: <http://trac.webkit.org/changeset/98928> 113116 2011-10-31 17:40:38 -0700 2011-10-31 17:41:34 -0700 Patch bug-71257-20111031174024.patch text/plain 4439 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogOTg5MjMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCA0MzU0OGZiN2VkMjkwNTU1 YzNlNzY1NDZjNDI0MjlhNDFlMjVhMWE1Li5iNjUyZjdiZTQ1ZDM4ODhkOTM2NDE3M2QxN2M1MGVk MWE4ZmI5M2FlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjMgQEAKIDIwMTEtMTAtMzEgIEFuZGVy cyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAorICAgICAgICBQbHVnaW5Qcm94eTo6 VXBkYXRlIHNob3VsZCBwYXNzIHRoZSBwYWludGVkIHJlY3QgaW4gcGx1Zy1pbiBjb29yZGluYXRl cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzEyNTcK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFBsdWdp blByb2Nlc3MvUGx1Z2luQ29udHJvbGxlclByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6UGx1 Z2luQ29udHJvbGxlclByb3h5OjpwYWludCk6CisgICAgICAgIENvbnZlcnQgdGhlIGRpcnR5IHJl Y3QgYmFjayB0byBwbHVnLWluIGNvb3JkaW5hdGVzLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9Q bHVnaW5zL1BsdWdpblByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6UGx1Z2luUHJveHk6OnVw ZGF0ZSk6CisgICAgICAgIE5vIG5lZWQgdG8gY29udmVydCB0aGUgcGFpbnRlZCByZWN0IGJhY2sg dG8gcGx1Zy1pbiBjb29yZGluYXRlcyBhbnltb3JlLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9Q bHVnaW5zL1BsdWdpblByb3h5Lm1lc3NhZ2VzLmluOgorICAgICAgICBEb2N1bWVudCB0aGF0IHRo ZSBwYWludGVkIHJlY3QgaXMgaW4gcGx1Zy1pbiBjb29yZGluYXRlcy4KKworMjAxMS0xMC0zMSAg QW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgorCiAgICAgICAgIFBsdWdpbkNv bnRyb2xsZXJQcm94eSBzaG91bGQgY2FsbCBQbHVnaW46Omdlb21ldHJ5RGlkQ2hhbmdlCiAgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MTI1NQogCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9QbHVnaW5Qcm9jZXNzL1BsdWdpbkNvbnRyb2xsZXJQcm94 eS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9QbHVnaW5Qcm9jZXNzL1BsdWdpbkNvbnRyb2xsZXJQcm94 eS5jcHAKaW5kZXggMjY2YWM3OWUxNTU2YTY3MjQ2NjIyNzk3Y2QxYTFlMzI0MDQ3MGJiNS4uYTc4 Mjg0MjgyZDI2OTI4ZGVlYTNjYTkwMzk3ZGZkY2I2MzAxZGEwNSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvUGx1Z2luUHJvY2Vzcy9QbHVnaW5Db250cm9sbGVyUHJveHkuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQyL1BsdWdpblByb2Nlc3MvUGx1Z2luQ29udHJvbGxlclByb3h5LmNwcApAQCAt MTc2LDYgKzE3Niw4IEBAIHZvaWQgUGx1Z2luQ29udHJvbGxlclByb3h5OjpwYWludCgpCiAKICAg ICBtX3BsdWdpbi0+cGFpbnQoZ3JhcGhpY3NDb250ZXh0LmdldCgpLCBkaXJ0eVJlY3QpOwogCisg ICAgLy8gQ29udmVydCB0aGUgZGlydHkgcmVjdCBiYWNrIHRvIHBsdWctaW4gY29vcmRpbmF0ZXMu CisgICAgZGlydHlSZWN0Lm1vdmUoLW1fZnJhbWVSZWN0SW5XaW5kb3dDb29yZGluYXRlcy54KCks IC1tX2ZyYW1lUmVjdEluV2luZG93Q29vcmRpbmF0ZXMueSgpKTsKICAgICBtX2Nvbm5lY3Rpb24t PmNvbm5lY3Rpb24oKS0+c2VuZChNZXNzYWdlczo6UGx1Z2luUHJveHk6OlVwZGF0ZShkaXJ0eVJl Y3QpLCBtX3BsdWdpbkluc3RhbmNlSUQpOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luUHJveHkuY3BwIGIvU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9QbHVnaW5zL1BsdWdpblByb3h5LmNwcAppbmRleCBjNjViMWJkOTdjYjE5NzJjYTY2 NDA2ZDQzYTRmM2YxYzgyZDEwNWNiLi5lYzgyNjFjNGRhOWU1YWM3OTE2NzQ4N2Y1MDcyZGM1NjM1 YTA5Y2ZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUGx1 Z2luUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QbHVn aW5Qcm94eS5jcHAKQEAgLTU1MSwyNCArNTUxLDIwIEBAIHZvaWQgUGx1Z2luUHJveHk6OnNldFN0 YXR1c2JhclRleHQoY29uc3QgU3RyaW5nJiBzdGF0dXNiYXJUZXh0KQogCiB2b2lkIFBsdWdpblBy b3h5Ojp1cGRhdGUoY29uc3QgSW50UmVjdCYgcGFpbnRlZFJlY3QpCiB7Ci0gICAgaWYgKHBhaW50 ZWRSZWN0ID09IG1fZnJhbWVSZWN0SW5XaW5kb3dDb29yZGluYXRlcykKKyAgICBpZiAocGFpbnRl ZFJlY3QgPT0gcGx1Z2luQm91bmRzKCkpCiAgICAgICAgIG1fcGx1Z2luQmFja2luZ1N0b3JlQ29u dGFpbnNWYWxpZERhdGEgPSB0cnVlOwogCi0gICAgSW50UmVjdCBwYWludGVkUmVjdFBsdWdpbkNv b3JkaW5hdGVzID0gcGFpbnRlZFJlY3Q7Ci0gICAgcGFpbnRlZFJlY3RQbHVnaW5Db29yZGluYXRl cy5tb3ZlKC1tX2ZyYW1lUmVjdEluV2luZG93Q29vcmRpbmF0ZXMueCgpLCAtbV9mcmFtZVJlY3RJ bldpbmRvd0Nvb3JkaW5hdGVzLnkoKSk7Ci0KICAgICBpZiAobV9iYWNraW5nU3RvcmUpIHsKICAg ICAgICAgLy8gQmxpdCB0aGUgcGx1Zy1pbiBiYWNraW5nIHN0b3JlIGludG8gb3VyIG93biBiYWNr aW5nIHN0b3JlLgogICAgICAgICBPd25QdHI8R3JhcGhpY3NDb250ZXh0PiBncmFwaGljc0NvbnRl eHQgPSBtX2JhY2tpbmdTdG9yZS0+Y3JlYXRlR3JhcGhpY3NDb250ZXh0KCk7CiAgICAgICAgIGdy YXBoaWNzQ29udGV4dC0+YXBwbHlEZXZpY2VTY2FsZUZhY3Rvcihjb250ZW50c1NjYWxlRmFjdG9y KCkpOwogICAgICAgICBncmFwaGljc0NvbnRleHQtPnNldENvbXBvc2l0ZU9wZXJhdGlvbihDb21w b3NpdGVDb3B5KTsKLSAgICAgICAgbV9wbHVnaW5CYWNraW5nU3RvcmUtPnBhaW50KCpncmFwaGlj c0NvbnRleHQsIGNvbnRlbnRzU2NhbGVGYWN0b3IoKSwgcGFpbnRlZFJlY3RQbHVnaW5Db29yZGlu YXRlcy5sb2NhdGlvbigpLCAKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBh aW50ZWRSZWN0UGx1Z2luQ29vcmRpbmF0ZXMpOworICAgICAgICBtX3BsdWdpbkJhY2tpbmdTdG9y ZS0+cGFpbnQoKmdyYXBoaWNzQ29udGV4dCwgY29udGVudHNTY2FsZUZhY3RvcigpLCBwYWludGVk UmVjdC5sb2NhdGlvbigpLCBwYWludGVkUmVjdCk7CiAgICAgfQogCiAgICAgLy8gQXNrIHRoZSBj b250cm9sbGVyIHRvIGludmFsaWRhdGUgdGhlIHJlY3QgZm9yIHVzLgogICAgIG1fd2FpdGluZ0Zv clBhaW50SW5SZXNwb25zZVRvVXBkYXRlID0gdHJ1ZTsKLSAgICBjb250cm9sbGVyKCktPmludmFs aWRhdGUocGFpbnRlZFJlY3RQbHVnaW5Db29yZGluYXRlcyk7CisgICAgY29udHJvbGxlcigpLT5p bnZhbGlkYXRlKHBhaW50ZWRSZWN0KTsKIH0KIAogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luUHJveHkubWVz c2FnZXMuaW4gYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luUHJveHku bWVzc2FnZXMuaW4KaW5kZXggM2Y0NDA1NjczZDUzNjA1MjE3ZTczNGZiNTQ4ODQ3OTc0ZDY2YjIw ZC4uY2U3NTYxNjlhNTcyOWQwOTk3MzU4NjhjOWRjYTU4NGRmZGMyYTUyNCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BsdWdpblByb3h5Lm1lc3NhZ2VzLmlu CisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QbHVnaW5Qcm94eS5tZXNz YWdlcy5pbgpAQCAtMjYsNyArMjYsNyBAQCBtZXNzYWdlcyAtPiBQbHVnaW5Qcm94eSB7CiAgICAg IyBBc2tzIHRoZSB3ZWIgcHJvY2VzcyB0byBsb2FkIGEgVVJMLgogICAgIExvYWRVUkwodWludDY0 X3QgcmVxdWVzdElELCBXVEY6OlN0cmluZyBtZXRob2QsIFdURjo6U3RyaW5nIHVybFN0cmluZywg V1RGOjpTdHJpbmcgdGFyZ2V0LCBXZWJDb3JlOjpIVFRQSGVhZGVyTWFwIGhlYWRlckZpZWxkcywg VmVjdG9yPHVpbnQ4X3Q+IGh0dHBCb2R5LCBib29sIGFsbG93UG9wdXBzKTsKIAotICAgICMgQ2Fs bGVkIHdoZW4gdGhlIHBsdWctaW4gaGFzIHBhaW50ZWQgaW50byBpdHMgYmFja2luZyBzdG9yZS4K KyAgICAjIENhbGxlZCB3aGVuIHRoZSBwbHVnLWluIGhhcyBwYWludGVkIGludG8gaXRzIGJhY2tp bmcgc3RvcmUuIFRoZSBwYWludGVkIHJlY3QgaXMgaW4gcGx1Zy1pbiBjb29yZGluYXRlcy4KICAg ICBVcGRhdGUoV2ViQ29yZTo6SW50UmVjdCBwYWludGVkUmVjdCkKIAogICAgICMgUmV0dXJucyBh IFBBQyBzdHlsZSBzdHJpbmcgd2l0aCBwcm94aWVzIGZvciB0aGUgZ2l2ZW4gVVJMLgo=