71223 2011-10-31 08:57:14 -0700 CSSRule: Devirtualize insertedIntoParent() 2011-10-31 10:03:23 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling macpherson webkit.review.bot oldest_to_newest 493337 0 kling 2011-10-31 08:57:14 -0700 This one is only needed by CSSImportRule. 493338 1 113055 kling 2011-10-31 09:01:57 -0700 Created attachment 113055 Probably a patch 493339 2 113055 kling 2011-10-31 09:03:39 -0700 Comment on attachment 113055 Probably a patch Oopsie loopsie.. 493341 3 113055 kling 2011-10-31 09:07:43 -0700 Comment on attachment 113055 Probably a patch False alarm, I had an unrelated local build failure. 493349 4 113055 koivisto 2011-10-31 09:18:45 -0700 Comment on attachment 113055 Probably a patch View in context: https://bugs.webkit.org/attachment.cgi?id=113055&action=review r=me, with a comment. > Source/WebCore/css/CSSImportRule.cpp:112 > -void CSSImportRule::insertedIntoParent() > +void CSSImportRule::insertedIntoStyleSheet() Maybe a name that describes what it actually does? Something like "requestStyleSheet". Or perharps the loading code should actually live in CSSStyleSheet? 493356 5 113055 macpherson 2011-10-31 09:32:53 -0700 Comment on attachment 113055 Probably a patch View in context: https://bugs.webkit.org/attachment.cgi?id=113055&action=review > Source/WebCore/css/CSSStyleSheet.cpp:91 > + if (c->isImportRule()) Given that c->isImportRule() is virtual, I'm not sure that this buys anything in terms of performance (in fact it is probably immeasurably slower). 493362 6 macpherson 2011-10-31 09:42:03 -0700 My apologies, I hadn't seen https://bugs.webkit.org/show_bug.cgi?id=71221 which will devirtualize isimportRule(). 493384 7 kling 2011-10-31 10:03:23 -0700 Committed r98861: <http://trac.webkit.org/changeset/98861> 113055 2011-10-31 09:01:57 -0700 2011-10-31 09:32:53 -0700 Probably a patch bug-71223.diff text/plain 3399 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyMzNmZTUxLi4wYjFiMjRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjMg QEAKIDIwMTEtMTAtMzEgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgogCisgICAg ICAgIENTU1J1bGU6IERldmlydHVhbGl6ZSBpbnNlcnRlZEludG9QYXJlbnQoKQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzEyMjMKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNb3ZlZCBpbnNlcnRlZEludG9Q YXJlbnQoKSBkb3duIGludG8gQ1NTSW1wb3J0UnVsZSBhbmQgcmVuYW1lZCBpdCB0bworICAgICAg ICBpbnNlcnRlZEludG9TdHlsZVNoZWV0KCkuIENTU0ltcG9ydFJ1bGUgaXMgdGhlIG9ubHkgdXNl ciBvZiB0aGlzIGZ1bmN0aW9uLgorCisgICAgICAgICogY3NzL0NTU0ltcG9ydFJ1bGUuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6Q1NTSW1wb3J0UnVsZTo6aW5zZXJ0ZWRJbnRvU3R5bGVTaGVldCk6 CisgICAgICAgICogY3NzL0NTU0ltcG9ydFJ1bGUuaDoKKyAgICAgICAgKiBjc3MvQ1NTUnVsZS5o OgorICAgICAgICAqIGNzcy9DU1NTdHlsZVNoZWV0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNT U1N0eWxlU2hlZXQ6OmFwcGVuZCk6CisgICAgICAgIChXZWJDb3JlOjpDU1NTdHlsZVNoZWV0Ojpp bnNlcnRSdWxlKToKKworMjAxMS0xMC0zMSAgQW5kcmVhcyBLbGluZyAgPGtsaW5nQHdlYmtpdC5v cmc+CisKICAgICAgICAgQ1NTUnVsZTogRGV2aXJ0dWFsaXplIHR5cGUoKSBhbmQgaXNGb29SdWxl KCkKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcxMjIx CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NJbXBvcnRSdWxlLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2Nzcy9DU1NJbXBvcnRSdWxlLmNwcAppbmRleCBmN2YxMzdlLi42NDJlZDA4 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTSW1wb3J0UnVsZS5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvY3NzL0NTU0ltcG9ydFJ1bGUuY3BwCkBAIC0xMDksNyArMTA5LDcgQEAg Ym9vbCBDU1NJbXBvcnRSdWxlOjppc0xvYWRpbmcoKSBjb25zdAogICAgIHJldHVybiBtX2xvYWRp bmcgfHwgKG1fc3R5bGVTaGVldCAmJiBtX3N0eWxlU2hlZXQtPmlzTG9hZGluZygpKTsKIH0KIAot dm9pZCBDU1NJbXBvcnRSdWxlOjppbnNlcnRlZEludG9QYXJlbnQoKQordm9pZCBDU1NJbXBvcnRS dWxlOjppbnNlcnRlZEludG9TdHlsZVNoZWV0KCkKIHsKICAgICBDU1NTdHlsZVNoZWV0KiBwYXJl bnRTaGVldCA9IHBhcmVudFN0eWxlU2hlZXQoKTsKICAgICBpZiAoIXBhcmVudFNoZWV0IHx8ICFw YXJlbnRTaGVldC0+ZG9jdW1lbnQoKSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9D U1NJbXBvcnRSdWxlLmggYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTSW1wb3J0UnVsZS5oCmluZGV4 IGYxYTc4MjAuLjZiYmM1OGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NJbXBv cnRSdWxlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU0ltcG9ydFJ1bGUuaApAQCAtNTQs MTEgKzU0LDExIEBAIHB1YmxpYzoKIAogICAgIHZpcnR1YWwgdm9pZCBhZGRTdWJyZXNvdXJjZVN0 eWxlVVJMcyhMaXN0SGFzaFNldDxLVVJMPiYgdXJscyk7CiAKKyAgICB2b2lkIGluc2VydGVkSW50 b1N0eWxlU2hlZXQoKTsKKwogcHJpdmF0ZToKICAgICBDU1NJbXBvcnRSdWxlKENTU1N0eWxlU2hl ZXQqIHBhcmVudCwgY29uc3QgU3RyaW5nJiBocmVmLCBQYXNzUmVmUHRyPE1lZGlhTGlzdD4pOwog Ci0gICAgdmlydHVhbCB2b2lkIGluc2VydGVkSW50b1BhcmVudCgpOwotCiAgICAgLy8gZnJvbSBD YWNoZWRSZXNvdXJjZUNsaWVudAogICAgIHZpcnR1YWwgdm9pZCBzZXRDU1NTdHlsZVNoZWV0KGNv bnN0IFN0cmluZyYgaHJlZiwgY29uc3QgS1VSTCYgYmFzZVVSTCwgY29uc3QgU3RyaW5nJiBjaGFy c2V0LCBjb25zdCBDYWNoZWRDU1NTdHlsZVNoZWV0Kik7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2Nzcy9DU1NSdWxlLmggYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUnVsZS5oCmluZGV4 IDRjMGI0ZWUuLjRlZjNhMmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NSdWxl LmgKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1J1bGUuaApAQCAtOTYsOCArOTYsNiBAQCBw dWJsaWM6CiAKICAgICB2aXJ0dWFsIHZvaWQgYWRkU3VicmVzb3VyY2VTdHlsZVVSTHMoTGlzdEhh c2hTZXQ8S1VSTD4mKSB7IH0KIAotICAgIHZpcnR1YWwgdm9pZCBpbnNlcnRlZEludG9QYXJlbnQo KSB7IH0KLQogICAgIEtVUkwgYmFzZVVSTCgpIGNvbnN0CiAgICAgewogICAgICAgICBpZiAoQ1NT U3R5bGVTaGVldCogcGFyZW50U2hlZXQgPSBwYXJlbnRTdHlsZVNoZWV0KCkpCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVTaGVldC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9j c3MvQ1NTU3R5bGVTaGVldC5jcHAKaW5kZXggMDAyZmNiYi4uNTNjN2I0ZSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlU2hlZXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2Nzcy9DU1NTdHlsZVNoZWV0LmNwcApAQCAtODgsNyArODgsOCBAQCB2b2lkIENTU1N0eWxlU2hl ZXQ6OmFwcGVuZChQYXNzUmVmUHRyPENTU1J1bGU+IGNoaWxkKQogewogICAgIENTU1J1bGUqIGMg PSBjaGlsZC5nZXQoKTsKICAgICBtX2NoaWxkcmVuLmFwcGVuZChjaGlsZCk7Ci0gICAgYy0+aW5z ZXJ0ZWRJbnRvUGFyZW50KCk7CisgICAgaWYgKGMtPmlzSW1wb3J0UnVsZSgpKQorICAgICAgICBz dGF0aWNfY2FzdDxDU1NJbXBvcnRSdWxlKj4oYyktPmluc2VydGVkSW50b1N0eWxlU2hlZXQoKTsK IH0KIAogdm9pZCBDU1NTdHlsZVNoZWV0OjpyZW1vdmUodW5zaWduZWQgaW5kZXgpCkBAIC0xMzYs NyArMTM3LDggQEAgdW5zaWduZWQgQ1NTU3R5bGVTaGVldDo6aW5zZXJ0UnVsZShjb25zdCBTdHJp bmcmIHJ1bGUsIHVuc2lnbmVkIGluZGV4LCBFeGNlcHRpb24KIAogICAgIENTU1J1bGUqIGMgPSBy LmdldCgpOwogICAgIG1fY2hpbGRyZW4uaW5zZXJ0KGluZGV4LCByLnJlbGVhc2UoKSk7Ci0gICAg Yy0+aW5zZXJ0ZWRJbnRvUGFyZW50KCk7CisgICAgaWYgKGMtPmlzSW1wb3J0UnVsZSgpKQorICAg ICAgICBzdGF0aWNfY2FzdDxDU1NJbXBvcnRSdWxlKj4oYyktPmluc2VydGVkSW50b1N0eWxlU2hl ZXQoKTsKIAogICAgIHN0eWxlU2hlZXRDaGFuZ2VkKCk7CiAK