71213 2011-10-31 03:12:53 -0700 [EFL] Added ewk_tile_memory_size_get function 2011-11-03 17:27:26 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 t.morawski webkit-unassigned gyuyoung.kim hyuki.kim leandro lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 493227 0 t.morawski 2011-10-31 03:12:53 -0700 Added the ewk_tile_memory_size_get function returns size of used memory by given tile. Simplify and cleanup the code. 493228 1 113029 t.morawski 2011-10-31 03:14:44 -0700 Created attachment 113029 added new function 493248 2 113029 rakuco 2011-10-31 04:40:41 -0700 Comment on attachment 113029 added new function View in context: https://bugs.webkit.org/attachment.cgi?id=113029&action=review > Source/WebKit/efl/ewk/ewk_tiled_model.cpp:347 > +size_t ewk_tile_memory_size_get(Ewk_Tile* tile) I'd make `tile' const. 494474 3 113284 t.morawski 2011-11-02 00:35:16 -0700 Created attachment 113284 Added const 494623 4 rakuco 2011-11-02 08:01:58 -0700 LGTM. 494686 5 hyuki.kim 2011-11-02 09:59:49 -0700 > Source/WebKit/efl/ewk/ewk_tiled_model.h:34 > +size_t ewk_tile_memory_size_get(const Ewk_Tile* t); I prefer tile instead of t although other existing API is still using it. :) 495235 6 t.morawski 2011-11-03 00:26:23 -0700 (In reply to comment #5) > > Source/WebKit/efl/ewk/ewk_tiled_model.h:34 > > +size_t ewk_tile_memory_size_get(const Ewk_Tile* t); > > I prefer tile instead of t although other existing API is still using it. :) So, I think the "tile" name will look badly in courrent API implementation. So, it could be changed when existing API will be updated form "t" to "tile". 495286 7 hyuki.kim 2011-11-03 02:40:00 -0700 LGTM. 495913 8 113284 webkit.review.bot 2011-11-03 17:27:22 -0700 Comment on attachment 113284 Added const Clearing flags on attachment: 113284 Committed r99252: <http://trac.webkit.org/changeset/99252> 495914 9 webkit.review.bot 2011-11-03 17:27:26 -0700 All reviewed patches have been landed. Closing bug. 113029 2011-10-31 03:14:44 -0700 2011-11-02 00:35:16 -0700 added new function patch.patch text/plain 3454 t.morawski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCBhMTk4OTIyLi4xODI0NjZmIDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjAgQEAKKzIwMTEtMTAtMzEgIFRvbWFzeiBNb3Jhd3NraSAgPHQubW9yYXdza2lA c2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gQWRkZWQgZXdrX3RpbGVfbWVtb3J5X3NpemVf Z2V0IGZ1bmN0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD03MTIxMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEFkZGVkIHRoZSBld2tfdGlsZV9tZW1vcnlfc2l6ZV9nZXQgZnVuY3Rpb24gcmV0dXJucyBz aXplIG9mIHVzZWQgbWVtb3J5IGJ5IGdpdmVuIHRpbGUuIFNpbXBsaWZ5IGFuZCBjbGVhbnVwCisg ICAgICAgIHRoZSBjb2RlLgorCisgICAgICAgICogZXdrL2V3a190aWxlZF9tb2RlbC5jcHA6Cisg ICAgICAgIChld2tfdGlsZV9tZW1vcnlfc2l6ZV9nZXQpOgorICAgICAgICAoZXdrX3RpbGVfdW51 c2VkX2NhY2hlX2ZsdXNoKToKKyAgICAgICAgKGV3a190aWxlX3VudXNlZF9jYWNoZV90aWxlX2dl dCk6CisgICAgICAgIChld2tfdGlsZV91bnVzZWRfY2FjaGVfdGlsZV9wdXQpOgorICAgICAgICAq IGV3ay9ld2tfdGlsZWRfbW9kZWwuaDoKKwogMjAxMS0xMC0yNCAgSXZhbiBCcmlhbm8gIDxpdmFu QHByb2Z1c2lvbi5tb2JpPgogCiAgICAgICAgIFtFRkxdIEJ1aWxkIGZpeC4gUmVuYW1lIGFsbCBp bnN0YW5jZXMgb2YgYSB2YXJpYWJsZSB3aGVuIGl0IGdldHMgY2hhbmdlZApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9lZmwvZXdrL2V3a190aWxlZF9tb2RlbC5jcHAgYi9Tb3VyY2UvV2ViS2l0 L2VmbC9ld2svZXdrX3RpbGVkX21vZGVsLmNwcAppbmRleCBkZDVmMGQ1Li4wN2ZkZDg3IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3RpbGVkX21vZGVsLmNwcAorKysgYi9T b3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3RpbGVkX21vZGVsLmNwcApAQCAtMzM4LDYgKzMzOCwx OSBAQCB2b2lkIGV3a190aWxlX2ZyZWUoRXdrX1RpbGUqIHRpbGUpCiB9CiAKIC8qKgorICogQGlu dGVybmFsCisgKiBSZXR1cm5zIG1lbW9yeSBzaXplIHVzZWQgYnkgZ2l2ZW4gdGlsZQorICoKKyAq IEBwYXJhbSB0IHRpbGUgdG8gc2l6ZSBjaGVjaworICogQHJldHVybiBSZXR1cm5zIHVzZWQgbWVt b3J5IG9yIHplcm8gaWYgb2JqZWN0IGlzIE5VTEwuCisgKi8KK3NpemVfdCBld2tfdGlsZV9tZW1v cnlfc2l6ZV9nZXQoRXdrX1RpbGUqIHRpbGUpCit7CisgICAgRUlOQV9TQUZFVFlfT05fTlVMTF9S RVRVUk5fVkFMKHRpbGUsIDApOworICAgIHJldHVybiBzaXplb2YoRXdrX1RpbGUpICsgdGlsZS0+ Ynl0ZXM7Cit9CisKKy8qKgogICogTWFrZSB0aGUgdGlsZSB2aXNpYmxlLCBpbmNyZW1lbnRpbmcg aXRzIGNvdW50ZXIuCiAgKi8KIHZvaWQgZXdrX3RpbGVfc2hvdyhFd2tfVGlsZSogdGlsZSkKQEAg LTY4MSw3ICs2OTQsNyBAQCBzaXplX3QgZXdrX3RpbGVfdW51c2VkX2NhY2hlX2ZsdXNoKEV3a19U aWxlX1VudXNlZF9DYWNoZSogdGlsZVVudXNlZENhY2hlLCBzaXplXwogICAgICAgICAgICAgJiYg dGlsZS0+em9vbSA9PSB0aWxlVW51c2VkQ2FjaGUtPmxvY2tlZC56b29tKSB7CiAgICAgICAgICAg ICBjb250aW51ZTsKICAgICAgICAgfQotICAgICAgICBkb25lICs9IHNpemVvZihFd2tfVGlsZSkg KyBpdHItPnRpbGUtPmJ5dGVzOworICAgICAgICBkb25lICs9IGV3a190aWxlX21lbW9yeV9zaXpl X2dldChpdHItPnRpbGUpOwogICAgICAgICBpdHItPnRpbGVfZnJlZS5jYWxsYmFjayhpdHItPnRp bGVfZnJlZS5kYXRhLCBpdHItPnRpbGUpOwogICAgICAgICB0aWxlVW51c2VkQ2FjaGUtPmVudHJp ZXMubGlzdCA9IGVpbmFfbGlzdF9yZW1vdmVfbGlzdCh0aWxlVW51c2VkQ2FjaGUtPmVudHJpZXMu bGlzdCwgbGlzdCk7CiAgICAgICAgIGZyZWUoaXRyKTsKQEAgLTc2Niw3ICs3NzksNyBAQCBFaW5h X0Jvb2wgZXdrX3RpbGVfdW51c2VkX2NhY2hlX3RpbGVfZ2V0KEV3a19UaWxlX1VudXNlZF9DYWNo ZSogdGlsZVVudXNlZENhY2hlLAogICAgIH0KIAogICAgIHRpbGVVbnVzZWRDYWNoZS0+ZW50cmll cy5jb3VudC0tOwotICAgIHRpbGVVbnVzZWRDYWNoZS0+bWVtb3J5LnVzZWQgLT0gc2l6ZW9mKEV3 a19UaWxlKSArIHRpbGUtPmJ5dGVzOworICAgIHRpbGVVbnVzZWRDYWNoZS0+bWVtb3J5LnVzZWQg LT0gZXdrX3RpbGVfbWVtb3J5X3NpemVfZ2V0KHRpbGUpOwogICAgIHRpbGVVbnVzZWRDYWNoZS0+ ZW50cmllcy5saXN0ID0gZWluYV9saXN0X3JlbW92ZV9saXN0KHRpbGVVbnVzZWRDYWNoZS0+ZW50 cmllcy5saXN0LCBmb3VuZEVudHJ5KTsKICAgICBmcmVlKGl0ZW0pOwogCkBAIC04MjAsNyArODMz LDcgQEAgRWluYV9Cb29sIGV3a190aWxlX3VudXNlZF9jYWNoZV90aWxlX3B1dChFd2tfVGlsZV9V bnVzZWRfQ2FjaGUqIHRpbGVVbnVzZWRDYWNoZSwKICAgICB1bnVzZWRDYWNoZUVudHJ5LT50aWxl X2ZyZWUuZGF0YSA9ICh2b2lkKilkYXRhOwogCiAgICAgdGlsZVVudXNlZENhY2hlLT5lbnRyaWVz LmNvdW50Kys7Ci0gICAgdGlsZVVudXNlZENhY2hlLT5tZW1vcnkudXNlZCArPSBzaXplb2YoRXdr X1RpbGUpICsgdGlsZS0+Ynl0ZXM7CisgICAgdGlsZVVudXNlZENhY2hlLT5tZW1vcnkudXNlZCAr PSBld2tfdGlsZV9tZW1vcnlfc2l6ZV9nZXQodGlsZSk7CiAKICAgICByZXR1cm4gRUlOQV9UUlVF OwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a190aWxlZF9tb2RlbC5o IGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a190aWxlZF9tb2RlbC5oCmluZGV4IDg1ZGUwMTYu LjQ3ZTBhNTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdGlsZWRfbW9k ZWwuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3RpbGVkX21vZGVsLmgKQEAgLTMx LDYgKzMxLDcgQEAgdm9pZCBld2tfdGlsZV9mcmVlKEV3a19UaWxlKiB0KTsKIHZvaWQgZXdrX3Rp bGVfdW51c2VkX2NhY2hlX2NsZWFyKEV3a19UaWxlX1VudXNlZF9DYWNoZSogdHVjKTsKIHZvaWQg ZXdrX3RpbGVfc2hvdyhFd2tfVGlsZSogdCk7CiB2b2lkIGV3a190aWxlX2hpZGUoRXdrX1RpbGUq IHQpOworc2l6ZV90IGV3a190aWxlX21lbW9yeV9zaXplX2dldChFd2tfVGlsZSogdCk7CiBFaW5h X0Jvb2wgZXdrX3RpbGVfdmlzaWJsZV9nZXQoRXdrX1RpbGUqIHQpOwogdm9pZCBld2tfdGlsZV91 cGRhdGVfZnVsbChFd2tfVGlsZSogdCk7CiB2b2lkIGV3a190aWxlX3VwZGF0ZV9hcmVhKEV3a19U aWxlKiB0LCBjb25zdCBFaW5hX1JlY3RhbmdsZSogcik7Cg== 113284 2011-11-02 00:35:16 -0700 2011-11-03 17:27:22 -0700 Added const newpatch.patch text/plain 3476 t.morawski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCBjM2Y3NWNlLi4xYmFmMWE0IDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjAgQEAKKzIwMTEtMTEtMDIgIFRvbWFzeiBNb3Jhd3NraSAgPHQubW9yYXdza2lA c2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gQWRkZWQgZXdrX3RpbGVfbWVtb3J5X3NpemVf Z2V0IGZ1bmN0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD03MTIxMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEFkZGVkIHRoZSBld2tfdGlsZV9tZW1vcnlfc2l6ZV9nZXQgZnVuY3Rpb24gcmV0dXJucyBz aXplIG9mIHVzZWQgbWVtb3J5IGJ5IGdpdmVuIHRpbGUuIFNpbXBsaWZ5IGFuZCBjbGVhbnVwCisg ICAgICAgIHRoZSBjb2RlLgorCisgICAgICAgICogZXdrL2V3a190aWxlZF9tb2RlbC5jcHA6Cisg ICAgICAgIChld2tfdGlsZV9tZW1vcnlfc2l6ZV9nZXQpOgorICAgICAgICAoZXdrX3RpbGVfdW51 c2VkX2NhY2hlX2ZsdXNoKToKKyAgICAgICAgKGV3a190aWxlX3VudXNlZF9jYWNoZV90aWxlX2dl dCk6CisgICAgICAgIChld2tfdGlsZV91bnVzZWRfY2FjaGVfdGlsZV9wdXQpOgorICAgICAgICAq IGV3ay9ld2tfdGlsZWRfbW9kZWwuaDoKKwogMjAxMS0xMC0zMSAgUmFwaGFlbCBLdWJvIGRhIENv c3RhICA8a3Vib0Bwcm9mdXNpb24ubW9iaT4KIAogICAgICAgICBbRUZMXSBSZW5hbWUgZXdrX3Zp ZXdfc2V0dGluZ19zY3JpcHRzX3dpbmRvd19vcGVuX3tnZXQsc2V0fSBhZnRlciByOTM4MzMKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdGlsZWRfbW9kZWwuY3BwIGIvU291 cmNlL1dlYktpdC9lZmwvZXdrL2V3a190aWxlZF9tb2RlbC5jcHAKaW5kZXggYTc0N2M5MC4uZThj ZDEyZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a190aWxlZF9tb2RlbC5j cHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a190aWxlZF9tb2RlbC5jcHAKQEAgLTMz OCw2ICszMzgsMTkgQEAgdm9pZCBld2tfdGlsZV9mcmVlKEV3a19UaWxlKiB0aWxlKQogfQogCiAv KioKKyAqIEBpbnRlcm5hbAorICogUmV0dXJucyBtZW1vcnkgc2l6ZSB1c2VkIGJ5IGdpdmVuIHRp bGUKKyAqCisgKiBAcGFyYW0gdCB0aWxlIHRvIHNpemUgY2hlY2sKKyAqIEByZXR1cm4gUmV0dXJu cyB1c2VkIG1lbW9yeSBvciB6ZXJvIGlmIG9iamVjdCBpcyBOVUxMLgorICovCitzaXplX3QgZXdr X3RpbGVfbWVtb3J5X3NpemVfZ2V0KGNvbnN0IEV3a19UaWxlKiB0aWxlKQoreworICAgIEVJTkFf U0FGRVRZX09OX05VTExfUkVUVVJOX1ZBTCh0aWxlLCAwKTsKKyAgICByZXR1cm4gc2l6ZW9mKEV3 a19UaWxlKSArIHRpbGUtPmJ5dGVzOworfQorCisvKioKICAqIE1ha2UgdGhlIHRpbGUgdmlzaWJs ZSwgaW5jcmVtZW50aW5nIGl0cyBjb3VudGVyLgogICovCiB2b2lkIGV3a190aWxlX3Nob3coRXdr X1RpbGUqIHRpbGUpCkBAIC02ODUsNyArNjk4LDcgQEAgc2l6ZV90IGV3a190aWxlX3VudXNlZF9j YWNoZV9mbHVzaChFd2tfVGlsZV9VbnVzZWRfQ2FjaGUqIHRpbGVVbnVzZWRDYWNoZSwgc2l6ZV8K ICAgICAgICAgICAgICYmIHRpbGUtPnpvb20gPT0gdGlsZVVudXNlZENhY2hlLT5sb2NrZWQuem9v bSkgewogICAgICAgICAgICAgY29udGludWU7CiAgICAgICAgIH0KLSAgICAgICAgZG9uZSArPSBz aXplb2YoRXdrX1RpbGUpICsgaXRyLT50aWxlLT5ieXRlczsKKyAgICAgICAgZG9uZSArPSBld2tf dGlsZV9tZW1vcnlfc2l6ZV9nZXQoaXRyLT50aWxlKTsKICAgICAgICAgaXRyLT50aWxlX2ZyZWUu Y2FsbGJhY2soaXRyLT50aWxlX2ZyZWUuZGF0YSwgaXRyLT50aWxlKTsKICAgICAgICAgdGlsZVVu dXNlZENhY2hlLT5lbnRyaWVzLmxpc3QgPSBlaW5hX2xpc3RfcmVtb3ZlX2xpc3QodGlsZVVudXNl ZENhY2hlLT5lbnRyaWVzLmxpc3QsIGxpc3QpOwogICAgICAgICBmcmVlKGl0cik7CkBAIC03NzAs NyArNzgzLDcgQEAgRWluYV9Cb29sIGV3a190aWxlX3VudXNlZF9jYWNoZV90aWxlX2dldChFd2tf VGlsZV9VbnVzZWRfQ2FjaGUqIHRpbGVVbnVzZWRDYWNoZSwKICAgICB9CiAKICAgICB0aWxlVW51 c2VkQ2FjaGUtPmVudHJpZXMuY291bnQtLTsKLSAgICB0aWxlVW51c2VkQ2FjaGUtPm1lbW9yeS51 c2VkIC09IHNpemVvZihFd2tfVGlsZSkgKyB0aWxlLT5ieXRlczsKKyAgICB0aWxlVW51c2VkQ2Fj aGUtPm1lbW9yeS51c2VkIC09IGV3a190aWxlX21lbW9yeV9zaXplX2dldCh0aWxlKTsKICAgICB0 aWxlVW51c2VkQ2FjaGUtPmVudHJpZXMubGlzdCA9IGVpbmFfbGlzdF9yZW1vdmVfbGlzdCh0aWxl VW51c2VkQ2FjaGUtPmVudHJpZXMubGlzdCwgZm91bmRFbnRyeSk7CiAgICAgZnJlZShpdGVtKTsK IApAQCAtODI0LDcgKzgzNyw3IEBAIEVpbmFfQm9vbCBld2tfdGlsZV91bnVzZWRfY2FjaGVfdGls ZV9wdXQoRXdrX1RpbGVfVW51c2VkX0NhY2hlKiB0aWxlVW51c2VkQ2FjaGUsCiAgICAgdW51c2Vk Q2FjaGVFbnRyeS0+dGlsZV9mcmVlLmRhdGEgPSAodm9pZCopZGF0YTsKIAogICAgIHRpbGVVbnVz ZWRDYWNoZS0+ZW50cmllcy5jb3VudCsrOwotICAgIHRpbGVVbnVzZWRDYWNoZS0+bWVtb3J5LnVz ZWQgKz0gc2l6ZW9mKEV3a19UaWxlKSArIHRpbGUtPmJ5dGVzOworICAgIHRpbGVVbnVzZWRDYWNo ZS0+bWVtb3J5LnVzZWQgKz0gZXdrX3RpbGVfbWVtb3J5X3NpemVfZ2V0KHRpbGUpOwogCiAgICAg cmV0dXJuIEVJTkFfVFJVRTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9l d2tfdGlsZWRfbW9kZWwuaCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdGlsZWRfbW9kZWwu aAppbmRleCA4NWRlMDE2Li41ODcxNmM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9l d2svZXdrX3RpbGVkX21vZGVsLmgKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a190aWxl ZF9tb2RlbC5oCkBAIC0zMSw2ICszMSw3IEBAIHZvaWQgZXdrX3RpbGVfZnJlZShFd2tfVGlsZSog dCk7CiB2b2lkIGV3a190aWxlX3VudXNlZF9jYWNoZV9jbGVhcihFd2tfVGlsZV9VbnVzZWRfQ2Fj aGUqIHR1Yyk7CiB2b2lkIGV3a190aWxlX3Nob3coRXdrX1RpbGUqIHQpOwogdm9pZCBld2tfdGls ZV9oaWRlKEV3a19UaWxlKiB0KTsKK3NpemVfdCBld2tfdGlsZV9tZW1vcnlfc2l6ZV9nZXQoY29u c3QgRXdrX1RpbGUqIHQpOwogRWluYV9Cb29sIGV3a190aWxlX3Zpc2libGVfZ2V0KEV3a19UaWxl KiB0KTsKIHZvaWQgZXdrX3RpbGVfdXBkYXRlX2Z1bGwoRXdrX1RpbGUqIHQpOwogdm9pZCBld2tf dGlsZV91cGRhdGVfYXJlYShFd2tfVGlsZSogdCwgY29uc3QgRWluYV9SZWN0YW5nbGUqIHIpOwo=