71210 2011-10-31 01:43:26 -0700 StringImpl::reallocate() should have a 8-bit version 2011-11-01 12:52:48 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 wangxianzhu webkit-unassigned darin ggaren msaboff rniwa webkit.review.bot oldest_to_newest 493209 0 wangxianzhu 2011-10-31 01:43:26 -0700 StringImpl::reallocate() was added when bug 66161 was being worked on, so the patch of bug 66161 didn't include the 8-bit version of it. 493211 1 113024 wangxianzhu 2011-10-31 01:57:39 -0700 Created attachment 113024 patch 493333 2 msaboff 2011-10-31 08:47:28 -0700 Looks fine to me. 494057 3 113024 ggaren 2011-11-01 11:58:40 -0700 Comment on attachment 113024 patch r=me 494078 4 113024 webkit.review.bot 2011-11-01 12:52:43 -0700 Comment on attachment 113024 patch Clearing flags on attachment: 113024 Committed r98993: <http://trac.webkit.org/changeset/98993> 494079 5 webkit.review.bot 2011-11-01 12:52:48 -0700 All reviewed patches have been landed. Closing bug. 113024 2011-10-31 01:57:39 -0700 2011-11-01 12:52:43 -0700 patch 71210 text/plain 3690 wangxianzhu SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTg4MzkpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTEtMTAtMzEgIFhpYW56aHUgV2FuZyAgPHdhbmd4aWFuemh1QGNocm9taXVtLm9yZz4KKwor ICAgICAgICBTdHJpbmdJbXBsOjpyZWFsbG9jYXRlKCkgc2hvdWxkIGhhdmUgYSA4LWJpdCB2ZXJz aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MTIx MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3Rm L3RleHQvU3RyaW5nSW1wbC5jcHA6CisgICAgICAgIChXVEY6OlN0cmluZ0ltcGw6OnJlYWxsb2Nh dGUpOgorICAgICAgICAqIHd0Zi90ZXh0L1N0cmluZ0ltcGwuaDoKKwogMjAxMS0xMC0zMCAgRmls aXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIEpTUGFyc2VyOjpwYXJzZVBy aW1hcnlFeHByZXNzaW9uIHNob3VsZCBoYXZlIGFuIG92ZXJmbG93IGNoZWNrCkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvd3RmL3RleHQvU3RyaW5nSW1wbC5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi90ZXh0L1N0cmluZ0ltcGwuY3BwCShyZXZpc2lvbiA5 ODgzNSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvdGV4dC9TdHJpbmdJbXBsLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMzcsOCArMzcsNiBAQCBuYW1lc3BhY2UgV1RGIHsKIAogdXNpbmcg bmFtZXNwYWNlIFVuaWNvZGU7CiAKLXN0YXRpYyBjb25zdCB1bnNpZ25lZCBtaW5MZW5ndGhUb1No YXJlID0gMjA7Ci0KIENPTVBJTEVfQVNTRVJUKHNpemVvZihTdHJpbmdJbXBsKSA9PSAyICogc2l6 ZW9mKGludCkgKyAzICogc2l6ZW9mKHZvaWQqKSwgU3RyaW5nSW1wbF9zaG91bGRfc3RheV9zbWFs bCk7CiAKIFN0cmluZ0ltcGw6On5TdHJpbmdJbXBsKCkKQEAgLTExMyw5ICsxMTEsMzMgQEAgUGFz c1JlZlB0cjxTdHJpbmdJbXBsPiBTdHJpbmdJbXBsOjpjcmVhdAogICAgIHJldHVybiBhZG9wdFJl ZihuZXcgKHN0cmluZykgU3RyaW5nSW1wbChsZW5ndGgpKTsKIH0KIAorUGFzc1JlZlB0cjxTdHJp bmdJbXBsPiBTdHJpbmdJbXBsOjpyZWFsbG9jYXRlKFBhc3NSZWZQdHI8U3RyaW5nSW1wbD4gb3Jp Z2luYWxTdHJpbmcsIHVuc2lnbmVkIGxlbmd0aCwgTENoYXIqJiBkYXRhKQoreworICAgIEFTU0VS VChvcmlnaW5hbFN0cmluZy0+aXM4Qml0KCkpOworICAgIEFTU0VSVChvcmlnaW5hbFN0cmluZy0+ aGFzT25lUmVmKCkpOworICAgIEFTU0VSVChvcmlnaW5hbFN0cmluZy0+YnVmZmVyT3duZXJzaGlw KCkgPT0gQnVmZmVySW50ZXJuYWwpOworCisgICAgaWYgKCFsZW5ndGgpIHsKKyAgICAgICAgZGF0 YSA9IDA7CisgICAgICAgIHJldHVybiBlbXB0eSgpOworICAgIH0KKworICAgIC8vIFNhbWUgYXMg Y3JlYXRlVW5pbml0aWFsaXplZCgpIGV4Y2VwdCBoZXJlIHdlIHVzZSBmYXN0UmVhbGxvYy4KKyAg ICBpZiAobGVuZ3RoID4gKChzdGQ6Om51bWVyaWNfbGltaXRzPHVuc2lnbmVkPjo6bWF4KCkgLSBz aXplb2YoU3RyaW5nSW1wbCkpIC8gc2l6ZW9mKExDaGFyKSkpCisgICAgICAgIENSQVNIKCk7Cisg ICAgc2l6ZV90IHNpemUgPSBzaXplb2YoU3RyaW5nSW1wbCkgKyBsZW5ndGggKiBzaXplb2YoTENo YXIpOworICAgIG9yaWdpbmFsU3RyaW5nLT5+U3RyaW5nSW1wbCgpOworICAgIFN0cmluZ0ltcGwq IHN0cmluZyA9IHN0YXRpY19jYXN0PFN0cmluZ0ltcGwqPihmYXN0UmVhbGxvYyhvcmlnaW5hbFN0 cmluZy5sZWFrUmVmKCksIHNpemUpKTsKKworICAgIGRhdGEgPSByZWludGVycHJldF9jYXN0PExD aGFyKj4oc3RyaW5nICsgMSk7CisgICAgcmV0dXJuIGFkb3B0UmVmKG5ldyAoc3RyaW5nKSBTdHJp bmdJbXBsKGxlbmd0aCkpOworfQorCiBQYXNzUmVmUHRyPFN0cmluZ0ltcGw+IFN0cmluZ0ltcGw6 OnJlYWxsb2NhdGUoUGFzc1JlZlB0cjxTdHJpbmdJbXBsPiBvcmlnaW5hbFN0cmluZywgdW5zaWdu ZWQgbGVuZ3RoLCBVQ2hhciomIGRhdGEpCiB7Ci0gICAgQVNTRVJUKG9yaWdpbmFsU3RyaW5nLT5o YXNPbmVSZWYoKSAmJiBvcmlnaW5hbFN0cmluZy0+YnVmZmVyT3duZXJzaGlwKCkgPT0gQnVmZmVy SW50ZXJuYWwpOworICAgIEFTU0VSVCghb3JpZ2luYWxTdHJpbmctPmlzOEJpdCgpKTsKKyAgICBB U1NFUlQob3JpZ2luYWxTdHJpbmctPmhhc09uZVJlZigpKTsKKyAgICBBU1NFUlQob3JpZ2luYWxT dHJpbmctPmJ1ZmZlck93bmVyc2hpcCgpID09IEJ1ZmZlckludGVybmFsKTsKIAogICAgIGlmICgh bGVuZ3RoKSB7CiAgICAgICAgIGRhdGEgPSAwOwpAQCAtMTA3NCw3ICsxMDk2LDcgQEAgUGFzc1Jl ZlB0cjxTdHJpbmdJbXBsPiBTdHJpbmdJbXBsOjpyZXBsYQogICAgICAgICArK3NyY1NlZ21lbnRT dGFydDsKICAgICB9CiAgICAgCi0gICAgLy8gSWYgd2UgaGF2ZSAwIG1hdGNoZXMgdGhlbiB3ZSBk b24ndCBoYXZlIHRvIGRvIGFueSBtb3JlIHdvcmsgdG8gZG8uCisgICAgLy8gSWYgd2UgaGF2ZSAw IG1hdGNoZXMgdGhlbiB3ZSBkb24ndCBoYXZlIHRvIGRvIGFueSBtb3JlIHdvcmsuCiAgICAgaWYg KCFtYXRjaENvdW50KQogICAgICAgICByZXR1cm4gdGhpczsKICAgICAKSW5kZXg6IFNvdXJjZS9K YXZhU2NyaXB0Q29yZS93dGYvdGV4dC9TdHJpbmdJbXBsLmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L0phdmFTY3JpcHRDb3JlL3d0Zi90ZXh0L1N0cmluZ0ltcGwuaAkocmV2aXNpb24gOTg4MzUpCisr KyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL3RleHQvU3RyaW5nSW1wbC5oCSh3b3JraW5nIGNv cHkpCkBAIC0yNDIsNiArMjQyLDcgQEAgcHVibGljOgogICAgIC8vIFJlYWxsb2NhdGUgdGhlIFN0 cmluZ0ltcGwuIFRoZSBvcmlnaW5hbFN0cmluZyBtdXN0IGJlIG9ubHkgb3duZWQgYnkgdGhlIFBh c3NSZWZQdHIsCiAgICAgLy8gYW5kIHRoZSBidWZmZXIgb3duZXJzaGlwIG11c3QgYmUgQnVmZmVy SW50ZXJuYWwuIEp1c3QgbGlrZSB0aGUgaW5wdXQgcG9pbnRlciBvZiByZWFsbG9jKCksCiAgICAg Ly8gdGhlIG9yaWdpbmFsU3RyaW5nIGNhbid0IGJlIHVzZWQgYWZ0ZXIgdGhpcyBmdW5jdGlvbi4K KyAgICBzdGF0aWMgUGFzc1JlZlB0cjxTdHJpbmdJbXBsPiByZWFsbG9jYXRlKFBhc3NSZWZQdHI8 U3RyaW5nSW1wbD4gb3JpZ2luYWxTdHJpbmcsIHVuc2lnbmVkIGxlbmd0aCwgTENoYXIqJiBkYXRh KTsKICAgICBzdGF0aWMgUGFzc1JlZlB0cjxTdHJpbmdJbXBsPiByZWFsbG9jYXRlKFBhc3NSZWZQ dHI8U3RyaW5nSW1wbD4gb3JpZ2luYWxTdHJpbmcsIHVuc2lnbmVkIGxlbmd0aCwgVUNoYXIqJiBk YXRhKTsKIAogICAgIHN0YXRpYyB1bnNpZ25lZCBmbGFnc09mZnNldCgpIHsgcmV0dXJuIE9CSkVD VF9PRkZTRVRPRihTdHJpbmdJbXBsLCBtX2hhc2hBbmRGbGFncyk7IH0K