71206 2011-10-30 23:50:36 -0700 WTF::StringImpl::create(const char*, unsigned) calls itself 2011-10-31 16:19:15 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 wangxianzhu webkit-unassigned darin ggaren gregsimon msaboff rniwa sullivan webkit.review.bot oldest_to_newest 493174 0 wangxianzhu 2011-10-30 23:50:36 -0700 Now WTF::StringImpl::create(const char*, unsigned) is: ALWAYS_INLINE static PassRefPtr<StringImpl> create(const char* s, unsigned length) { return create(s, length); }; which is an infinite recursion. 493176 1 rniwa 2011-10-30 23:58:05 -0700 I think it meant to be create(reinterpret_cast<const LChar*>(s), length). 493177 2 113016 wangxianzhu 2011-10-30 23:59:30 -0700 Created attachment 113016 patch 493178 3 113016 rniwa 2011-10-31 00:00:44 -0700 Comment on attachment 113016 patch View in context: https://bugs.webkit.org/attachment.cgi?id=113016&action=review > Source/JavaScriptCore/ChangeLog:5 > + It'll be nice if you explained what was wrong with the existing code and what you fixed. 493179 4 rniwa 2011-10-31 00:01:16 -0700 In fact, I suggest you rename the bug title to something like "StringImpl::create(const char*, unsigned) calls itself" 493186 5 113019 wangxianzhu 2011-10-31 00:16:32 -0700 Created attachment 113019 patch v2 493187 6 113019 rniwa 2011-10-31 00:20:47 -0700 Comment on attachment 113019 patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=113019&action=review > Source/JavaScriptCore/ChangeLog:9 > + Reviewed by Ryosuke Niwa. Ugh... this line is supposed to appear ABOVE the description. 493344 7 msaboff 2011-10-31 09:10:52 -0700 The changes look good to me. 493394 8 ap 2011-10-31 10:16:01 -0700 Is this dead code? Otherwise, it should be possible to make a regression test. 493424 9 rniwa 2011-10-31 11:27:13 -0700 (In reply to comment #8) > Is this dead code? Otherwise, it should be possible to make a regression test. I believe this change is needed in an effort to support 8-bit string optimization. 493596 10 113019 webkit.review.bot 2011-10-31 16:19:09 -0700 Comment on attachment 113019 patch v2 Clearing flags on attachment: 113019 Committed r98903: <http://trac.webkit.org/changeset/98903> 493598 11 webkit.review.bot 2011-10-31 16:19:15 -0700 All reviewed patches have been landed. Closing bug. 113016 2011-10-30 23:59:30 -0700 2011-10-31 00:16:32 -0700 patch 71206 text/plain 1729 wangxianzhu SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTg4MzUpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTEgQEAK KzIwMTEtMTAtMzAgIFhpYW56aHUgV2FuZyAgPHdhbmd4aWFuemh1QGNocm9taXVtLm9yZz4KKwor ICAgICAgICBQcm9ibGVtIG9mIFdURjo6U3RyaW5nSW1wbDo6Y3JlYXRlKGNvbnN0IGNoYXIqLCB1 bnNpZ25lZCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTcxMjA2CisKKyAgICAgICAgKiB3dGYvdGV4dC9TdHJpbmdJbXBsLmg6CisgICAgICAgIChXVEY6 OlN0cmluZ0ltcGw6OmNyZWF0ZSk6CisKIDIwMTEtMTAtMzAgIEZpbGlwIFBpemxvICA8ZnBpemxv QGFwcGxlLmNvbT4KIAogICAgICAgICBKU1BhcnNlcjo6cGFyc2VQcmltYXJ5RXhwcmVzc2lvbiBz aG91bGQgaGF2ZSBhbiBvdmVyZmxvdyBjaGVjawpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3Jl L3d0Zi90ZXh0L1N0cmluZ0ltcGwuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENv cmUvd3RmL3RleHQvU3RyaW5nSW1wbC5oCShyZXZpc2lvbiA5ODgzNSkKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS93dGYvdGV4dC9TdHJpbmdJbXBsLmgJKHdvcmtpbmcgY29weSkKQEAgLTE4Miw5 ICsxODIsOSBAQCBwdWJsaWM6CiAKICAgICBzdGF0aWMgUGFzc1JlZlB0cjxTdHJpbmdJbXBsPiBj cmVhdGUoY29uc3QgVUNoYXIqLCB1bnNpZ25lZCBsZW5ndGgpOwogICAgIHN0YXRpYyBQYXNzUmVm UHRyPFN0cmluZ0ltcGw+IGNyZWF0ZShjb25zdCBMQ2hhciosIHVuc2lnbmVkIGxlbmd0aCk7Ci0g ICAgQUxXQVlTX0lOTElORSBzdGF0aWMgUGFzc1JlZlB0cjxTdHJpbmdJbXBsPiBjcmVhdGUoY29u c3QgY2hhciogcywgdW5zaWduZWQgbGVuZ3RoKSB7IHJldHVybiBjcmVhdGUocywgbGVuZ3RoKTsg fTsKKyAgICBBTFdBWVNfSU5MSU5FIHN0YXRpYyBQYXNzUmVmUHRyPFN0cmluZ0ltcGw+IGNyZWF0 ZShjb25zdCBjaGFyKiBzLCB1bnNpZ25lZCBsZW5ndGgpIHsgcmV0dXJuIGNyZWF0ZShyZWludGVy cHJldF9jYXN0PGNvbnN0IExDaGFyKj4ocyksIGxlbmd0aCk7IH0KICAgICBzdGF0aWMgUGFzc1Jl ZlB0cjxTdHJpbmdJbXBsPiBjcmVhdGUoY29uc3QgTENoYXIqKTsKLSAgICBBTFdBWVNfSU5MSU5F IHN0YXRpYyBQYXNzUmVmUHRyPFN0cmluZ0ltcGw+IGNyZWF0ZShjb25zdCBjaGFyKiBzKSB7IHJl dHVybiBjcmVhdGUocmVpbnRlcnByZXRfY2FzdDxjb25zdCBMQ2hhcio+KHMpKTsgfTsKKyAgICBB TFdBWVNfSU5MSU5FIHN0YXRpYyBQYXNzUmVmUHRyPFN0cmluZ0ltcGw+IGNyZWF0ZShjb25zdCBj aGFyKiBzKSB7IHJldHVybiBjcmVhdGUocmVpbnRlcnByZXRfY2FzdDxjb25zdCBMQ2hhcio+KHMp KTsgfQogCiAgICAgc3RhdGljIEFMV0FZU19JTkxJTkUgUGFzc1JlZlB0cjxTdHJpbmdJbXBsPiBj cmVhdGU4KFBhc3NSZWZQdHI8U3RyaW5nSW1wbD4gcmVwLCB1bnNpZ25lZCBvZmZzZXQsIHVuc2ln bmVkIGxlbmd0aCkKICAgICB7Cg== 113019 2011-10-31 00:16:32 -0700 2011-10-31 16:19:09 -0700 patch v2 71206a text/plain 1917 wangxianzhu SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTg4MzUpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTEtMTAtMzAgIFhpYW56aHUgV2FuZyAgPHdhbmd4aWFuemh1QGNocm9taXVtLm9yZz4KKwor ICAgICAgICBXVEY6OlN0cmluZ0ltcGw6OmNyZWF0ZShjb25zdCBjaGFyKiwgdW5zaWduZWQpIGNh bGxzIGl0c2VsZgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NzEyMDYKKworICAgICAgICBUaGUgb3JpZ2luYWwgaW1wbGVtZW50YXRpb24ganVzdCBjYWxs cyBpdHNlbGYsIGNhdXNpbmcgaW5maW5pdGUgcmVjdXJzaW9uLgorICAgICAgICBDYXN0IHRoZSBm aXJzdCBwYXJhbWV0ZXIgdG8gY29uc3QgTENoYXIqIHRvIGZpeCB0aGF0LgorCisgICAgICAgIFJl dmlld2VkIGJ5IFJ5b3N1a2UgTml3YS4KKworICAgICAgICAqIHd0Zi90ZXh0L1N0cmluZ0ltcGwu aDoKKyAgICAgICAgKFdURjo6U3RyaW5nSW1wbDo6Y3JlYXRlKToKKwogMjAxMS0xMC0zMCAgRmls aXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIEpTUGFyc2VyOjpwYXJzZVBy aW1hcnlFeHByZXNzaW9uIHNob3VsZCBoYXZlIGFuIG92ZXJmbG93IGNoZWNrCkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvd3RmL3RleHQvU3RyaW5nSW1wbC5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvdGV4dC9TdHJpbmdJbXBsLmgJKHJldmlzaW9uIDk4ODM1 KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi90ZXh0L1N0cmluZ0ltcGwuaAkod29ya2lu ZyBjb3B5KQpAQCAtMTgyLDkgKzE4Miw5IEBAIHB1YmxpYzoKIAogICAgIHN0YXRpYyBQYXNzUmVm UHRyPFN0cmluZ0ltcGw+IGNyZWF0ZShjb25zdCBVQ2hhciosIHVuc2lnbmVkIGxlbmd0aCk7CiAg ICAgc3RhdGljIFBhc3NSZWZQdHI8U3RyaW5nSW1wbD4gY3JlYXRlKGNvbnN0IExDaGFyKiwgdW5z aWduZWQgbGVuZ3RoKTsKLSAgICBBTFdBWVNfSU5MSU5FIHN0YXRpYyBQYXNzUmVmUHRyPFN0cmlu Z0ltcGw+IGNyZWF0ZShjb25zdCBjaGFyKiBzLCB1bnNpZ25lZCBsZW5ndGgpIHsgcmV0dXJuIGNy ZWF0ZShzLCBsZW5ndGgpOyB9OworICAgIEFMV0FZU19JTkxJTkUgc3RhdGljIFBhc3NSZWZQdHI8 U3RyaW5nSW1wbD4gY3JlYXRlKGNvbnN0IGNoYXIqIHMsIHVuc2lnbmVkIGxlbmd0aCkgeyByZXR1 cm4gY3JlYXRlKHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgTENoYXIqPihzKSwgbGVuZ3RoKTsgfQog ICAgIHN0YXRpYyBQYXNzUmVmUHRyPFN0cmluZ0ltcGw+IGNyZWF0ZShjb25zdCBMQ2hhciopOwot ICAgIEFMV0FZU19JTkxJTkUgc3RhdGljIFBhc3NSZWZQdHI8U3RyaW5nSW1wbD4gY3JlYXRlKGNv bnN0IGNoYXIqIHMpIHsgcmV0dXJuIGNyZWF0ZShyZWludGVycHJldF9jYXN0PGNvbnN0IExDaGFy Kj4ocykpOyB9OworICAgIEFMV0FZU19JTkxJTkUgc3RhdGljIFBhc3NSZWZQdHI8U3RyaW5nSW1w bD4gY3JlYXRlKGNvbnN0IGNoYXIqIHMpIHsgcmV0dXJuIGNyZWF0ZShyZWludGVycHJldF9jYXN0 PGNvbnN0IExDaGFyKj4ocykpOyB9CiAKICAgICBzdGF0aWMgQUxXQVlTX0lOTElORSBQYXNzUmVm UHRyPFN0cmluZ0ltcGw+IGNyZWF0ZTgoUGFzc1JlZlB0cjxTdHJpbmdJbXBsPiByZXAsIHVuc2ln bmVkIG9mZnNldCwgdW5zaWduZWQgbGVuZ3RoKQogICAgIHsK