71196 2011-10-30 17:16:06 -0700 [Qt] [WK2] MiniBrowser assert in QtWebProccess on startup in debug build. 2011-11-03 04:20:57 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt P3 Normal --- 1 ostap73 ostap73 hausmann noam webkit.review.bot zoltan oldest_to_newest 493105 0 ostap73 2011-10-30 17:16:06 -0700 Assert in DrawingAreaImpl::exitAcceleratedCompositingMode() ASSERT(!m_layerTreeStateIsFrozen); Call stack: 0 WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode DrawingAreaImpl.cpp 470 0xb5fd7ad4 1 WebKit::DrawingAreaImpl::setRootCompositingLayer DrawingAreaImpl.cpp 298 0xb5fd7111 2 WebKit::WebPage::exitAcceleratedCompositingMode WebPage.cpp 468 0xb5ed1396 3 WebKit::WebChromeClient::attachRootGraphicsLayer WebChromeClient.cpp 684 0xb5fb8aff 4 WebCore::RenderLayerCompositor::detachRootLayer RenderLayerCompositor.cpp 1899 0xb66dcc37 5 WebCore::RenderLayerCompositor::destroyRootLayer RenderLayerCompositor.cpp 1808 0xb66dc63c 6 WebCore::RenderLayerCompositor::enableCompositingMode RenderLayerCompositor.cpp 129 0xb66d6eb0 7 WebCore::RenderLayerCompositor::computeCompositingRequirements RenderLayerCompositor.cpp 791 0xb66d9198 8 WebCore::RenderLayerCompositor::updateCompositingLayers RenderLayerCompositor.cpp 304 0xb66d7626 9 WebCore::FrameView::updateCompositingLayers FrameView.cpp 643 0xb650eac8 10 WebCore::FrameView::layout FrameView.cpp 1127 0xb650ffb0 11 WebCore::FrameView::visibleContentsResized FrameView.cpp 1802 0xb65124be 12 WebCore::ScrollView::updateScrollbars ScrollView.cpp 516 0xb65c6168 13 WebCore::ScrollView::setFrameRect ScrollView.cpp 863 0xb65c7a32 14 WebCore::FrameView::setFrameRect FrameView.cpp 406 0xb650df67 15 WebCore::Widget::resize Widget.h 143 0xb5d7d9d6 16 WebKit::WebPage::setSize WebPage.cpp 687 0xb5ed2917 17 WebKit::DrawingAreaImpl::updateBackingStoreState DrawingAreaImpl.cpp 328 0xb5fd72ac 18 CoreIPC::callMemberFunction<WebKit::DrawingArea, void (WebKit::DrawingArea::*)(unsigned long long, bool, float, WebCore::IntSize const&, WebCore::IntSize const&), unsigned long long, bool, float, WebCore::IntSize, WebCore::IntSize> HandleMessage.h 43 0xb5efa40e 19 CoreIPC::handleMessage<Messages::DrawingArea::UpdateBackingStoreState, WebKit::DrawingArea, void (WebKit::DrawingArea::*)(unsigned long long, bool, float, WebCore::IntSize const&, WebCore::IntSize const&)> HandleMessage.h 277 0xb5efa059 20 WebKit::DrawingArea::didReceiveDrawingAreaMessage DrawingAreaMessageReceiver.cpp 47 0xb5ef9db6 21 WebKit::WebPage::didReceiveMessage WebPage.cpp 2205 0xb5ed856c 22 WebKit::WebProcess::didReceiveMessage WebProcess.cpp 658 0xb5eea5a1 23 CoreIPC::Connection::dispatchMessage Connection.cpp 689 0xb5f1ed76 24 CoreIPC::Connection::dispatchMessages Connection.cpp 716 0xb5f1ef1f 25 MemberFunctionWorkItem0<CoreIPC::Connection>::execute WorkItem.h 79 0xb5f276af 26 RunLoop::performWork RunLoop.cpp 63 0xb5e04499 27 RunLoop::TimerObject::performWork RunLoopQt.cpp 49 0xb5e0549c 28 RunLoop::TimerObject::qt_static_metacall RunLoopQt.moc 48 0xb5e05eca 29 QMetaCallEvent::placeMetaCall qobject.cpp 529 0xb284d6d6 30 QObject::event qobject.cpp 1111 0xb284e2f7 31 QApplicationPrivate::notify_helper qapplication.cpp 4080 0xb35dc436 32 QApplication::notify qapplication.cpp 3497 0xb35d9e37 33 QCoreApplication::notifyInternal qcoreapplication.cpp 827 0xb282e10a 34 QCoreApplication::sendEvent qcoreapplication.h 205 0xb5d78a35 35 QCoreApplicationPrivate::sendPostedEvents qcoreapplication.cpp 1469 0xb282efef 36 QCoreApplication::sendPostedEvents qcoreapplication.cpp 1339 0xb282ecab 37 QCoreApplication::sendPostedEvents qcoreapplication.h 210 0xb2b3564a 38 QWindowSystemInterface::sendWindowSystemEvents qwindowsysteminterface_qpa.cpp 296 0xb2b3542a 39 QEventDispatcherQPA::processEvents qeventdispatcher_qpa.cpp 70 0xb09550e8 40 QEventLoop::processEvents qeventloop.cpp 149 0xb282bc31 41 QEventLoop::exec qeventloop.cpp 225 0xb282be92 42 QCoreApplication::exec qcoreapplication.cpp 1094 0xb282e76e 43 RunLoop::run RunLoopQt.cpp 65 0xb5e056c9 44 WebKit::WebProcessMainQt WebProcessMainQt.cpp 199 0xb5e00e6f 45 main MainQt.cpp 38 0x804850f 493107 1 113004 ostap73 2011-10-30 17:51:54 -0700 Created attachment 113004 Delay exit from AC mode if layer state is frozen during setSize/layout. 493217 2 113004 hausmann 2011-10-31 02:11:53 -0700 Comment on attachment 113004 Delay exit from AC mode if layer state is frozen during setSize/layout. View in context: https://bugs.webkit.org/attachment.cgi?id=113004&action=review > Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp:297 > + if (m_inUpdateBackingStoreState && !m_layerTreeStateIsFrozen) How is it possible to hit this code patch? It's wrapped in if (!m_alwaysUseCompositing). 493220 3 hausmann 2011-10-31 02:29:44 -0700 As a matter of fact, I can't reproduce this on trunk (r98839), because we should now always be compositing. 493380 4 ostap73 2011-10-31 09:59:38 -0700 (In reply to comment #3) > As a matter of fact, I can't reproduce this on trunk (r98839), because we should now always be compositing. I have r98793 and it doesn't run in AC always mode. I'll figure out. 493726 5 ostap73 2011-10-31 20:10:32 -0700 (In reply to comment #3) > As a matter of fact, I can't reproduce this on trunk (r98839), because we should now always be compositing. It's QDesktopWebView.Seems QDesktopWebView doesn't have AC because QtDesktopWebPageProxy disables AC in constructor: 493754 6 noam 2011-10-31 23:15:19 -0700 Maybe a better solution would be to expose forceCompositing to WebPreferencesPrivate, and to enable force-compositing for touch only. 493760 7 hausmann 2011-10-31 23:26:28 -0700 Ohh, I see. On that note: Alexis is currently working on changing the DesktopWebView from a painted item to using AC together with layered scrollbars. 493860 8 ostap73 2011-11-01 05:52:42 -0700 (In reply to comment #6) > Maybe a better solution would be to expose forceCompositing to WebPreferencesPrivate, and to enable force-compositing for touch only. forceCompositing is not enabled for desktop view. The problem, that it tries to switch AC on and off. IMHO, another solution would be to disable AC for DV now. 493863 9 ostap73 2011-11-01 05:57:39 -0700 (In reply to comment #6) > Maybe a better solution would be to expose forceCompositing to WebPreferencesPrivate, and to enable force-compositing for touch only. BTW, is any other port still using switchable AC (not always on)? In this case they would need patch because webprocess would assert/crash if window get resized during load (when m_layerTreeStateIsFrozen is set). In Qt Minibrowser on startup 1st comes load, then setSize from window getting visible. 494638 10 noam 2011-11-02 08:40:12 -0700 (In reply to comment #9) > (In reply to comment #6) > > Maybe a better solution would be to expose forceCompositing to WebPreferencesPrivate, and to enable force-compositing for touch only. > > BTW, is any other port still using switchable AC (not always on)? > In this case they would need patch because webprocess would assert/crash if window get resized during load (when m_layerTreeStateIsFrozen is set). > In Qt Minibrowser on startup 1st comes load, then setSize from window getting visible. Yes, Apple uses switchable AC I believe. but we have AC always on for touch and always off for desktop (at least that's how it should be). 495292 11 hausmann 2011-11-03 02:56:34 -0700 (In reply to comment #10) > (In reply to comment #9) > > (In reply to comment #6) > > > Maybe a better solution would be to expose forceCompositing to WebPreferencesPrivate, and to enable force-compositing for touch only. > > > > BTW, is any other port still using switchable AC (not always on)? > > In this case they would need patch because webprocess would assert/crash if window get resized during load (when m_layerTreeStateIsFrozen is set). > > In Qt Minibrowser on startup 1st comes load, then setSize from window getting visible. > > Yes, Apple uses switchable AC I believe. but we have AC always on for touch and always off for desktop (at least that's how it should be). And it turns out that this is where the bug is, AC is not actually properly turned off for the desktop view. I'm fixing this as we speak :) 495298 12 113449 hausmann 2011-11-03 03:00:41 -0700 Created attachment 113449 [Qt] [WK2] MiniBrowser assert in QtWebProccess on startup in debug build. 495337 13 113449 hausmann 2011-11-03 04:20:49 -0700 Comment on attachment 113449 [Qt] [WK2] MiniBrowser assert in QtWebProccess on startup in debug build. Clearing flags on attachment: 113449 Committed r99165: <http://trac.webkit.org/changeset/99165> 495338 14 hausmann 2011-11-03 04:20:57 -0700 All reviewed patches have been landed. Closing bug. 113004 2011-10-30 17:51:54 -0700 2011-11-03 03:00:36 -0700 Delay exit from AC mode if layer state is frozen during setSize/layout. ACModeExitAssert.diff text/plain 1627 ostap73 ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA1MmJhNGM1Li4xYTQ1Yzc1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMTAtMzAgIFZpYXRjaGVzbGF2IE9zdGFwZW5rbyAgPG9zdGFwZW5rby52aWF0Y2hl c2xhdkBub2tpYS5jb20+CisKKyAgICAgICAgW1F0XSBbV0syXSBNaW5pQnJvd3NlciBhc3NlcnQg aW4gUXRXZWJQcm9jY2VzcyBvbiBzdGFydHVwIGluIGRlYnVnIGJ1aWxkLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzExOTYKKworICAgICAgICBEZWxh eSBleGl0IGZyb20gQUMgbW9kZSBpZiBsYXllciB0cmVlIHN0YXRlIGlzIGZyb3plbiBkdXJpbmcK KyAgICAgICAgc2V0U2l6ZSBhbmQgbGF5b3V0LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL0RyYXdpbmdBcmVhSW1w bC5jcHA6CisgICAgICAgIChXZWJLaXQ6OkRyYXdpbmdBcmVhSW1wbDo6c2V0Um9vdENvbXBvc2l0 aW5nTGF5ZXIpOgorCiAyMDExLTEwLTI4ICBKZWZmIE1pbGxlciAgPGplZmZtQGFwcGxlLmNvbT4K IAogICAgICAgICBNb3JlIHdvcmsgb24gV2ViS2l0MiBzaG91bGQgcmVzcGVjdCBXZWJLaXRPbWl0 UERGU3VwcG9ydCBwcmVmZXJlbmNlIG9uIHRoZSBNYWMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9EcmF3aW5nQXJlYUltcGwuY3BwIGIvU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0RyYXdpbmdBcmVhSW1wbC5jcHAKaW5kZXggNDcyMDZiZi4u YzM2YmI4YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0Ry YXdpbmdBcmVhSW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdl L0RyYXdpbmdBcmVhSW1wbC5jcHAKQEAgLTI5NCw3ICsyOTQsNyBAQCB2b2lkIERyYXdpbmdBcmVh SW1wbDo6c2V0Um9vdENvbXBvc2l0aW5nTGF5ZXIoR3JhcGhpY3NMYXllciogZ3JhcGhpY3NMYXll cikKICAgICAgICAgICAgICAgICAvLyBjb21wb3NpdGluZyBjb2RlIHZpYSBkaXNwbGF5KCkgYW5k IGxheW91dC4KICAgICAgICAgICAgICAgICAvLyBJZiB3ZSdyZSBsZWF2aW5nIGNvbXBvc2l0aW5n IG1vZGUgYmVjYXVzZSBvZiBhIHNldFNpemUsIGl0IGlzIHNhZmUgdG8KICAgICAgICAgICAgICAg ICAvLyBleGl0IGFjY2VsZXJhdGVkIGNvbXBvc2l0aW5nIG1vZGUgcmlnaHQgYXdheS4KLSAgICAg ICAgICAgICAgICBpZiAobV9pblVwZGF0ZUJhY2tpbmdTdG9yZVN0YXRlKQorICAgICAgICAgICAg ICAgIGlmIChtX2luVXBkYXRlQmFja2luZ1N0b3JlU3RhdGUgJiYgIW1fbGF5ZXJUcmVlU3RhdGVJ c0Zyb3plbikKICAgICAgICAgICAgICAgICAgICAgZXhpdEFjY2VsZXJhdGVkQ29tcG9zaXRpbmdN b2RlKCk7CiAgICAgICAgICAgICAgICAgZWxzZQogICAgICAgICAgICAgICAgICAgICBleGl0QWNj ZWxlcmF0ZWRDb21wb3NpdGluZ01vZGVTb29uKCk7Cg== 113449 2011-11-03 03:00:41 -0700 2011-11-03 04:20:49 -0700 [Qt] [WK2] MiniBrowser assert in QtWebProccess on startup in debug build. bug-71196-20111103110041.patch text/plain 1980 hausmann U3VidmVyc2lvbiBSZXZpc2lvbjogOTkxNTEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCA2NzU4ODM5N2NhODRlMTUx NmU5YmFhNTRlMjliMjY1NDRiNTgxYWM4Li4wNDFjZjhlMmFlZjY1ZmU1NjI3MDRiMjc3ZjlhZGZh ZDNmY2E5ZGVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjIgQEAKIDIwMTEtMTEtMDMgIFNpbW9u IEhhdXNtYW5uICA8c2ltb24uaGF1c21hbm5Abm9raWEuY29tPgogCisgICAgICAgIFtRdF0gW1dL Ml0gTWluaUJyb3dzZXIgYXNzZXJ0IGluIFF0V2ViUHJvY2Nlc3Mgb24gc3RhcnR1cCBpbiBkZWJ1 ZyBidWlsZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTcxMTk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg RW5zdXJlIEFDIGlzIHR1cm5lZCBvZmYgZm9yIHRoZSBkZXNrdG9wIHZpZXcgYmVmb3JlIHdlIGxh dW5jaCB0aGUgcHJvY2Vzcy4KKyAgICAgICAgVGhpcyBhdm9pZHMgImFjY2lkZW50aWFsIiBlbnRl ckFjL2V4aXRBYyBjYWxscyB0aGF0IGNhdXNlIGZhaWxpbmcgYXNzZXJ0aW9ucworICAgICAgICBi ZWNhdXNlIHdlIGRvbid0IHJlYWxseSBzdXBwb3J0IEFDIGluIHRoaXMgc2V0dXAuCisKKyAgICAg ICAgVGhlIHRvdWNoIHNpZGUgd29ya3MgdGhlIHNhbWUgd2F5LCBpLmUuIGVuYWJsZSB0aGUgcHJl ZmVyZW5jZSBiZWZvcmUgY2FsbGluZworICAgICAgICBpbml0KCkuCisKKyAgICAgICAgKiBVSVBy b2Nlc3MvcXQvUXREZXNrdG9wV2ViUGFnZVByb3h5LmNwcDoKKyAgICAgICAgKFF0RGVza3RvcFdl YlBhZ2VQcm94eTo6UXREZXNrdG9wV2ViUGFnZVByb3h5KToKKworMjAxMS0xMS0wMyAgU2ltb24g SGF1c21hbm4gIDxzaW1vbi5oYXVzbWFubkBub2tpYS5jb20+CisKICAgICAgICAgVW5yZXZpZXdl ZCBRdCBidWlsZCBmaXgoZXMpLgogCiAgICAgICAgICogVUlQcm9jZXNzL3F0L1F0RGVza3RvcFdl YlBhZ2VQcm94eS5jcHA6CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQv UXREZXNrdG9wV2ViUGFnZVByb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9R dERlc2t0b3BXZWJQYWdlUHJveHkuY3BwCmluZGV4IDIxMTBiOGE5NjFhMzI2M2ZkYzAzZTkyOWNi NGJhMWRlNWI1MzEyZDcuLjFlMmQ0MzllODg5ZGJlNjEyY2MyZjYyMjM5ZDM4MmY3NGUyZGFhNTkg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdERlc2t0b3BXZWJQYWdl UHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdERlc2t0b3BXZWJQ YWdlUHJveHkuY3BwCkBAIC01NSw4ICs1NSw4IEBAIHN0YXRpYyBpbmxpbmUgUXQ6OkRyb3BBY3Rp b24gZHJhZ09wZXJhdGlvblRvRHJvcEFjdGlvbih1bnNpZ25lZCBkcmFnT3BlcmF0aW9uKQogUXRE ZXNrdG9wV2ViUGFnZVByb3h5OjpRdERlc2t0b3BXZWJQYWdlUHJveHkoUURlc2t0b3BXZWJWaWV3 UHJpdmF0ZSogZGVza3RvcFdlYlZpZXcsIFdLQ29udGV4dFJlZiBjb250ZXh0LCBXS1BhZ2VHcm91 cFJlZiBwYWdlR3JvdXApCiAgICAgOiBRdFdlYlBhZ2VQcm94eShkZXNrdG9wV2ViVmlldywgZGVz a3RvcFdlYlZpZXcsIGNvbnRleHQsIHBhZ2VHcm91cCkKIHsKLSAgICBpbml0KCk7CiAgICAgUVdl YlByZWZlcmVuY2VzUHJpdmF0ZTo6Z2V0KHByZWZlcmVuY2VzKCkpLT5zZXRBdHRyaWJ1dGUoUVdl YlByZWZlcmVuY2VzUHJpdmF0ZTo6QWNjZWxlcmF0ZWRDb21wb3NpdGluZ0VuYWJsZWQsIGZhbHNl KTsKKyAgICBpbml0KCk7CiB9CiAKIFBhc3NPd25QdHI8RHJhd2luZ0FyZWFQcm94eT4gUXREZXNr dG9wV2ViUGFnZVByb3h5OjpjcmVhdGVEcmF3aW5nQXJlYVByb3h5KCkK