71179 2011-10-29 12:55:24 -0700 [Cairo] Avoid clipping when painting more often 2011-11-09 19:10:19 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mrobinson mrobinson krit otte oldest_to_newest 492959 0 mrobinson 2011-10-29 12:55:24 -0700 Instead of calling cairo_clip/cairo_paint_with_alpha, we should try hard to just encapsulate the global alpha into the source pattern. This avoids an unnecessary clip. 492961 1 112974 mrobinson 2011-10-29 13:11:20 -0700 Created attachment 112974 Patch 492963 2 mrobinson 2011-10-29 13:48:40 -0700 (In reply to comment #1) > Created an attachment (id=112974) [details] > Patch Note; This patch introduces a performance hit for image pattern fills that have a non-opaque alpha. These kind of fills are not very common and I plan to address this in a followup patch. 494301 3 mrobinson 2011-11-01 16:43:36 -0700 On my machine this increases the framerate of the Man in Blue Canvas benchmark (http://themaninblue.com/experiment/AnimationBenchmark/canvas/) from 80 frames per second to 95 frames per second. 499044 4 112974 xan.lopez 2011-11-09 09:18:22 -0800 Comment on attachment 112974 Patch After talking about the patch a bit with Martin online I cannot see anything obviously wrong here, so r+. 499591 5 112974 mrobinson 2011-11-09 19:10:16 -0800 Comment on attachment 112974 Patch Clearing flags on attachment: 112974 Committed r99803: <http://trac.webkit.org/changeset/99803> 499592 6 mrobinson 2011-11-09 19:10:19 -0800 All reviewed patches have been landed. Closing bug. 112974 2011-10-29 13:11:20 -0700 2011-11-09 19:10:16 -0800 Patch bug-71179-20111029131119.patch text/plain 7393 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogOTg4MTAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAzNmE0ODA1OWFmMjlhNmNl YzQ5NWY0YjViNThkOTBmYTI3MjVkODk2Li5kMDUwMWIwYmQxYmE2MzhlNTNhYjNiNGRkZTk2MTY1 ODlkMDg0N2Y5IDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzAgQEAKKzIwMTEtMTAtMjkgIE1hcnRp biBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgorCisgICAgICAgIFtDYWlyb10gQXZv aWQgY2xpcHBpbmcgd2hlbiBwYWludGluZyBtb3JlIG9mdGVuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MTE3OQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gVGhlc2UgY2hhbmdlcyBh cmUgY292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL0dyYWRpZW50Lmg6IEFkZCBhIENhaXJvLXNwZWNpZmljIG1ldGhvZAorICAgICAgICB0aGF0 IGdldHMgdGhlIHBsYXRmb3JtIGdyYWRpZW50IHdpdGggYSBwYXJ0aWN1bGFyIGFscGhhIHZhbHVl LgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYWRpZW50Q2Fpcm8uY3BwOiBO b3cgY2FjaGUgdGhlIGFscGhhCisgICAgICAgIHZhbHVlIG9mIHRoZSBsYXN0IGNyZWF0ZWQgcGxh dGZvcm0gZ3JhZGllbnQuCisgICAgICAgIChXZWJDb3JlOjpHcmFkaWVudDo6cGxhdGZvcm1HcmFk aWVudCk6IElmIHRoZSBjYWNoZWQgcGxhdGZvcm0gZ3JhZGllbnQKKyAgICAgICAgaGFzIGEgZGlm ZmVyZW50IGFscGhhIHZhbHVlIHRoYW4gdGhlIG9uZSByZXF1ZXN0ZWQsIGRlc3Ryb3kgaXQgYW5k IHN0YXJ0CisgICAgICAgIG92ZXIuCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8v R3JhcGhpY3NDb250ZXh0Q2Fpcm8uY3BwOgorICAgICAgICAoV2ViQ29yZTo6ZHJhd1BhdGhTaGFk b3cpOiBBZGp1c3QgdGhlIHNvdXJjZSB0byBhdm9pZCBjYWxsaW5nCisgICAgICAgIGNhaXJvX2Ns aXAvY2Fpcm9fcGFpbnRfd2l0aF9hbHBoYSBhbmQganVzdCBkbyBhIGZpbGwuCisgICAgICAgIChX ZWJDb3JlOjpzaGFkb3dBbmRGaWxsQ3VycmVudENhaXJvUGF0aCk6IE5vIG5lZWQgdG8gY2xpcCBo ZXJlLiBKdXN0CisgICAgICAgIGNhbGwgY2Fpcm9fZmlsbC4KKyAgICAgICAgKiBwbGF0Zm9ybS9n cmFwaGljcy9jYWlyby9QbGF0Zm9ybUNvbnRleHRDYWlyby5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpkcmF3UGF0dGVyblRvQ2Fpcm9Db250ZXh0KTogSWYgd2UgaGF2ZSBhID49IDEgYWxwaGEgdmFs dWUKKyAgICAgICAgd2UgY2FuIHNpbXBseSBmaWxsIGFuZCBhdm9pZCBjYWxsaW5nIGNhaXJvX2Ns aXAgaGVyZS4KKyAgICAgICAgKFdlYkNvcmU6OnByZXBhcmVDYWlyb0NvbnRleHRTb3VyY2UpOiBS ZW1vdmUgVE9ETyBhYm91dCByZWNyZWF0aW5nIHRoZQorICAgICAgICBncmFkaWVudC4gTm8gbG9u Z2VyIG5lZWQgdG8gcmVkdWNlIHRoZSBncmFkaWVudCBzb3VyY2UuCisKIDIwMTEtMTAtMjkgIEFu bmEgQ2F2ZW5kZXIgIDxhbm5hY2NAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIE1ha2Ugc3VyZSBU ZXh0VHJhY2tzIGFyZSBkZXN0cnVjdGVkIGlmIEhUTUxNZWRpYUVsZW1lbnQgZ29lcyBhd2F5Lgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhZGllbnQuaCBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYWRpZW50LmgKaW5kZXggMWZmMzQ2 ZGE0OWQwNTM3ZDg3ZTY4Nzc5MjY2YjdjMzZiN2NkNWE2Zi4uMDFlNDk3ZGE4ZGRhNTBhZmEyOTE1 NDA2MGVjZmE4MzdlNmY3MzdhMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvR3JhZGllbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9HcmFkaWVudC5oCkBAIC0xMzgsNiArMTM4LDggQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogI2lm IFVTRShDRykKICAgICAgICAgdm9pZCBwYWludChDR0NvbnRleHRSZWYpOwogICAgICAgICB2b2lk IHBhaW50KEdyYXBoaWNzQ29udGV4dCopOworI2VsaWYgVVNFKENBSVJPKQorICAgICAgICBQbGF0 Zm9ybUdyYWRpZW50IHBsYXRmb3JtR3JhZGllbnQoZmxvYXQgZ2xvYmFsQWxwaGEpOwogI2VuZGlm CiAKICAgICBwcml2YXRlOgpAQCAtMTYzLDYgKzE2NSwxMSBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7 CiAgICAgICAgIEFmZmluZVRyYW5zZm9ybSBtX2dyYWRpZW50U3BhY2VUcmFuc2Zvcm1hdGlvbjsK IAogICAgICAgICBQbGF0Zm9ybUdyYWRpZW50IG1fZ3JhZGllbnQ7CisKKyNpZiBVU0UoQ0FJUk8p CisgICAgICAgIGZsb2F0IG1fcGxhdGZvcm1HcmFkaWVudEFscGhhOworI2VuZGlmCisKICAgICB9 OwogCiB9IC8vbmFtZXNwYWNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9jYWlyby9HcmFkaWVudENhaXJvLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2NhaXJvL0dyYWRpZW50Q2Fpcm8uY3BwCmluZGV4IDIyNTA0NmFhM2FhMTM5ZmU0 MjlmN2Q5ZjQ5ZWQ1NzY2NmRhYTJjMTYuLmY3NmJiNmRiOTc4MTYxYWM2YzIzYzMyNTkzZDQ3ZTNh OWQ3MDNkODkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nh aXJvL0dyYWRpZW50Q2Fpcm8uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2NhaXJvL0dyYWRpZW50Q2Fpcm8uY3BwCkBAIC00NCw5ICs0NCwxNyBAQCB2b2lkIEdyYWRp ZW50OjpwbGF0Zm9ybURlc3Ryb3koKQogCiBjYWlyb19wYXR0ZXJuX3QqIEdyYWRpZW50OjpwbGF0 Zm9ybUdyYWRpZW50KCkKIHsKLSAgICBpZiAobV9ncmFkaWVudCkKKyAgICByZXR1cm4gcGxhdGZv cm1HcmFkaWVudCgxKTsKK30KKworY2Fpcm9fcGF0dGVybl90KiBHcmFkaWVudDo6cGxhdGZvcm1H cmFkaWVudChmbG9hdCBnbG9iYWxBbHBoYSkKK3sKKyAgICBpZiAobV9ncmFkaWVudCAmJiBtX3Bs YXRmb3JtR3JhZGllbnRBbHBoYSA9PSBnbG9iYWxBbHBoYSkKICAgICAgICAgcmV0dXJuIG1fZ3Jh ZGllbnQ7CiAKKyAgICBwbGF0Zm9ybURlc3Ryb3koKTsKKyAgICBtX3BsYXRmb3JtR3JhZGllbnRB bHBoYSA9IGdsb2JhbEFscGhhOworCiAgICAgaWYgKG1fcmFkaWFsKQogICAgICAgICBtX2dyYWRp ZW50ID0gY2Fpcm9fcGF0dGVybl9jcmVhdGVfcmFkaWFsKG1fcDAueCgpLCBtX3AwLnkoKSwgbV9y MCwgbV9wMS54KCksIG1fcDEueSgpLCBtX3IxKTsKICAgICBlbHNlCkBAIC01NCw3ICs2Miw5IEBA IGNhaXJvX3BhdHRlcm5fdCogR3JhZGllbnQ6OnBsYXRmb3JtR3JhZGllbnQoKQogCiAgICAgVmVj dG9yPENvbG9yU3RvcD46Oml0ZXJhdG9yIHN0b3BJdGVyYXRvciA9IG1fc3RvcHMuYmVnaW4oKTsK ICAgICB3aGlsZSAoc3RvcEl0ZXJhdG9yICE9IG1fc3RvcHMuZW5kKCkpIHsKLSAgICAgICAgY2Fp cm9fcGF0dGVybl9hZGRfY29sb3Jfc3RvcF9yZ2JhKG1fZ3JhZGllbnQsIHN0b3BJdGVyYXRvci0+ c3RvcCwgc3RvcEl0ZXJhdG9yLT5yZWQsIHN0b3BJdGVyYXRvci0+Z3JlZW4sIHN0b3BJdGVyYXRv ci0+Ymx1ZSwgc3RvcEl0ZXJhdG9yLT5hbHBoYSk7CisgICAgICAgIGNhaXJvX3BhdHRlcm5fYWRk X2NvbG9yX3N0b3BfcmdiYShtX2dyYWRpZW50LCBzdG9wSXRlcmF0b3ItPnN0b3AsCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdG9wSXRlcmF0b3ItPnJlZCwgc3Rv cEl0ZXJhdG9yLT5ncmVlbiwgc3RvcEl0ZXJhdG9yLT5ibHVlLAorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgc3RvcEl0ZXJhdG9yLT5hbHBoYSAqIGdsb2JhbEFscGhh KTsKICAgICAgICAgKytzdG9wSXRlcmF0b3I7CiAgICAgfQogCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHRDYWlyby5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHRD YWlyby5jcHAKaW5kZXggMDA0MjlkNzhiNDc3OTNlM2NmNTM2MDZmYmRhY2QwM2NkMDExODNiYi4u NGMzNDQ3YjcyNjA4OWI0YjM3Y2Y1MjYwMjMwOGJhY2VmNzM1M2U1MyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0Q2Fpcm8u Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNz Q29udGV4dENhaXJvLmNwcApAQCAtMTM0LDggKzEzNCw3IEBAIHN0YXRpYyBpbmxpbmUgdm9pZCBk cmF3UGF0aFNoYWRvdyhHcmFwaGljc0NvbnRleHQqIGNvbnRleHQsIFBhdGhEcmF3aW5nU3R5bGUg ZHJhCiAgICAgICAgIGNhaXJvX3NhdmUoY2Fpcm9TaGFkb3dDb250ZXh0KTsKICAgICAgICAgY2Fp cm9fYXBwZW5kX3BhdGgoY2Fpcm9TaGFkb3dDb250ZXh0LCBwYXRoLmdldCgpKTsKICAgICAgICAg c2hhZG93Q29udGV4dC0+cGxhdGZvcm1Db250ZXh0KCktPnByZXBhcmVGb3JGaWxsaW5nKGNvbnRl eHQtPnN0YXRlKCksIFBsYXRmb3JtQ29udGV4dENhaXJvOjpOb0FkanVzdG1lbnQpOwotICAgICAg ICBjYWlyb19jbGlwKGNhaXJvU2hhZG93Q29udGV4dCk7Ci0gICAgICAgIGNhaXJvX3BhaW50KGNh aXJvU2hhZG93Q29udGV4dCk7CisgICAgICAgIGNhaXJvX2ZpbGwoY2Fpcm9TaGFkb3dDb250ZXh0 KTsKICAgICAgICAgY2Fpcm9fcmVzdG9yZShjYWlyb1NoYWRvd0NvbnRleHQpOwogICAgIH0KIApA QCAtMTU3LDEyICsxNTYsMTEgQEAgc3RhdGljIGlubGluZSB2b2lkIHNoYWRvd0FuZEZpbGxDdXJy ZW50Q2Fpcm9QYXRoKEdyYXBoaWNzQ29udGV4dCogY29udGV4dCkKICAgICBjYWlyb190KiBjciA9 IGNvbnRleHQtPnBsYXRmb3JtQ29udGV4dCgpLT5jcigpOwogICAgIGNhaXJvX3NhdmUoY3IpOwog Ci0gICAgY29udGV4dC0+cGxhdGZvcm1Db250ZXh0KCktPnByZXBhcmVGb3JGaWxsaW5nKGNvbnRl eHQtPnN0YXRlKCksIFBsYXRmb3JtQ29udGV4dENhaXJvOjpOb0FkanVzdG1lbnQpOwotCiAgICAg ZHJhd1BhdGhTaGFkb3coY29udGV4dCwgRmlsbCk7CiAKLSAgICBjYWlyb19jbGlwKGNyKTsKLSAg ICBjYWlyb19wYWludF93aXRoX2FscGhhKGNyLCBjb250ZXh0LT5wbGF0Zm9ybUNvbnRleHQoKS0+ Z2xvYmFsQWxwaGEoKSk7CisgICAgY29udGV4dC0+cGxhdGZvcm1Db250ZXh0KCktPnByZXBhcmVG b3JGaWxsaW5nKGNvbnRleHQtPnN0YXRlKCksIFBsYXRmb3JtQ29udGV4dENhaXJvOjpBZGp1c3RQ YXR0ZXJuRm9yR2xvYmFsQWxwaGEpOworICAgIGNhaXJvX2ZpbGwoY3IpOworCiAgICAgY2Fpcm9f cmVzdG9yZShjcik7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2NhaXJvL1BsYXRmb3JtQ29udGV4dENhaXJvLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2NhaXJvL1BsYXRmb3JtQ29udGV4dENhaXJvLmNwcAppbmRleCA1MmRj MGYzMDNmMWNiNTNhZjBjNTg5Yzc1ZGQ2YTE3OTE1NWE0MGQ3Li5mMmRkMmI5NjVkMGRlNzY0MWUx NjVlYzQ3MGJhZTNmNWViYzIxNjY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9jYWlyby9QbGF0Zm9ybUNvbnRleHRDYWlyby5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vUGxhdGZvcm1Db250ZXh0Q2Fpcm8uY3BwCkBA IC0xNDMsOCArMTQzLDEyIEBAIHN0YXRpYyB2b2lkIGRyYXdQYXR0ZXJuVG9DYWlyb0NvbnRleHQo Y2Fpcm9fdCogY3IsIGNhaXJvX3BhdHRlcm5fdCogcGF0dGVybiwgY29uCiAgICAgY2Fpcm9fdHJh bnNsYXRlKGNyLCBkZXN0UmVjdC54KCksIGRlc3RSZWN0LnkoKSk7CiAgICAgY2Fpcm9fc2V0X3Nv dXJjZShjciwgcGF0dGVybik7CiAgICAgY2Fpcm9fcmVjdGFuZ2xlKGNyLCAwLCAwLCBkZXN0UmVj dC53aWR0aCgpLCBkZXN0UmVjdC5oZWlnaHQoKSk7Ci0gICAgY2Fpcm9fY2xpcChjcik7Ci0gICAg Y2Fpcm9fcGFpbnRfd2l0aF9hbHBoYShjciwgYWxwaGEpOworCisgICAgaWYgKGFscGhhIDwgMSkg eworICAgICAgICBjYWlyb19jbGlwKGNyKTsKKyAgICAgICAgY2Fpcm9fcGFpbnRfd2l0aF9hbHBo YShjciwgYWxwaGEpOworICAgIH0gZWxzZQorICAgICAgICBjYWlyb19maWxsKGNyKTsKIH0KIAog dm9pZCBQbGF0Zm9ybUNvbnRleHRDYWlybzo6ZHJhd1N1cmZhY2VUb0NvbnRleHQoY2Fpcm9fc3Vy ZmFjZV90KiBzdXJmYWNlLCBjb25zdCBGbG9hdFJlY3QmIGRlc3RSZWN0LCBjb25zdCBGbG9hdFJl Y3QmIHNyY1JlY3QsIEdyYXBoaWNzQ29udGV4dCogY29udGV4dCkKQEAgLTIxMywxMyArMjE3LDkg QEAgc3RhdGljIHZvaWQgcHJlcGFyZUNhaXJvQ29udGV4dFNvdXJjZShjYWlyb190KiBjciwgUGF0 dGVybiogcGF0dGVybiwgR3JhZGllbnQqIGcKICAgICAgICAgUmVmUHRyPGNhaXJvX3BhdHRlcm5f dD4gY2Fpcm9QYXR0ZXJuKGFkb3B0UmVmKHBhdHRlcm4tPmNyZWF0ZVBsYXRmb3JtUGF0dGVybihB ZmZpbmVUcmFuc2Zvcm0oKSkpKTsKICAgICAgICAgY2Fpcm9fc2V0X3NvdXJjZShjciwgY2Fpcm9Q YXR0ZXJuLmdldCgpKTsKICAgICAgICAgcmVkdWNlU291cmNlQnlBbHBoYShjciwgZ2xvYmFsQWxw aGEpOwotICAgIH0gZWxzZSBpZiAoZ3JhZGllbnQpIHsKLSAgICAgICAgY2Fpcm9fc2V0X3NvdXJj ZShjciwgZ3JhZGllbnQtPnBsYXRmb3JtR3JhZGllbnQoKSk7Ci0KLSAgICAgICAgLy8gRklYTUU6 IEl0IHdvdWxkIGJlIGZhc3RlciB0byBzaW1wbHkgcmVjcmVhdGUgdGhlIENhaXJvIGdyYWRpZW50 IGFuZCBtdWx0aXBseSB0aGUKLSAgICAgICAgLy8gY29sb3Igc3RvcHMgYnkgdGhlIGdsb2JhbCBh bHBoYS4KLSAgICAgICAgcmVkdWNlU291cmNlQnlBbHBoYShjciwgZ2xvYmFsQWxwaGEpOwotICAg IH0gZWxzZSB7IC8vIFNvbGlkIGNvbG9yIHNvdXJjZS4KKyAgICB9IGVsc2UgaWYgKGdyYWRpZW50 KQorICAgICAgICBjYWlyb19zZXRfc291cmNlKGNyLCBncmFkaWVudC0+cGxhdGZvcm1HcmFkaWVu dChnbG9iYWxBbHBoYSkpOworICAgIGVsc2UgeyAvLyBTb2xpZCBjb2xvciBzb3VyY2UuCiAgICAg ICAgIGlmIChnbG9iYWxBbHBoYSA8IDEpCiAgICAgICAgICAgICBzZXRTb3VyY2VSR0JBRnJvbUNv bG9yKGNyLCBjb2xvcldpdGhPdmVycmlkZUFscGhhKGNvbG9yLnJnYigpLCBjb2xvci5hbHBoYSgp IC8gMjU1LmYgKiBnbG9iYWxBbHBoYSkpOwogICAgICAgICBlbHNlCg==