71156 2011-10-28 16:04:14 -0700 More work on WebKit2 should respect WebKitOmitPDFSupport preference on the Mac 2011-10-28 16:35:19 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jeffm jeffm ap oldest_to_newest 492752 0 jeffm 2011-10-28 16:04:14 -0700 More work on WebKit2 should respect WebKitOmitPDFSupport preference on the Mac 492755 1 jeffm 2011-10-28 16:05:28 -0700 Follow up to bug 70943, where Alexey commented: > There is also PDF code in WebContext::platformInitializeWebProcess. Should that be conditional, too? 492757 2 112936 jeffm 2011-10-28 16:08:28 -0700 Created attachment 112936 Patch 492770 3 112936 ap 2011-10-28 16:18:54 -0700 Comment on attachment 112936 Patch What was the manifestation of this problem, and are we sure that omitPDFSupport() will return the correct result so early in context lifetime? 492779 4 jeffm 2011-10-28 16:31:29 -0700 (In reply to comment #3) > (From update of attachment 112936 [details]) > What was the manifestation of this problem, and are we sure that omitPDFSupport() will return the correct result so early in context lifetime? There was no end-user symptom, PDF support was disabled correctly when this pref was set with the previous patch in r98513. This is just being complete by not including these MIME types in the initialization message. omitPDFSupport() just reads a preference from the standard user defaults, which should definitely be OK when this is called (note that this code is in the UI process, not the web process which is being created). 492784 5 jeffm 2011-10-28 16:35:19 -0700 Committed r98781: <http://trac.webkit.org/changeset/98781> 112936 2011-10-28 16:08:28 -0700 2011-10-28 16:18:54 -0700 Patch bug-71156-20111028160825.patch text/plain 1861 jeffm SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDk4NzczKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMTAtMjggIEplZmYgTWls bGVyICA8amVmZm1AYXBwbGUuY29tPgorCisgICAgICAgIE1vcmUgd29yayBvbiBXZWJLaXQyIHNo b3VsZCByZXNwZWN0IFdlYktpdE9taXRQREZTdXBwb3J0IHByZWZlcmVuY2Ugb24gdGhlIE1hYwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzExNTYKKyAg ICAgICAgCisgICAgICAgIERvbid0IGluY2x1ZGUgUERGIGFuZCBQb3N0U2NyaXB0IHR5cGVzIGlu IHRoZSBzZXQgb2YgTUlNRSB0eXBlcyB3aXRoIGN1c3RvbSByZXByZXNlbnRhdGlvbnMKKyAgICAg ICAgd2hlbiBpbml0aWFsaXppbmcgdGhlIHdlYiBwcm9jZXNzIGlmIFdlYktpdE9taXRQREZTdXBw b3J0IGlzIHNldC4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFVJUHJvY2Vzcy9tYWMvV2ViQ29udGV4dE1hYy5tbToKKyAgICAgICAgKFdlYktpdDo6 V2ViQ29udGV4dDo6cGxhdGZvcm1Jbml0aWFsaXplV2ViUHJvY2Vzcyk6CisKIDIwMTEtMTAtMjgg IEpvaG4gU3VsbGl2YW4gIDxzdWxsaXZhbkBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViS2l0MiBw YXJ0IG9mOgpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9XZWJDb250ZXh0TWFj Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV2ViQ29udGV4 dE1hYy5tbQkocmV2aXNpb24gOTg3NjQpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFj L1dlYkNvbnRleHRNYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTY5LDkgKzY5LDExIEBAIFN0cmlu ZyBXZWJDb250ZXh0OjphcHBsaWNhdGlvbkNhY2hlRGlyZWMKIAogdm9pZCBXZWJDb250ZXh0Ojpw bGF0Zm9ybUluaXRpYWxpemVXZWJQcm9jZXNzKFdlYlByb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMm IHBhcmFtZXRlcnMpCiB7Ci0gICAgLy8gV2Ugd2FudCB0byB1c2UgYSBQREYgdmlldyBpbiB0aGUg VUkgcHJvY2VzcyBmb3IgUERGIE1JTUUgdHlwZXMuCi0gICAgSGFzaFNldDxTdHJpbmcsIENhc2VG b2xkaW5nSGFzaD4gbWltZVR5cGUgPSBwZGZBbmRQb3N0U2NyaXB0TUlNRVR5cGVzKCk7Ci0gICAg cGFyYW1ldGVycy5taW1lVHlwZXNXaXRoQ3VzdG9tUmVwcmVzZW50YXRpb24uYXBwZW5kUmFuZ2Uo bWltZVR5cGUuYmVnaW4oKSwgbWltZVR5cGUuZW5kKCkpOworICAgIGlmICghb21pdFBERlN1cHBv cnQoKSkgeworICAgICAgICAvLyBXZSB3YW50IHRvIHVzZSBhIFBERiB2aWV3IGluIHRoZSBVSSBw cm9jZXNzIGZvciBQREYgTUlNRSB0eXBlcy4KKyAgICAgICAgSGFzaFNldDxTdHJpbmcsIENhc2VG b2xkaW5nSGFzaD4gbWltZVR5cGUgPSBwZGZBbmRQb3N0U2NyaXB0TUlNRVR5cGVzKCk7CisgICAg ICAgIHBhcmFtZXRlcnMubWltZVR5cGVzV2l0aEN1c3RvbVJlcHJlc2VudGF0aW9uLmFwcGVuZFJh bmdlKG1pbWVUeXBlLmJlZ2luKCksIG1pbWVUeXBlLmVuZCgpKTsKKyAgICB9CiAKICAgICBSZXRh aW5QdHI8Q0ZTdHJpbmdSZWY+IGNhY2hlUGF0aChBZG9wdENGLCBXS0NvcHlGb3VuZGF0aW9uQ2Fj aGVEaXJlY3RvcnkoKSk7CiAgICAgaWYgKCFjYWNoZVBhdGgpCg==