71154 2011-10-28 15:53:18 -0700 webkit.py gdb visualizer is broken after change to StringImpl 2011-10-28 17:04:05 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rafaelw rafaelw darin ggaren msaboff tony webkit.review.bot oldest_to_newest 492738 0 rafaelw 2011-10-28 15:53:18 -0700 StringImpl's m_data is now m_data16. Change webkit.py to match. 492741 1 112929 rafaelw 2011-10-28 15:56:56 -0700 Created attachment 112929 Patch 492744 2 rafaelw 2011-10-28 15:58:07 -0700 BTW, I've never touched this file before and know almost no python. I'm just guessing that both WTFString & JSCUString need to be changed. Please verify that this is right. 492800 3 112929 webkit.review.bot 2011-10-28 17:04:01 -0700 Comment on attachment 112929 Patch Clearing flags on attachment: 112929 Committed r98785: <http://trac.webkit.org/changeset/98785> 492801 4 webkit.review.bot 2011-10-28 17:04:05 -0700 All reviewed patches have been landed. Closing bug. 112929 2011-10-28 15:56:56 -0700 2011-10-28 17:04:00 -0700 Patch bug-71154-20111028155655.patch text/plain 1571 rafaelw U3VidmVyc2lvbiBSZXZpc2lvbjogOTg3NzEKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4MWM0YTAyY2VjMjA4OTQ4MzNiYzk2MGIzOWNjZGMyOTRh NDFmYmM1Li5hOWZhMmFlYWQ1OTA5ZDQzZmZiMzRmOTc4ZWYzM2Q3ZTdkNGUyYTM4IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMTAtMjggIFJhZmFlbCBXZWluc3RlaW4gIDxyYWZhZWx3QGNocm9taXVtLm9yZz4K KworICAgICAgICB3ZWJraXQucHkgZ2RiIHZpc3VhbGl6ZXIgaXMgYnJva2VuIGFmdGVyIGNoYW5n ZSB0byBTdHJpbmdJbXBsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD03MTE1NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIHI5ODYyNCBjaGFuZ2VkIFN0cmluZ0ltcGwgbV9kYXRhIHRvIG1fZGF0YTMyLiBUaGlz IGNoYW5nZXMgdXBkYXRlcworICAgICAgICB3ZWJraXQucHkgdG8gbWF0Y2guCisKKyAgICAgICAg KiBnZGIvd2Via2l0LnB5OgorCiAyMDExLTEwLTI4ICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0 Lm9yZz4KIAogICAgICAgICBOUldUIGNyYXNoZXMgd2hlbiBwYXJzaW5nIGxlYWtzIG91dHB1dCBk dWUgdG8gVVRGLTggZGVjb2RpbmcgZXJyb3IKZGlmZiAtLWdpdCBhL1Rvb2xzL2dkYi93ZWJraXQu cHkgYi9Ub29scy9nZGIvd2Via2l0LnB5CmluZGV4IDZlZGRkNDM4N2YwNjNlNWQ2MWM5M2E0Njkz YWM2YTNjN2U4NzIzMjcuLjgzYTNlOGFmNGIzYzhjMGM2NGZhYzAyOGU0YzNiN2U3MzllY2Y2ODEg MTAwNjQ0Ci0tLSBhL1Rvb2xzL2dkYi93ZWJraXQucHkKKysrIGIvVG9vbHMvZ2RiL3dlYmtpdC5w eQpAQCAtMTExLDcgKzExMSw3IEBAIGNsYXNzIFdURlN0cmluZ1ByaW50ZXIoU3RyaW5nUHJpbnRl cik6CiAgICAgICAgIGlmIHNlbGYuZ2V0X2xlbmd0aCgpID09IDA6CiAgICAgICAgICAgICByZXR1 cm4gJyhudWxsKScKIAotICAgICAgICByZXR1cm4gdXN0cmluZ190b19zdHJpbmcoc2VsZi52YWxb J21faW1wbCddWydtX3B0ciddWydtX2RhdGEnXSwKKyAgICAgICAgcmV0dXJuIHVzdHJpbmdfdG9f c3RyaW5nKHNlbGYudmFsWydtX2ltcGwnXVsnbV9wdHInXVsnbV9kYXRhMTYnXSwKICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIHNlbGYuZ2V0X2xlbmd0aCgpKQogCiAKQEAgLTEyNiw3 ICsxMjYsNyBAQCBjbGFzcyBKU0NVU3RyaW5nUHJpbnRlcihTdHJpbmdQcmludGVyKToKICAgICAg ICAgaWYgc2VsZi5nZXRfbGVuZ3RoKCkgPT0gMDoKICAgICAgICAgICAgIHJldHVybiAnJwogCi0g ICAgICAgIHJldHVybiB1c3RyaW5nX3RvX3N0cmluZyhzZWxmLnZhbFsnbV9pbXBsJ11bJ21fcHRy J11bJ21fZGF0YSddLAorICAgICAgICByZXR1cm4gdXN0cmluZ190b19zdHJpbmcoc2VsZi52YWxb J21faW1wbCddWydtX3B0ciddWydtX2RhdGExNiddLAogICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgc2VsZi5nZXRfbGVuZ3RoKCkpCiAKIAo=