<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>71133</bug_id>
          
          <creation_ts>2011-10-28 12:24:53 -0700</creation_ts>
          <short_desc>Clean up BuiltInPDFView a little</short_desc>
          <delta_ts>2011-10-28 13:28:04 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>PDF</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Trivial</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Alexey Proskuryakov">ap</reporter>
          <assigned_to name="Alexey Proskuryakov">ap</assigned_to>
          <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>492593</commentid>
    <comment_count>0</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2011-10-28 12:24:53 -0700</bug_when>
    <thetext>Just some trivial changes.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>492595</commentid>
    <comment_count>1</comment_count>
      <attachid>112893</attachid>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2011-10-28 12:27:13 -0700</bug_when>
    <thetext>Created attachment 112893
proposed patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>492632</commentid>
    <comment_count>2</comment_count>
      <attachid>112893</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-10-28 13:28:00 -0700</bug_when>
    <thetext>Comment on attachment 112893
proposed patch

Clearing flags on attachment: 112893

Committed r98756: &lt;http://trac.webkit.org/changeset/98756&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>492633</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-10-28 13:28:04 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>112893</attachid>
            <date>2011-10-28 12:27:13 -0700</date>
            <delta_ts>2011-10-28 13:28:00 -0700</delta_ts>
            <desc>proposed patch</desc>
            <filename>cleanup.txt</filename>
            <type>text/plain</type>
            <size>3091</size>
            <attacher name="Alexey Proskuryakov">ap</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDk4NzQ5KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMTAtMjggIEFsZXhleSBQ
cm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgQ2xlYW4gdXAgQnVpbHRJblBE
RlZpZXcgYSBsaXR0bGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu
Y2dpP2lkPTcxMTMzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg
ICAgICAgKiBXZWJQcm9jZXNzL1BsdWdpbnMvUERGL0J1aWx0SW5QREZWaWV3LmNwcDogKFdlYktp
dDo6QnVpbHRJblBERlZpZXc6OmNyZWF0ZVNjcm9sbGJhcik6CisgICAgICAgIFJlbW92ZWQgYW4g
aW5jb3JyZWN0IEZJWE1FLiBDdXN0b20gc2Nyb2xsYmFycyBzcGVjaWZpZWQgaW4gYSBkb2N1bWVu
dCBkb24ndCBhcHBseQorICAgICAgICB0byBzdWJmcmFtZXMsIGFuZCB0aHVzIHNob3VsZG4ndCBh
cHBseSB0byBQREZzLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9CdWlsdElu
UERGVmlldy5oOiAoV2ViS2l0OjpCdWlsdEluUERGVmlldzo6em9vbUFuaW1hdG9yVHJhbnNmb3Jt
Q2hhbmdlZCk6CisgICAgICAgIE1vdmVkIHRvIGEgY29ycmVjdCBsb2NhdGlvbi4gVGhpcyBpcyBu
b3QgYSBQbHVnaW4gbWV0aG9kLCBidXQgYSBTY3JvbGxWaWV3IG9uZS4KKwogMjAxMS0xMC0yOCAg
Sm9jaGVuIEVpc2luZ2VyICA8am9jaGVuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZW5hbWUg
YSBudW1iZXIgb2YgbWV0aG9kcyBtZW50aW9uaW5nIEphdmFTY3JpcHQgdG8ganVzdCBTY3JpcHQg
aW5zdGVhZApJbmRleDogU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9CdWls
dEluUERGVmlldy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9Q
bHVnaW5zL1BERi9CdWlsdEluUERGVmlldy5jcHAJKHJldmlzaW9uIDk4NjA4KQorKysgU291cmNl
L1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9CdWlsdEluUERGVmlldy5jcHAJKHdvcmtp
bmcgY29weSkKQEAgLTE2MSw3ICsxNjEsNiBAQCB2b2lkIEJ1aWx0SW5QREZWaWV3Ojp3aWxsUmVt
b3ZlVmVydGljYWxTCiAKIFBhc3NSZWZQdHI8U2Nyb2xsYmFyPiBCdWlsdEluUERGVmlldzo6Y3Jl
YXRlU2Nyb2xsYmFyKFNjcm9sbGJhck9yaWVudGF0aW9uIG9yaWVudGF0aW9uKQogewotICAgIC8v
IEZJWE1FOiBTdXBwb3J0IGN1c3RvbSBzY3JvbGxiYXIgc3R5bGVzLgogICAgIFJlZlB0cjxTY3Jv
bGxiYXI+IHdpZGdldCA9IFNjcm9sbGJhcjo6Y3JlYXRlTmF0aXZlU2Nyb2xsYmFyKHRoaXMsIG9y
aWVudGF0aW9uLCBSZWd1bGFyU2Nyb2xsYmFyKTsKICAgICBpZiAob3JpZW50YXRpb24gPT0gSG9y
aXpvbnRhbFNjcm9sbGJhcikKICAgICAgICAgZGlkQWRkSG9yaXpvbnRhbFNjcm9sbGJhcih3aWRn
ZXQuZ2V0KCkpOwpJbmRleDogU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9C
dWlsdEluUERGVmlldy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv
UGx1Z2lucy9QREYvQnVpbHRJblBERlZpZXcuaAkocmV2aXNpb24gOTg2MDgpCisrKyBTb3VyY2Uv
V2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUERGL0J1aWx0SW5QREZWaWV3LmgJKHdvcmtpbmcg
Y29weSkKQEAgLTkwLDkgKzkwLDYgQEAgcHJpdmF0ZToKICAgICB2aXJ0dWFsIHZvaWQgbWFudWFs
U3RyZWFtRGlkUmVjZWl2ZURhdGEoY29uc3QgY2hhciogYnl0ZXMsIGludCBsZW5ndGgpOwogICAg
IHZpcnR1YWwgdm9pZCBtYW51YWxTdHJlYW1EaWRGaW5pc2hMb2FkaW5nKCk7CiAgICAgdmlydHVh
bCB2b2lkIG1hbnVhbFN0cmVhbURpZEZhaWwoYm9vbCB3YXNDYW5jZWxsZWQpOwotCi0gICAgdmly
dHVhbCB2b2lkIHpvb21BbmltYXRvclRyYW5zZm9ybUNoYW5nZWQoZmxvYXQsIGZsb2F0LCBmbG9h
dCwgWm9vbUFuaW1hdGlvblN0YXRlKSB7IH0KLQogICAgIHZpcnR1YWwgYm9vbCBoYW5kbGVNb3Vz
ZUV2ZW50KGNvbnN0IFdlYk1vdXNlRXZlbnQmKTsKICAgICB2aXJ0dWFsIGJvb2wgaGFuZGxlV2hl
ZWxFdmVudChjb25zdCBXZWJXaGVlbEV2ZW50Jik7CiAgICAgdmlydHVhbCBib29sIGhhbmRsZU1v
dXNlRW50ZXJFdmVudChjb25zdCBXZWJNb3VzZUV2ZW50Jik7CkBAIC0xMzksNiArMTM2LDcgQEAg
cHJpdmF0ZToKICAgICB2aXJ0dWFsIHZvaWQgZGlzY29ubmVjdEZyb21QYWdlKCkgeyBtX3BhZ2Ug
PSAwOyB9CiAgICAgdmlydHVhbCBib29sIHNob3VsZFN1c3BlbmRTY3JvbGxBbmltYXRpb25zKCkg
Y29uc3QgeyByZXR1cm4gZmFsc2U7IH0gLy8gSWYgd2UgcmV0dXJuIHRydWUsIFNjcm9sbEFuaW1h
dG9yTWFjIHdpbGwga2VlcCBjeWNsaW5nIGEgdGltZXIgZm9yZXZlciwgd2FpdGluZyBmb3IgYSBn
b29kIHRpbWUgdG8gYW5pbWF0ZS4KICAgICB2aXJ0dWFsIHZvaWQgc2Nyb2xsYmFyU3R5bGVDaGFu
Z2VkKCk7CisgICAgdmlydHVhbCB2b2lkIHpvb21BbmltYXRvclRyYW5zZm9ybUNoYW5nZWQoZmxv
YXQsIGZsb2F0LCBmbG9hdCwgWm9vbUFuaW1hdGlvblN0YXRlKSB7IH0KIAogICAgIC8vIEZJWE1F
OiBJbXBsZW1lbnQgdGhlIG90aGVyIGNvbnZlcnNpb24gZnVuY3Rpb25zOyB0aGlzIG9uZSBpcyBl
bm91Z2ggdG8gZ2V0IHNjcm9sbGJhciBoaXQgdGVzdGluZyB3b3JraW5nLgogICAgIHZpcnR1YWwg
V2ViQ29yZTo6SW50UG9pbnQgY29udmVydEZyb21Db250YWluaW5nVmlld1RvU2Nyb2xsYmFyKGNv
bnN0IFdlYkNvcmU6OlNjcm9sbGJhciosIGNvbnN0IFdlYkNvcmU6OkludFBvaW50JiBwYXJlbnRQ
b2ludCkgY29uc3Q7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>