71119 2011-10-28 07:46:12 -0700 Web Inspector: Using keyboard to increment/decrement units is inconsistent 2011-10-31 01:37:54 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 apavlov apavlov apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 492446 0 apavlov 2011-10-28 07:46:12 -0700 What steps will reproduce the problem? 1. Open Web Inspector in the Elements tab 2. Enter an CSS property with a float value (1em) 3. Double click on that value and use the arrow keys (up/down) to change it. What is the expected result? Starting at a value of 0, arrows should change the value by 1 unit (em, px, %, etc). Using the arrows while pressing ALT (or Option) should change the value by 1 unit. Using the arrows while pressing Shift should change the value by 10 units What happens instead? Starting at a value of 0, arrows change the value by .1 unit between "0" and "1" and then suddenly the action is modified and values increase by 1 unit after "1" is reached. The ALT (or Option) key allows to toggle into a .1 unit modification mode from "1" to infinity. It doesn't between "0" and "1" where the roles are reversed with the normal behavior. The following screenshot illustrates a good test case. http://link.olivierlacan.com/BLyz As a sidenote (which will require a separate issue), note that pixel values are incorrectly incremented as decimal numbers because of this unexpected behavior. Please provide any additional information below. Attach a screenshot if possible. UserAgentString: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_2) AppleWebKit/535.2 (KHTML, like Gecko) Chrome/15.0.874.106 Safari/535.2 Upstreaming http://code.google.com/p/chromium/issues/detail?id=101947 492460 1 112866 apavlov 2011-10-28 08:09:10 -0700 Created attachment 112866 [PATCH] Suggested fix 493206 2 apavlov 2011-10-31 01:37:54 -0700 Committed r98839: <http://trac.webkit.org/changeset/98839> 112866 2011-10-28 08:09:10 -0700 2011-10-31 01:27:20 -0700 [PATCH] Suggested fix incdecval.patch text/plain 6673 apavlov Y29tbWl0IDU3Y2E5OWM1MDJlNzc0MWFlYWNmNTJjMWQ1YTgwZTBmOGVlN2RlMmEKQXV0aG9yOiBB bGV4YW5kZXIgUGF2bG92IDxhcGF2bG92QGNocm9taXVtLm9yZz4KRGF0ZTogICBGcmkgT2N0IDI4 IDE4OjU4OjU2IDIwMTEgKzA0MDAKCiAgICBGaXgKCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNDJhNmE2Yi4uNTYzNzA3NSAx MDA3NTUKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDExLTEwLTI4ICBBbGV4YW5kZXIgUGF2bG92ICA8YXBh dmxvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVXNpbmcga2V5Ym9h cmQgdG8gaW5jcmVtZW50L2RlY3JlbWVudCB1bml0cyBpcyBpbmNvbnNpc3RlbnQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcxMTE5CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3Ivc3R5bGVz L3VwLWRvd24tbnVtZXJpY3MtYW5kLWNvbG9ycy1leHBlY3RlZC50eHQ6CisgICAgICAgICogaW5z cGVjdG9yL3N0eWxlcy91cC1kb3duLW51bWVyaWNzLWFuZC1jb2xvcnMuaHRtbDoKKwogMjAxMS0x MC0xOSAgQWxleGFuZGVyIFBhdmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFdlYiBJbnNwZWN0b3I6IENTUyBiYWNrZ3JvdW5kLWltYWdlIGFwcGxpZWQgaW5saW5lIHNob3dz IGEgd2FybmluZywgYnV0IHN0aWxsIHdvcmtzLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW5z cGVjdG9yL3N0eWxlcy91cC1kb3duLW51bWVyaWNzLWFuZC1jb2xvcnMtZXhwZWN0ZWQudHh0IGIv TGF5b3V0VGVzdHMvaW5zcGVjdG9yL3N0eWxlcy91cC1kb3duLW51bWVyaWNzLWFuZC1jb2xvcnMt ZXhwZWN0ZWQudHh0CmluZGV4IGMzN2E4MDYuLmUxMTljZjYgMTAwNzU1Ci0tLSBhL0xheW91dFRl c3RzL2luc3BlY3Rvci9zdHlsZXMvdXAtZG93bi1udW1lcmljcy1hbmQtY29sb3JzLWV4cGVjdGVk LnR4dAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3Ivc3R5bGVzL3VwLWRvd24tbnVtZXJpY3Mt YW5kLWNvbG9ycy1leHBlY3RlZC50eHQKQEAgLTksNyArOSw3IEBAIFJ1bm5pbmc6IHRlc3RBbHRl ckNvbG9yCiBjb2xvcjogI0VFMzsKIAogUnVubmluZzogdGVzdEFsdGVyTnVtYmVyCi1vcGFjaXR5 OiAxMC42Oworb3BhY2l0eTogMTEuNjsKIAogUnVubmluZzogdGVzdEFsdGVyQmlnTnVtYmVyCiAt d2Via2l0LXRyYW5zZm9ybTogcm90YXRlKDEwMDAwMDAwMDAwMDAwMDAwNjU1MzdkZWcpOwpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3N0eWxlcy91cC1kb3duLW51bWVyaWNzLWFu ZC1jb2xvcnMuaHRtbCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9zdHlsZXMvdXAtZG93bi1udW1l cmljcy1hbmQtY29sb3JzLmh0bWwKaW5kZXggMTVhOWE3Ni4uOGZhOGZlOCAxMDA3NTUKLS0tIGEv TGF5b3V0VGVzdHMvaW5zcGVjdG9yL3N0eWxlcy91cC1kb3duLW51bWVyaWNzLWFuZC1jb2xvcnMu aHRtbAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3Ivc3R5bGVzL3VwLWRvd24tbnVtZXJpY3Mt YW5kLWNvbG9ycy5odG1sCkBAIC00OCw4ICs0OCwxMyBAQCBmdW5jdGlvbiB0ZXN0KCkKICAgICAg ICAgewogICAgICAgICAgICAgdmFyIG9wYWNpdHlUcmVlRWxlbWVudCA9IHNlY3Rpb24uZmluZFRy ZWVFbGVtZW50V2l0aE5hbWUoIm9wYWNpdHkiKTsKICAgICAgICAgICAgIG9wYWNpdHlUcmVlRWxl bWVudC5zdGFydEVkaXRpbmcob3BhY2l0eVRyZWVFbGVtZW50LnZhbHVlRWxlbWVudCk7CisgICAg ICAgICAgICAvLyAwLjUgKGluaXRpYWwpCisgICAgICAgICAgICBvcGFjaXR5VHJlZUVsZW1lbnQu dmFsdWVFbGVtZW50LmRpc3BhdGNoRXZlbnQoSW5zcGVjdG9yVGVzdC5jcmVhdGVLZXlFdmVudCgi VXAiLCBmYWxzZSwgdHJ1ZSwgZmFsc2UpKTsgLy8gQWx0LVVwCisgICAgICAgICAgICAvLyAwLjYK ICAgICAgICAgICAgIG9wYWNpdHlUcmVlRWxlbWVudC52YWx1ZUVsZW1lbnQuZGlzcGF0Y2hFdmVu dChJbnNwZWN0b3JUZXN0LmNyZWF0ZUtleUV2ZW50KCJVcCIpKTsKKyAgICAgICAgICAgIC8vIDEu NgogICAgICAgICAgICAgb3BhY2l0eVRyZWVFbGVtZW50LnZhbHVlRWxlbWVudC5kaXNwYXRjaEV2 ZW50KEluc3BlY3RvclRlc3QuY3JlYXRlS2V5RXZlbnQoIlBhZ2VVcCIpKTsKKyAgICAgICAgICAg IC8vIDExLjYKICAgICAgICAgICAgIEluc3BlY3RvclRlc3QuYWRkUmVzdWx0KG9wYWNpdHlUcmVl RWxlbWVudC5saXN0SXRlbUVsZW1lbnQudGV4dENvbnRlbnQpOwogICAgICAgICAgICAgbmV4dCgp OwogICAgICAgICB9LApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGE3YmIzZDkuLmNhZTE2MDIgMTAwNzU1Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxNiBAQAorMjAxMS0xMC0yOCAgQWxleGFuZGVyIFBhdmxvdiAgPGFwYXZsb3ZA Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFVzaW5nIGtleWJvYXJkIHRv IGluY3JlbWVudC9kZWNyZW1lbnQgdW5pdHMgaXMgaW5jb25zaXN0ZW50CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MTExOQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgY2hhbmdlIG1ha2VzIHRoZSBi ZWhhdmlvciBjb25zaXN0ZW50IHdpdGggdGhhdCBkZXNjcmliZWQgYXQgaHR0cDovL3RyYWMud2Vi a2l0Lm9yZy93aWtpL1dlYkluc3BlY3RvcgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVu ZC9TdHlsZXNTaWRlYmFyUGFuZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5TdHlsZXNTaWRl YmFyUGFuZS5hbHRlcmVkRmxvYXROdW1iZXIpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlN0eWxl c1NpZGViYXJQYW5lLnByb3RvdHlwZS5fYXR0cmlidXRlc01vZGlmaWVkKToKKwogMjAxMS0xMC0x OSAgQWxleGFuZGVyIFBhdmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdl YiBJbnNwZWN0b3I6IENTUyBiYWNrZ3JvdW5kLWltYWdlIGFwcGxpZWQgaW5saW5lIHNob3dzIGEg d2FybmluZywgYnV0IHN0aWxsIHdvcmtzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9TdHlsZXNTaWRlYmFyUGFuZS5qcyBiL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvU3R5bGVzU2lkZWJhclBhbmUuanMKaW5kZXggZDlhZGViNC4uMzNj OGMwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TdHls ZXNTaWRlYmFyUGFuZS5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L1N0eWxlc1NpZGViYXJQYW5lLmpzCkBAIC0xMzMsMzkgKzEzMywyNSBAQCBXZWJJbnNwZWN0b3Iu U3R5bGVzU2lkZWJhclBhbmUuQ1NTTnVtYmVyUmVnZXggPSAvXigtPyg/OlxkKyg/OlwuXGQrKT98 XC5cZCspKSQvOwogV2ViSW5zcGVjdG9yLlN0eWxlc1NpZGViYXJQYW5lLmFsdGVyZWRGbG9hdE51 bWJlciA9IGZ1bmN0aW9uKG51bWJlciwgZXZlbnQpCiB7CiAgICAgdmFyIGFycm93S2V5UHJlc3Nl ZCA9IChldmVudC5rZXlJZGVudGlmaWVyID09PSAiVXAiIHx8IGV2ZW50LmtleUlkZW50aWZpZXIg PT09ICJEb3duIik7Ci0gICAgLy8gSWYgdGhlIG51bWJlciBpcyBuZWFyIHplcm8gb3IgdGhlIG51 bWJlciBpcyBvbmUgYW5kIHRoZSBkaXJlY3Rpb24gd2lsbCB0YWtlIGl0IG5lYXIgemVyby4KLSAg ICB2YXIgbnVtYmVyTmVhclplcm8gPSAobnVtYmVyIDwgMSAmJiBudW1iZXIgPiAtMSk7Ci0gICAg aWYgKG51bWJlciA9PT0gMSAmJiBldmVudC5rZXlJZGVudGlmaWVyID09PSAiRG93biIpCi0gICAg ICAgIG51bWJlck5lYXJaZXJvID0gdHJ1ZTsKLSAgICBlbHNlIGlmIChudW1iZXIgPT09IC0xICYm IGV2ZW50LmtleUlkZW50aWZpZXIgPT09ICJVcCIpCi0gICAgICAgIG51bWJlck5lYXJaZXJvID0g dHJ1ZTsKLQotICAgIHZhciByZXN1bHQ7Ci0gICAgaWYgKG51bWJlck5lYXJaZXJvICYmIGV2ZW50 LmFsdEtleSAmJiBhcnJvd0tleVByZXNzZWQpIHsKLSAgICAgICAgaWYgKGV2ZW50LmtleUlkZW50 aWZpZXIgPT09ICJEb3duIikKLSAgICAgICAgICAgIHJlc3VsdCA9IE1hdGguY2VpbChudW1iZXIg LSAxKTsKLSAgICAgICAgZWxzZQotICAgICAgICAgICAgcmVzdWx0ID0gTWF0aC5mbG9vcihudW1i ZXIgKyAxKTsKLSAgICB9IGVsc2UgewotICAgICAgICAvLyBKdW1wIGJ5IDEwIHdoZW4gc2hpZnQg aXMgZG93biBvciBqdW1wIGJ5IDAuMSB3aGVuIG5lYXIgemVybyBvciBBbHQvT3B0aW9uIGlzIGRv d24uCi0gICAgICAgIC8vIEFsc28ganVtcCBieSAxMCBmb3IgcGFnZSB1cCBhbmQgZG93biwgb3Ig YnkgMTAwIGlmIHNoaWZ0IGlzIGhlbGQgd2l0aCBhIHBhZ2Uga2V5LgotICAgICAgICB2YXIgY2hh bmdlQW1vdW50ID0gMTsKLSAgICAgICAgaWYgKGV2ZW50LnNoaWZ0S2V5ICYmICFhcnJvd0tleVBy ZXNzZWQpCi0gICAgICAgICAgICBjaGFuZ2VBbW91bnQgPSAxMDA7Ci0gICAgICAgIGVsc2UgaWYg KGV2ZW50LnNoaWZ0S2V5IHx8ICFhcnJvd0tleVByZXNzZWQpCi0gICAgICAgICAgICBjaGFuZ2VB bW91bnQgPSAxMDsKLSAgICAgICAgZWxzZSBpZiAoZXZlbnQuYWx0S2V5IHx8IG51bWJlck5lYXJa ZXJvKQotICAgICAgICAgICAgY2hhbmdlQW1vdW50ID0gMC4xOwotCi0gICAgICAgIGlmIChldmVu dC5rZXlJZGVudGlmaWVyID09PSAiRG93biIgfHwgZXZlbnQua2V5SWRlbnRpZmllciA9PT0gIlBh Z2VEb3duIikKLSAgICAgICAgICAgIGNoYW5nZUFtb3VudCAqPSAtMTsKLQotICAgICAgICAvLyBN YWtlIHRoZSBuZXcgbnVtYmVyIGFuZCBjb25zdHJhaW4gaXQgdG8gYSBwcmVjaXNpb24gb2YgNiwg dGhpcyBtYXRjaGVzIG51bWJlcnMgdGhlIGVuZ2luZSByZXR1cm5zLgotICAgICAgICAvLyBVc2Ug dGhlIE51bWJlciBjb25zdHJ1Y3RvciB0byBmb3JnZXQgdGhlIGZpeGVkIHByZWNpc2lvbiwgc28g MS4xMDAwMDAgd2lsbCBwcmludCBhcyAxLjEuCi0gICAgICAgIHJlc3VsdCA9IE51bWJlcigobnVt YmVyICsgY2hhbmdlQW1vdW50KS50b0ZpeGVkKDYpKTsKLSAgICAgICAgaWYgKCFTdHJpbmcocmVz dWx0KS5tYXRjaChXZWJJbnNwZWN0b3IuU3R5bGVzU2lkZWJhclBhbmUuQ1NTTnVtYmVyUmVnZXgp KQotICAgICAgICAgICAgcmV0dXJuIG51bGw7Ci0gICAgfQorCisgICAgLy8gSnVtcCBieSAxMCB3 aGVuIHNoaWZ0IGlzIGRvd24gb3IganVtcCBieSAwLjEgd2hlbiBBbHQvT3B0aW9uIGlzIGRvd24u CisgICAgLy8gQWxzbyBqdW1wIGJ5IDEwIGZvciBwYWdlIHVwIGFuZCBkb3duLCBvciBieSAxMDAg aWYgc2hpZnQgaXMgaGVsZCB3aXRoIGEgcGFnZSBrZXkuCisgICAgdmFyIGNoYW5nZUFtb3VudCA9 IDE7CisgICAgaWYgKGV2ZW50LnNoaWZ0S2V5ICYmICFhcnJvd0tleVByZXNzZWQpCisgICAgICAg IGNoYW5nZUFtb3VudCA9IDEwMDsKKyAgICBlbHNlIGlmIChldmVudC5zaGlmdEtleSB8fCAhYXJy b3dLZXlQcmVzc2VkKQorICAgICAgICBjaGFuZ2VBbW91bnQgPSAxMDsKKyAgICBlbHNlIGlmIChl dmVudC5hbHRLZXkpCisgICAgICAgIGNoYW5nZUFtb3VudCA9IDAuMTsKKworICAgIGlmIChldmVu dC5rZXlJZGVudGlmaWVyID09PSAiRG93biIgfHwgZXZlbnQua2V5SWRlbnRpZmllciA9PT0gIlBh Z2VEb3duIikKKyAgICAgICAgY2hhbmdlQW1vdW50ICo9IC0xOworCisgICAgLy8gTWFrZSB0aGUg bmV3IG51bWJlciBhbmQgY29uc3RyYWluIGl0IHRvIGEgcHJlY2lzaW9uIG9mIDYsIHRoaXMgbWF0 Y2hlcyBudW1iZXJzIHRoZSBlbmdpbmUgcmV0dXJucy4KKyAgICAvLyBVc2UgdGhlIE51bWJlciBj b25zdHJ1Y3RvciB0byBmb3JnZXQgdGhlIGZpeGVkIHByZWNpc2lvbiwgc28gMS4xMDAwMDAgd2ls bCBwcmludCBhcyAxLjEuCisgICAgdmFyIHJlc3VsdCA9IE51bWJlcigobnVtYmVyICsgY2hhbmdl QW1vdW50KS50b0ZpeGVkKDYpKTsKKyAgICBpZiAoIVN0cmluZyhyZXN1bHQpLm1hdGNoKFdlYklu c3BlY3Rvci5TdHlsZXNTaWRlYmFyUGFuZS5DU1NOdW1iZXJSZWdleCkpCisgICAgICAgIHJldHVy biBudWxsOwogCiAgICAgcmV0dXJuIHJlc3VsdDsKIH0KQEAgLTI4NCw3ICsyNzAsNyBAQCBXZWJJ bnNwZWN0b3IuU3R5bGVzU2lkZWJhclBhbmUucHJvdG90eXBlID0gewogICAgICAgICBpZiAodGhp cy5ub2RlICE9PSBldmVudC5kYXRhLm5vZGUpCiAgICAgICAgICAgICByZXR1cm47CiAKLSAgICAg ICAgLy8gQ2hhbmdpbmcgc3R5bGUgYXR0cmlidXRlIHdpbGwgYW55d2F5cyBnZW5lcmF0ZSBfc3R5 bGVJbnZhbGlkYXRlZCBtZXNzYWdlLiAKKyAgICAgICAgLy8gQ2hhbmdpbmcgc3R5bGUgYXR0cmli dXRlIHdpbGwgYW55d2F5cyBnZW5lcmF0ZSBfc3R5bGVJbnZhbGlkYXRlZCBtZXNzYWdlLgogICAg ICAgICBpZiAoZXZlbnQuZGF0YS5uYW1lID09PSAic3R5bGUiKQogICAgICAgICAgICAgcmV0dXJu OwogCg==