71117 2011-10-28 06:52:04 -0700 [Qt] REGRESSION: 5 editing tests fail 2011-11-02 11:09:56 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 ossy webkit-unassigned abecsi hausmann jturcotte kenneth laszlo.gombos menard ossy oldest_to_newest 492427 0 ossy 2011-10-28 06:52:04 -0700 After Qt5 updating on the WK2 bot, there are 5 new failing test: editing/deleting/merge-paragraph-from-p-with-style-2.html editing/deleting/merge-paragraph-from-p-with-style-3.html editing/deleting/merge-paragraph-into-h1-with-dir-2.html editing/deleting/merge-paragraph-into-h1-with-dir.html editing/deleting/merge-paragraph-from-h6-with-style-2.html Qt5 version before updating: https://lists.webkit.org/pipermail/webkit-qt/2011-October/002035.html Qt5 version after updating: https://lists.webkit.org/pipermail/webkit-qt/2011-October/002053.html It might be regression come from Qt5 update or might be a regression come from WebKit trunk between 98716-98723. I tested them with Qt5 and QtWebKit - WebKit1 and all of them passed. So it is a Qt5 and WK2 related bug. 492428 1 ossy 2011-10-28 06:52:59 -0700 (In reply to comment #0) > It might be regression come from Qt5 update or might be a regression come from WebKit > trunk between 98716-98723. I tested them with Qt5 and QtWebKit - WebKit1 and all of > them passed. So it is a Qt5 and WK2 related bug. These tests fail on 98716 too, so it is a Qt5 regression. 492430 2 ossy 2011-10-28 06:55:33 -0700 Here are the diffs: --- /ramdisk/qt-linux-32-release-webkit2/build/layout-test-results/editing/deleting/merge-paragraph-from-p-with-style-2-expected.txt +++ /ramdisk/qt-linux-32-release-webkit2/build/layout-test-results/editing/deleting/merge-paragraph-from-p-with-style-2-actual.txt @@ -1,12 +1,9 @@ -EDITING DELEGATE: shouldBeginEditingInDOMRange:range from 0 of DIV > BODY > HTML > #document to 5 of DIV > BODY > HTML > #document -EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification EDITING DELEGATE: shouldDeleteDOMRange:range from 5 of #text > H1 > DIV > BODY > HTML > #document to 0 of P > DIV > BODY > HTML > #document EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 2 of DIV > BODY > HTML > #document to 2 of DIV > BODY > HTML > #document toDOMRange:range from 5 of #text > H1 > DIV > BODY > HTML > #document to 5 of #text > H1 > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification -EDITING DELEGATE: webViewDidEndEditing:WebViewDidEndEditingNotification This tests deleting line break before p. WebKit should not keep the style of p added by a style rule, and "world" should be italic and not be in red. | " --- /ramdisk/qt-linux-32-release-webkit2/build/layout-test-results/editing/deleting/merge-paragraph-from-p-with-style-3-expected.txt +++ /ramdisk/qt-linux-32-release-webkit2/build/layout-test-results/editing/deleting/merge-paragraph-from-p-with-style-3-actual.txt @@ -1,12 +1,9 @@ -EDITING DELEGATE: shouldBeginEditingInDOMRange:range from 0 of DIV > BODY > HTML > #document to 5 of DIV > BODY > HTML > #document -EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification EDITING DELEGATE: shouldDeleteDOMRange:range from 5 of #text > H1 > DIV > BODY > HTML > #document to 0 of P > DIV > BODY > HTML > #document EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 2 of DIV > BODY > HTML > #document to 2 of DIV > BODY > HTML > #document toDOMRange:range from 5 of #text > H1 > DIV > BODY > HTML > #document to 5 of #text > H1 > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification -EDITING DELEGATE: webViewDidEndEditing:WebViewDidEndEditingNotification This tests deleting line break before p. WebKit preserves the inline style of the merged paragraph, and "world" should be in green. | " --- /ramdisk/qt-linux-32-release-webkit2/build/layout-test-results/editing/deleting/merge-paragraph-into-h1-with-dir-2-expected.txt +++ /ramdisk/qt-linux-32-release-webkit2/build/layout-test-results/editing/deleting/merge-paragraph-into-h1-with-dir-2-actual.txt @@ -1,12 +1,9 @@ -EDITING DELEGATE: shouldBeginEditingInDOMRange:range from 0 of DIV > BODY > HTML > #document to 5 of DIV > BODY > HTML > #document -EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification EDITING DELEGATE: shouldDeleteDOMRange:range from 5 of #text > H1 > DIV > BODY > HTML > #document to 0 of P > DIV > BODY > HTML > #document EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 2 of DIV > BODY > HTML > #document to 2 of DIV > BODY > HTML > #document toDOMRange:range from 5 of #text > H1 > DIV > BODY > HTML > #document to 5 of #text > H1 > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification -EDITING DELEGATE: webViewDidEndEditing:WebViewDidEndEditingNotification This tests deleting line break after h1 inside a block with dir attribute. WebKit should not add direction or unicode-bidi properties while merging paragraphs. | " --- /ramdisk/qt-linux-32-release-webkit2/build/layout-test-results/editing/deleting/merge-paragraph-into-h1-with-dir-expected.txt +++ /ramdisk/qt-linux-32-release-webkit2/build/layout-test-results/editing/deleting/merge-paragraph-into-h1-with-dir-actual.txt @@ -1,12 +1,9 @@ -EDITING DELEGATE: shouldBeginEditingInDOMRange:range from 0 of DIV > BODY > HTML > #document to 5 of DIV > BODY > HTML > #document -EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification EDITING DELEGATE: shouldDeleteDOMRange:range from 5 of #text > H1 > DIV > BODY > HTML > #document to 0 of P > DIV > BODY > HTML > #document EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 2 of DIV > BODY > HTML > #document to 2 of DIV > BODY > HTML > #document toDOMRange:range from 5 of #text > H1 > DIV > BODY > HTML > #document to 5 of #text > H1 > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification -EDITING DELEGATE: webViewDidEndEditing:WebViewDidEndEditingNotification This tests deleting line break after h1 inside a block with dir attribute. WebKit should not add direction or unicode-bidi properties while merging paragraphs. | " --- /ramdisk/qt-linux-32-release-webkit2/build/layout-test-results/editing/deleting/merge-paragraph-from-h6-with-style-2-expected.txt +++ /ramdisk/qt-linux-32-release-webkit2/build/layout-test-results/editing/deleting/merge-paragraph-from-h6-with-style-2-actual.txt @@ -1,12 +1,9 @@ -EDITING DELEGATE: shouldBeginEditingInDOMRange:range from 0 of DIV > BODY > HTML > #document to 5 of DIV > BODY > HTML > #document -EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification EDITING DELEGATE: shouldDeleteDOMRange:range from 1 of #text > DIV > BODY > HTML > #document to 0 of H6 > DIV > BODY > HTML > #document EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 5 of #text > EM > DIV > BODY > HTML > #document to 5 of #text > EM > DIV > BODY > HTML > #document toDOMRange:range from 5 of #text > EM > DIV > BODY > HTML > #document to 5 of #text > EM > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification -EDITING DELEGATE: webViewDidEndEditing:WebViewDidEndEditingNotification This tests deleting line break before h6. WebKit should not cancel styles added by h6 by those of document's default style but still keep "hello" italicized and "world" in red. | " 492442 3 hausmann 2011-10-28 07:36:43 -0700 I suspect that this is related to focus handling. It seems to me that didBeginEditing is called when the focus is transferred to an editable element. It could be that something changed with the focus handling in Qt not causing the view/widget to receive the focus the way it did before. 492445 4 ossy 2011-10-28 07:44:02 -0700 I skipped them to make bot happier : http://trac.webkit.org/changeset/98726 494699 5 113328 hausmann 2011-11-02 10:19:32 -0700 Created attachment 113328 [Qt] REGRESSION: 5 editing tests fail 494735 6 113328 kling 2011-11-02 10:58:53 -0700 Comment on attachment 113328 [Qt] REGRESSION: 5 editing tests fail r=me 494744 7 113328 hausmann 2011-11-02 11:09:49 -0700 Comment on attachment 113328 [Qt] REGRESSION: 5 editing tests fail Clearing flags on attachment: 113328 Committed r99081: <http://trac.webkit.org/changeset/99081> 494746 8 hausmann 2011-11-02 11:09:56 -0700 All reviewed patches have been landed. Closing bug. 113328 2011-11-02 10:19:32 -0700 2011-11-02 11:09:49 -0700 [Qt] REGRESSION: 5 editing tests fail bug-71117-20111102181931.patch text/plain 3669 hausmann U3VidmVyc2lvbiBSZXZpc2lvbjogOTkwNTQKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4NjBiZmFmOTM5YTM5OGU1MjQ2NmRhYmEzMGM3NzIwNWQy NmQwZTc0Li5jODNkZWU0NjVlZGRiZGIyYTMxZjI0NmZiNmE3NjEwYmM1NWY2ZGNlIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjMg QEAKIDIwMTEtMTEtMDIgIFNpbW9uIEhhdXNtYW5uICA8c2ltb24uaGF1c21hbm5Abm9raWEuY29t PgogCisgICAgICAgIFtRdF0gUkVHUkVTU0lPTjogNSBlZGl0aW5nIHRlc3RzIGZhaWwKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcxMTE3CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZSBzdXJlIHRoYXQg dGhlIHZpZXcgaXMgcHJvcGVybHkgZm9jdXNlZCwgaW4gb3JkZXIgdG8gZ2V0IHRoZQorICAgICAg ICBkaWRCZWdpbkVkaXRpbmcgRFJUIGNhbGxzLgorCisgICAgICAgIFRoaXMgcmVxdWlyZXMgYWN0 aXZhdGluZyB0aGUgd2luZG93ICh0aGUgY2FsbCB3aWxsIHJlc3VsdCBpbiBhIEZvY3VzSW4KKyAg ICAgICAgZXZlbnQgdG8gdGhlIHdpbmRvdyBhcyB3ZWxsIGFzIHNldHRpbmcgUUd1aUFwcGxpY2F0 aW9uOjpmb2N1c1dpbmRvdygpKQorICAgICAgICBhcyB3ZWxsIGFzIGVuYWJsaW5nIHRoZSBmb2N1 cyBvbiB0aGUgdmlldyBpdGVtLiBUaGUgc2lnbmF0dXJlIG9mCisgICAgICAgIHNldEZvY3VzIGhh cyBjaGFuZ2VkIHRvIHRha2UgYSBib29sZWFuLgorCisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5l ci9xdC9QbGF0Zm9ybVdlYlZpZXdRdC5jcHA6CisgICAgICAgIChXVFI6OldyYXBwZXJXaW5kb3c6 OmhhbmRsZVN0YXR1c0NoYW5nZWQpOgorCisyMDExLTExLTAyICBTaW1vbiBIYXVzbWFubiAgPHNp bW9uLmhhdXNtYW5uQG5va2lhLmNvbT4KKwogICAgICAgICBbUXRdW1dLMl0gQWRkIHN1cHBvcnQg Zm9yIHRvdWNoIGV2ZW50IHRlc3RpbmcgdG8gV2ViS2l0VGVzdFJ1bm5lcgogICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzEzMTAKIApkaWZmIC0tZ2l0IGEv VG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9xdC9QbGF0Zm9ybVdlYlZpZXdRdC5jcHAgYi9Ub29scy9X ZWJLaXRUZXN0UnVubmVyL3F0L1BsYXRmb3JtV2ViVmlld1F0LmNwcAppbmRleCA1MTUzYjUzZWRk OTE5YTkyOTk3NWJjNTAzODI1NmFjN2VkZmNmNzFhLi4yMmUzYWE2NDFiZTIxYjMxYTJiMjZmYzA4 NzcyN2M5ZmZhMDIwZWFkIDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL3F0L1Bs YXRmb3JtV2ViVmlld1F0LmNwcAorKysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL3F0L1BsYXRm b3JtV2ViVmlld1F0LmNwcApAQCAtMzIsNiArMzIsNyBAQAogI2luY2x1ZGUgPFFBcHBsaWNhdGlv bj4KICNpbmNsdWRlIDxRRGVjbGFyYXRpdmVQcm9wZXJ0eT4KICNpbmNsdWRlIDxRUXVpY2tWaWV3 PgorI2luY2x1ZGUgPHF3aW5kb3dzeXN0ZW1pbnRlcmZhY2VfcXBhLmg+CiAKIG5hbWVzcGFjZSBX VFIgewogCkBAIC01Nyw5ICs1OCw4IEBAIHByaXZhdGUgc2xvdHM6CiAgICAgICAgIG1fdmlldy0+ c2V0UGFyZW50SXRlbShyb290T2JqZWN0KCkpOwogICAgICAgICBRRGVjbGFyYXRpdmVQcm9wZXJ0 eTo6d3JpdGUobV92aWV3LCAiYW5jaG9ycy5maWxsIiwgcVZhcmlhbnRGcm9tVmFsdWUocm9vdE9i amVjdCgpKSk7CiAKLSAgICAgICAgUUZvY3VzRXZlbnQgZXYoUUV2ZW50OjpXaW5kb3dBY3RpdmF0 ZSk7Ci0gICAgICAgIFFBcHBsaWNhdGlvbjo6c2VuZEV2ZW50KG1fdmlldywgJmV2KTsKLSAgICAg ICAgbV92aWV3LT5zZXRGb2N1cyhRdDo6T3RoZXJGb2N1c1JlYXNvbik7CisgICAgICAgIFFXaW5k b3dTeXN0ZW1JbnRlcmZhY2U6OmhhbmRsZVdpbmRvd0FjdGl2YXRlZCh0aGlzKTsKKyAgICAgICAg bV92aWV3LT5zZXRGb2N1cyh0cnVlKTsKICAgICB9CiAKIHByaXZhdGU6CmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZWQwOTYw M2I5MjBiNzUwOTIwY2RhZGY2ZjE1NTVmMWU2NmE4MTAzMy4uZDE4ZTU1MDBiNjRjMGU3YjNmZjcw OTY3NGQxMmJlMWRhODhmYmY5NiAxMDA3NTUKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisr KyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDExLTExLTAyICBT aW1vbiBIYXVzbWFubiAgPHNpbW9uLmhhdXNtYW5uQG5va2lhLmNvbT4KKworICAgICAgICBbUXRd IFJFR1JFU1NJT046IDUgZWRpdGluZyB0ZXN0cyBmYWlsCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MTExNworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vcXQtNS4wL1NraXBwZWQ6IFVuc2tp cCB0ZXN0cyB0aGF0IG5vdyBwYXNzLgorCiAyMDExLTExLTAyICBBbmRyZXkgS29zeWFrb3YgIDxj YXNlcUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gQW5vdGhlciByZWJhc2Vs aW5lIG9mIG1lZGlhL21lZGlhLWRvY3VtZW50LWF1ZGlvLXJlcGFpbnQuaHRtbApkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQtNS4wL1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9xdC01LjAvU2tpcHBlZAppbmRleCAyZmZkYjY0MmY4YWVlMDViMmVmOWYwODBlODE2OGY2 ZWIxMGE3ZTRjLi5kY2UyYWFhY2Y2ZjU1YjE2MzQ0NDY0NDBhMWJiODBkNWMxZWFiZjc5IDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC01LjAvU2tpcHBlZAorKysgYi9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9xdC01LjAvU2tpcHBlZApAQCAtNjk1NywxNCArNjk1Nyw2IEBAIGZhc3Qv c3BhdGlhbC1uYXZpZ2F0aW9uL3NuYXYtaWZyYW1lLW5vLXNjcm9sbGFibGUtY29udGVudC5odG1s CiBmYXN0L3NwYXRpYWwtbmF2aWdhdGlvbi9zbmF2LW1lZGlhLWVsZW1lbnRzLmh0bWwKIGZhc3Qv c3BhdGlhbC1uYXZpZ2F0aW9uL3NuYXYtb2Zmc2NyZWVuLWNvbnRlbnQuaHRtbAogCi0jIFtRdF1S RUdSRVNTSU9OOiA1IGVkaXRpbmcgdGVzdHMgZmFpbAotIyBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NzExMTcKLWVkaXRpbmcvZGVsZXRpbmcvbWVyZ2UtcGFyYWdyYXBo LWZyb20tcC13aXRoLXN0eWxlLTIuaHRtbAotZWRpdGluZy9kZWxldGluZy9tZXJnZS1wYXJhZ3Jh cGgtZnJvbS1wLXdpdGgtc3R5bGUtMy5odG1sCi1lZGl0aW5nL2RlbGV0aW5nL21lcmdlLXBhcmFn cmFwaC1pbnRvLWgxLXdpdGgtZGlyLTIuaHRtbAotZWRpdGluZy9kZWxldGluZy9tZXJnZS1wYXJh Z3JhcGgtaW50by1oMS13aXRoLWRpci5odG1sCi1lZGl0aW5nL2RlbGV0aW5nL21lcmdlLXBhcmFn cmFwaC1mcm9tLWg2LXdpdGgtc3R5bGUtMi5odG1sCi0KICMgW1F0XSBmYXN0L211bHRpY29sL2Zs aXBwZWQtYmxvY2tzLWhpdC10ZXN0Lmh0bWwgZmFpbHMgd2l0aCBRdDUKICMgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcxMTE4CiBmYXN0L211bHRpY29sL2ZsaXBwZWQt YmxvY2tzLWhpdC10ZXN0Lmh0bWwK