71112 2011-10-28 05:17:47 -0700 NRWT crashes when parsing leaks output due to UTF-8 decoding error 2011-10-28 13:46:45 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED http://build.webkit.org/builders/SnowLeopard%20Intel%20Leaks/builds/19800/steps/layout-test/logs/stdio MakingBotsRed P2 Normal --- 1 aroben eric eric oldest_to_newest 492388 0 aroben 2011-10-28 05:17:47 -0700 NRWT is crashing when parsing leaks files due to a UTF-8 decoding error: http://build.webkit.org/builders/SnowLeopard%20Intel%20Leaks/builds/19800/steps/layout-test/logs/stdio Traceback (most recent call last): File "/Volumes/Data/WebKit-BuildSlave/snowleopard-intel-leaks/build/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 436, in <module> sys.exit(main()) File "/Volumes/Data/WebKit-BuildSlave/snowleopard-intel-leaks/build/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 431, in main return run(port, options, args) File "/Volumes/Data/WebKit-BuildSlave/snowleopard-intel-leaks/build/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 107, in run num_unexpected_results = manager.run(result_summary) File "/Volumes/Data/WebKit-BuildSlave/snowleopard-intel-leaks/build/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 919, in run self._port.print_leaks_summary() File "/Volumes/Data/WebKit-BuildSlave/snowleopard-intel-leaks/build/Tools/Scripts/webkitpy/layout_tests/port/mac.py", line 143, in print_leaks_summary total_leaks = self._leak_detector.count_total_leaks(leaks_files) File "/Volumes/Data/WebKit-BuildSlave/snowleopard-intel-leaks/build/Tools/Scripts/webkitpy/layout_tests/port/leakdetector.py", line 123, in count_total_leaks leaks_output = self._filesystem.read_text_file(leak_file_path) File "/Volumes/Data/WebKit-BuildSlave/snowleopard-intel-leaks/build/Tools/Scripts/webkitpy/common/system/filesystem.py", line 218, in read_text_file return f.read() File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/codecs.py", line 666, in read return self.reader.read(size) File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/codecs.py", line 472, in read newchars, decodedbytes = self.decode(data, self.errors) UnicodeDecodeError: 'utf8' codec can't decode byte 0x90 in position 3419483: unexpected code byte 492391 1 aroben 2011-10-28 05:19:47 -0700 The files it was trying to parse can be found here: http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r98706%20(19800)/ 492604 2 eric 2011-10-28 12:32:36 -0700 Very trivial fix. Will post patch momentarily. 492636 3 eric 2011-10-28 13:32:42 -0700 http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r98706%20(19800)/DumpRenderTree-88620-leaks.txt is the file with the bad char. Leak: 0x1240d0090 size=32 zone: DefaultMallocZone_0x107420000 instance of 'NSCFNumber', type ObjC, implemented in Foundation 0x70fdd8c8 0x00007fff 0x00001686 0x00000001 ...p............ 0x00000000 0x40300000 0x00000000 0x00000000 ......0@........ Call stack: [thread 0x7fff7026fca0]: | start | main | dumpRenderTree(int, char const**) | runTestingServerLoop() | runTest(std::string const&) | -[NSRunLoop(NSRunLoop) runMode:beforeDate:] | CFRunLoopRunSpecific | __CFRunLoopRun | __CFRunLoopDoSources0 | MultiplexerSource::perform() | URLConnectionClient::processEvents() | URLConnectionClient::ClientConnectionEventQueue::processAllEventsAndConsumePayload(XConnectionEventInfo<XClientEvent, XClientEventParams>*, long) | URLConnectionClient::_clientDidReceiveData(__CFData const*, URLConnectionClient::ClientConnectionEventQueue*) | _NSURLConnectionDidReceiveData | -[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:] | WebCore::ResourceLoader::didReceiveData(WebCore::ResourceHandle*, char const*, int, int) | WebCore::MainResourceLoader::didReceiveData(char const*, int, long long, bool) | WebCore::ResourceLoader::didReceiveData(char const*, int, long long, bool) | WebCore::MainResourceLoader::addData(char const*, int, bool) | WebCore::DocumentLoader::receivedData(char const*, int) | WebCore::DocumentLoader::commitLoad(char const*, int) | WebFrameLoaderClient::committedLoad(WebCore::DocumentLoader*, char const*, int) | -[WebDataSource(WebInternal) _receivedData:] | -[WebHTMLRepresentation receivedData:withDataSource:] | -[WebFrame(WebInternal) _commitData:] | WebCore::DocumentLoader::commitData(char const*, unsigned long) | WebCore::DocumentWriter::addData(char const*, unsigned long) | WebCore::DecodedDataDocumentParser::appendBytes(WebCore::DocumentWriter*, char const*, unsigned long) | WebCore::HTMLDocumentParser::append(WebCore::SegmentedString const&) | WebCore::HTMLDocumentParser::pumpTokenizerIfPossible(WebCore::HTMLDocumentParser::SynchronousMode) | WebCore::HTMLDocumentParser::pumpTokenizer(WebCore::HTMLDocumentParser::SynchronousMode) | WebCore::HTMLDocumentParser::canTakeNextToken(WebCore::HTMLDocumentParser::SynchronousMode, WebCore::PumpSession&) | WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder() | WebCore::HTMLScriptRunner::execute(WTF::PassRefPtr<WebCore::Element>, WTF::TextPosition const&) | WebCore::HTMLScriptRunner::runScript(WebCore::Element*, WTF::TextPosition const&) | WebCore::ScriptElement::prepareScript(WTF::TextPosition const&, WebCore::ScriptElement::LegacyTypeSupport) | WebCore::ScriptElement::executeScript(WebCore::ScriptSourceCode const&) | WebCore::ScriptController::evaluate(WebCore::ScriptSourceCode const&) | WebCore::ScriptController::evaluateInWorld(WebCore::ScriptSourceCode const&, WebCore::DOMWrapperWorld*) | WebCore::JSMainThreadExecState::evaluate(JSC::ExecState*, JSC::ScopeChainNode*, JSC::SourceCode const&, JSC::JSValue, JSC::JSValue*) | JSC::evaluate(JSC::ExecState*, JSC::ScopeChainNode*, JSC::SourceCode const&, JSC::JSValue, JSC::JSValue*) | JSC::Interpreter::execute(JSC::ProgramExecutable*, JSC::ExecState*, JSC::ScopeChainNode*, JSC::JSObject*) | JSC::JITCode::execute(JSC::RegisterFile*, JSC::ExecState*, JSC::JSGlobalData*) | 0x262ebe8011f8 | WebCore::jsDOMSelectionPrototypeFunctionSetBaseAndExtent(JSC::ExecState*) | WebCore::DOMSelection::setBaseAndExtent(WebCore::Node*, int, WebCore::Node*, int, int&) | WebCore::FrameSelection::moveTo(WebCore::VisiblePosition const&, WebCore::VisiblePosition const&, WebCore::EUserTriggered) | WebCore::FrameSelection::setSelection(WebCore::VisibleSelection const&, unsigned int, WebCore::FrameSelection::CursorAlignOnScroll, WebCore::TextGranularity) | WebCore::FrameSelection::updateAppearance() | WebCore::RenderView::setSelection(WebCore::RenderObject*, int, WebCore::RenderObject*, int, WebCore::RenderView::SelectionRepaintMode) | WebCore::RenderSelectionInfo::RenderSelectionInfo(WebCore::RenderObject*, bool) | WebCore::RenderText::selectionRectForRepaint(WebCore::RenderBoxModelObject*, bool) | WebCore::InlineTextBox::localSelectionRect(int, int) | WebCore::Font::selectionRectForText(WebCore::TextRun const&, WebCore::FloatPoint const&, int, int, int) const | WebCore::Font::selectionRectForComplexText(WebCore::TextRun const&, WebCore::FloatPoint const&, int, int, int) const | WebCore::ComplexTextController::ComplexTextController(WebCore::Font const*, WebCore::TextRun const&, bool, WTF::HashSet<WebCore::SimpleFontData const*, WTF::PtrHash<WebCore::SimpleFontData const*>, WTF::HashTraits<WebCore::SimpleFontData const*> >*, bool) | WebCore::ComplexTextController::collectComplexTextRuns() | WebCore::ComplexTextController::collectComplexTextRunsForCharacters(unsigned short const*, unsigned int, unsigned int, WebCore::SimpleFontData const*) | WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText(unsigned short const*, unsigned int, unsigned int, WebCore::SimpleFontData const*) | CTTypesetterCreateWithAttributedStringAndOptions | TTypesetterAttrString::Initialize() | TGlyphEncoder::EncodeChars(CFRange, __CFDictionary const*) | TGlyphEncoder::RunUnicodeEncoder(CTRun*, CFRange, TGlyphList<TDeletedGlyphIndex>&, TFontCascade const&) | TGlyphEncoder::RunUnicodeEncoderRecursively(CTRun*, CFRange, TGlyphList<TDeletedGlyphIndex>&, TFontCascade const&) | TGlyphEncoder::AppendUnmappedCharRun(CTRun*, CFRange, TGlyphList<TDeletedGlyphIndex>&, TFontCascade const&) | TFontCascade::CreateFallback(__CTFont const*, __CFString const*, CFRange) const | TFontCascade::CreateCascadeFallback(long) | -[WebCascadeList objectAtIndex:] | TFont::CopyDescriptor() const | CFNumberCreate | _CFRuntimeCreateInstance | malloc_zone_malloc Leak: 0x1240d00f0 size=32 zone: DefaultMallocZone_0x107420000 string '' is the bad leak. that string is the char 0x90. :( 492644 4 112904 eric 2011-10-28 13:44:36 -0700 Created attachment 112904 Patch 492648 5 eric 2011-10-28 13:46:45 -0700 Committed r98758: <http://trac.webkit.org/changeset/98758> 112904 2011-10-28 13:44:36 -0700 2011-10-28 13:45:30 -0700 Patch bug-71112-20111028134435.patch text/plain 2986 eric U3VidmVyc2lvbiBSZXZpc2lvbjogOTg3NTMKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjZTJjOGRjY2E1NjE4N2UyYzY1OWUzZDRlM2M3NjQ1NDE1 Y2Y3MzMzLi5jOTczYmUzNTI4ZjhmYWVhY2MxMzg2ZDY3ODA1MmY3ZGE1Yzk0OWQ5IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMTAtMjggIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAg IE5SV1QgY3Jhc2hlcyB3aGVuIHBhcnNpbmcgbGVha3Mgb3V0cHV0IGR1ZSB0byBVVEYtOCBkZWNv ZGluZyBlcnJvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NzExMTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBVc2UgcmVhZF9iaW5hcnlfZmlsZSBpbnN0ZWFkIG9mIHJlYWRfdGV4dF9maWxlIGFuZCBhZGQg YSB0ZXN0CisgICAgICAgIGNhc2Ugd2l0aCBzb21lIG5vbi11dGY4IGRhdGEgdG8gbWFrZSBzdXJl IHdlIGRvbid0IGJyZWFrIHRoaXMgaW4gdGhlIGZ1dHVyZS4KKworICAgICAgICAqIFNjcmlwdHMv d2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvbGVha2RldGVjdG9yLnB5OgorICAgICAgICAqIFNj cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvbGVha2RldGVjdG9yX3VuaXR0ZXN0LnB5 OgorCiAyMDExLTEwLTI4ICBEYXZpZCBMZXZpbiAgPGxldmluQGNocm9taXVtLm9yZz4KIAogICAg ICAgICB3YXRjaGxpc3Qgc2hvdWxkIG5vdCBDQyB0aGUgYnVnIHJlcG9ydGVyCmRpZmYgLS1naXQg YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2xlYWtkZXRlY3Rvci5w eSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvbGVha2RldGVjdG9y LnB5CmluZGV4IDBiMWUxNTY3MDk4ZTgyZTlmOThlMThiNzExMzhhNTQwMDM4NzY3MDMuLmYzYjgw MDU5N2NhZDYyMWQ2MzBhNDc4NDgwODVmN2E2OTNhYzJlMTUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvbGVha2RldGVjdG9yLnB5CisrKyBiL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvbGVha2RldGVjdG9yLnB5CkBA IC0xMjAsNyArMTIwLDkgQEAgY2xhc3MgTGVha0RldGVjdG9yKG9iamVjdCk6CiAgICAgZGVmIGNv dW50X3RvdGFsX2xlYWtzKHNlbGYsIGxlYWtfZmlsZV9wYXRocyk6CiAgICAgICAgIHRvdGFsX2xl YWtzID0gMAogICAgICAgICBmb3IgbGVha19maWxlX3BhdGggaW4gbGVha19maWxlX3BhdGhzOgot ICAgICAgICAgICAgbGVha3Nfb3V0cHV0ID0gc2VsZi5fZmlsZXN5c3RlbS5yZWFkX3RleHRfZmls ZShsZWFrX2ZpbGVfcGF0aCkKKyAgICAgICAgICAgICMgTGVha3MgaGF2ZSBiZWVuIHNlZW4gdG8g aW5jbHVkZSBub24tdXRmOCBkYXRhLCBzbyB3ZSB1c2UgcmVhZF9iaW5hcnlfZmlsZS4KKyAgICAg ICAgICAgICMgU2VlIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MTEx Mi4KKyAgICAgICAgICAgIGxlYWtzX291dHB1dCA9IHNlbGYuX2ZpbGVzeXN0ZW0ucmVhZF9iaW5h cnlfZmlsZShsZWFrX2ZpbGVfcGF0aCkKICAgICAgICAgICAgIGNvdW50LCBfLCBfID0gc2VsZi5f cGFyc2VfbGVha3Nfb3V0cHV0KGxlYWtzX291dHB1dCkKICAgICAgICAgICAgIHRvdGFsX2xlYWtz ICs9IGNvdW50CiAgICAgICAgIHJldHVybiB0b3RhbF9sZWFrcwpkaWZmIC0tZ2l0IGEvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9sZWFrZGV0ZWN0b3JfdW5pdHRlc3Qu cHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2xlYWtkZXRlY3Rv cl91bml0dGVzdC5weQppbmRleCBhNjg3NGQxMGUwMjgyMmEwNDk1ZDFjYzAyOTQ2N2E5NDU1Y2Q2 M2Y2Li42OWM2OTM5ZGRjNDgxZmY0NTJkZTQwZDMyN2ZlMTkzNWZkMDEyZWEwIDEwMDY0NAotLS0g YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2xlYWtkZXRlY3Rvcl91 bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0 L2xlYWtkZXRlY3Rvcl91bml0dGVzdC5weQpAQCAtMTA5LDcgKzEwOSw4IEBAIHRvdGFsOiA1LDg4 OCBieXRlcyAoMCBieXRlcyBleGNsdWRlZCkuIiIiCiAgICAgZGVmIHRlc3RfY291bnRfdG90YWxf bGVha3Moc2VsZik6CiAgICAgICAgIGRldGVjdG9yID0gc2VsZi5fbWFrZV9kZXRlY3RvcigpCiAg ICAgICAgIGRldGVjdG9yLl9maWxlc3lzdGVtID0gTW9ja0ZpbGVTeXN0ZW0oewotICAgICAgICAg ICAgJy9tb2NrLXJlc3VsdHMvRHVtcFJlbmRlclRyZWUtMTIzNC1sZWFrcy50eHQnOiAnUHJvY2Vz cyAxMjM0OiAxMiBsZWFrcyBmb3IgNDAgdG90YWwgbGVha2VkIGJ5dGVzLlxuJywKKyAgICAgICAg ICAgICMgVGhlIFx4ZmYgaXMgc29tZSBub24tdXRmOCBjaGFyYWN0ZXJzIHRvIG1ha2Ugc3VyZSB3 ZSBkb24ndCBibG93IHVwIHRyeWluZyB0byBwYXJzZSB0aGUgZmlsZS4KKyAgICAgICAgICAgICcv bW9jay1yZXN1bHRzL0R1bXBSZW5kZXJUcmVlLTEyMzQtbGVha3MudHh0JzogJ1x4ZmZcblByb2Nl c3MgMTIzNDogMTIgbGVha3MgZm9yIDQwIHRvdGFsIGxlYWtlZCBieXRlcy5cblx4ZmZcbicsCiAg ICAgICAgICAgICAnL21vY2stcmVzdWx0cy9EdW1wUmVuZGVyVHJlZS0yMzQyMy1sZWFrcy50eHQn OiAnUHJvY2VzcyAxMjM1OiAxMjM0MSBsZWFrcyBmb3IgMjc5MzQgdG90YWwgbGVha2VkIGJ5dGVz LlxuJywKICAgICAgICAgICAgICcvbW9jay1yZXN1bHRzL0R1bXBSZW5kZXJUcmVlLTgyMy1sZWFr cy50eHQnOiAnUHJvY2VzcyAxMjM1NjogMjM0MTIgbGVha3MgZm9yIDE4IHRvdGFsIGxlYWtlZCBi eXRlcy5cbicsCiAgICAgICAgIH0pCg==