71106 2011-10-28 04:04:58 -0700 [Qt] Fix the Ctrl behavior for touch mocking in MiniBrowser. 2011-10-28 05:28:50 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jturcotte jturcotte webkit.review.bot oldest_to_newest 492365 0 jturcotte 2011-10-28 04:04:58 -0700 [Qt] Fix the Ctrl behavior for touch mocking in MiniBrowser. 492366 1 112843 jturcotte 2011-10-28 04:08:10 -0700 Created attachment 112843 Patch 492373 2 112843 hausmann 2011-10-28 04:20:35 -0700 Comment on attachment 112843 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112843&action=review > Tools/ChangeLog:15 > + It also removes the touch QEvent::Type logic since it's currently handled > + by QtGui by observing the modified touch points. Nice catch :) 492395 3 112843 webkit.review.bot 2011-10-28 05:28:47 -0700 Comment on attachment 112843 Patch Clearing flags on attachment: 112843 Committed r98719: <http://trac.webkit.org/changeset/98719> 492396 4 webkit.review.bot 2011-10-28 05:28:50 -0700 All reviewed patches have been landed. Closing bug. 112843 2011-10-28 04:08:10 -0700 2011-10-28 05:28:47 -0700 Patch bug-71106-20111028130808.patch text/plain 6281 jturcotte U3VidmVyc2lvbiBSZXZpc2lvbjogOTg1NDcKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjODkxMjlmNzNiYzY3NjBjMTViZWQwYzg2NWVlMDMwY2M1 YjZiZWNmLi45Y2RkM2M4OTA3YmI0YjkzOWJhOWFjYjI4ODkxOWYyMzNiNzEwMThlIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQg QEAKKzIwMTEtMTAtMjggIEpvY2VseW4gVHVyY290dGUgIDxqb2NlbHluLnR1cmNvdHRlQG5va2lh LmNvbT4KKworICAgICAgICBbUXRdIEZpeCB0aGUgQ3RybCBiZWhhdmlvciBmb3IgdG91Y2ggbW9j a2luZyBpbiBNaW5pQnJvd3Nlci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTcxMTA2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgSG9sZGluZyBDdHJsIGFsbG93cyBtdWx0aXBsZSB0b3VjaCBwb2ludHMgdG8g YmUgaGVsZCBvbiB0aGUgc2NyZWVuIHVzaW5nCisgICAgICAgIG1vdXNlIGJ1dHRvbnMuIEl0IHdv dWxkIHByZXZpb3VzbHkgb25seSBwcmV2ZW50IFRvdWNoUmVsZWFzZWQgdG8gYmUgc2VudAorICAg ICAgICBhbmQgd291bGQgcmVxdWlyZSBhbm90aGVyIE1vdXNlQnV0dG9uUmVsZWFzZSB0byBiZSBz ZW50IHdpdGhvdXQgaG9sZGluZyBDdHJsLgorCisgICAgICAgIFRoaXMgcGF0Y2ggbWFrZXMgc3Vy ZSB0aGF0IGFsbCBoZWxkIHRvdWNoIHBvaW50cyBhcmUgcmVsZWFzZWQgd2hlbiBDdHJsCisgICAg ICAgIGlzIHJlbGVhc2VkIGlmIE1vdXNlQnV0dG9uUmVsZWFzZSB3YXMgcmVjZWl2ZWQuCisgICAg ICAgIEl0IGFsc28gcmVtb3ZlcyB0aGUgdG91Y2ggUUV2ZW50OjpUeXBlIGxvZ2ljIHNpbmNlIGl0 J3MgY3VycmVudGx5IGhhbmRsZWQKKyAgICAgICAgYnkgUXRHdWkgYnkgb2JzZXJ2aW5nIHRoZSBt b2RpZmllZCB0b3VjaCBwb2ludHMuCisKKyAgICAgICAgKiBNaW5pQnJvd3Nlci9xdC9NaW5pQnJv d3NlckFwcGxpY2F0aW9uLmNwcDoKKyAgICAgICAgKE1pbmlCcm93c2VyQXBwbGljYXRpb246Om5v dGlmeSk6CisgICAgICAgIChNaW5pQnJvd3NlckFwcGxpY2F0aW9uOjpzZW5kVG91Y2hFdmVudCk6 CisgICAgICAgICogTWluaUJyb3dzZXIvcXQvTWluaUJyb3dzZXJBcHBsaWNhdGlvbi5oOgorCiAy MDExLTEwLTIxICBKb2NlbHluIFR1cmNvdHRlICA8am9jZWx5bi50dXJjb3R0ZUBub2tpYS5jb20+ CiAKICAgICAgICAgW1F0XSBJbXByb3ZlIGNvbW1hbmQgbGluZSBhcmd1bWVudHMgaGFuZGxpbmcg Zm9yIE1pbmlCcm93c2VyLgpkaWZmIC0tZ2l0IGEvVG9vbHMvTWluaUJyb3dzZXIvcXQvTWluaUJy b3dzZXJBcHBsaWNhdGlvbi5jcHAgYi9Ub29scy9NaW5pQnJvd3Nlci9xdC9NaW5pQnJvd3NlckFw cGxpY2F0aW9uLmNwcAppbmRleCAzNjczYmJhMDI0YWEyMDg5NDIzZmUxYmZiZWVlNWNkYzU3YjQx ZDc1Li42NTFhNWUzYjhmN2NmZmEwNTQ5MGIyMzE0Zjg4NDM2NzQ3M2EyNzRmIDEwMDY0NAotLS0g YS9Ub29scy9NaW5pQnJvd3Nlci9xdC9NaW5pQnJvd3NlckFwcGxpY2F0aW9uLmNwcAorKysgYi9U b29scy9NaW5pQnJvd3Nlci9xdC9NaW5pQnJvd3NlckFwcGxpY2F0aW9uLmNwcApAQCAtOTYsNiAr OTYsMTQgQEAgYm9vbCBNaW5pQnJvd3NlckFwcGxpY2F0aW9uOjpub3RpZnkoUU9iamVjdCogdGFy Z2V0LCBRRXZlbnQqIGV2ZW50KQogICAgIH0KIAogICAgIFFXaW5kb3cqIHRhcmdldFdpbmRvdyA9 IHFvYmplY3RfY2FzdDxRV2luZG93Kj4odGFyZ2V0KTsKKyAgICBpZiAoZXZlbnQtPnR5cGUoKSA9 PSBRRXZlbnQ6OktleVJlbGVhc2UgJiYgc3RhdGljX2Nhc3Q8UUtleUV2ZW50Kj4oZXZlbnQpLT5r ZXkoKSA9PSBRdDo6S2V5X0NvbnRyb2wpIHsKKyAgICAgICAgZm9yZWFjaCAoaW50IGlkLCBtX2hl bGRUb3VjaFBvaW50cykKKyAgICAgICAgICAgIGlmIChtX3RvdWNoUG9pbnRzLmNvbnRhaW5zKGlk KSkKKyAgICAgICAgICAgICAgICBtX3RvdWNoUG9pbnRzW2lkXS5zdGF0ZSA9IFF0OjpUb3VjaFBv aW50UmVsZWFzZWQ7CisgICAgICAgIG1faGVsZFRvdWNoUG9pbnRzLmNsZWFyKCk7CisgICAgICAg IHNlbmRUb3VjaEV2ZW50KHRhcmdldFdpbmRvdyk7CisgICAgfQorCiAgICAgaWYgKHRhcmdldFdp bmRvdyAmJiBpc01vdXNlRXZlbnQoZXZlbnQpKSB7CiAgICAgICAgIGNvbnN0IFFNb3VzZUV2ZW50 KiBjb25zdCBtb3VzZUV2ZW50ID0gc3RhdGljX2Nhc3Q8UU1vdXNlRXZlbnQqPihldmVudCk7CiAK QEAgLTExNSwyMCArMTIzLDI0IEBAIGJvb2wgTWluaUJyb3dzZXJBcHBsaWNhdGlvbjo6bm90aWZ5 KFFPYmplY3QqIHRhcmdldCwgUUV2ZW50KiBldmVudCkKICAgICAgICAgY2FzZSBRRXZlbnQ6Ok1v dXNlTW92ZToKICAgICAgICAgICAgIGlmICghbW91c2VFdmVudC0+YnV0dG9ucygpIHx8ICFtX3Rv dWNoUG9pbnRzLmNvbnRhaW5zKG1vdXNlRXZlbnQtPmJ1dHRvbnMoKSkpCiAgICAgICAgICAgICAg ICAgcmV0dXJuIFFBcHBsaWNhdGlvbjo6bm90aWZ5KHRhcmdldCwgZXZlbnQpOwotICAgICAgICAg ICAgdG91Y2hQb2ludC5zdGF0ZSA9IFF0OjpUb3VjaFBvaW50TW92ZWQ7CiAgICAgICAgICAgICB0 b3VjaFBvaW50LmlkID0gbW91c2VFdmVudC0+YnV0dG9ucygpOworICAgICAgICAgICAgdG91Y2hQ b2ludC5zdGF0ZSA9IFF0OjpUb3VjaFBvaW50TW92ZWQ7CiAgICAgICAgICAgICBicmVhazsKICAg ICAgICAgY2FzZSBRRXZlbnQ6Ok1vdXNlQnV0dG9uUmVsZWFzZToKLSAgICAgICAgICAgIGlmICht b3VzZUV2ZW50LT5tb2RpZmllcnMoKS50ZXN0RmxhZyhRdDo6Q29udHJvbE1vZGlmaWVyKSkKLSAg ICAgICAgICAgICAgICByZXR1cm4gUUFwcGxpY2F0aW9uOjpub3RpZnkodGFyZ2V0LCBldmVudCk7 CiAgICAgICAgICAgICB0b3VjaFBvaW50LnN0YXRlID0gUXQ6OlRvdWNoUG9pbnRSZWxlYXNlZDsK ICAgICAgICAgICAgIHRvdWNoUG9pbnQuaWQgPSBtb3VzZUV2ZW50LT5idXR0b24oKTsKKyAgICAg ICAgICAgIGlmIChtb3VzZUV2ZW50LT5tb2RpZmllcnMoKS50ZXN0RmxhZyhRdDo6Q29udHJvbE1v ZGlmaWVyKSkgeworICAgICAgICAgICAgICAgIG1faGVsZFRvdWNoUG9pbnRzLmluc2VydCh0b3Vj aFBvaW50LmlkKTsKKyAgICAgICAgICAgICAgICByZXR1cm4gUUFwcGxpY2F0aW9uOjpub3RpZnko dGFyZ2V0LCBldmVudCk7CisgICAgICAgICAgICB9CiAgICAgICAgICAgICBicmVhazsKICAgICAg ICAgZGVmYXVsdDoKICAgICAgICAgICAgIFFfQVNTRVJUX1goZmFsc2UsICJtdWx0aS10b3VjaCBt b2NraW5nIiwgInVuaGFuZGxlZCBldmVudCB0eXBlIik7CiAgICAgICAgIH0KIAogICAgICAgICAv LyBVcGRhdGUgY3VycmVudCB0b3VjaC1wb2ludAorICAgICAgICBpZiAobV90b3VjaFBvaW50cy5p c0VtcHR5KCkpCisgICAgICAgICAgICB0b3VjaFBvaW50LmlzUHJpbWFyeSA9IHRydWU7CiAgICAg ICAgIG1fdG91Y2hQb2ludHMuaW5zZXJ0KHRvdWNoUG9pbnQuaWQsIHRvdWNoUG9pbnQpOwogCiAg ICAgICAgIC8vIFVwZGF0ZSBzdGF0ZXMgZm9yIGFsbCBvdGhlciB0b3VjaC1wb2ludHMKQEAgLTEz NywzNyArMTQ5LDIyIEBAIGJvb2wgTWluaUJyb3dzZXJBcHBsaWNhdGlvbjo6bm90aWZ5KFFPYmpl Y3QqIHRhcmdldCwgUUV2ZW50KiBldmVudCkKICAgICAgICAgICAgICAgICBpdC52YWx1ZSgpLnN0 YXRlID0gUXQ6OlRvdWNoUG9pbnRTdGF0aW9uYXJ5OwogICAgICAgICB9CiAKLSAgICAgICAgUUxp c3Q8UVdpbmRvd1N5c3RlbUludGVyZmFjZTo6VG91Y2hQb2ludD4gdG91Y2hQb2ludHMgPSBtX3Rv dWNoUG9pbnRzLnZhbHVlcygpOwotICAgICAgICBRV2luZG93U3lzdGVtSW50ZXJmYWNlOjpUb3Vj aFBvaW50JiBmaXJzdFBvaW50ID0gdG91Y2hQb2ludHMuZmlyc3QoKTsKLSAgICAgICAgZmlyc3RQ b2ludC5pc1ByaW1hcnkgPSB0cnVlOworICAgICAgICBzZW5kVG91Y2hFdmVudCh0YXJnZXRXaW5k b3cpOworICAgIH0KIAotICAgICAgICBRRXZlbnQ6OlR5cGUgZXZlbnRUeXBlOwotICAgICAgICBz d2l0Y2ggKHRvdWNoUG9pbnQuc3RhdGUpIHsKLSAgICAgICAgY2FzZSBRdDo6VG91Y2hQb2ludFBy ZXNzZWQ6Ci0gICAgICAgICAgICBldmVudFR5cGUgPSBRRXZlbnQ6OlRvdWNoQmVnaW47Ci0gICAg ICAgICAgICBicmVhazsKLSAgICAgICAgY2FzZSBRdDo6VG91Y2hQb2ludFJlbGVhc2VkOgotICAg ICAgICAgICAgZXZlbnRUeXBlID0gUUV2ZW50OjpUb3VjaEVuZDsKLSAgICAgICAgICAgIGJyZWFr OwotICAgICAgICBjYXNlIFF0OjpUb3VjaFBvaW50U3RhdGlvbmFyeToKLSAgICAgICAgICAgIC8v IERvbid0IHNlbmQgdGhlIGV2ZW50IGlmIG5vdGhpbmcgY2hhbmdlZC4KLSAgICAgICAgICAgIHJl dHVybiBRQXBwbGljYXRpb246Om5vdGlmeSh0YXJnZXQsIGV2ZW50KTsKLSAgICAgICAgZGVmYXVs dDoKLSAgICAgICAgICAgIGV2ZW50VHlwZSA9IFFFdmVudDo6VG91Y2hVcGRhdGU7Ci0gICAgICAg ICAgICBicmVhazsKLSAgICAgICAgfQorICAgIHJldHVybiBRQXBwbGljYXRpb246Om5vdGlmeSh0 YXJnZXQsIGV2ZW50KTsKK30KIAotICAgICAgICBtX3BlbmRpbmdGYWtlVG91Y2hFdmVudENvdW50 Kys7Ci0gICAgICAgIFFXaW5kb3dTeXN0ZW1JbnRlcmZhY2U6OmhhbmRsZVRvdWNoRXZlbnQodGFy Z2V0V2luZG93LCBldmVudFR5cGUsIFFUb3VjaEV2ZW50OjpUb3VjaFNjcmVlbiwgdG91Y2hQb2lu dHMpOwordm9pZCBNaW5pQnJvd3NlckFwcGxpY2F0aW9uOjpzZW5kVG91Y2hFdmVudChRV2luZG93 KiB0YXJnZXRXaW5kb3cpCit7CisgICAgbV9wZW5kaW5nRmFrZVRvdWNoRXZlbnRDb3VudCsrOwor ICAgIFFXaW5kb3dTeXN0ZW1JbnRlcmZhY2U6OmhhbmRsZVRvdWNoRXZlbnQodGFyZ2V0V2luZG93 LCBRRXZlbnQ6Ok5vbmUsIFFUb3VjaEV2ZW50OjpUb3VjaFNjcmVlbiwgbV90b3VjaFBvaW50cy52 YWx1ZXMoKSk7CiAKLSAgICAgICAgLy8gR2V0IHJpZCBvZiB0b3VjaC1wb2ludHMgdGhhdCBhcmUg bm8gbG9uZ2VyIHZhbGlkCi0gICAgICAgIGZvcmVhY2ggKGNvbnN0IFFXaW5kb3dTeXN0ZW1JbnRl cmZhY2U6OlRvdWNoUG9pbnQmIHRvdWNoUG9pbnQsIG1fdG91Y2hQb2ludHMpIHsKLSAgICAgICAg ICAgIGlmICh0b3VjaFBvaW50LnN0YXRlID09ICBRdDo6VG91Y2hQb2ludFJlbGVhc2VkKQotICAg ICAgICAgICAgICAgIG1fdG91Y2hQb2ludHMucmVtb3ZlKHRvdWNoUG9pbnQuaWQpOwotICAgICAg ICB9CisgICAgLy8gR2V0IHJpZCBvZiB0b3VjaC1wb2ludHMgdGhhdCBhcmUgbm8gbG9uZ2VyIHZh bGlkCisgICAgZm9yZWFjaCAoY29uc3QgUVdpbmRvd1N5c3RlbUludGVyZmFjZTo6VG91Y2hQb2lu dCYgdG91Y2hQb2ludCwgbV90b3VjaFBvaW50cykgeworICAgIGlmICh0b3VjaFBvaW50LnN0YXRl ID09ICBRdDo6VG91Y2hQb2ludFJlbGVhc2VkKQorICAgICAgICBtX3RvdWNoUG9pbnRzLnJlbW92 ZSh0b3VjaFBvaW50LmlkKTsKICAgICB9Ci0KLSAgICByZXR1cm4gUUFwcGxpY2F0aW9uOjpub3Rp ZnkodGFyZ2V0LCBldmVudCk7CiB9CiAKIHN0YXRpYyB2b2lkIHByaW50SGVscChjb25zdCBRU3Ry aW5nJiBwcm9ncmFtTmFtZSkKZGlmZiAtLWdpdCBhL1Rvb2xzL01pbmlCcm93c2VyL3F0L01pbmlC cm93c2VyQXBwbGljYXRpb24uaCBiL1Rvb2xzL01pbmlCcm93c2VyL3F0L01pbmlCcm93c2VyQXBw bGljYXRpb24uaAppbmRleCBmNDNlMzJlMmU0NDA4MGQyYTNiYjJhN2E2OWFjZGM2ZWY0YTdiYTRi Li45NTE2M2U0NDY4NDUxMDc1Y2ZlNWExMjE2ZjJhYTJkZjRkMjI4MGEzIDEwMDY0NAotLS0gYS9U b29scy9NaW5pQnJvd3Nlci9xdC9NaW5pQnJvd3NlckFwcGxpY2F0aW9uLmgKKysrIGIvVG9vbHMv TWluaUJyb3dzZXIvcXQvTWluaUJyb3dzZXJBcHBsaWNhdGlvbi5oCkBAIC04MSw2ICs4MSw3IEBA IHB1YmxpYzoKICAgICB2aXJ0dWFsIGJvb2wgbm90aWZ5KFFPYmplY3QqLCBRRXZlbnQqKTsKIAog cHJpdmF0ZToKKyAgICB2b2lkIHNlbmRUb3VjaEV2ZW50KFFXaW5kb3cqIHRhcmdldFdpbmRvdyk7 CiAgICAgdm9pZCBoYW5kbGVVc2VyT3B0aW9ucygpOwogCiBwcml2YXRlOgpAQCAtOTIsNiArOTMs NyBAQCBwcml2YXRlOgogICAgIFFTdHJpbmdMaXN0IG1fdXJsczsKIAogICAgIFFIYXNoPGludCwg UVdpbmRvd1N5c3RlbUludGVyZmFjZTo6VG91Y2hQb2ludD4gbV90b3VjaFBvaW50czsKKyAgICBR U2V0PGludD4gbV9oZWxkVG91Y2hQb2ludHM7CiB9OwogCiBRTUxfREVDTEFSRV9UWVBFKFdpbmRv d09wdGlvbnMpOwo=