71101 2011-10-28 02:20:26 -0700 Stylebot should not complain about a RefPtr argument passed by pointer (RefPtr<...>*) 2011-12-26 23:40:06 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 apavlov webkit-unassigned loislo sam vsevik oldest_to_newest 492329 0 apavlov 2011-10-28 02:20:26 -0700 A legitimate use of RefPtr's in arguments passed as pointers (since this does not involve reference counter changes or something of the kind) is reported as a stylebot error. 492356 1 vsevik 2011-10-28 02:57:24 -0700 Apparently this use is not actually legitimate. https://bugs.webkit.org/show_bug.cgi?id=69366 492364 2 apavlov 2011-10-28 03:57:17 -0700 (In reply to comment #1) > Apparently this use is not actually legitimate. > > https://bugs.webkit.org/show_bug.cgi?id=69366 Yes, that makes sense, since the pointer-vs-reference decision was changed recently. In my case, a change added a parameter to a method signature, and this method already had a RefPtr<..>* output parameter. Fixing this particular stylebot failure implied touching A LOT of this method call sites (I was adding a parameter with a default value) and fixing the method body instead of just modifying a dozen of lines for my original change. I agree, however, that this is a challenge to balance the stylebot output against the obsolete-styled code. 492520 3 sam 2011-10-28 10:40:48 -0700 Where is this style used? It seems quite odd so I would like to understand what its utility is. 493203 4 apavlov 2011-10-31 01:17:24 -0700 (In reply to comment #3) > Where is this style used? It seems quite odd so I would like to understand what its utility is. It is used in the InspectorBackendDispatcher generator which invokes methods on Inspector*Agent instances (as such, their method signatures use this style, too). It has been there for quite a while, since the times when the "output argument should be a reference, not a pointer" was proper style. That said, I'm told that we are going to correct this shortly (this week), so that this will no longer be an issue, and I believe this bug can be closed as wontfix.