71026 2011-10-27 09:28:23 -0700 Tighten font change conditions in matched declaration cache 2022-08-02 13:26:18 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED CONFIGURATION CHANGED InRadar P2 Normal --- 71186 1 koivisto koivisto bfulgham eric macpherson ossy rniwa webkit-bug-importer webkit.review.bot oldest_to_newest 491638 0 koivisto 2011-10-27 09:28:23 -0700 We currently test if font description has changed to see if all properties need to be applied. However only a few size related metrics can actually affect other properties. We can just test those, making the cache somewhat more effective while also making the test faster. 491640 1 112694 koivisto 2011-10-27 09:37:53 -0700 Created attachment 112694 patch 492931 2 koivisto 2011-10-29 02:36:41 -0700 http://trac.webkit.org/changeset/98803 492948 3 ossy 2011-10-29 10:37:58 -0700 It made all tests assert on Qt in debug mode: ASSERTION FAILED: fontCache()->generation() == m_generation ../../../Source/WebCore/platform/graphics/FontFallbackList.cpp(104) : const WebCore::FontData* WebCore::FontFallbackList::fontDataAt(const WebCore::Font*, unsigned int) const Could you check it, please? 492974 4 rniwa 2011-10-29 14:18:33 -0700 It appears that this patch broke 500+ tests on Windows: http://build.webkit.org/builders/Windows%207%20Release%20%28Tests%29/builds/17418 493046 5 koivisto 2011-10-30 09:06:12 -0700 Rolled out in http://trac.webkit.org/changeset/98826, don't know yet why this would fail only on some platforms. 525616 6 eric 2011-12-21 14:34:33 -0800 Attachment 112694 was posted by a committer and has review+, assigning to Antti Koivisto for commit. 1888480 7 bfulgham 2022-08-02 13:25:44 -0700 This path doesn't seem relevant after the updated CSS parser. 1888481 8 webkit-bug-importer 2022-08-02 13:26:18 -0700 <rdar://problem/98005179> 112694 2011-10-27 09:37:53 -0700 2022-08-02 13:25:50 -0700 patch tighten-font-conditions.patch text/plain 4288 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk4NTg5KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTEtMTAtMjcgIEFudHRpIEtv aXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgorCisgICAgICAgIFRpZ2h0ZW4gZm9udCBjaGFuZ2Ug Y29uZGl0aW9ucyBpbiBtYXRjaGVkIGRlY2xhcmF0aW9uIGNhY2hlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MTAyNgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIGN1cnJlbnRseSB0ZXN0IGlmIGZvbnQg ZGVzY3JpcHRpb24gaGFzIGNoYW5nZWQgdG8gc2VlIGlmIGFsbCBwcm9wZXJ0aWVzIG5lZWQgdG8g YmUgYXBwbGllZC4gSG93ZXZlcgorICAgICAgICBvbmx5IGEgZmV3IHNpemUgcmVsYXRlZCBtZXRy aWNzIGNhbiBhY3R1YWxseSBhZmZlY3Qgb3RoZXIgcHJvcGVydGllcy4gV2UgY2FuIGp1c3QgdGVz dCB0aG9zZSwgbWFraW5nIAorICAgICAgICB0aGUgY2FjaGUgc29tZXdoYXQgbW9yZSBlZmZlY3Rp dmUgd2hpbGUgYWxzbyBtYWtpbmcgdGhlIHRlc3QgZmFzdGVyLgorICAgICAgICAKKyAgICAgICAg LSBUZXN0IGZvciB0ZXh0IGNvbXB1dGVkU2l6ZSwgeEhlaWdodCBhbmQgb3JpZW50YXRpb24gb25s eS4gT3RoZXIgdGV4dCBwcm9wZXJ0aWVzIGRvbid0IGFmZmVjdCBjb21wdXRlZAorICAgICAgICAg IHZhbHVlcyBvZiBDU1MgcHJvcGVydGllcy4KKyAgICAgICAgLSBNYXJrIGEgZmV3IHJhcmUgdGV4 dCByZWxhdGVkIHByb3BlcnRpZXMgY29ycmVjdGx5IGFzIGluaGVyaXRlZC4KKworICAgICAgICAq IGNzcy9DU1NQcm9wZXJ0eS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NQcm9wZXJ0eTo6aXNJ bmhlcml0ZWRQcm9wZXJ0eSk6CisgICAgICAgICogY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6Zm9udERpZmZlcmVuY2VBZmZlY3RzTm9uSW5oZXJpdGVkKToKKyAg ICAgICAgKFdlYkNvcmU6OkNTU1N0eWxlU2VsZWN0b3I6OmFwcGx5TWF0Y2hlZERlY2xhcmF0aW9u cyk6CisKIDIwMTEtMTAtMjcgIERhbmllbCBDaGVuZyAgPGRjaGVuZ0BjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgQ2xlYW4gdXAgTWljcm9EYXRhSXRlbVZhbHVlIHRvIHVzZSBjb25zdCBTdHJpbmcm IGluc3RlYWQgb2YgU3RyaW5nCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUHJvcGVydHku Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcm9wZXJ0eS5jcHAJKHJl dmlzaW9uIDk4NTY0KQorKysgU291cmNlL1dlYkNvcmUvY3NzL0NTU1Byb3BlcnR5LmNwcAkod29y a2luZyBjb3B5KQpAQCAtMzIxLDYgKzMyMSw4IEBAIGJvb2wgQ1NTUHJvcGVydHk6OmlzSW5oZXJp dGVkUHJvcGVydHkodW4KICAgICBjYXNlIENTU1Byb3BlcnR5V2Via2l0Qm9yZGVyVmVydGljYWxT cGFjaW5nOgogICAgIGNhc2UgQ1NTUHJvcGVydHlXZWJraXRCb3hEaXJlY3Rpb246CiAgICAgY2Fz ZSBDU1NQcm9wZXJ0eVdlYmtpdENvbG9yQ29ycmVjdGlvbjoKKyAgICBjYXNlIENTU1Byb3BlcnR5 V2Via2l0Rm9udEZlYXR1cmVTZXR0aW5nczoKKyAgICBjYXNlIENTU1Byb3BlcnR5V2Via2l0Rm9u dFNtb290aGluZzoKICAgICBjYXNlIENTU1Byb3BlcnR5V2Via2l0TG9jYWxlOgogICAgIGNhc2Ug Q1NTUHJvcGVydHlXZWJraXRIaWdobGlnaHQ6CiAgICAgY2FzZSBDU1NQcm9wZXJ0eVdlYmtpdEh5 cGhlbmF0ZUNoYXJhY3RlcjoKQEAgLTMzOSw2ICszNDEsNyBAQCBib29sIENTU1Byb3BlcnR5Ojpp c0luaGVyaXRlZFByb3BlcnR5KHVuCiAgICAgY2FzZSBDU1NQcm9wZXJ0eVdlYmtpdFRleHRFbXBo YXNpc1Bvc2l0aW9uOgogICAgIGNhc2UgQ1NTUHJvcGVydHlXZWJraXRUZXh0RW1waGFzaXNTdHls ZToKICAgICBjYXNlIENTU1Byb3BlcnR5V2Via2l0VGV4dEZpbGxDb2xvcjoKKyAgICBjYXNlIENT U1Byb3BlcnR5V2Via2l0VGV4dE9yaWVudGF0aW9uOgogICAgIGNhc2UgQ1NTUHJvcGVydHlXZWJr aXRUZXh0U2VjdXJpdHk6CiAgICAgY2FzZSBDU1NQcm9wZXJ0eVdlYmtpdFRleHRTaXplQWRqdXN0 OgogICAgIGNhc2UgQ1NTUHJvcGVydHlXZWJraXRUZXh0U3Ryb2tlOgpAQCAtMzg0LDkgKzM4Nyw2 IEBAIGJvb2wgQ1NTUHJvcGVydHk6OmlzSW5oZXJpdGVkUHJvcGVydHkodW4KICNlbmRpZgogICAg ICAgICByZXR1cm4gdHJ1ZTsKICAgICBjYXNlIENTU1Byb3BlcnR5RGlzcGxheToKLSAgICBjYXNl IENTU1Byb3BlcnR5V2Via2l0Rm9udEZlYXR1cmVTZXR0aW5nczoKLSAgICBjYXNlIENTU1Byb3Bl cnR5V2Via2l0Rm9udFNtb290aGluZzoKLSAgICBjYXNlIENTU1Byb3BlcnR5V2Via2l0VGV4dE9y aWVudGF0aW9uOgogICAgIGNhc2UgQ1NTUHJvcGVydHlab29tOgogICAgIGNhc2UgQ1NTUHJvcGVy dHlCYWNrZ3JvdW5kOgogICAgIGNhc2UgQ1NTUHJvcGVydHlCYWNrZ3JvdW5kQXR0YWNobWVudDoK SW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAJKHJldmlzaW9uIDk4 NTczKQorKysgU291cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0yMjEwLDYgKzIyMTAsMTcgQEAgc3RhdGljIGJvb2wgaXNDYWNoZWFibGVJbk1h dGNoZWREZWNsYXJhdAogICAgIHJldHVybiB0cnVlOwogfQogCitzdGF0aWMgYm9vbCBmb250RGlm ZmVyZW5jZUFmZmVjdHNOb25Jbmhlcml0ZWQoY29uc3QgUmVuZGVyU3R5bGUqIHN0eWxlLCBjb25z dCBSZW5kZXJTdHlsZSogY2FjaGVkU3R5bGUpCit7CisgICAgaWYgKHN0eWxlLT5mb250TWV0cmlj cygpLnhIZWlnaHQoKSAhPSBjYWNoZWRTdHlsZS0+Zm9udE1ldHJpY3MoKS54SGVpZ2h0KCkpCisg ICAgICAgIHJldHVybiB0cnVlOworICAgIGlmIChzdHlsZS0+Zm9udERlc2NyaXB0aW9uKCkuY29t cHV0ZWRTaXplKCkgIT0gY2FjaGVkU3R5bGUtPmZvbnREZXNjcmlwdGlvbigpLmNvbXB1dGVkU2l6 ZSgpKQorICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICBpZiAoc3R5bGUtPmZvbnREZXNjcmlwdGlv bigpLm9yaWVudGF0aW9uKCkgIT0gY2FjaGVkU3R5bGUtPmZvbnREZXNjcmlwdGlvbigpLm9yaWVu dGF0aW9uKCkpCisgICAgICAgIHJldHVybiB0cnVlOworICAgIHJldHVybiBmYWxzZTsKK30KKwog dm9pZCBDU1NTdHlsZVNlbGVjdG9yOjphcHBseU1hdGNoZWREZWNsYXJhdGlvbnMoY29uc3QgTWF0 Y2hSZXN1bHQmIG1hdGNoUmVzdWx0KQogewogICAgIHVuc2lnbmVkIGNhY2hlSGFzaCA9IG1hdGNo UmVzdWx0LmlzQ2FjaGVhYmxlID8gY29tcHV0ZURlY2xhcmF0aW9uSGFzaChtX21hdGNoZWREZWNs cy5kYXRhKCksIG1fbWF0Y2hlZERlY2xzLnNpemUoKSkgOiAwOwpAQCAtMjI0NCw4ICsyMjU1LDgg QEAgdm9pZCBDU1NTdHlsZVNlbGVjdG9yOjphcHBseU1hdGNoZWREZWNsYQogICAgIGlmIChtX2xp bmVIZWlnaHRWYWx1ZSkKICAgICAgICAgYXBwbHlQcm9wZXJ0eShDU1NQcm9wZXJ0eUxpbmVIZWln aHQsIG1fbGluZUhlaWdodFZhbHVlKTsKIAotICAgIC8vIE1hbnkgcHJvcGVydGllcyBkZXBlbmQg b24gdGhlIGZvbnQuIElmIGl0IGNoYW5nZXMgd2UganVzdCBhcHBseSBhbGwgcHJvcGVydGllcy4K LSAgICBpZiAoY2FjaGVkU3R5bGUgJiYgY2FjaGVkU3R5bGUtPmZvbnREZXNjcmlwdGlvbigpICE9 IG1fc3R5bGUtPmZvbnREZXNjcmlwdGlvbigpKQorICAgIC8vIE1hbnkgcHJvcGVydGllcyBkZXBl bmQgb24gdGhlIGZvbnQgc2l6ZS4gSWYgaXQgY2hhbmdlcyB3ZSBqdXN0IGFwcGx5IGFsbCBwcm9w ZXJ0aWVzLgorICAgIGlmIChjYWNoZWRTdHlsZSAmJiBmb250RGlmZmVyZW5jZUFmZmVjdHNOb25J bmhlcml0ZWQobV9zdHlsZS5nZXQoKSwgY2FjaGVkU3R5bGUpKQogICAgICAgICBhcHBseUluaGVy aXRlZE9ubHkgPSBmYWxzZTsKIAogICAgIC8vIE5vdyBkbyB0aGUgbm9ybWFsIHByaW9yaXR5IFVB IHByb3BlcnRpZXMuCg==