71020 2011-10-27 08:49:21 -0700 [EFL] Fix variable renaming issue inside ewk_view.cpp 2011-10-27 19:48:09 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 glima webkit-unassigned gyuyoung.kim lucas.de.marchi webkit.review.bot oldest_to_newest 491612 0 glima 2011-10-27 08:49:21 -0700 [EFL] Fix variable renaming issue inside ewk_view.cpp 491614 1 112689 glima 2011-10-27 08:52:13 -0700 Created attachment 112689 Patch 491618 2 webkit.review.bot 2011-10-27 08:54:07 -0700 Attachment 112689 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/efl/ChangeLog', u'Source/Web..." exit_code: 1 Source/WebKit/efl/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 491630 3 112692 glima 2011-10-27 09:05:07 -0700 Created attachment 112692 Patch 492186 4 112692 gyuyoung.kim 2011-10-27 18:40:54 -0700 Comment on attachment 112692 Patch LGTM. 492205 5 112692 webkit.review.bot 2011-10-27 19:48:03 -0700 Comment on attachment 112692 Patch Clearing flags on attachment: 112692 Committed r98680: <http://trac.webkit.org/changeset/98680> 492206 6 webkit.review.bot 2011-10-27 19:48:09 -0700 All reviewed patches have been landed. Closing bug. 112689 2011-10-27 08:52:13 -0700 2011-10-27 09:04:59 -0700 Patch bug-71020-20111027135211.patch text/plain 1329 glima U3VidmVyc2lvbiBSZXZpc2lvbjogOTg0OTUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwppbmRleCA1NWZiZjFiZDhh NmQxODdlYzY4ZDc1YmJmNmY1NzEyOGIyOWZiZmNkLi4xZmQ0MmMxZjEwMDUyODc1ZDIzMGY3MjVl OWQzNzQwZTYxNjljNzVmIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEt MTAtMjcgIEd1c3Rhdm8gTGltYSBDaGF2ZXMgIDxnbGltYUBwcm9mdXNpb24ubW9iaT4KKworICAg ICAgICBbRUZMXSBGaXggdmFyaWFibGUgcmVuYW1pbmcgaXNzdWUgaW5zaWRlIGV3a192aWV3LmNw cAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzEwMjAK KworCVVucmV2aWV3ZWQgYnVpbGQgZml4LgorCisgICAgICAgICogZXdrL2V3a192aWV3LmNwcDoK KyAgICAgICAgKGV3a192aWV3X2pzX29iamVjdF9hZGQpOgorCiAyMDExLTEwLTI2ICBaYWxhbiBC dWp0YXMgIDx6YnVqdGFzQGdtYWlsLmNvbT4KIAogICAgICAgICBOYW1lIHZpZXdwb3J0IGNoYW5n ZSBldmVudCBjb25zaXN0ZW50bHkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2sv ZXdrX3ZpZXcuY3BwIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcAppbmRleCA5 OWVlMjkxZTk1MTE2YmMyMmE5MjQ5MDBkZjAwYzE1ZTcxYWNlYmU4Li5lMzcyMjgyZjEwYzk5YmE4 MDg3MDUzYjc5NzdjYzcxNjY2Mjc4N2E2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9l d2svZXdrX3ZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAK QEAgLTM2OTQsNyArMzY5NCw3IEBAIEVpbmFfQm9vbCBld2tfdmlld19qc19vYmplY3RfYWRkKEV2 YXNfT2JqZWN0KiBld2tWaWV3LCBFd2tfSlNfT2JqZWN0KiBvYmplY3QsIGNvCiAgICAgSlNDOjpJ ZGVudGlmaWVyIGlkID0gSlNDOjpJZGVudGlmaWVyKGV4ZWN1dGVTdGF0ZSwgb2JqZWN0TmFtZSk7 CiAKICAgICBKU0M6OlB1dFByb3BlcnR5U2xvdCBzbG90OwotICAgIHdpbmRvdy0+bWV0aG9kVGFi bGUoKS0+cHV0KHdpbmRvdywgZXhlY1N0YXRlLCBpZCwgcnVudGltZU9iamVjdCwgc2xvdCk7Cisg ICAgd2luZG93LT5tZXRob2RUYWJsZSgpLT5wdXQod2luZG93LCBleGVjdXRlU3RhdGUsIGlkLCBy dW50aW1lT2JqZWN0LCBzbG90KTsKICAgICByZXR1cm4gRUlOQV9UUlVFOwogI2Vsc2UKICAgICBy ZXR1cm4gRUlOQV9GQUxTRTsK 112692 2011-10-27 09:05:07 -0700 2011-10-27 19:48:03 -0700 Patch bug-71020-20111027140505.patch text/plain 1336 glima U3VidmVyc2lvbiBSZXZpc2lvbjogOTg0OTUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwppbmRleCA1NWZiZjFiZDhh NmQxODdlYzY4ZDc1YmJmNmY1NzEyOGIyOWZiZmNkLi42MDYzMjQ3ZmZhNDgwNWQyYzcwMzNiYzQ0 NTgyZDhlMzE0NDViNWZkIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEt MTAtMjcgIEd1c3Rhdm8gTGltYSBDaGF2ZXMgIDxnbGltYUBwcm9mdXNpb24ubW9iaT4KKworICAg ICAgICBbRUZMXSBGaXggdmFyaWFibGUgcmVuYW1pbmcgaXNzdWUgaW5zaWRlIGV3a192aWV3LmNw cAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzEwMjAK KworICAgICAgICBVbnJldmlld2VkIGJ1aWxkIGZpeC4KKworICAgICAgICAqIGV3ay9ld2tfdmll dy5jcHA6CisgICAgICAgIChld2tfdmlld19qc19vYmplY3RfYWRkKToKKwogMjAxMS0xMC0yNiAg WmFsYW4gQnVqdGFzICA8emJ1anRhc0BnbWFpbC5jb20+CiAKICAgICAgICAgTmFtZSB2aWV3cG9y dCBjaGFuZ2UgZXZlbnQgY29uc2lzdGVudGx5LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9l ZmwvZXdrL2V3a192aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAK aW5kZXggOTllZTI5MWU5NTExNmJjMjJhOTI0OTAwZGYwMGMxNWU3MWFjZWJlOC4uZTM3MjI4MmYx MGM5OWJhODA4NzA1M2I3OTc3Y2M3MTY2NjI3ODdhNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9lZmwvZXdrL2V3a192aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3Zp ZXcuY3BwCkBAIC0zNjk0LDcgKzM2OTQsNyBAQCBFaW5hX0Jvb2wgZXdrX3ZpZXdfanNfb2JqZWN0 X2FkZChFdmFzX09iamVjdCogZXdrVmlldywgRXdrX0pTX09iamVjdCogb2JqZWN0LCBjbwogICAg IEpTQzo6SWRlbnRpZmllciBpZCA9IEpTQzo6SWRlbnRpZmllcihleGVjdXRlU3RhdGUsIG9iamVj dE5hbWUpOwogCiAgICAgSlNDOjpQdXRQcm9wZXJ0eVNsb3Qgc2xvdDsKLSAgICB3aW5kb3ctPm1l dGhvZFRhYmxlKCktPnB1dCh3aW5kb3csIGV4ZWNTdGF0ZSwgaWQsIHJ1bnRpbWVPYmplY3QsIHNs b3QpOworICAgIHdpbmRvdy0+bWV0aG9kVGFibGUoKS0+cHV0KHdpbmRvdywgZXhlY3V0ZVN0YXRl LCBpZCwgcnVudGltZU9iamVjdCwgc2xvdCk7CiAgICAgcmV0dXJuIEVJTkFfVFJVRTsKICNlbHNl CiAgICAgcmV0dXJuIEVJTkFfRkFMU0U7Cg==