71009 2011-10-27 05:40:06 -0700 Fix the build if NO_LISTBOX_RENDERING is enabled 2011-10-27 06:02:59 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 abecsi abecsi darin kenneth luiz tkent oldest_to_newest 491483 0 abecsi 2011-10-27 05:40:06 -0700 If NO_LISTBOX_RENDERING is enabled RenderMenuList::listBoxSelectItem uses the HTMLSelectElement::listBoxSelectItem function which was accidentally removed in r97533. Reintroduce HTMLSelectElement::listBoxSelectItem with a NO_LISTBOX_RENDERING guard to unbreak this setup. This code path seems to be only used by Chromium and Qt: ./Source/WebKit/chromium/src/ExternalPopupMenu.cpp:136: listPopupMenuClient->listBoxSelectItem(indices[i], (i > 0), false, (i == indices.size() - 1)); ./Source/WebKit/qt/WebCoreSupport/PopupMenuQt.cpp:148: client->listBoxSelectItem(index, ctrl, shift); 491484 1 112667 abecsi 2011-10-27 05:42:44 -0700 Created attachment 112667 proposed patch 491491 2 112667 kenneth 2011-10-27 05:58:09 -0700 Comment on attachment 112667 proposed patch On so this wasn't really unused. It is used by RenderMenu::listBoxSelectItem which is used for NO_LISTBOX_RENDERING. Given that, r=me 491492 3 112667 abecsi 2011-10-27 06:02:51 -0700 Comment on attachment 112667 proposed patch Clearing flags on attachment: 112667 Committed r98557: <http://trac.webkit.org/changeset/98557> 491493 4 abecsi 2011-10-27 06:02:59 -0700 All reviewed patches have been landed. Closing bug. 112667 2011-10-27 05:42:44 -0700 2011-10-27 06:02:51 -0700 proposed patch patch.diff text/plain 2548 abecsi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4MWY4MGJmLi44MmNmZmU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTEtMTAtMjcgIEFuZHJhcyBCZWNzaSAgPGFuZHJhcy5iZWNzaUBub2tpYS5jb20+CisK KyAgICAgICAgRml4IHRoZSBidWlsZCBpZiBOT19MSVNUQk9YX1JFTkRFUklORyBpcyBlbmFibGVk CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MTAwOQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIElmIE5PX0xJ U1RCT1hfUkVOREVSSU5HIGlzIGVuYWJsZWQgUmVuZGVyTWVudUxpc3Q6Omxpc3RCb3hTZWxlY3RJ dGVtIHVzZXMgdGhlCisgICAgICAgIEhUTUxTZWxlY3RFbGVtZW50OjpsaXN0Qm94U2VsZWN0SXRl bSBmdW5jdGlvbiB3aGljaCB3YXMgYWNjaWRlbnRhbGx5IHJlbW92ZWQgaW4gcjk3NTMzLgorICAg ICAgICBSZWludHJvZHVjZSBIVE1MU2VsZWN0RWxlbWVudDo6bGlzdEJveFNlbGVjdEl0ZW0gd2l0 aCBhIE5PX0xJU1RCT1hfUkVOREVSSU5HIGd1YXJkIHRvIHVuYnJlYWsgdGhpcyBzZXR1cC4KKwor ICAgICAgICBUaGlzIGlzIGNvdmVyZWQgYnk6CisgICAgICAgIFNvdXJjZS9XZWJDb3JlL21hbnVh bC10ZXN0cy9uby1saXN0Ym94LXJlbmRlcmluZy5odG1sCisKKyAgICAgICAgKiBodG1sL0hUTUxT ZWxlY3RFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxTZWxlY3RFbGVtZW50Ojps aXN0Qm94U2VsZWN0SXRlbSk6IFJlaW50cm9kdWNlLgorICAgICAgICAqIGh0bWwvSFRNTFNlbGVj dEVsZW1lbnQuaDoKKwogMjAxMS0xMC0yNyAgSWx5YSBUaWtob25vdnNreSAgPGxvaXNsb0BjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCBvbmUgbGluZSBmaXggZm9yIERPTVN0b3Jh Z2VJdGVtc1ZpZXcuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxTZWxlY3RF bGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFNlbGVjdEVsZW1lbnQuY3BwCmlu ZGV4IDkzNzBiZWIuLjYyM2MzNWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRN TFNlbGVjdEVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFNlbGVjdEVs ZW1lbnQuY3BwCkBAIC0xNjcsNiArMTY3LDIwIEBAIGJvb2wgSFRNTFNlbGVjdEVsZW1lbnQ6OnZh bHVlTWlzc2luZygpIGNvbnN0CiAgICAgcmV0dXJuIGZpcnN0U2VsZWN0aW9uSW5kZXggPCAwIHx8 ICghZmlyc3RTZWxlY3Rpb25JbmRleCAmJiBoYXNQbGFjZWhvbGRlckxhYmVsT3B0aW9uKCkpOwog fQogCisjaWYgRU5BQkxFKE5PX0xJU1RCT1hfUkVOREVSSU5HKQordm9pZCBIVE1MU2VsZWN0RWxl bWVudDo6bGlzdEJveFNlbGVjdEl0ZW0oaW50IGxpc3RJbmRleCwgYm9vbCBhbGxvd011bHRpcGx5 U2VsZWN0aW9ucywgYm9vbCBzaGlmdCwgYm9vbCBmaXJlT25DaGFuZ2VOb3cpCit7CisgICAgaWYg KCFtdWx0aXBsZSgpKQorICAgICAgICBzZXRTZWxlY3RlZEluZGV4QnlVc2VyKGxpc3RUb09wdGlv bkluZGV4KGxpc3RJbmRleCksIHRydWUsIGZpcmVPbkNoYW5nZU5vdyk7CisgICAgZWxzZSB7Cisg ICAgICAgIHVwZGF0ZVNlbGVjdGVkU3RhdGUobGlzdEluZGV4LCBhbGxvd011bHRpcGx5U2VsZWN0 aW9ucywgc2hpZnQpOworICAgICAgICBzZXROZWVkc1ZhbGlkaXR5Q2hlY2soKTsKKyAgICAgICAg aWYgKGZpcmVPbkNoYW5nZU5vdykKKyAgICAgICAgICAgIGxpc3RCb3hPbkNoYW5nZSgpOworICAg IH0KK30KKyNlbmRpZgorCiBpbnQgSFRNTFNlbGVjdEVsZW1lbnQ6OmFjdGl2ZVNlbGVjdGlvblN0 YXJ0TGlzdEluZGV4KCkgY29uc3QKIHsKICAgICBpZiAobV9hY3RpdmVTZWxlY3Rpb25BbmNob3JJ bmRleCA+PSAwKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MU2VsZWN0RWxl bWVudC5oIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MU2VsZWN0RWxlbWVudC5oCmluZGV4IGRh Yzk2ZTcuLmEyMmM2MGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFNlbGVj dEVsZW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxTZWxlY3RFbGVtZW50LmgK QEAgLTg3LDYgKzg3LDEwIEBAIHB1YmxpYzoKIAogICAgIHZvaWQgc2Nyb2xsVG9TZWxlY3Rpb24o KTsKIAorI2lmIEVOQUJMRShOT19MSVNUQk9YX1JFTkRFUklORykKKyAgICB2b2lkIGxpc3RCb3hT ZWxlY3RJdGVtKGludCBsaXN0SW5kZXgsIGJvb2wgYWxsb3dNdWx0aXBseVNlbGVjdGlvbnMsIGJv b2wgc2hpZnQsIGJvb2wgZmlyZU9uQ2hhbmdlTm93ID0gdHJ1ZSk7CisjZW5kaWYKKwogICAgIGJv b2wgY2FuU2VsZWN0QWxsKCkgY29uc3Q7CiAgICAgdm9pZCBzZWxlY3RBbGwoKTsKICAgICBpbnQg bGlzdFRvT3B0aW9uSW5kZXgoaW50IGxpc3RJbmRleCkgY29uc3Q7Cg==