70990 2011-10-26 21:07:45 -0700 [EFL] Fix building with Glib support disabled 2011-12-23 02:06:15 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 ivan webkit-unassigned gyuyoung.kim lucas.de.marchi mrobinson rakuco webkit.review.bot oldest_to_newest 491337 0 ivan 2011-10-26 21:07:45 -0700 [EFL] Fix building with Glib support disabled 491339 1 112637 ivan 2011-10-26 21:12:02 -0700 Created attachment 112637 Patch 491340 2 webkit.review.bot 2011-10-26 21:14:35 -0700 Attachment 112637 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/cairo/WidgetBackingStore.h:28: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 491585 3 112684 ivan 2011-10-27 08:10:33 -0700 Created attachment 112684 Patch 491587 4 112684 ivan 2011-10-27 08:12:16 -0700 Comment on attachment 112684 Patch I'm not sure this is the right way to fix this, but since platforms others than Gtk may want to use cairo, and the usage of cairo_surface_t is not under conditionals, it seems coherent to just have the right header included as well. 491606 5 112684 mrobinson 2011-10-27 08:39:01 -0700 Comment on attachment 112684 Patch Why not add the typedefs here or create a similar typedefs file for yourself. We worked pretty hard to keep system headers out of WebCore/JSC headers. 491613 6 rakuco 2011-10-27 08:50:26 -0700 (In reply to comment #5) > (From update of attachment 112684 [details]) > Why not add the typedefs here or create a similar typedefs file for yourself. Just adding a typedef there should be fine IMHO. > We worked pretty hard to keep system headers out of WebCore/JSC headers. Hmm. Does it mean the same should be done to other headers (platform/graphics/CairoUtilities.h), for example? 491624 7 mrobinson 2011-10-27 08:58:23 -0700 (In reply to comment #6) > Hmm. Does it mean the same should be done to other headers (platform/graphics/CairoUtilities.h), for example? Yes, if possible and within reason. :) 524076 8 112684 eric 2011-12-19 11:49:06 -0800 Comment on attachment 112684 Patch Do we forward-declare these instead of including cairo.h? 524087 9 ivan 2011-12-19 11:58:30 -0800 Oh my, I had completely forgotten about this. I'll make a new patch this week. 526373 10 120344 ivan 2011-12-22 11:05:45 -0800 Created attachment 120344 Patch New patch. Leaving the declaration unconditional to match its usage below. 526449 11 120344 mrobinson 2011-12-22 12:36:44 -0800 Comment on attachment 120344 Patch I would have preferred this go within the PLATFORM(EFL) block, but this is fine. 526450 12 ivan 2011-12-22 12:38:28 -0800 Even when the type is used without any #ifdef later? I will keep that in mind if so. Thanks. 526778 13 120344 webkit.review.bot 2011-12-23 02:06:11 -0800 Comment on attachment 120344 Patch Clearing flags on attachment: 120344 Committed r103614: <http://trac.webkit.org/changeset/103614> 526779 14 webkit.review.bot 2011-12-23 02:06:15 -0800 All reviewed patches have been landed. Closing bug. 112637 2011-10-26 21:12:02 -0700 2011-10-27 08:10:25 -0700 Patch bug-70990-20111027021203.patch text/plain 1254 ivan U3VidmVyc2lvbiBSZXZpc2lvbjogOTg1MzIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBjZTJlMjE0OGNiODE5ZGEz NzM0MzhiYTk3NTlhMzNjOGMzOTZmNzhjLi4wYzE5YzU5ZTI5MmE2MjIxOTc4MjRiMWEzOWQxYWQ3 NTJjYzQ2Mjg2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMTAtMjYgIEl2YW4g QnJpYW5vICA8aXZhbkBwcm9mdXNpb24ubW9iaT4KKworICAgICAgICBbRUZMXSBGaXggYnVpbGRp bmcgd2l0aCBHbGliIHN1cHBvcnQgZGlzYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTcwOTkwCisKKyAgICAgICAgVW5yZXZpZXdlZCBidWlsZCBm aXguCisKKyAgICAgICAgSW5jbHVkZSBmb3IgY2Fpcm8uaCB3YXMgbWlzc2luZyBhbmQgd2l0aG91 dCBHbGliIHN1cHBvcnQgZW5hYmxlZCwKKyAgICAgICAgdGhlIGNhaXJvX3N1cmZhY2VfdCB1c2Vk IGJlbG93IHdhcyBub3QgZGVmaW5lZC4KKworICAgICAgICAqIHBsYXRmb3JtL2NhaXJvL1dpZGdl dEJhY2tpbmdTdG9yZS5oOgorCiAyMDExLTEwLTI2ICBTdGV2ZSBGYWxrZW5idXJnICA8c2ZhbGtl bkBhcHBsZS5jb20+CiAKICAgICAgICAgUmVzb3VyY2VFcnJvciBkb2Vzbid0IHN1cHBvcnQgY3Vz dG9tIGRvbWFpbnMgb24gV2luZG93cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vY2Fpcm8vV2lkZ2V0QmFja2luZ1N0b3JlLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9j YWlyby9XaWRnZXRCYWNraW5nU3RvcmUuaAppbmRleCBlMzdlOTllNjE3MzUzNWYyMTJkYjA4NzAw ZTkyOWJmN2U5YWJkYjM2Li5mYTg3NDExZmE2NTAyOTI0ZWNmMzMwOGVkMmQxYTFjOGUzOTI3NjU0 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jYWlyby9XaWRnZXRCYWNraW5n U3RvcmUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jYWlyby9XaWRnZXRCYWNraW5n U3RvcmUuaApAQCAtMjUsNiArMjUsOCBAQAogI2luY2x1ZGUgPHd0Zi9Ob25jb3B5YWJsZS5oPgog I2luY2x1ZGUgPHd0Zi9QYXNzT3duUHRyLmg+CiAKKyNpbmNsdWRlIDxjYWlyby5oPgorCiAjaWYg UExBVEZPUk0oR1RLKQogI2luY2x1ZGUgPGd0ay9ndGsuaD4KICNlbGlmIFBMQVRGT1JNKEVGTCkK 112684 2011-10-27 08:10:33 -0700 2011-12-22 11:05:38 -0800 Patch bug-70990-20111027131102.patch text/plain 1353 ivan U3VidmVyc2lvbiBSZXZpc2lvbjogOTg1NzAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAzMjk4MWM2YTU5Yjk0YmZi ODhlOTM2MDQ1Y2MxYTQzYjNiOGVjZjg3Li43NjU1ZWNjNWE0OGYzZDk5OGQ4Yzg1ZjIyZmRlY2E1 NTkwZjU3YzhjIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMTAtMjcgIEl2YW4g QnJpYW5vICA8aXZhbkBwcm9mdXNpb24ubW9iaT4KKworICAgICAgICBbRUZMXSBGaXggYnVpbGRp bmcgd2l0aCBHbGliIHN1cHBvcnQgZGlzYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTcwOTkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgV2hlbiBidWlsZGluZyB0aGUgRUZMIHBvcnQgd2l0aG91dCBH bGliIHN1cHBvcnQsIHRoZSBHVHlwZWRlZnMuaCBmaWxlCisgICAgICAgIGlzIG5vdCBpbmNsdWRl ZCBhbnl3aGVyZSBhbmQgaXQgcmVhY2hlcyB0aGlzIGhlYWRlciB1c2luZworICAgICAgICBjYWly b19zdXJmYWNlX3Qgd2l0aG91dCBldmVyIGRlZmluaW5nIGl0IGJlZm9yZS4KKworICAgICAgICAq IHBsYXRmb3JtL2NhaXJvL1dpZGdldEJhY2tpbmdTdG9yZS5oOiBBZGRlZCBpbmNsdWRlIGZvciBj YWlyby5oCisKIDIwMTEtMTAtMjcgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgog CiAgICAgICAgIFN0eWxlU2hlZXQucGFyZW50U3R5bGVTaGVldCBkb2VzIG5vdCB3b3JrLgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2Fpcm8vV2lkZ2V0QmFja2luZ1N0b3Jl LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jYWlyby9XaWRnZXRCYWNraW5nU3RvcmUuaApp bmRleCBlMzdlOTllNjE3MzUzNWYyMTJkYjA4NzAwZTkyOWJmN2U5YWJkYjM2Li41OGI0ZDcwN2Q2 ZTc2ZGZmYmQ2ODE3Y2U4NGUxMWY2NWYzNzJjOGZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9jYWlyby9XaWRnZXRCYWNraW5nU3RvcmUuaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9jYWlyby9XaWRnZXRCYWNraW5nU3RvcmUuaApAQCAtMjEsNiArMjEsNyBAQAog CiAjaW5jbHVkZSAiSW50UmVjdC5oIgogI2luY2x1ZGUgIkludFNpemUuaCIKKyNpbmNsdWRlIDxj YWlyby5oPgogI2luY2x1ZGUgPHd0Zi9GYXN0QWxsb2NCYXNlLmg+CiAjaW5jbHVkZSA8d3RmL05v bmNvcHlhYmxlLmg+CiAjaW5jbHVkZSA8d3RmL1Bhc3NPd25QdHIuaD4K 120344 2011-12-22 11:05:45 -0800 2011-12-23 02:06:11 -0800 Patch bug-70990-20111222170623.patch text/plain 1232 ivan U3VidmVyc2lvbiBSZXZpc2lvbjogMTAzNTQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWU2ODE0ZjE2MzBjYzhi MTU3ZmE4MTA0M2VkYjY3NTc4NjUwMjRiZC4uYmFkMGE5ZGVkN2E4MjA0YzM1NDFkOGE4YmRkY2Nm YWY1NTY0ZTg0OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDExLTEyLTIyICBJdmFu IEJyaWFubyAgPGl2YW5AcHJvZnVzaW9uLm1vYmk+CisKKyAgICAgICAgW0VGTF0gRml4IGJ1aWxk aW5nIHdpdGggR2xpYiBzdXBwb3J0IGRpc2FibGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MDk5MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEFkZCBmb3J3YXJkIGRlY2xhcmF0aW9uIGZvciBjYWlyb19z dXJmYWNlX3QsIG1pc3Npbmcgd2hlbiBidWlsZGluZworICAgICAgICB0aGUgRUZMIHBvcnQgd2l0 aCBHbGliIGRpc2FibGVkLgorCisgICAgICAgICogcGxhdGZvcm0vY2Fpcm8vV2lkZ2V0QmFja2lu Z1N0b3JlLmg6CisKIDIwMTEtMTItMjIgIE1hcml1c3ogR3J6ZWdvcmN6eWsgIDxtYXJpdXN6LmdA c2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VGTF0gTWlzc2luZyBwbHVnaW5zIHN1cHBvcnQgZm9y IGVmbCBwb3J0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jYWlyby9XaWRn ZXRCYWNraW5nU3RvcmUuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2NhaXJvL1dpZGdldEJh Y2tpbmdTdG9yZS5oCmluZGV4IDk4OTM4NjIzMzA0ZTRjNWM2OWJmODVmNjJmMjNhYTQwZjQxZDVl ZTguLjQyNWMyYjcxYWFkZjhlOTkyZWU5OGE3YzRiODY3ZGY3ZmYwOTlkZTYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2NhaXJvL1dpZGdldEJhY2tpbmdTdG9yZS5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2NhaXJvL1dpZGdldEJhY2tpbmdTdG9yZS5oCkBAIC0z MSw2ICszMSw4IEBACiAjaW5jbHVkZSA8RXZhcy5oPgogI2VuZGlmCiAKK3R5cGVkZWYgc3RydWN0 IF9jYWlyb19zdXJmYWNlIGNhaXJvX3N1cmZhY2VfdDsKKwogbmFtZXNwYWNlIFdlYkNvcmUgewog CiBjbGFzcyBXaWRnZXRCYWNraW5nU3RvcmVQcml2YXRlOwo=