70986 2011-10-26 18:32:22 -0700 Add ability to check for presence of static members at compile time 2011-10-27 10:38:43 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 70960 1 mhahnenberg mhahnenberg oldest_to_newest 491320 0 mhahnenberg 2011-10-26 18:32:22 -0700 With the imminent addition of methods from JSObject to the MethodTable, we now need to be able to determine whether or not a class has an implementation of a particular static function in order to properly fill in the MethodTable for classes that don't implement the function (i.e. classes that don't inherit directly or indirectly from JSObject). For classes that don't have an implementation of the method, we put a null pointer in the MethodTable. We can do this through the use of a macro-ized template taking advantage of SFINAE. 491326 1 112632 mhahnenberg 2011-10-26 19:06:51 -0700 Created attachment 112632 Patch 491608 2 112632 ggaren 2011-10-27 08:41:56 -0700 Comment on attachment 112632 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112632&action=review Two words: robot barf. > Source/JavaScriptCore/runtime/ClassInfo.h:65 > +struct MemberCheck##foo { \ Let's use "member" instead of "foo". 491703 3 mhahnenberg 2011-10-27 10:38:43 -0700 Committed r98601: <http://trac.webkit.org/changeset/98601> 112632 2011-10-26 19:06:51 -0700 2011-10-27 08:41:56 -0700 Patch bug-70986-20111026190650.patch text/plain 2164 mhahnenberg U3VidmVyc2lvbiBSZXZpc2lvbjogOTg1MjMKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGFh NjZhYTdiNmU0M2JjZGNmZTYzNWY1M2Q5YTg5NTM2ZTkxZDhiOTEuLmRjODc4YzJmZTg4NDc2YTMw Y2NhMTFmMzM0MjViMWEwYzU3N2UxMmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE4IEBACisyMDExLTEwLTI2ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBs ZS5jb20+CisKKyAgICAgICAgQWRkIGFiaWxpdHkgdG8gY2hlY2sgZm9yIHByZXNlbmNlIG9mIHN0 YXRpYyBtZW1iZXJzIGF0IGNvbXBpbGUgdGltZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzA5ODYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBZGRlZCBuZXcgQ1JFQVRFX01FTUJFUl9DSEVDS0VSIG1hY3Jv IHRvIGluc3RhbnRpYXRlIHRoZSB0ZW1wbGF0ZSBhbmQgdGhlIAorICAgICAgICBIQVNfTUVNQkVS X05BTUVEIG1hY3JvIHRvIHVzZSB0aGF0IHRlbXBsYXRlIHRvIGNoZWNrIGlmIHRoZSBzcGVjaWZp ZWQgY2xhc3MgCisgICAgICAgIGRvZXMgaW5kZWVkIGhhdmUgYSBtZXRob2Qgd2l0aCB0aGF0IG5h bWUuICBUaGlzIG1lY2hhbmlzbSBpcyBub3QgY3VycmVudGx5IAorICAgICAgICB1c2VkIGFueXdo ZXJlLCBidXQgd2lsbCBiZSBpbiB0aGUgZnV0dXJlIHdoZW4gYWRkaW5nIHZpcnR1YWwgbWV0aG9k cyBmcm9tIAorICAgICAgICBKU09iamVjdCB0byB0aGUgTWV0aG9kVGFibGUuCisKKyAgICAgICAg KiBydW50aW1lL0NsYXNzSW5mby5oOgorCiAyMDExLTEwLTI2ICBGaWxpcCBQaXpsbyAgPGZwaXps b0BhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjk3MDMwKTogQ2Fubm90IGxvZyBp biB0byBwcm9ncmVzc2l2ZS5jb20KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL0NsYXNzSW5mby5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ2xhc3NJ bmZvLmgKaW5kZXggYmZmZmQ3OGI1Nzc5NWNhMzdhNTU3OWM5NTc2ZWFmMjBlZGNiMWRmOS4uYjAy NGVhNWUzNjk3MGU2NzBjOWYwZjRjYTQ2M2MyODkxOWVhOTk2MiAxMDA2NDQKLS0tIGEvU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ2xhc3NJbmZvLmgKKysrIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvQ2xhc3NJbmZvLmgKQEAgLTYwLDYgKzYwLDI1IEBAIG5hbWVzcGFjZSBK U0MgewogICAgICAgICBHZXRPd25Qcm9wZXJ0eVNsb3RCeUluZGV4RnVuY3Rpb25QdHIgZ2V0T3du UHJvcGVydHlTbG90QnlJbmRleDsKICAgICB9OwogCisjZGVmaW5lIENSRUFURV9NRU1CRVJfQ0hF Q0tFUihmb28pIFwKK3RlbXBsYXRlIDx0eXBlbmFtZSBUPiBcCitzdHJ1Y3QgTWVtYmVyQ2hlY2sj I2ZvbyB7IFwKKyAgICBzdHJ1Y3QgRmFsbGJhY2sgeyBcCisgICAgICAgIHZvaWQgZm9vKC4uLik7 IFwKKyAgICB9OyBcCisgICAgc3RydWN0IERlcml2ZWQgOiBULCBGYWxsYmFjayB7IH07IFwKKyAg ICB0ZW1wbGF0ZSA8dHlwZW5hbWUgVSwgVT4gc3RydWN0IENoZWNrOyBcCisgICAgdHlwZWRlZiBj aGFyIFllc1syXTsgXAorICAgIHR5cGVkZWYgY2hhciBOb1sxXTsgXAorICAgIHRlbXBsYXRlIDx0 eXBlbmFtZSBVPiBcCisgICAgc3RhdGljIE5vICZmdW5jKENoZWNrPHZvaWQgKEZhbGxiYWNrOjoq KSguLi4pLCAmVTo6Zm9vPiopOyBcCisgICAgdGVtcGxhdGUgPHR5cGVuYW1lIFU+IFwKKyAgICBz dGF0aWMgWWVzICZmdW5jKC4uLik7IFwKKyAgICBlbnVtIHsgaGFzID0gc2l6ZW9mKGZ1bmM8RGVy aXZlZD4oMCkpID09IHNpemVvZihZZXMpIH07IFwKK30KKworI2RlZmluZSBIQVNfTUVNQkVSX05B TUVEKGtsYXNzLCBuYW1lKSAoTWVtYmVyQ2hlY2sjI25hbWU8a2xhc3M+OjpoYXMpCisKICNkZWZp bmUgQ1JFQVRFX01FVEhPRF9UQUJMRShDbGFzc05hbWUpIHsgXAogICAgICAgICAmQ2xhc3NOYW1l Ojp2aXNpdENoaWxkcmVuLCBcCiAgICAgICAgICZDbGFzc05hbWU6OmdldENhbGxEYXRhLCBcCg==