70970 2011-10-26 15:11:04 -0700 [Qt] Failure to build when QT_NO_MENU defined 2011-10-27 12:53:07 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 helder.correia webkit-unassigned webkit.review.bot oldest_to_newest 491212 0 helder.correia 2011-10-26 15:11:04 -0700 A preprocessor guard is necessary for static function iterateContextMenu(QMenu* menu) in DumpRenderTreeSupportQt.cpp (patch coming). 491237 1 112609 helder.correia 2011-10-26 15:50:33 -0700 Created attachment 112609 Patch 491467 2 112609 kling 2011-10-27 04:58:49 -0700 Comment on attachment 112609 Patch rs=me 491837 3 112609 webkit.review.bot 2011-10-27 12:53:04 -0700 Comment on attachment 112609 Patch Clearing flags on attachment: 112609 Committed r98619: <http://trac.webkit.org/changeset/98619> 491838 4 webkit.review.bot 2011-10-27 12:53:07 -0700 All reviewed patches have been landed. Closing bug. 112609 2011-10-26 15:50:33 -0700 2011-10-27 12:53:03 -0700 Patch menu.diff text/plain 1410 helder.correia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9x dC9DaGFuZ2VMb2cKaW5kZXggNzQyZmZlYy4uNzQ3MDQ0MSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9xdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxMS0xMC0yNiAgSGVsZGVyIENvcnJlaWEgIDxoZWxkZXIuY29ycmVpYUBw YWxtLmNvbT4KKworICAgICAgICBbUXRdIEZhaWx1cmUgdG8gYnVpbGQgd2hlbiBRVF9OT19NRU5V IGRlZmluZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTcwOTcwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg aXRlcmF0ZUNvbnRleHRNZW51KCkgbXVzdCBiZSB3cmFwcGVkIGFyb3VuZCAjaWZuZGVmIFFUX05P X01FTlUuCisKKyAgICAgICAgQnVpbGQgZml4LCBubyBuZXcgdGVzdHMuCisKKyAgICAgICAgKiBX ZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRRdC5jcHA6CisKIDIwMTEtMTAtMjYg IFphbGFuIEJ1anRhcyAgPHpidWp0YXNAZ21haWwuY29tPgogCiAgICAgICAgIE5hbWUgdmlld3Bv cnQgY2hhbmdlIGV2ZW50IGNvbnNpc3RlbnRseS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv cXQvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0UXQuY3BwIGIvU291cmNlL1dl YktpdC9xdC9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRRdC5jcHAKaW5kZXgg NGE1Y2FiNC4uYzFlMDM5MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3Vw cG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRRdC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9xdC9X ZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRRdC5jcHAKQEAgLTEwMzMsNiArMTAz Myw3IEBAIHZvaWQgRHVtcFJlbmRlclRyZWVTdXBwb3J0UXQ6OnNldEludGVyYWN0aXZlRm9ybVZh bGlkYXRpb25FbmFibGVkKFFXZWJQYWdlKiBwYWdlCiAgICAgICAgIGNvcmVQYWdlLT5zZXR0aW5n cygpLT5zZXRJbnRlcmFjdGl2ZUZvcm1WYWxpZGF0aW9uRW5hYmxlZChlbmFibGUpOwogfQogCisj aWZuZGVmIFFUX05PX01FTlUKIHN0YXRpYyBRU3RyaW5nTGlzdCBpdGVyYXRlQ29udGV4dE1lbnUo UU1lbnUqIG1lbnUpCiB7CiAgICAgaWYgKCFtZW51KQpAQCAtMTA1MCw2ICsxMDUxLDcgQEAgc3Rh dGljIFFTdHJpbmdMaXN0IGl0ZXJhdGVDb250ZXh0TWVudShRTWVudSogbWVudSkKICAgICB9CiAg ICAgcmV0dXJuIGl0ZW1zOwogfQorI2VuZGlmCiAKIFFTdHJpbmdMaXN0IER1bXBSZW5kZXJUcmVl U3VwcG9ydFF0Ojpjb250ZXh0TWVudShRV2ViUGFnZSogcGFnZSkKIHsK