<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>70954</bug_id>
          
          <creation_ts>2011-10-26 11:48:59 -0700</creation_ts>
          <short_desc>Embedded PDFs cannot be opened from Web archives</short_desc>
          <delta_ts>2011-11-02 15:25:57 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>PDF</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Alexey Proskuryakov">ap</reporter>
          <assigned_to name="Alexey Proskuryakov">ap</assigned_to>
          <cc>andersca</cc>
    
    <cc>darin</cc>
    
    <cc>japhet</cc>
    
    <cc>psolanki</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>491062</commentid>
    <comment_count>0</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2011-10-26 11:48:59 -0700</bug_when>
    <thetext>Archived resources don&apos;t have an HTTP status code.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>491067</commentid>
    <comment_count>1</comment_count>
      <attachid>112571</attachid>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2011-10-26 11:53:49 -0700</bug_when>
    <thetext>Created attachment 112571
proposed fix</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>491100</commentid>
    <comment_count>2</comment_count>
    <who name="Adam Roben (:aroben)">aroben</who>
    <bug_when>2011-10-26 12:28:48 -0700</bug_when>
    <thetext>The content of attachment 112571 has been deleted by
    Adam Roben (:aroben) &lt;aroben@apple.com&gt;
who provided the following reason:

Wrong patch

The token used to delete this attachment was generated at 2011-10-26 12:28:38 PST.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>491103</commentid>
    <comment_count>3</comment_count>
      <attachid>112578</attachid>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2011-10-26 12:41:13 -0700</bug_when>
    <thetext>Created attachment 112578
proposed fix</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>494922</commentid>
    <comment_count>4</comment_count>
      <attachid>112578</attachid>
    <who name="Oliver Hunt">oliver</who>
    <bug_when>2011-11-02 14:38:34 -0700</bug_when>
    <thetext>Comment on attachment 112578
proposed fix

Is it possible to have a test for this?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>494965</commentid>
    <comment_count>5</comment_count>
      <attachid>112578</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-11-02 15:25:07 -0700</bug_when>
    <thetext>Comment on attachment 112578
proposed fix

Clearing flags on attachment: 112578

Committed r99104: &lt;http://trac.webkit.org/changeset/99104&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>494966</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-11-02 15:25:11 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>494968</commentid>
    <comment_count>7</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2011-11-02 15:25:57 -0700</bug_when>
    <thetext>&gt; Is it possible to have a test for this?

Probably. Ideally, we would go over the many built-in PDF commits and add tests.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="0"
              isprivate="0"
          >
            <attachid>112571</attachid>
            <date>2011-10-26 11:53:49 -0700</date>
            <delta_ts>2011-10-26 11:53:49 -0700</delta_ts>
            <desc>proposed fix</desc>
            <filename>SaveAsInternal.txt</filename>
            <type>text/plain</type>
            <size>0</size>
            <attacher name="Alexey Proskuryakov">ap</attacher>
            
              <data encoding="base64"></data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>112578</attachid>
            <date>2011-10-26 12:41:13 -0700</date>
            <delta_ts>2011-11-02 15:25:07 -0700</delta_ts>
            <desc>proposed fix</desc>
            <filename>PDFWebArchive.txt</filename>
            <type>text/plain</type>
            <size>1737</size>
            <attacher name="Alexey Proskuryakov">ap</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk4NTA2KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMTAtMjYgIEFsZXhleSBQ
cm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgRW1lZGRlZCBQREZzIGNhbm5v
dCBiZSBvcGVuZWQgZnJvbSBXZWIgYXJjaGl2ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp
dC5vcmcvc2hvd19idWcuY2dpP2lkPTcwOTU0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ
IChPT1BTISkuCisKKyAgICAgICAgQnVpbHRJblBERlBsdWdpbiBkb2Vzbid0IGhhdmUgYWNjZXNz
IHRvIG9yaWdpbmFsIFJlc291cmNlUmVzcG9uc2UgYW5kIGhhcyB0byByZS1jcmVhdGUgaXQKKyAg
ICAgICAgSXQgZG9lc24ndCBzZWVtIHRvIGJlIHBvc3NpYmxlIHRvIGNyZWF0ZSBhbiBOU1VSTFJl
c3BvbnNlIHdpdGggYSBub24tbnVsbCBIVFRQIHN0YXR1cyBjb2RlLAorICAgICAgICBhbmQgTmV0
c2NhcGVQbHVnSW5TdHJlYW1Mb2FkZXIgYmVjb21lcyB1bmhhcHB5LgorCisgICAgICAgICogbG9h
ZGVyL05ldHNjYXBlUGx1Z0luU3RyZWFtTG9hZGVyLmNwcDogKFdlYkNvcmU6Ok5ldHNjYXBlUGx1
Z0luU3RyZWFtTG9hZGVyOjpkaWRSZWNlaXZlUmVzcG9uc2UpOgorICAgICAgICBBbGxvdyAwIHN0
YXR1cyBjb2RlLCBpdCdzIG5vdCBhIHJlYWwgZXJyb3IgdG8gaGF2ZSBvbmUgaW4gcmVzcG9uc2Uu
CisKIDIwMTEtMTAtMjUgIEFuZHkgRXN0ZXMgIDxhZXN0ZXNAYXBwbGUuY29tPgogCiAgICAgICAg
IFJFR1JFU1NJT04gKHI5MzEwOCk6IFNoYWRvdyBET00gbWVkaWEgY29udHJvbHMgY3JlYXRlZCBm
b3IgcGx1Zy1pbiBiYWNrZWQgbWVkaWEgZWxlbWVudHMuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9s
b2FkZXIvTmV0c2NhcGVQbHVnSW5TdHJlYW1Mb2FkZXIuY3BwCj09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj
ZS9XZWJDb3JlL2xvYWRlci9OZXRzY2FwZVBsdWdJblN0cmVhbUxvYWRlci5jcHAJKHJldmlzaW9u
IDk4NTAyKQorKysgU291cmNlL1dlYkNvcmUvbG9hZGVyL05ldHNjYXBlUGx1Z0luU3RyZWFtTG9h
ZGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtODcsOCArODcsOSBAQCB2b2lkIE5ldHNjYXBlUGx1
Z0luU3RyZWFtTG9hZGVyOjpkaWRSZWNlCiAgICAgCiAgICAgaWYgKG1fY2xpZW50LT53YW50c0Fs
bFN0cmVhbXMoKSkKICAgICAgICAgcmV0dXJuOwotICAgIAotICAgIGlmIChyZXNwb25zZS5odHRw
U3RhdHVzQ29kZSgpIDwgMTAwIHx8IHJlc3BvbnNlLmh0dHBTdGF0dXNDb2RlKCkgPj0gNDAwKQor
CisgICAgLy8gU3RhdHVzIGNvZGUgY2FuIGJlIG51bGwgd2hlbiBzZXJ2aW5nIGZyb20gYSBXZWIg
YXJjaGl2ZS4KKyAgICBpZiAocmVzcG9uc2UuaHR0cFN0YXR1c0NvZGUoKSAmJiAocmVzcG9uc2Uu
aHR0cFN0YXR1c0NvZGUoKSA8IDEwMCB8fCByZXNwb25zZS5odHRwU3RhdHVzQ29kZSgpID49IDQw
MCkpCiAgICAgICAgIGNhbmNlbChmcmFtZUxvYWRlcigpLT5jbGllbnQoKS0+ZmlsZURvZXNOb3RF
eGlzdEVycm9yKHJlc3BvbnNlKSk7CiB9CiAK
</data>

          </attachment>
      

    </bug>

</bugzilla>