70953 crbug.com/101665 2011-10-26 11:44:04 -0700 Chromium ui_tests WorkerTest.WorkerMessagePort[GC] were broken by https://bugs.webkit.org/attachment.cgi?id=112342 2011-10-27 15:40:22 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) All All RESOLVED FIXED http://crbug.com/101665 P2 Normal --- 0 dmichael webkit-unassigned dslomov levin webkit.review.bot oldest_to_newest 491058 0 dmichael 2011-10-26 11:44:04 -0700 In http://trac.webkit.org/changeset/98381, I changed PlatformMessagePortChannel::hasPendingActivity thusly: bool PlatformMessagePortChannel::hasPendingActivity() { MutexLocker lock(m_mutex); - return m_localPort; + return m_localPort && m_localPort->hasPendingActivity(); } I suspect the new code is 'right' (in that I think it provides the originally _intended_ behavior), but existing code elsewhere must depend on the previous behavior. I'm planning to undo this part of CS 98381, and hoping that somebody else more familiar with existing PlatformMessagePortChannels can fix the problem with this function and its caller(s) (if there is a problem). 491068 1 112572 dmichael 2011-10-26 11:53:52 -0700 Created attachment 112572 Patch 491071 2 dmichael 2011-10-26 11:55:45 -0700 I verified locally that these ui tests pass with this change. 491072 3 112572 levin 2011-10-26 11:55:52 -0700 Comment on attachment 112572 Patch hmm. I missed that change somehow. It is best not to do unrelated changes in your patch and it is also good to explain why a change was necessary in the changelog where the function is listed. I should have mentioned this in your previous change. 491073 4 levin 2011-10-26 11:57:27 -0700 Please re-enable the disabled tests where this gets into chromium. (Also for changes of this sort, there should be some test to verify that the change is correct and stays in place, but that was for the last patch.) 491538 5 112572 webkit.review.bot 2011-10-27 07:03:47 -0700 Comment on attachment 112572 Patch Clearing flags on attachment: 112572 Committed r98566: <http://trac.webkit.org/changeset/98566> 491539 6 webkit.review.bot 2011-10-27 07:03:51 -0700 All reviewed patches have been landed. Closing bug. 112572 2011-10-26 11:53:52 -0700 2011-10-27 07:03:47 -0700 Patch bug-70953-20111026125351.patch text/plain 1552 dmichael U3VidmVyc2lvbiBSZXZpc2lvbjogOTgzODEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg ODAzODA5Yzc2MGIyMjY2Njg0MjMzZDQ4MGY0ZjlkYzZjNDgyMjFlOS4uODYzZmI2MDQzMDM5ODM2 NDFmMmNjMGZmNDUwMDdhMDEyZjg2MWM4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxMyBAQAorMjAxMS0xMC0yNiAgRGF2ZSBNaWNoYWVsICA8ZG1pY2hhZWxAY2hyb21p dW0ub3JnPgorCisgICAgICAgIENocm9taXVtIHVpX3Rlc3RzIFdvcmtlclRlc3QuV29ya2VyTWVz c2FnZVBvcnRbR0NdIHdlcmUgYnJva2VuIGJ5IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL2F0dGFj aG1lbnQuY2dpP2lkPTExMjM0MgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NzA5NTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIHNyYy9QbGF0Zm9ybU1lc3NhZ2VQb3J0Q2hhbm5lbC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpQbGF0Zm9ybU1lc3NhZ2VQb3J0Q2hhbm5lbDo6aGFzUGVuZGluZ0FjdGl2aXR5 KToKKwogMjAxMS0xMC0yNSAgRGF2ZSBNaWNoYWVsICA8ZG1pY2hhZWxAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIE1ha2UgaXQgcG9zc2libGUgdG8gY3JlYXRlIGFuZCBkaXNwYXRjaCBhIG1lc3Nh Z2UgZXZlbnQgdGhyb3VnaCBjaHJvbWl1bSBBUEkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vc3JjL1BsYXRmb3JtTWVzc2FnZVBvcnRDaGFubmVsLmNwcCBiL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vc3JjL1BsYXRmb3JtTWVzc2FnZVBvcnRDaGFubmVsLmNwcAppbmRleCBkOTFm Zjk0N2Q2YTYyNWIwY2NhNjMzZjFhMWMzNWM4NTc0OGU2YjE4Li5iYTIxMjlmZTFkYzViNTNiMmUw NGQ1MTliZjNjMDUxMTQ1NjVmNTc5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3NyYy9QbGF0Zm9ybU1lc3NhZ2VQb3J0Q2hhbm5lbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9zcmMvUGxhdGZvcm1NZXNzYWdlUG9ydENoYW5uZWwuY3BwCkBAIC0yMzYsNyArMjM2 LDcgQEAgYm9vbCBQbGF0Zm9ybU1lc3NhZ2VQb3J0Q2hhbm5lbDo6aXNDb25uZWN0ZWRUbyhNZXNz YWdlUG9ydCogcG9ydCkKIGJvb2wgUGxhdGZvcm1NZXNzYWdlUG9ydENoYW5uZWw6Omhhc1BlbmRp bmdBY3Rpdml0eSgpCiB7CiAgICAgTXV0ZXhMb2NrZXIgbG9jayhtX211dGV4KTsKLSAgICByZXR1 cm4gbV9sb2NhbFBvcnQgJiYgbV9sb2NhbFBvcnQtPmhhc1BlbmRpbmdBY3Rpdml0eSgpOworICAg IHJldHVybiBtX2xvY2FsUG9ydDsKIH0KIAogdm9pZCBQbGF0Zm9ybU1lc3NhZ2VQb3J0Q2hhbm5l bDo6c2V0RW50YW5nbGVkQ2hhbm5lbChQYXNzUmVmUHRyPFBsYXRmb3JtTWVzc2FnZVBvcnRDaGFu bmVsPiByZW1vdGUpCg==