70943 2011-10-26 10:52:51 -0700 WebKit2 should respect WebKitOmitPDFSupport preference on the Mac 2011-10-28 16:04:35 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Mac All RESOLVED FIXED InRadar P2 Normal --- 1 jeffm jeffm ap aroben jeffm webkit-bug-importer oldest_to_newest 491010 0 jeffm 2011-10-26 10:52:51 -0700 This is a regression from WebKit1. 491011 1 jeffm 2011-10-26 10:53:05 -0700 <rdar://problem/10333309> REGRESSION: WebKitOmitPDFSupport default lost in WebKit2 491015 2 112565 jeffm 2011-10-26 10:58:14 -0700 Created attachment 112565 Patch 491038 3 112565 ap 2011-10-26 11:32:13 -0700 Comment on attachment 112565 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112565&action=review > Source/WebKit2/ChangeLog:6 > + Don't register built-in PDF plugin if WebKitOmitPDFSupport pref is set. This explanation is slightly misleading, as the patch disables both the new "plug-in" for subframes and the PDFKit-based support for main frame only. 491136 4 jeffm 2011-10-26 13:19:26 -0700 Committed r98513: <http://trac.webkit.org/changeset/98513> 492698 5 ap 2011-10-28 14:53:57 -0700 There is also PDF code in WebContext::platformInitializeWebProcess. Should that be conditional, too? 492745 6 jeffm 2011-10-28 15:59:12 -0700 (In reply to comment #5) > There is also PDF code in WebContext::platformInitializeWebProcess. Should that be conditional, too? Probably, although PDF viewing seems to be disabled with just r98513. I'll file another bug to fix this. 492753 7 jeffm 2011-10-28 16:04:35 -0700 (In reply to comment #6) > (In reply to comment #5) > > There is also PDF code in WebContext::platformInitializeWebProcess. Should that be conditional, too? > > Probably, although PDF viewing seems to be disabled with just r98513. I'll file another bug to fix this. Tracked by bug 71156. 112565 2011-10-26 10:58:14 -0700 2011-10-26 11:32:13 -0700 Patch bug-70943-20111026105810.patch text/plain 3389 jeffm SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDk4NTAwKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTEtMTAtMjYgIEplZmYgTWls bGVyICA8amVmZm1AYXBwbGUuY29tPgorCisgICAgICAgIFdlYktpdDIgc2hvdWxkIHJlc3BlY3Qg c2VjcmV0IFdlYktpdE9taXRQREZTdXBwb3J0IHByZWZlcmVuY2Ugb24gdGhlIE1hYworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzA5NDMKKyAgICAgICAg CisgICAgICAgIERvbid0IHJlZ2lzdGVyIGJ1aWx0LWluIFBERiBwbHVnaW4gaWYgV2ViS2l0T21p dFBERlN1cHBvcnQgcHJlZiBpcyBzZXQuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViQ29udGV4dC5jcHA6CisgICAgICAgIChX ZWJLaXQ6OldlYkNvbnRleHQ6OmdldFBsdWdpbnMpOiBEb24ndCByZWdpc3RlciBidWlsdC1pbiBQ REYgcGx1Z2luIGlmIFdlYktpdE9taXRQREZTdXBwb3J0IHByZWYgaXMgc2V0LgorICAgICAgICAK KyAgICAgICAgKiBVSVByb2Nlc3MvV2ViQ29udGV4dC5oOiBBZGRlZCBvbWl0UERGU3VwcG9ydCgp LgorICAgICAgICAKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViRnJhbWVQcm94eS5jcHA6CisgICAg ICAgIChXZWJLaXQ6OldlYkZyYW1lUHJveHk6OmNhblNob3dNSU1FVHlwZSk6IERvbid0IHNob3cg UERGcyBpZiBXZWJLaXRPbWl0UERGU3VwcG9ydCBpcyBzZXQuCisgICAgICAgIAorICAgICAgICAq IFVJUHJvY2Vzcy9tYWMvV2ViQ29udGV4dE1hYy5tbToKKyAgICAgICAgKFdlYktpdDo6V2ViQ29u dGV4dDo6b21pdFBERlN1cHBvcnQpOiBBZGRlZC4KKwogMjAxMS0xMC0yNiAgQWxlamFuZHJvIEcu IENhc3RybyAgPGFsZXhAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBbV0syXSBBZGQgV2Vi S2l0MiBkaXN0Y2hlY2sgc3VwcG9ydApJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dl YkNvbnRleHQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJD b250ZXh0LmNwcAkocmV2aXNpb24gOTg0ODApCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv V2ViQ29udGV4dC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU2OCw3ICs1NjgsOCBAQCB2b2lkIFdl YkNvbnRleHQ6OmdldFBsdWdpbnMoYm9vbCByZWZyZXNoCiAKICNpZiBQTEFURk9STShNQUMpCiAg ICAgLy8gQWRkIGJ1aWx0LWluIFBERiBsYXN0LCBzbyB0aGF0IGl0J3Mgbm90IHVzZWQgd2hlbiBh IHJlYWwgcGx1Zy1pbiBpcyBpbnN0YWxsZWQuCi0gICAgcGx1Z2luSW5mb3MuYXBwZW5kKEJ1aWx0 SW5QREZWaWV3OjpwbHVnaW5JbmZvKCkpOworICAgIGlmICghb21pdFBERlN1cHBvcnQoKSkKKyAg ICAgICAgcGx1Z2luSW5mb3MuYXBwZW5kKEJ1aWx0SW5QREZWaWV3OjpwbHVnaW5JbmZvKCkpOwog I2VuZGlmCiB9CiAKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJDb250ZXh0LmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkNvbnRleHQuaAkocmV2 aXNpb24gOTg0ODApCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViQ29udGV4dC5oCSh3 b3JraW5nIGNvcHkpCkBAIC0xODQsNiArMTg0LDEwIEBAIHB1YmxpYzoKICAgICB2b2lkIGdldFdl YkNvcmVTdGF0aXN0aWNzKFBhc3NSZWZQdHI8RGljdGlvbmFyeUNhbGxiYWNrPik7CiAgICAgdm9p ZCBnYXJiYWdlQ29sbGVjdEphdmFTY3JpcHRPYmplY3RzKCk7CiAKKyNpZiBQTEFURk9STShNQUMp CisgICAgc3RhdGljIGJvb2wgb21pdFBERlN1cHBvcnQoKTsKKyNlbmRpZgorCiBwcml2YXRlOgog ICAgIFdlYkNvbnRleHQoUHJvY2Vzc01vZGVsLCBjb25zdCBTdHJpbmcmIGluamVjdGVkQnVuZGxl UGF0aCk7CiAKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJGcmFtZVByb3h5LmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViRnJhbWVQcm94eS5j cHAJKHJldmlzaW9uIDk4NDgwKQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkZyYW1l UHJveHkuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMTEsNyArMTExLDcgQEAgYm9vbCBXZWJGcmFt ZVByb3h5OjpjYW5TaG93TUlNRVR5cGUoY29ucwogI2lmIFBMQVRGT1JNKE1BQykKICAgICAvLyBP biBNYWMsIHdlIGNhbiBzaG93IFBERnMuCiAgICAgaWYgKCFtaW1lVHlwZS5pc0VtcHR5KCkpCi0g ICAgICAgIHJldHVybiBXZWJDb250ZXh0OjpwZGZBbmRQb3N0U2NyaXB0TUlNRVR5cGVzKCkuY29u dGFpbnMobWltZVR5cGUpOworICAgICAgICByZXR1cm4gV2ViQ29udGV4dDo6cGRmQW5kUG9zdFNj cmlwdE1JTUVUeXBlcygpLmNvbnRhaW5zKG1pbWVUeXBlKSAmJiAhV2ViQ29udGV4dDo6b21pdFBE RlN1cHBvcnQoKTsKICNlbmRpZgogCiAgICAgcmV0dXJuIGZhbHNlOwpJbmRleDogU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL21hYy9XZWJDb250ZXh0TWFjLm1tCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV2ViQ29udGV4dE1hYy5tbQkocmV2aXNpb24gOTg0ODAp CisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dlYkNvbnRleHRNYWMubW0JKHdvcmtp bmcgY29weSkKQEAgLTEzOSw1ICsxMzksMTEgQEAgU3RyaW5nIFdlYkNvbnRleHQ6OnBsYXRmb3Jt RGVmYXVsdExvY2FsUwogICAgIHJldHVybiBbbG9jYWxTdG9yYWdlRGlyZWN0b3J5IHN0cmluZ0J5 U3RhbmRhcmRpemluZ1BhdGhdOwogfQogCitib29sIFdlYkNvbnRleHQ6Om9taXRQREZTdXBwb3J0 KCkKK3sKKyAgICAvLyBTaW5jZSB0aGlzIGlzIGEgInNlY3JldCBkZWZhdWx0IiB3ZSBkb24ndCBi b3RoZXIgcmVnaXN0ZXJpbmcgaXQuCisgICAgcmV0dXJuIFtbTlNVc2VyRGVmYXVsdHMgc3RhbmRh cmRVc2VyRGVmYXVsdHNdIGJvb2xGb3JLZXk6QCJXZWJLaXRPbWl0UERGU3VwcG9ydCJdOworfQor CiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQKIAo=