70941 2011-10-26 10:20:21 -0700 make lion observe MAC lines in test_expectations.txt 2011-10-27 06:36:17 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac OS X 10.7 RESOLVED FIXED P2 Normal --- 1 epoger epoger abarth ojan webkit.review.bot oldest_to_newest 490986 0 epoger 2011-10-26 10:20:21 -0700 Right now, if you run NRWT on a Lion machine, it doesn't know to observe text_expectations lines marked with MAC. 491004 1 112563 epoger 2011-10-26 10:41:21 -0700 Created attachment 112563 Patch 491101 2 epoger 2011-10-26 12:30:12 -0700 abarth or ojan, please review 491120 3 112563 ojan 2011-10-26 13:01:27 -0700 Comment on attachment 112563 Patch At some point you'll also need to update the flakiness dashboard to handle lion variants. See Tools/TestsResultsServer/static-dashboards. 491524 4 112563 webkit.review.bot 2011-10-27 06:36:13 -0700 Comment on attachment 112563 Patch Clearing flags on attachment: 112563 Committed r98564: <http://trac.webkit.org/changeset/98564> 491526 5 webkit.review.bot 2011-10-27 06:36:17 -0700 All reviewed patches have been landed. Closing bug. 112563 2011-10-26 10:41:21 -0700 2011-10-27 06:36:12 -0700 Patch bug-70941-20111026134120.patch text/plain 3137 epoger SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDk4NDg4KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTMgQEAKKzIwMTEtMTAtMjYgIEVsbGlvdCBQb2dlciAgPGVwb2dlckBnb29nbGUuY29tPgor CisgICAgICAgIG1ha2UgbGlvbiBvYnNlcnZlIE1BQyBsaW5lcyBpbiB0ZXN0X2V4cGVjdGF0aW9u cy50eHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcw OTQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBT Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtLnB5OgorICAgICAgICAq IFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fdW5pdHRlc3QucHk6 CisKIDIwMTEtMTAtMjYgIFNpbW9uIEhhdXNtYW5uICA8c2ltb24uaGF1c21hbm5Abm9raWEuY29t PgogCiAgICAgICAgIFtRdF1bV0syXSBGaXggZmFpbGluZyBhc3NlcnRpb24gb24gc3RhcnR1cCBv ZiBNaW5pQnJvd3NlciAtdG91Y2guCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91 dF90ZXN0cy9wb3J0L2Nocm9taXVtLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW0ucHkJKHJldmlzaW9uIDk4NDg4KQorKysg VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bS5weQkod29y a2luZyBjb3B5KQpAQCAtNzEsMTkgKzcxLDE5IEBAIGNsYXNzIENocm9taXVtUG9ydChQb3J0KToK ICAgICAgICAgKCdsdWNpZCcsICd4ODZfNjQnKSkKIAogICAgIEFMTF9HUkFQSElDU19UWVBFUyA9 ICgnY3B1JywgJ2dwdScpCi0gICAgQ09SRV9HUkFQSElDU19WRVJTSU9OUyA9ICgnbGVvcGFyZCcs ICdzbm93bGVvcGFyZCcpCisgICAgQ09SRV9HUkFQSElDU19WRVJTSU9OUyA9ICgnbGVvcGFyZCcs ICdzbm93bGVvcGFyZCcsICdsaW9uJykKICAgICBDT1JFX0dSQVBISUNTX1RZUEVTID0gKCdjcHUt Y2cnLCAnZ3B1LWNnJykKIAogICAgIEFMTF9CQVNFTElORV9WQVJJQU5UUyA9IFsKLSAgICAgICAg J2Nocm9taXVtLW1hYy1zbm93bGVvcGFyZCcsICdjaHJvbWl1bS1tYWMtbGVvcGFyZCcsCi0gICAg ICAgICdjaHJvbWl1bS1jZy1tYWMtc25vd2xlb3BhcmQnLCAnY2hyb21pdW0tY2ctbWFjLWxlb3Bh cmQnLAorICAgICAgICAnY2hyb21pdW0tbWFjLWxpb24nLCAnY2hyb21pdW0tbWFjLXNub3dsZW9w YXJkJywgJ2Nocm9taXVtLW1hYy1sZW9wYXJkJywKKyAgICAgICAgJ2Nocm9taXVtLWNnLW1hYy1s aW9uJywgJ2Nocm9taXVtLWNnLW1hYy1zbm93bGVvcGFyZCcsICdjaHJvbWl1bS1jZy1tYWMtbGVv cGFyZCcsCiAgICAgICAgICdjaHJvbWl1bS13aW4td2luNycsICdjaHJvbWl1bS13aW4tdmlzdGEn LCAnY2hyb21pdW0td2luLXhwJywKICAgICAgICAgJ2Nocm9taXVtLWxpbnV4LXg4Nl82NCcsICdj aHJvbWl1bS1saW51eC14ODYnLAogICAgICAgICAnY2hyb21pdW0tZ3B1LW1hYy1zbm93bGVvcGFy ZCcsICdjaHJvbWl1bS1ncHUtd2luLXdpbjcnLCAnY2hyb21pdW0tZ3B1LWxpbnV4LXg4Nl82NCcs CiAgICAgXQogCiAgICAgQ09ORklHVVJBVElPTl9TUEVDSUZJRVJfTUFDUk9TID0gewotICAgICAg ICAnbWFjJzogWydsZW9wYXJkJywgJ3Nub3dsZW9wYXJkJ10sCisgICAgICAgICdtYWMnOiBbJ2xl b3BhcmQnLCAnc25vd2xlb3BhcmQnLCAnbGlvbiddLAogICAgICAgICAnd2luJzogWyd4cCcsICd2 aXN0YScsICd3aW43J10sCiAgICAgICAgICdsaW51eCc6IFsnbHVjaWQnXSwKICAgICB9CkluZGV4 OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX3VuaXR0 ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L3BvcnQvY2hyb21pdW1fdW5pdHRlc3QucHkJKHJldmlzaW9uIDk4NDg4KQorKysgVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV91bml0dGVzdC5weQkod29y a2luZyBjb3B5KQpAQCAtMTQyLDggKzE0MiwxMiBAQCBjbGFzcyBDaHJvbWl1bVBvcnRUZXN0KHBv cnRfdGVzdGNhc2UuUG9yCiAgICAgICAgICAgICBUZXN0Q29uZmlndXJhdGlvbignc25vd2xlb3Bh cmQnLCAneDg2JywgJ3JlbGVhc2UnLCAnZ3B1LWNnJyksCiAgICAgICAgICAgICBUZXN0Q29uZmln dXJhdGlvbignbGlvbicsICd4ODYnLCAnZGVidWcnLCAnY3B1JyksCiAgICAgICAgICAgICBUZXN0 Q29uZmlndXJhdGlvbignbGlvbicsICd4ODYnLCAnZGVidWcnLCAnZ3B1JyksCisgICAgICAgICAg ICBUZXN0Q29uZmlndXJhdGlvbignbGlvbicsICd4ODYnLCAnZGVidWcnLCAnY3B1LWNnJyksCisg ICAgICAgICAgICBUZXN0Q29uZmlndXJhdGlvbignbGlvbicsICd4ODYnLCAnZGVidWcnLCAnZ3B1 LWNnJyksCiAgICAgICAgICAgICBUZXN0Q29uZmlndXJhdGlvbignbGlvbicsICd4ODYnLCAncmVs ZWFzZScsICdjcHUnKSwKICAgICAgICAgICAgIFRlc3RDb25maWd1cmF0aW9uKCdsaW9uJywgJ3g4 NicsICdyZWxlYXNlJywgJ2dwdScpLAorICAgICAgICAgICAgVGVzdENvbmZpZ3VyYXRpb24oJ2xp b24nLCAneDg2JywgJ3JlbGVhc2UnLCAnY3B1LWNnJyksCisgICAgICAgICAgICBUZXN0Q29uZmln dXJhdGlvbignbGlvbicsICd4ODYnLCAncmVsZWFzZScsICdncHUtY2cnKSwKICAgICAgICAgICAg IFRlc3RDb25maWd1cmF0aW9uKCd4cCcsICd4ODYnLCAnZGVidWcnLCAnY3B1JyksCiAgICAgICAg ICAgICBUZXN0Q29uZmlndXJhdGlvbigneHAnLCAneDg2JywgJ2RlYnVnJywgJ2dwdScpLAogICAg ICAgICAgICAgVGVzdENvbmZpZ3VyYXRpb24oJ3hwJywgJ3g4NicsICdyZWxlYXNlJywgJ2NwdScp LAo=