70912 2011-10-26 06:01:26 -0700 [NRWT] Parsing of test_expectations.txt should be agnostic to newline at end 2011-11-07 13:21:37 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 64491 1 kbalazs webkit-unassigned abarth bank dpranke kkristof ojan ossy webkit.review.bot oldest_to_newest 490776 0 kbalazs 2011-10-26 06:01:26 -0700 I tried this: diff --git a/LayoutTests/platform/qt/Skipped b/LayoutTests/platform/qt/Skipped index ecc5470..587a69f 100644 --- a/LayoutTests/platform/qt/Skipped +++ b/LayoutTests/platform/qt/Skipped @@ -2440,9 +2440,9 @@ http/tests/inspector/resource-tree/resource-tree-non-unique-url.html # inspector/cookie-parser.html is a flaky crash # https://bugs.webkit.org/show_bug.cgi?id=62662 -inspector/cookie-parser.html -inspector/cookie-resource-match.html -inspector/evaluate-in-page.html +#inspector/cookie-parser.html +#inspector/cookie-resource-match.html +#inspector/evaluate-in-page.html # [Qt] Assertion fail in CSSPrimitiveValue ctor # https://bugs.webkit.org/show_bug.cgi?id=69933 diff --git a/LayoutTests/platform/qt/test_expectations.txt b/LayoutTests/platform/qt/test_expectations.txt index 8dd25f3..6173e9c 100644 --- a/LayoutTests/platform/qt/test_expectations.txt +++ b/LayoutTests/platform/qt/test_expectations.txt @@ -23,3 +23,4 @@ BUGWK67007 DEBUG : fast/ruby/after-block-doesnt-crash.html = CRASH BUGWK67007 DEBUG : fast/ruby/after-table-doesnt-crash.html = CRASH BUGWK67007 DEBUG : fast/ruby/generated-after-counter-doesnt-crash.html = CRASH BUGWK67007 DEBUG : fast/ruby/generated-before-and-after-counter-doesnt-crash.html = CRASH +BUGWK62662 DEBUG : inspector/cookie-parser.html = CRASH And the results is quite strange to me: balazs@kbsuse:~/master_clean> Tools/Scripts/run-webkit-tests --results-directory _tst --no-show-results --no-http Running new-run-webkit-tests with one child process. For more parallelism, run new-run-webkit-tests directly. FAILURES FOR <linux, x86, release, cpu> Line:26 Extraneous ':' BUGWK67007 DEBUG : inspector/cookie-parser.html = CRASHBUG_SKIPPED SKIP : fast/repaint/block-selection-gap-stale-cache.html = FAIL Traceback (most recent call last): File "/home/balazs/master_clean/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 445, in <module> sys.exit(main()) File "/home/balazs/master_clean/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 440, in main return run(port, options, args) File "/home/balazs/master_clean/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 103, in run manager.parse_expectations() File "/home/balazs/master_clean/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 386, in parse_expectations port.test_expectations_overrides()) File "/home/balazs/master_clean/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py", line 709, in __init__ self._report_errors() File "/home/balazs/master_clean/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py", line 794, in _report_errors raise ParseError(fatal=True, errors=errors) webkitpy.layout_tests.models.test_expectations.ParseError: Line:26 Extraneous ':' BUGWK67007 DEBUG : inspector/cookie-parser.html = CRASHBUG_SKIPPED SKIP : fast/repaint/block-selection-gap-stale-cache.html = FAIL Seems like an NRWT bug. 490862 1 kbalazs 2011-10-26 08:31:48 -0700 Ok, I did not add a new line, sorry for the noise :) BTW, don't you think we should check the expectations file for new line at the end and die with a nice error message if it doesn't have it? 496123 2 113638 bank 2011-11-04 02:14:44 -0700 Created attachment 113638 proposed fix 496156 3 kbalazs 2011-11-04 05:06:38 -0700 As discussed with Balazs I renamed the bug title to be consistent with the patch. Balazs, please reupload the patch with a new changelog. 496159 4 113648 bank 2011-11-04 05:16:05 -0700 Created attachment 113648 proposed fix 496248 5 113648 abarth 2011-11-04 10:01:09 -0700 Comment on attachment 113648 proposed fix Seems reasonable, but we need a test. 497107 6 113852 bank 2011-11-07 05:54:26 -0800 Created attachment 113852 proposed fix 497218 7 113852 ojan 2011-11-07 09:02:55 -0800 Comment on attachment 113852 proposed fix Would be nicer to make all the test expectations files not require a newline, but this is fine. 497420 8 113852 webkit.review.bot 2011-11-07 13:20:28 -0800 Comment on attachment 113852 proposed fix Clearing flags on attachment: 113852 Committed r99469: <http://trac.webkit.org/changeset/99469> 497421 9 webkit.review.bot 2011-11-07 13:20:33 -0800 All reviewed patches have been landed. Closing bug. 497423 10 113852 eric 2011-11-07 13:21:37 -0800 Comment on attachment 113852 proposed fix Yeah, making it not required would have been a better fix, but OK. 113638 2011-11-04 02:14:44 -0700 2011-11-04 05:16:05 -0700 proposed fix 1.patch text/plain 1369 bank ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmY2I4 MjJjLi4xMDBhZWVmIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMTEtMDQgIEJhbGF6cyBBbmtlcyAgPEFua2Vz LkJhbGF6c0BzdHVkLnUtc3plZ2VkLmh1PgorCisgICAgICAgIFtOUldUXSBObyBuZXdsaW5lIGF0 IGFuZCBvZiB0ZXN0X2V4cGVjdGF0aW9ucy50eHQgc2hvdWxkIHJlc3VsdCBpbiBlcnJvciBtZXNz YWdlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MDkx MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2Ny aXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJraXQucHk6IEFkZCBuZXdsaW5lIGF0 IHRoZSBlbmQgb2YgdGVzdF9leHBlY3RhdGlvbnMudHh0LgorCiAyMDExLTExLTAxICBTYW0gV2Vp bmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgcmVzb2x2ZS1DaGFuZ2VMb2dzIC0taGVs cCBzaG91bGQgYmUgZmFzdGVyLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9s YXlvdXRfdGVzdHMvcG9ydC93ZWJraXQucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91 dF90ZXN0cy9wb3J0L3dlYmtpdC5weQppbmRleCAyNDhiNDMwLi45MWI0ZTMwIDEwMDY0NAotLS0g YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdC5weQorKysg Yi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdC5weQpAQCAt MzQ4LDcgKzM0OCw3IEBAIGNsYXNzIFdlYktpdFBvcnQoUG9ydCk6CiAgICAgICAgIGV4cGVjdGF0 aW9uc19wYXRoID0gc2VsZi5wYXRoX3RvX3Rlc3RfZXhwZWN0YXRpb25zX2ZpbGUoKQogICAgICAg ICBpZiBzZWxmLl9maWxlc3lzdGVtLmV4aXN0cyhleHBlY3RhdGlvbnNfcGF0aCk6CiAgICAgICAg ICAgICBfbG9nLmRlYnVnKCJVc2luZyB0ZXN0X2V4cGVjdGF0aW9ucy50eHQ6ICVzIiAlIGV4cGVj dGF0aW9uc19wYXRoKQotICAgICAgICAgICAgZXhwZWN0YXRpb25zID0gc2VsZi5fZmlsZXN5c3Rl bS5yZWFkX3RleHRfZmlsZShleHBlY3RhdGlvbnNfcGF0aCkgKyBleHBlY3RhdGlvbnMKKyAgICAg ICAgICAgIGV4cGVjdGF0aW9ucyA9IHNlbGYuX2ZpbGVzeXN0ZW0ucmVhZF90ZXh0X2ZpbGUoZXhw ZWN0YXRpb25zX3BhdGgpICsgJ1xuJyArIGV4cGVjdGF0aW9ucwogICAgICAgICByZXR1cm4gZXhw ZWN0YXRpb25zCiAKICAgICBkZWYgX3NraXBwZWRfbGlzdF9hc19leHBlY3RhdGlvbnMoc2VsZik6 Cg== 113648 2011-11-04 05:16:05 -0700 2011-11-07 05:54:26 -0800 proposed fix 1103.patch text/plain 1365 bank ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmY2I4 MjJjLi41NGE1MGVmIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMTEtMDQgIEJhbGF6cyBBbmtlcyAgPEFua2Vz LkJhbGF6c0BzdHVkLnUtc3plZ2VkLmh1PgorCisgICAgICAgIFtOUldUXSBQYXJzaW5nIG9mIHRl c3RfZXhwZWN0YXRpb25zLnR4dCBzaG91bGQgYmUgYWdub3N0aWMgdG8gbmV3bGluZSBhdCBlbmQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcwOTEyCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdC5weTogQWRkIG5ld2xpbmUgYXQgdGhl IGVuZCBvZiB0ZXN0X2V4cGVjdGF0aW9ucy50eHQuCisKIDIwMTEtMTEtMDEgIFNhbSBXZWluaWcg IDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICByZXNvbHZlLUNoYW5nZUxvZ3MgLS1oZWxwIHNo b3VsZCBiZSBmYXN0ZXIuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91 dF90ZXN0cy9wb3J0L3dlYmtpdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL3BvcnQvd2Via2l0LnB5CmluZGV4IDI0OGI0MzAuLjkxYjRlMzAgMTAwNjQ0Ci0tLSBhL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2Via2l0LnB5CisrKyBiL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2Via2l0LnB5CkBAIC0zNDgs NyArMzQ4LDcgQEAgY2xhc3MgV2ViS2l0UG9ydChQb3J0KToKICAgICAgICAgZXhwZWN0YXRpb25z X3BhdGggPSBzZWxmLnBhdGhfdG9fdGVzdF9leHBlY3RhdGlvbnNfZmlsZSgpCiAgICAgICAgIGlm IHNlbGYuX2ZpbGVzeXN0ZW0uZXhpc3RzKGV4cGVjdGF0aW9uc19wYXRoKToKICAgICAgICAgICAg IF9sb2cuZGVidWcoIlVzaW5nIHRlc3RfZXhwZWN0YXRpb25zLnR4dDogJXMiICUgZXhwZWN0YXRp b25zX3BhdGgpCi0gICAgICAgICAgICBleHBlY3RhdGlvbnMgPSBzZWxmLl9maWxlc3lzdGVtLnJl YWRfdGV4dF9maWxlKGV4cGVjdGF0aW9uc19wYXRoKSArIGV4cGVjdGF0aW9ucworICAgICAgICAg ICAgZXhwZWN0YXRpb25zID0gc2VsZi5fZmlsZXN5c3RlbS5yZWFkX3RleHRfZmlsZShleHBlY3Rh dGlvbnNfcGF0aCkgKyAnXG4nICsgZXhwZWN0YXRpb25zCiAgICAgICAgIHJldHVybiBleHBlY3Rh dGlvbnMKIAogICAgIGRlZiBfc2tpcHBlZF9saXN0X2FzX2V4cGVjdGF0aW9ucyhzZWxmKToK 113852 2011-11-07 05:54:26 -0800 2011-11-07 13:21:37 -0800 proposed fix 1107.patch text/plain 2880 bank ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmY2I4 MjJjLi5hNWQ5ZDAzIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMTEtMDcgIEJhbGF6cyBBbmtlcyAgPEFua2Vz LkJhbGF6c0BzdHVkLnUtc3plZ2VkLmh1PgorCisgICAgICAgIFtOUldUXSBQYXJzaW5nIG9mIHRl c3RfZXhwZWN0YXRpb25zLnR4dCBzaG91bGQgYmUgYWdub3N0aWMgdG8gbmV3bGluZSBhdCBlbmQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcwOTEyCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdC5weTogQWRkIG5ld2xpbmUgYXQgdGhl IGVuZCBvZiB0ZXN0X2V4cGVjdGF0aW9ucy50eHQuCisgICAgICAgICogU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJraXRfdW5pdHRlc3QucHk6IE1ha2UgdXAgdGhlIHRlc3Rf dGVzdF9leHBlY3RhdGlvbnMgbWV0aG9kIGZvciB0aGUgdXBkYXRlZCB3ZWJraXQucHkuCisKIDIw MTEtMTEtMDEgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICByZXNvbHZl LUNoYW5nZUxvZ3MgLS1oZWxwIHNob3VsZCBiZSBmYXN0ZXIuCmRpZmYgLS1naXQgYS9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdC5weSBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2Via2l0LnB5CmluZGV4IDI0OGI0MzAuLjkx YjRlMzAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3Bv cnQvd2Via2l0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3Bv cnQvd2Via2l0LnB5CkBAIC0zNDgsNyArMzQ4LDcgQEAgY2xhc3MgV2ViS2l0UG9ydChQb3J0KToK ICAgICAgICAgZXhwZWN0YXRpb25zX3BhdGggPSBzZWxmLnBhdGhfdG9fdGVzdF9leHBlY3RhdGlv bnNfZmlsZSgpCiAgICAgICAgIGlmIHNlbGYuX2ZpbGVzeXN0ZW0uZXhpc3RzKGV4cGVjdGF0aW9u c19wYXRoKToKICAgICAgICAgICAgIF9sb2cuZGVidWcoIlVzaW5nIHRlc3RfZXhwZWN0YXRpb25z LnR4dDogJXMiICUgZXhwZWN0YXRpb25zX3BhdGgpCi0gICAgICAgICAgICBleHBlY3RhdGlvbnMg PSBzZWxmLl9maWxlc3lzdGVtLnJlYWRfdGV4dF9maWxlKGV4cGVjdGF0aW9uc19wYXRoKSArIGV4 cGVjdGF0aW9ucworICAgICAgICAgICAgZXhwZWN0YXRpb25zID0gc2VsZi5fZmlsZXN5c3RlbS5y ZWFkX3RleHRfZmlsZShleHBlY3RhdGlvbnNfcGF0aCkgKyAnXG4nICsgZXhwZWN0YXRpb25zCiAg ICAgICAgIHJldHVybiBleHBlY3RhdGlvbnMKIAogICAgIGRlZiBfc2tpcHBlZF9saXN0X2FzX2V4 cGVjdGF0aW9ucyhzZWxmKToKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL3BvcnQvd2Via2l0X3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJraXRfdW5pdHRlc3QucHkKaW5kZXggYjFiOTg0Zi4uMjIy MzkzZCAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9y dC93ZWJraXRfdW5pdHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvcG9ydC93ZWJraXRfdW5pdHRlc3QucHkKQEAgLTE0MCwxMCArMTQwLDIxIEBAIGNsYXNz IFdlYktpdFBvcnRUZXN0KHBvcnRfdGVzdGNhc2UuUG9ydFRlc3RDYXNlKToKICAgICAgICAgbW9j a19mcyA9IE1vY2tGaWxlU3lzdGVtKGZpbGVzKQogICAgICAgICBwb3J0ID0gVGVzdFdlYktpdFBv cnQoZmlsZXN5c3RlbT1tb2NrX2ZzKQogICAgICAgICBzZWxmLmFzc2VydEVxdWFsKHBvcnQudGVz dF9leHBlY3RhdGlvbnMoKSwKKyAgICAgICAgIiIiQlVHX1RFU1RFWFBFQ1RBVElPTlMgU0tJUCA6 IGZhc3QvaHRtbC9hcnRpY2xlLWVsZW1lbnQuaHRtbCA9IEZBSUxcbgorQlVHX1NLSVBQRUQgU0tJ UCA6IGZhc3QvaHRtbC9rZXlnZW4uaHRtbCA9IEZBSUwKK0JVR19TS0lQUEVEIFNLSVAgOiBtZWRp YSA9IEZBSUwiIiIpCisgICAgICAgIGZpbGVzID0geworICAgICAgICAgICAgJy9tb2NrLWNoZWNr b3V0L0xheW91dFRlc3RzL3BsYXRmb3JtL3Rlc3R3ZWJraXRwb3J0L3Rlc3RfZXhwZWN0YXRpb25z LnR4dCc6ICdCVUdfVEVTVEVYUEVDVEFUSU9OUyBTS0lQIDogZmFzdC9odG1sL2FydGljbGUtZWxl bWVudC5odG1sID0gRkFJTCcsCisgICAgICAgICAgICAnL21vY2stY2hlY2tvdXQvTGF5b3V0VGVz dHMvcGxhdGZvcm0vdGVzdHdlYmtpdHBvcnQvU2tpcHBlZCc6ICdmYXN0L2h0bWwva2V5Z2VuLmh0 bWwnLAorICAgICAgICB9CisgICAgICAgIG1vY2tfZnMgPSBNb2NrRmlsZVN5c3RlbShmaWxlcykK KyAgICAgICAgcG9ydCA9IFRlc3RXZWJLaXRQb3J0KGZpbGVzeXN0ZW09bW9ja19mcykKKyAgICAg ICAgc2VsZi5hc3NlcnRFcXVhbChwb3J0LnRlc3RfZXhwZWN0YXRpb25zKCksCiAgICAgICAgICIi IkJVR19URVNURVhQRUNUQVRJT05TIFNLSVAgOiBmYXN0L2h0bWwvYXJ0aWNsZS1lbGVtZW50Lmh0 bWwgPSBGQUlMCiBCVUdfU0tJUFBFRCBTS0lQIDogZmFzdC9odG1sL2tleWdlbi5odG1sID0gRkFJ TAogQlVHX1NLSVBQRUQgU0tJUCA6IG1lZGlhID0gRkFJTCIiIikKIAorCiAgICAgZGVmIHRlc3Rf YnVpbGRfZHJpdmVyKHNlbGYpOgogICAgICAgICBvdXRwdXQgPSBPdXRwdXRDYXB0dXJlKCkKICAg ICAgICAgcG9ydCA9IFRlc3RXZWJLaXRQb3J0KCkK