70908 2011-10-26 05:26:38 -0700 [GTK] Remove g_thread_init() calls from gtk-doc scanner too 2011-10-26 05:38:14 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 cgarcia webkit-unassigned cgarcia webkit.review.bot oldest_to_newest 490755 0 cgarcia 2011-10-26 05:26:38 -0700 I forgot to remove g_thread_init from gtk-doc scanner too. See also bug #70717 490756 1 112484 cgarcia 2011-10-26 05:28:42 -0700 Created attachment 112484 Patch 490758 2 112484 gustavo 2011-10-26 05:30:09 -0700 Comment on attachment 112484 Patch Do we already depend (via configure.ac) on a new enough glib, btw? Worth double checking, LGTM otherwise! 490759 3 webkit.review.bot 2011-10-26 05:30:16 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 490762 4 cgarcia 2011-10-26 05:35:40 -0700 (In reply to comment #2) > (From update of attachment 112484 [details]) > Do we already depend (via configure.ac) on a new enough glib, btw? Worth double checking, LGTM otherwise! Yes, we already checked it for bug #70717. Thanks! 490764 5 cgarcia 2011-10-26 05:38:14 -0700 Committed r98465: <http://trac.webkit.org/changeset/98465> 112484 2011-10-26 05:28:42 -0700 2011-10-26 05:30:09 -0700 Patch thread-gtk-doc.diff text/plain 2447 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv Z3RrL0NoYW5nZUxvZwppbmRleCAxMWRkNGIwLi44YTdiZGMwIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTIgQEAKKzIwMTEtMTAtMjYgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNp YUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIFJlbW92ZSBnX3RocmVhZF9pbml0KCkgY2Fs bHMgZnJvbSBndGstZG9jIHNjYW5uZXIgdG9vCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD03MDkwOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogZG9jcy9HTlVtYWtlZmlsZS5hbToKKwogMjAxMS0xMC0yNSAg TWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10g R3RrQWRqdXN0bWVudCB3YXRjaGVyIHVwZGF0ZXMgYWRqdXN0bWVudHMgdG9vIGxhemlseQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCmluZGV4IGExYjQ5YzEuLjIzMGVlYWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAor MjAxMS0xMC0yNiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisK KyAgICAgICAgW0dUS10gUmVtb3ZlIGdfdGhyZWFkX2luaXQoKSBjYWxscyBmcm9tIGd0ay1kb2Mg c2Nhbm5lciB0b28KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTcwOTA4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9kb2NzL0dOVW1ha2VmaWxlLmFtOgorCiAyMDExLTEwLTI2 ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIEFub3RoZXIgR1RL IGJ1aWxkIGZpeCBhdHRlbXB0IGFmdGVyIHI5ODQxMyBhbmQgcjk4NDE2LgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9ndGsvZG9jcy9HTlVtYWtlZmlsZS5hbSBiL1NvdXJjZS9XZWJLaXQvZ3Rr L2RvY3MvR05VbWFrZWZpbGUuYW0KaW5kZXggY2VlMmVmMS4uODBkNWNkMSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9ndGsvZG9jcy9HTlVtYWtlZmlsZS5hbQorKysgYi9Tb3VyY2UvV2ViS2l0 L2d0ay9kb2NzL0dOVW1ha2VmaWxlLmFtCkBAIC0xOCw3ICsxOCw3IEBAIERPQ19NQUlOX1NHTUxf RklMRT0kKERPQ19NT0RVTEUpLWRvY3Muc2dtbAogRE9DX1NPVVJDRV9ESVI9JCh0b3Bfc3JjZGly KS9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQKIAogIyBFeHRyYSBvcHRpb25zIHRvIHBhc3MgdG8g Z3RrZG9jLXNjYW5nb2JqLiBOb3Qgbm9ybWFsbHkgbmVlZGVkLgotU0NBTkdPQkpfT1BUSU9OUz0i LS10eXBlLWluaXQtZnVuYz1nX3RocmVhZF9pbml0KE5VTEwpO2dfdHlwZV9pbml0KCkiCitTQ0FO R09CSl9PUFRJT05TPSItLXR5cGUtaW5pdC1mdW5jPWdfdHlwZV9pbml0KCkiCiAKICMgRXh0cmEg b3B0aW9ucyB0byBzdXBwbHkgdG8gZ3RrZG9jLXNjYW4uCiAjIGUuZy4gU0NBTl9PUFRJT05TPS0t ZGVwcmVjYXRlZC1ndWFyZHM9IkdUS19ESVNBQkxFX0RFUFJFQ0FURUQiCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9kb2NzL0dOVW1ha2VmaWxlLmFtIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvZG9jcy9HTlVtYWtlZmlsZS5hbQppbmRleCBi NzYyMDhhLi5mMTlkYWJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L2d0ay9kb2NzL0dOVW1ha2VmaWxlLmFtCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvZ3RrL2RvY3MvR05VbWFrZWZpbGUuYW0KQEAgLTIxLDcgKzIxLDcgQEAgRE9DX01BSU5fU0dN TF9GSUxFPSQoRE9DX01PRFVMRSktZG9jcy5zZ21sCiBET0NfU09VUkNFX0RJUj0kKHRvcF9zcmNk aXIpL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrCiAKICMgRXh0cmEgb3B0aW9ucyB0 byBwYXNzIHRvIGd0a2RvYy1zY2FuZ29iai4gTm90IG5vcm1hbGx5IG5lZWRlZC4KLVNDQU5HT0JK X09QVElPTlM9Ii0tdHlwZS1pbml0LWZ1bmM9Z190aHJlYWRfaW5pdChOVUxMKTtnX3R5cGVfaW5p dCgpIgorU0NBTkdPQkpfT1BUSU9OUz0iLS10eXBlLWluaXQtZnVuYz1nX3R5cGVfaW5pdCgpIgog CiAjIEV4dHJhIG9wdGlvbnMgdG8gc3VwcGx5IHRvIGd0a2RvYy1zY2FuLgogIyBlLmcuIFNDQU5f T1BUSU9OUz0tLWRlcHJlY2F0ZWQtZ3VhcmRzPSJHVEtfRElTQUJMRV9ERVBSRUNBVEVEIgo=