70906 2011-10-26 05:08:22 -0700 Web Inspector: Execution line in selected call frame should keep showing after toggling format source. 2011-10-27 04:49:44 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 vsevik vsevik apavlov bweinstein joepeck keishi loislo pfeldman pmuellr podivilov rik timothy yurys oldest_to_newest 490747 0 vsevik 2011-10-26 05:08:22 -0700 Execution line in selected call frame should keep showing after toggling format source. 490761 1 112485 vsevik 2011-10-26 05:34:40 -0700 Created attachment 112485 Patch 490820 2 112485 podivilov 2011-10-26 07:18:34 -0700 Comment on attachment 112485 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112485&action=review > LayoutTests/inspector/debugger/selected-call-frame-after-formatting-source.html:50 > +<p>Tests execution line in selected call frame keeps showing after formatting source..</p> I think it actually tests that selected call frame does not change when pretty-print is toggled. 490863 3 112485 pfeldman 2011-10-26 08:33:38 -0700 Comment on attachment 112485 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112485&action=review > Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:-315 > - if (WebInspector.debuggerModel.callFrames) So we are not rebuilding call frames now. Why? 491218 4 112485 vsevik 2011-10-26 15:18:31 -0700 Comment on attachment 112485 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112485&action=review >> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:-315 >> - if (WebInspector.debuggerModel.callFrames) > > So we are not rebuilding call frames now. Why? They are already correctly updated based on events from rawSourceCodes. Meanwhile calling debuggerPaused is bad because it resets selectedCallFrame to the top of the stack. 491375 5 112485 yurys 2011-10-27 00:29:25 -0700 Comment on attachment 112485 Patch Please update test description as Pavel suggests before landing. 491462 6 vsevik 2011-10-27 04:49:44 -0700 Committed r98549: <http://trac.webkit.org/changeset/98549> 112485 2011-10-26 05:34:40 -0700 2011-10-27 00:29:25 -0700 Patch bug-70906-20111026163438.patch text/plain 5240 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogOTg0NTQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0Yzc1YTk0MWY3YmZiYWI2 ZWMyNmRlZWVjZDBmYTU5NWYwZjYzOGYxLi45ZmExM2ZmYTdmOWQxZmEwYjc4NDE2MjM0YjAyMDc5 Mjg3ZTEzZGMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcgQEAKIDIwMTEtMTAtMjYgIFZzZXZv bG9kIFZsYXNvdiAgPHZzZXZpa0BjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogRXhlY3V0aW9uIGxpbmUgaW4gc2VsZWN0ZWQgY2FsbCBmcmFtZSBzaG91bGQga2VlcCBzaG93 aW5nIGFmdGVyIHRvZ2dsaW5nIGZvcm1hdCBzb3VyY2UuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MDkwNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3Q6IGluc3BlY3Rvci9kZWJ1Z2dlci9zZWxlY3Rl ZC1jYWxsLWZyYW1lLWFmdGVyLWZvcm1hdHRpbmctc291cmNlLmh0bWwKKworICAgICAgICAqIGlu c3BlY3Rvci9mcm9udC1lbmQvRGVidWdnZXJQcmVzZW50YXRpb25Nb2RlbC5qczoKKyAgICAgICAg KFdlYkluc3BlY3Rvci5EZWJ1Z2dlclByZXNlbnRhdGlvbk1vZGVsLnByb3RvdHlwZS5zZXRGb3Jt YXRTb3VyY2UpOgorCisyMDExLTEwLTI2ICBWc2V2b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21p dW0ub3JnPgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IERlYnVnZ2VyIGZhaWxzIHdoZW4gdGhl cmUgaXMgYW4gaW52YWxpZCB3YXRjaCBleHByZXNzaW9uLgogICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzA3MTgKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9EZWJ1Z2dlclByZXNlbnRhdGlvbk1vZGVsLmpzIGIv U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9EZWJ1Z2dlclByZXNlbnRhdGlvbk1v ZGVsLmpzCmluZGV4IGIzNTc1MjFmMTc0NTc4MGFlYTYyYjBiZGE4MGRhNzM3OGE4YWU5OTUuLjgz ZWQ2MTk5YmQ1ZDJjZjIxMzI5MTg5ZTQ3ZjU5YTFmNGVlZTA5MWIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRGVidWdnZXJQcmVzZW50YXRpb25Nb2RlbC5q cworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0RlYnVnZ2VyUHJlc2Vu dGF0aW9uTW9kZWwuanMKQEAgLTMxMSw5ICszMTEsNiBAQCBXZWJJbnNwZWN0b3IuRGVidWdnZXJQ cmVzZW50YXRpb25Nb2RlbC5wcm90b3R5cGUgPSB7CiAgICAgICAgIHRoaXMuX2JyZWFrcG9pbnRN YW5hZ2VyLnJlc2V0KCk7CiAgICAgICAgIGZvciAodmFyIGlkIGluIHRoaXMuX3Jhd1NvdXJjZUNv ZGUpCiAgICAgICAgICAgICB0aGlzLl9yYXdTb3VyY2VDb2RlW2lkXS5zZXRGb3JtYXR0ZWQodGhp cy5fZm9ybWF0U291cmNlKTsKLQotICAgICAgICBpZiAoV2ViSW5zcGVjdG9yLmRlYnVnZ2VyTW9k ZWwuY2FsbEZyYW1lcykKLSAgICAgICAgICAgIHRoaXMuX2RlYnVnZ2VyUGF1c2VkKCk7CiAgICAg fSwKIAogICAgIC8qKgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDdjNjUxNmFhYjBkNGU3MTY2ZGUyZjkxNjNlOWM5YmMxMTA5 NThlYTUuLmE5NDk0ZTJhMzgwZmQyOWU2YmRlZTQ1YmY0NzJjMDZkNjY5NTE2ZWMgMTAwNjQ0Ci0t LSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAg LTEsNSArMSwxNSBAQAogMjAxMS0xMC0yNiAgVnNldm9sb2QgVmxhc292ICA8dnNldmlrQGNocm9t aXVtLm9yZz4KIAorICAgICAgICBXZWIgSW5zcGVjdG9yOiBFeGVjdXRpb24gbGluZSBpbiBzZWxl Y3RlZCBjYWxsIGZyYW1lIHNob3VsZCBrZWVwIHNob3dpbmcgYWZ0ZXIgdG9nZ2xpbmcgZm9ybWF0 IHNvdXJjZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTcwOTA2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBpbnNwZWN0b3IvZGVidWdnZXIvc2VsZWN0ZWQtY2FsbC1mcmFtZS1hZnRlci1mb3JtYXR0aW5n LXNvdXJjZS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGluc3BlY3Rvci9kZWJ1Z2dl ci9zZWxlY3RlZC1jYWxsLWZyYW1lLWFmdGVyLWZvcm1hdHRpbmctc291cmNlLmh0bWw6IEFkZGVk LgorCisyMDExLTEwLTI2ICBWc2V2b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgor CiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IERlYnVnZ2VyIGZhaWxzIHdoZW4gdGhlcmUgaXMgYW4g aW52YWxpZCB3YXRjaCBleHByZXNzaW9uLgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NzA3MTgKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW5zcGVj dG9yL2RlYnVnZ2VyL3NlbGVjdGVkLWNhbGwtZnJhbWUtYWZ0ZXItZm9ybWF0dGluZy1zb3VyY2Ut ZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2RlYnVnZ2VyL3NlbGVjdGVkLWNh bGwtZnJhbWUtYWZ0ZXItZm9ybWF0dGluZy1zb3VyY2UtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1v ZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAu LjJiMjYxYWNjZmMxYTIzZTRjMDJjZmFmNTI0NTA2Y2YzMzYxNWFhMGUKLS0tIC9kZXYvbnVsbAor KysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvZGVidWdnZXIvc2VsZWN0ZWQtY2FsbC1mcmFtZS1h ZnRlci1mb3JtYXR0aW5nLXNvdXJjZS1leHBlY3RlZC50eHQKQEAgLTAsMCArMSw5IEBACitUZXN0 cyBleGVjdXRpb24gbGluZSBpbiBzZWxlY3RlZCBjYWxsIGZyYW1lIGtlZXBzIHNob3dpbmcgYWZ0 ZXIgZm9ybWF0dGluZyBzb3VyY2UuLgorCitCdWcgNzA5MDYKK0RlYnVnZ2VyIHdhcyBlbmFibGVk LgorU2V0IHRpbWVyIGZvciB0ZXN0IGZ1bmN0aW9uLgorU2NyaXB0IGV4ZWN1dGlvbiBwYXVzZWQu CitTY3JpcHQgZXhlY3V0aW9uIHJlc3VtZWQuCitEZWJ1Z2dlciB3YXMgZGlzYWJsZWQuCisKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9kZWJ1Z2dlci9zZWxlY3RlZC1jYWxsLWZy YW1lLWFmdGVyLWZvcm1hdHRpbmctc291cmNlLmh0bWwgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3Iv ZGVidWdnZXIvc2VsZWN0ZWQtY2FsbC1mcmFtZS1hZnRlci1mb3JtYXR0aW5nLXNvdXJjZS5odG1s Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAuLjBkNjZkYjI2Yjk2NDUwZDE5NTkxYTI0NDI0NWFmOWY2ZGIxOGM2MjYKLS0t IC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvZGVidWdnZXIvc2VsZWN0ZWQt Y2FsbC1mcmFtZS1hZnRlci1mb3JtYXR0aW5nLXNvdXJjZS5odG1sCkBAIC0wLDAgKzEsNTMgQEAK KzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vaHR0cC90ZXN0cy9pbnNwZWN0b3Iv aW5zcGVjdG9yLXRlc3QuanMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uLy4uL2h0dHAvdGVz dHMvaW5zcGVjdG9yL2RlYnVnZ2VyLXRlc3QuanMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4u Ly4uL2h0dHAvdGVzdHMvaW5zcGVjdG9yL2VsZW1lbnRzLXRlc3QuanMiPjwvc2NyaXB0PgorPHNj cmlwdD4KK2Z1bmN0aW9uIHRlc3RGdW5jdGlvbigpCit7CisgICAgcmV0dXJuIHRlc3RGdW5jdGlv bjIoKTsKK30KKworZnVuY3Rpb24gdGVzdEZ1bmN0aW9uMigpCit7CisgICAgdmFyIHggPSBNYXRo LnNxcnQoMTApOworICAgIGRlYnVnZ2VyOworICAgIHJldHVybiB4OworfQorCit2YXIgdGVzdCA9 IGZ1bmN0aW9uKCkKK3sKKyAgICBJbnNwZWN0b3JUZXN0LnN0YXJ0RGVidWdnZXJUZXN0KHN0ZXAx KTsKKyAgICB2YXIgcGFuZWwgPSBXZWJJbnNwZWN0b3IucGFuZWxzLnNjcmlwdHM7CisKKyAgICBm dW5jdGlvbiBzdGVwMSgpCisgICAgeworICAgICAgICB2YXIgdGVzdE5hbWUgPSBXZWJJbnNwZWN0 b3IubWFpblJlc291cmNlLnVybDsKKyAgICAgICAgdGVzdE5hbWUgPSB0ZXN0TmFtZS5zdWJzdHJp bmcodGVzdE5hbWUubGFzdEluZGV4T2YoJy8nKSArIDEpOworICAgICAgICBJbnNwZWN0b3JUZXN0 LnNob3dTY3JpcHRTb3VyY2UodGVzdE5hbWUsIHN0ZXAyKTsKKyAgICB9CisKKyAgICBmdW5jdGlv biBzdGVwMihjYWxsRnJhbWVzKQorICAgIHsKKyAgICAgICAgSW5zcGVjdG9yVGVzdC5ydW5UZXN0 RnVuY3Rpb25BbmRXYWl0VW50aWxQYXVzZWQoc3RlcDMpOworICAgIH0KKworICAgIGZ1bmN0aW9u IHN0ZXAzKGNhbGxGcmFtZXMpCisgICAgeworICAgICAgICBXZWJJbnNwZWN0b3IuZGVidWdnZXJQ cmVzZW50YXRpb25Nb2RlbC5zZWxlY3RlZENhbGxGcmFtZSA9IFdlYkluc3BlY3Rvci5kZWJ1Z2dl clByZXNlbnRhdGlvbk1vZGVsLl9wcmVzZW50YXRpb25DYWxsRnJhbWVzWzFdOworICAgICAgICBw YW5lbC5fdG9nZ2xlRm9ybWF0U291cmNlKCk7CisgICAgICAgIEluc3BlY3RvclRlc3QuYXNzZXJ0 RXF1YWxzKCJ0ZXN0RnVuY3Rpb24iLCBXZWJJbnNwZWN0b3IuZGVidWdnZXJQcmVzZW50YXRpb25N b2RlbC5zZWxlY3RlZENhbGxGcmFtZS5fY2FsbEZyYW1lLmZ1bmN0aW9uTmFtZSk7CisgICAgICAg IHBhbmVsLl90b2dnbGVGb3JtYXRTb3VyY2UoKTsKKyAgICAgICAgSW5zcGVjdG9yVGVzdC5hc3Nl cnRFcXVhbHMoInRlc3RGdW5jdGlvbiIsIFdlYkluc3BlY3Rvci5kZWJ1Z2dlclByZXNlbnRhdGlv bk1vZGVsLnNlbGVjdGVkQ2FsbEZyYW1lLl9jYWxsRnJhbWUuZnVuY3Rpb25OYW1lKTsKKyAgICAg ICAgSW5zcGVjdG9yVGVzdC5jb21wbGV0ZURlYnVnZ2VyVGVzdCgpOworICAgIH0KK30KKworPC9z Y3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keSBvbmxvYWQ9InJ1blRlc3QoKSI+Cis8cD5UZXN0cyBleGVj dXRpb24gbGluZSBpbiBzZWxlY3RlZCBjYWxsIGZyYW1lIGtlZXBzIHNob3dpbmcgYWZ0ZXIgZm9y bWF0dGluZyBzb3VyY2UuLjwvcD4KKzxhIGhyZWY9Imh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD03MDkwNiI+QnVnIDcwOTA2PC9hPgorPC9ib2R5PgorPC9odG1sPgo=