<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>70904</bug_id>
          
          <creation_ts>2011-10-26 05:04:13 -0700</creation_ts>
          <short_desc>Fix compilation of DFG JIT on PIC targets</short_desc>
          <delta_ts>2011-10-31 15:38:25 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Andy Wingo">wingo</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>darin</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>490744</commentid>
    <comment_count>0</comment_count>
    <who name="Andy Wingo">wingo</who>
    <bug_when>2011-10-26 05:04:13 -0700</bug_when>
    <thetext>The DFG JIT currently does not compile on PIC targets due to missing PLT relocations in DFGOperations.cpp.  The patch to be attached fixes this issue.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>490749</commentid>
    <comment_count>1</comment_count>
      <attachid>112483</attachid>
    <who name="Andy Wingo">wingo</who>
    <bug_when>2011-10-26 05:11:29 -0700</bug_when>
    <thetext>Created attachment 112483
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>490751</commentid>
    <comment_count>2</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-10-26 05:13:54 -0700</bug_when>
    <thetext>Attachment 112483 did not pass style-queue:

Failed to run &quot;[&apos;Tools/Scripts/check-webkit-style&apos;, &apos;--diff-files&apos;, u&apos;Source/JavaScriptCore/ChangeLog&apos;, u&apos;Source...&quot; exit_code: 1

Source/JavaScriptCore/ChangeLog:3:  Line contains tab character.  [whitespace/tab] [5]
Source/JavaScriptCore/ChangeLog:4:  Line contains tab character.  [whitespace/tab] [5]
Source/JavaScriptCore/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
Source/JavaScriptCore/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
Source/JavaScriptCore/ChangeLog:10:  Line contains tab character.  [whitespace/tab] [5]
Source/JavaScriptCore/ChangeLog:11:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 6 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>490978</commentid>
    <comment_count>3</comment_count>
      <attachid>112483</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2011-10-26 10:15:14 -0700</bug_when>
    <thetext>Comment on attachment 112483
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112483&amp;action=review

Contents of patch looks fine, but needs a new change log without tab characters and preferably with an explanation of the change too.

&gt; Source/JavaScriptCore/dfg/DFGOperations.cpp:53
&gt; +#if (OS(LINUX) || OS(FREEBSD)) &amp;&amp; CPU(X86_64)
&gt; +#define SYMBOL_STRING_RELOCATION(name) #name &quot;@plt&quot;
&gt; +#elif OS(DARWIN) || (CPU(X86_64) &amp;&amp; COMPILER(MINGW) &amp;&amp; !GCC_VERSION_AT_LEAST(4, 5, 0))
&gt; +#define SYMBOL_STRING_RELOCATION(name) &quot;_&quot; #name
&gt; +#elif CPU(X86) &amp;&amp; COMPILER(MINGW)
&gt; +#define SYMBOL_STRING_RELOCATION(name) &quot;@&quot; #name &quot;@4&quot;
&gt; +#else
&gt; +#define SYMBOL_STRING_RELOCATION(name) #name
&gt; +#endif

Can keep the size of this macro definition smaller by having it call SYMBOL_STRING in the #else case and removing one of the if cases?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>490990</commentid>
    <comment_count>4</comment_count>
      <attachid>112560</attachid>
    <who name="Andy Wingo">wingo</who>
    <bug_when>2011-10-26 10:27:31 -0700</bug_when>
    <thetext>Created attachment 112560
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>490993</commentid>
    <comment_count>5</comment_count>
    <who name="Andy Wingo">wingo</who>
    <bug_when>2011-10-26 10:29:43 -0700</bug_when>
    <thetext>Thanks for the comments.  I attached an updated patch and re-submitted it to the checkers.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>490994</commentid>
    <comment_count>6</comment_count>
      <attachid>112560</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2011-10-26 10:31:17 -0700</bug_when>
    <thetext>Comment on attachment 112560
Patch

Unfortunate to have two copies of this macro. Later we should put it in a header.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>490996</commentid>
    <comment_count>7</comment_count>
      <attachid>112561</attachid>
    <who name="Andy Wingo">wingo</who>
    <bug_when>2011-10-26 10:34:02 -0700</bug_when>
    <thetext>Created attachment 112561
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>490997</commentid>
    <comment_count>8</comment_count>
    <who name="Andy Wingo">wingo</who>
    <bug_when>2011-10-26 10:35:10 -0700</bug_when>
    <thetext>The newly attached patch updates the changelog message, as you suggested (and I forgot).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>491553</commentid>
    <comment_count>9</comment_count>
    <who name="Andy Wingo">wingo</who>
    <bug_when>2011-10-27 07:32:44 -0700</bug_when>
    <thetext>Please let me know if there is something I need to do to this patch.  Otherwise if it is acceptable, I am not a committer yet, so the ball would be in your court.

Thanks :)

Andy</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>492413</commentid>
    <comment_count>10</comment_count>
    <who name="Andy Wingo">wingo</who>
    <bug_when>2011-10-28 06:33:31 -0700</bug_when>
    <thetext>Darin, I&apos;m setting cq?.  Would you mind taking a look at this again?  Thanks :)

(I&apos;m still new at this webkit bugzilla protocol, please let me know if I&apos;m getting it wrong.)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>493546</commentid>
    <comment_count>11</comment_count>
      <attachid>112561</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-10-31 15:38:20 -0700</bug_when>
    <thetext>Comment on attachment 112561
Patch

Clearing flags on attachment: 112561

Committed r98891: &lt;http://trac.webkit.org/changeset/98891&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>493547</commentid>
    <comment_count>12</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-10-31 15:38:25 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>112483</attachid>
            <date>2011-10-26 05:11:29 -0700</date>
            <delta_ts>2011-10-26 10:27:23 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-70904-20111026141127.patch</filename>
            <type>text/plain</type>
            <size>3296</size>
            <attacher name="Andy Wingo">wingo</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogOTg0NjEKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0
Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGQy
YjYzOTAxMzczNmIyMzc3ODg3NjMwNDdjM2I1OTJhNzVhMmU0YWMuLmRkN2QyZDFmNGViYWQwZGQ1
MzU2YmE4MTRjNGJjMWRiMzU4YzdkMzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz
ICsxLDE1IEBACisyMDExLTEwLTI2ICBBbmR5IFdpbmdvICA8d2luZ29AaWdhbGlhLmNvbT4KKwor
CUZpeCBERkcgSklUIGNvbXBpbGF0aW9uIG9uIExpbnV4IHRhcmdldHMuCisJaHR0cHM6Ly9idWdz
LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcwOTA0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKwkqIGRmZy9ERkdPcGVyYXRpb25zLmNwcCAoU1lNQk9MX1NUUklO
R19SRUxPQ0FUSU9OKTogQ29weSB0aGlzCisJZGVmaW5pdGlvbiBmcm9tIGppdC9KSVRTdHVicy5j
cHAuCisJKEZVTkNUSU9OX1dSQVBQRVJfV0lUSF9SRVRVUk5fQUREUkVTUywgZ2V0SG9zdENhbGxS
ZXR1cm5WYWx1ZSk6CisJVXNlIHRoZSBtYWNybyB0byBmaXggY29tcGlsYXRpb24gb24gTGludXgg
c3lzdGVtcy4KKwogMjAxMS0xMC0yNSAgR2F2aW4gQmFycmFjbG91Z2ggIDxiYXJyYWNsb3VnaEBh
cHBsZS5jb20+CiAKICAgICAgICAgU3BsaXQgREZHSklUQ29kZUdlbmVyYXRvcjo6Y2FsbE9wZXJh
dGlvbiBtZXRob2RzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09w
ZXJhdGlvbnMuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPcGVyYXRpb25zLmNw
cAppbmRleCA5OWI0NzY2NzZmYzdlOGIxMjI1NjM5ZDg5NDU2OTFjMjU4ZDUyN2QzLi45NmM2MTYw
ODc1YmU2YjI1NzY5ZDMzNmVhOGIxZjY1OThiZDcwZThhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2
YVNjcmlwdENvcmUvZGZnL0RGR09wZXJhdGlvbnMuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0
Q29yZS9kZmcvREZHT3BlcmF0aW9ucy5jcHAKQEAgLTQyLDYgKzQyLDE2IEBACiAjZGVmaW5lIFNZ
TUJPTF9TVFJJTkcobmFtZSkgI25hbWUKICNlbmRpZgogCisjaWYgKE9TKExJTlVYKSB8fCBPUyhG
UkVFQlNEKSkgJiYgQ1BVKFg4Nl82NCkKKyNkZWZpbmUgU1lNQk9MX1NUUklOR19SRUxPQ0FUSU9O
KG5hbWUpICNuYW1lICJAcGx0IgorI2VsaWYgT1MoREFSV0lOKSB8fCAoQ1BVKFg4Nl82NCkgJiYg
Q09NUElMRVIoTUlOR1cpICYmICFHQ0NfVkVSU0lPTl9BVF9MRUFTVCg0LCA1LCAwKSkKKyNkZWZp
bmUgU1lNQk9MX1NUUklOR19SRUxPQ0FUSU9OKG5hbWUpICJfIiAjbmFtZQorI2VsaWYgQ1BVKFg4
NikgJiYgQ09NUElMRVIoTUlOR1cpCisjZGVmaW5lIFNZTUJPTF9TVFJJTkdfUkVMT0NBVElPTihu
YW1lKSAiQCIgI25hbWUgIkA0IgorI2Vsc2UKKyNkZWZpbmUgU1lNQk9MX1NUUklOR19SRUxPQ0FU
SU9OKG5hbWUpICNuYW1lCisjZW5kaWYKKwogI2lmIENQVShYODZfNjQpCiAKICNkZWZpbmUgRlVO
Q1RJT05fV1JBUFBFUl9XSVRIX1JFVFVSTl9BRERSRVNTKGZ1bmN0aW9uLCByZWdpc3RlcikgXApA
QCAtNDksNyArNTksNyBAQAogICAgICIuZ2xvYmwgIiBTWU1CT0xfU1RSSU5HKGZ1bmN0aW9uKSAi
XG4iIFwKICAgICBTWU1CT0xfU1RSSU5HKGZ1bmN0aW9uKSAiOiIgIlxuIiBcCiAgICAgICAgICJt
b3YgKCVyc3ApLCAlIiBTVFJJTkdJWkUocmVnaXN0ZXIpICJcbiIgXAotICAgICAgICAiam1wICIg
U1lNQk9MX1NUUklORyhmdW5jdGlvbikgIldpdGhSZXR1cm5BZGRyZXNzIiAiXG4iIFwKKyAgICAg
ICAgImptcCAiIFNZTUJPTF9TVFJJTkdfUkVMT0NBVElPTihmdW5jdGlvbiMjV2l0aFJldHVybkFk
ZHJlc3MpICJcbiIgXAogICAgICk7CiAjZGVmaW5lIEZVTkNUSU9OX1dSQVBQRVJfV0lUSF9SRVRV
Uk5fQUREUkVTU19FKGZ1bmN0aW9uKSAgICBGVU5DVElPTl9XUkFQUEVSX1dJVEhfUkVUVVJOX0FE
RFJFU1MoZnVuY3Rpb24sIHJzaSkKICNkZWZpbmUgRlVOQ1RJT05fV1JBUFBFUl9XSVRIX1JFVFVS
Tl9BRERSRVNTX0VDSShmdW5jdGlvbikgIEZVTkNUSU9OX1dSQVBQRVJfV0lUSF9SRVRVUk5fQURE
UkVTUyhmdW5jdGlvbiwgcmN4KQpAQCAtNjMsNyArNzMsNyBAQAogICAgIFNZTUJPTF9TVFJJTkco
ZnVuY3Rpb24pICI6IiAiXG4iIFwKICAgICAgICAgIm1vdiAoJWVzcCksICVlYXhcbiIgXAogICAg
ICAgICAibW92ICVlYXgsICIgU1RSSU5HSVpFKG9mZnNldCkgIiglZXNwKVxuIiBcCi0gICAgICAg
ICJqbXAgIiBTWU1CT0xfU1RSSU5HKGZ1bmN0aW9uKSAiV2l0aFJldHVybkFkZHJlc3MiICJcbiIg
XAorICAgICAgICAiam1wICIgU1lNQk9MX1NUUklOR19SRUxPQ0FUSU9OKGZ1bmN0aW9uIyNXaXRo
UmV0dXJuQWRkcmVzcykgIlxuIiBcCiAgICAgKTsKICNkZWZpbmUgRlVOQ1RJT05fV1JBUFBFUl9X
SVRIX1JFVFVSTl9BRERSRVNTX0UoZnVuY3Rpb24pICAgIEZVTkNUSU9OX1dSQVBQRVJfV0lUSF9S
RVRVUk5fQUREUkVTUyhmdW5jdGlvbiwgOCkKICNkZWZpbmUgRlVOQ1RJT05fV1JBUFBFUl9XSVRI
X1JFVFVSTl9BRERSRVNTX0VDSShmdW5jdGlvbikgIEZVTkNUSU9OX1dSQVBQRVJfV0lUSF9SRVRV
Uk5fQUREUkVTUyhmdW5jdGlvbiwgMTYpCkBAIC01MDksNyArNTE5LDcgQEAgYXNtICgKIFNZTUJP
TF9TVFJJTkcoZ2V0SG9zdENhbGxSZXR1cm5WYWx1ZSkgIjoiICJcbiIKICAgICAibW92IC00MCgl
cjEzKSwgJXIxM1xuIgogICAgICJtb3YgJXIxMywgJXJkaVxuIgotICAgICJqbXAgIiBTWU1CT0xf
U1RSSU5HKGdldEhvc3RDYWxsUmV0dXJuVmFsdWVXaXRoRXhlY1N0YXRlKSAiXG4iCisgICAgImpt
cCAiIFNZTUJPTF9TVFJJTkdfUkVMT0NBVElPTihnZXRIb3N0Q2FsbFJldHVyblZhbHVlV2l0aEV4
ZWNTdGF0ZSkgIlxuIgogKTsKICNlbGlmIENQVShYODYpCiBhc20gKApAQCAtNTE3LDcgKzUyNyw3
IEBAIGFzbSAoCiBTWU1CT0xfU1RSSU5HKGdldEhvc3RDYWxsUmV0dXJuVmFsdWUpICI6IiAiXG4i
CiAgICAgIm1vdiAtNDAoJWVkaSksICVlZGlcbiIKICAgICAibW92ICVlZGksIDQoJWVzcClcbiIK
LSAgICAiam1wICIgU1lNQk9MX1NUUklORyhnZXRIb3N0Q2FsbFJldHVyblZhbHVlV2l0aEV4ZWNT
dGF0ZSkgIlxuIgorICAgICJqbXAgIiBTWU1CT0xfU1RSSU5HX1JFTE9DQVRJT04oZ2V0SG9zdENh
bGxSZXR1cm5WYWx1ZVdpdGhFeGVjU3RhdGUpICJcbiIKICk7CiAjZW5kaWYKIAo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>112560</attachid>
            <date>2011-10-26 10:27:31 -0700</date>
            <delta_ts>2011-10-26 10:33:52 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-70904-20111026192729.patch</filename>
            <type>text/plain</type>
            <size>4096</size>
            <attacher name="Andy Wingo">wingo</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogOTg0NzcKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0
Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGQy
YjYzOTAxMzczNmIyMzc3ODg3NjMwNDdjM2I1OTJhNzVhMmU0YWMuLjhhMjFmOTU2MmI0ZDU5M2Fm
MmJhNzYwMGNiZWM3N2FhMDA1MDJjNzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz
ICsxLDE4IEBACisyMDExLTEwLTI2ICBBbmR5IFdpbmdvICA8d2luZ29AaWdhbGlhLmNvbT4KKwor
ICAgICAgICBGaXggREZHIEpJVCBjb21waWxhdGlvbiBvbiBMaW51eCB0YXJnZXRzLgorICAgICAg
ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzA5MDQKKworICAgICAg
ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGppdC9KSVRTdHVicy5j
cHAgKFNZTUJPTF9TVFJJTkdfUkVMT0NBVElPTik6IFNpbXBsaWZ5IHRoaXMKKyAgICAgICAgbWFj
cm8uCisKKyAgICAgICAgKiBkZmcvREZHT3BlcmF0aW9ucy5jcHAgKFNZTUJPTF9TVFJJTkdfUkVM
T0NBVElPTik6IENvcHkgdGhlCisgICAgICAgIHNpbXBsaWZpZWQgZGVmaW5pdGlvbiBmcm9tIGpp
dC9KSVRTdHVicy5jcHAuCisgICAgICAgIChGVU5DVElPTl9XUkFQUEVSX1dJVEhfUkVUVVJOX0FE
RFJFU1MsIGdldEhvc3RDYWxsUmV0dXJuVmFsdWUpOgorICAgICAgICBVc2UgdGhlIG1hY3JvIHRv
IGZpeCBjb21waWxhdGlvbiBvbiBMaW51eCBzeXN0ZW1zLgorCiAyMDExLTEwLTI1ICBHYXZpbiBC
YXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4KIAogICAgICAgICBTcGxpdCBERkdK
SVRDb2RlR2VuZXJhdG9yOjpjYWxsT3BlcmF0aW9uIG1ldGhvZHMKZGlmZiAtLWdpdCBhL1NvdXJj
ZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT3BlcmF0aW9ucy5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvZGZnL0RGR09wZXJhdGlvbnMuY3BwCmluZGV4IDk5YjQ3NjY3NmZjN2U4YjEyMjU2Mzlk
ODk0NTY5MWMyNThkNTI3ZDMuLjEwZjA0NTg2ODQ5YzBlNDQ3NmI4YzBiMTZlMGUxNTUwYmY3NmU3
ZGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT3BlcmF0aW9ucy5j
cHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPcGVyYXRpb25zLmNwcApAQCAt
NDIsNiArNDIsMTQgQEAKICNkZWZpbmUgU1lNQk9MX1NUUklORyhuYW1lKSAjbmFtZQogI2VuZGlm
CiAKKyNpZiAoT1MoTElOVVgpIHx8IE9TKEZSRUVCU0QpKSAmJiBDUFUoWDg2XzY0KQorI2RlZmlu
ZSBTWU1CT0xfU1RSSU5HX1JFTE9DQVRJT04obmFtZSkgI25hbWUgIkBwbHQiCisjZWxpZiBDUFUo
WDg2KSAmJiBDT01QSUxFUihNSU5HVykKKyNkZWZpbmUgU1lNQk9MX1NUUklOR19SRUxPQ0FUSU9O
KG5hbWUpICJAIiAjbmFtZSAiQDQiCisjZWxzZQorI2RlZmluZSBTWU1CT0xfU1RSSU5HX1JFTE9D
QVRJT04obmFtZSkgU1lNQk9MX1NUUklORyhuYW1lKQorI2VuZGlmCisKICNpZiBDUFUoWDg2XzY0
KQogCiAjZGVmaW5lIEZVTkNUSU9OX1dSQVBQRVJfV0lUSF9SRVRVUk5fQUREUkVTUyhmdW5jdGlv
biwgcmVnaXN0ZXIpIFwKQEAgLTQ5LDcgKzU3LDcgQEAKICAgICAiLmdsb2JsICIgU1lNQk9MX1NU
UklORyhmdW5jdGlvbikgIlxuIiBcCiAgICAgU1lNQk9MX1NUUklORyhmdW5jdGlvbikgIjoiICJc
biIgXAogICAgICAgICAibW92ICglcnNwKSwgJSIgU1RSSU5HSVpFKHJlZ2lzdGVyKSAiXG4iIFwK
LSAgICAgICAgImptcCAiIFNZTUJPTF9TVFJJTkcoZnVuY3Rpb24pICJXaXRoUmV0dXJuQWRkcmVz
cyIgIlxuIiBcCisgICAgICAgICJqbXAgIiBTWU1CT0xfU1RSSU5HX1JFTE9DQVRJT04oZnVuY3Rp
b24jI1dpdGhSZXR1cm5BZGRyZXNzKSAiXG4iIFwKICAgICApOwogI2RlZmluZSBGVU5DVElPTl9X
UkFQUEVSX1dJVEhfUkVUVVJOX0FERFJFU1NfRShmdW5jdGlvbikgICAgRlVOQ1RJT05fV1JBUFBF
Ul9XSVRIX1JFVFVSTl9BRERSRVNTKGZ1bmN0aW9uLCByc2kpCiAjZGVmaW5lIEZVTkNUSU9OX1dS
QVBQRVJfV0lUSF9SRVRVUk5fQUREUkVTU19FQ0koZnVuY3Rpb24pICBGVU5DVElPTl9XUkFQUEVS
X1dJVEhfUkVUVVJOX0FERFJFU1MoZnVuY3Rpb24sIHJjeCkKQEAgLTYzLDcgKzcxLDcgQEAKICAg
ICBTWU1CT0xfU1RSSU5HKGZ1bmN0aW9uKSAiOiIgIlxuIiBcCiAgICAgICAgICJtb3YgKCVlc3Ap
LCAlZWF4XG4iIFwKICAgICAgICAgIm1vdiAlZWF4LCAiIFNUUklOR0laRShvZmZzZXQpICIoJWVz
cClcbiIgXAotICAgICAgICAiam1wICIgU1lNQk9MX1NUUklORyhmdW5jdGlvbikgIldpdGhSZXR1
cm5BZGRyZXNzIiAiXG4iIFwKKyAgICAgICAgImptcCAiIFNZTUJPTF9TVFJJTkdfUkVMT0NBVElP
TihmdW5jdGlvbiMjV2l0aFJldHVybkFkZHJlc3MpICJcbiIgXAogICAgICk7CiAjZGVmaW5lIEZV
TkNUSU9OX1dSQVBQRVJfV0lUSF9SRVRVUk5fQUREUkVTU19FKGZ1bmN0aW9uKSAgICBGVU5DVElP
Tl9XUkFQUEVSX1dJVEhfUkVUVVJOX0FERFJFU1MoZnVuY3Rpb24sIDgpCiAjZGVmaW5lIEZVTkNU
SU9OX1dSQVBQRVJfV0lUSF9SRVRVUk5fQUREUkVTU19FQ0koZnVuY3Rpb24pICBGVU5DVElPTl9X
UkFQUEVSX1dJVEhfUkVUVVJOX0FERFJFU1MoZnVuY3Rpb24sIDE2KQpAQCAtNTA5LDcgKzUxNyw3
IEBAIGFzbSAoCiBTWU1CT0xfU1RSSU5HKGdldEhvc3RDYWxsUmV0dXJuVmFsdWUpICI6IiAiXG4i
CiAgICAgIm1vdiAtNDAoJXIxMyksICVyMTNcbiIKICAgICAibW92ICVyMTMsICVyZGlcbiIKLSAg
ICAiam1wICIgU1lNQk9MX1NUUklORyhnZXRIb3N0Q2FsbFJldHVyblZhbHVlV2l0aEV4ZWNTdGF0
ZSkgIlxuIgorICAgICJqbXAgIiBTWU1CT0xfU1RSSU5HX1JFTE9DQVRJT04oZ2V0SG9zdENhbGxS
ZXR1cm5WYWx1ZVdpdGhFeGVjU3RhdGUpICJcbiIKICk7CiAjZWxpZiBDUFUoWDg2KQogYXNtICgK
QEAgLTUxNyw3ICs1MjUsNyBAQCBhc20gKAogU1lNQk9MX1NUUklORyhnZXRIb3N0Q2FsbFJldHVy
blZhbHVlKSAiOiIgIlxuIgogICAgICJtb3YgLTQwKCVlZGkpLCAlZWRpXG4iCiAgICAgIm1vdiAl
ZWRpLCA0KCVlc3ApXG4iCi0gICAgImptcCAiIFNZTUJPTF9TVFJJTkcoZ2V0SG9zdENhbGxSZXR1
cm5WYWx1ZVdpdGhFeGVjU3RhdGUpICJcbiIKKyAgICAiam1wICIgU1lNQk9MX1NUUklOR19SRUxP
Q0FUSU9OKGdldEhvc3RDYWxsUmV0dXJuVmFsdWVXaXRoRXhlY1N0YXRlKSAiXG4iCiApOwogI2Vu
ZGlmCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUU3R1YnMuY3Bw
IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRTdHVicy5jcHAKaW5kZXggOTMzNTE2ZTIw
YjMyNzEyZDllY2E5NzAzNzFkMTcxODVkYjVjODE4Ny4uMTM5ZjYwNjllMGM1OTUyMTk4MmRkODkw
YWYyMzc3ODg1ODM1ZjI3YiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9K
SVRTdHVicy5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRTdHVicy5jcHAK
QEAgLTgyLDEyICs4MiwxMCBAQCBuYW1lc3BhY2UgSlNDIHsKIAogI2lmIChPUyhMSU5VWCkgfHwg
T1MoRlJFRUJTRCkpICYmIENQVShYODZfNjQpCiAjZGVmaW5lIFNZTUJPTF9TVFJJTkdfUkVMT0NB
VElPTihuYW1lKSAjbmFtZSAiQHBsdCIKLSNlbGlmIE9TKERBUldJTikgfHwgKENQVShYODZfNjQp
ICYmIENPTVBJTEVSKE1JTkdXKSAmJiAhR0NDX1ZFUlNJT05fQVRfTEVBU1QoNCwgNSwgMCkpCi0j
ZGVmaW5lIFNZTUJPTF9TVFJJTkdfUkVMT0NBVElPTihuYW1lKSAiXyIgI25hbWUKICNlbGlmIENQ
VShYODYpICYmIENPTVBJTEVSKE1JTkdXKQogI2RlZmluZSBTWU1CT0xfU1RSSU5HX1JFTE9DQVRJ
T04obmFtZSkgIkAiICNuYW1lICJANCIKICNlbHNlCi0jZGVmaW5lIFNZTUJPTF9TVFJJTkdfUkVM
T0NBVElPTihuYW1lKSAjbmFtZQorI2RlZmluZSBTWU1CT0xfU1RSSU5HX1JFTE9DQVRJT04obmFt
ZSkgU1lNQk9MX1NUUklORyhuYW1lKQogI2VuZGlmCiAKICNpZiBPUyhEQVJXSU4pCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>112561</attachid>
            <date>2011-10-26 10:34:02 -0700</date>
            <delta_ts>2011-10-31 15:38:20 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-70904-20111026193400.patch</filename>
            <type>text/plain</type>
            <size>4219</size>
            <attacher name="Andy Wingo">wingo</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogOTg0NzcKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0
Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGQy
YjYzOTAxMzczNmIyMzc3ODg3NjMwNDdjM2I1OTJhNzVhMmU0YWMuLjFmMzNiNjVlMzA1NjI5ZTJk
MTZmYTYzYTUwM2ZmNzZkNGM0OWY2NTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz
ICsxLDIwIEBACisyMDExLTEwLTI2ICBBbmR5IFdpbmdvICA8d2luZ29AaWdhbGlhLmNvbT4KKwor
ICAgICAgICBGaXggREZHIEpJVCBjb21waWxhdGlvbiBvbiBMaW51eCB0YXJnZXRzLgorICAgICAg
ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzA5MDQKKworICAgICAg
ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGppdC9KSVRTdHVicy5j
cHAgKFNZTUJPTF9TVFJJTkdfUkVMT0NBVElPTik6IFNpbXBsaWZ5IHRoaXMKKyAgICAgICAgbWFj
cm8uCisKKyAgICAgICAgKiBkZmcvREZHT3BlcmF0aW9ucy5jcHAgKFNZTUJPTF9TVFJJTkdfUkVM
T0NBVElPTik6IENvcHkgdGhlCisgICAgICAgIHNpbXBsaWZpZWQgZGVmaW5pdGlvbiBmcm9tIGpp
dC9KSVRTdHVicy5jcHAuCisgICAgICAgIChGVU5DVElPTl9XUkFQUEVSX1dJVEhfUkVUVVJOX0FE
RFJFU1MsIGdldEhvc3RDYWxsUmV0dXJuVmFsdWUpOgorICAgICAgICBVc2UgdGhlIG1hY3JvIHRv
IGFjY2VzcyB0cmFtcG9saW5lIHRhcmdldHMgdGhyb3VnaCB0aGUgUExUIG9uIFBJQworICAgICAg
ICBzeXN0ZW1zLCBpbnN0ZWFkIG9mIGludHJvZHVjaW5nIGEgdGV4dCByZWxvY2F0aW9uLiAgT3Ro
ZXJ3aXNlLCB0aGUKKyAgICAgICAgbGlicmFyeSBmYWlscyB0byBsaW5rLgorCiAyMDExLTEwLTI1
ICBHYXZpbiBCYXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4KIAogICAgICAgICBT
cGxpdCBERkdKSVRDb2RlR2VuZXJhdG9yOjpjYWxsT3BlcmF0aW9uIG1ldGhvZHMKZGlmZiAtLWdp
dCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT3BlcmF0aW9ucy5jcHAgYi9Tb3VyY2Uv
SmF2YVNjcmlwdENvcmUvZGZnL0RGR09wZXJhdGlvbnMuY3BwCmluZGV4IDk5YjQ3NjY3NmZjN2U4
YjEyMjU2MzlkODk0NTY5MWMyNThkNTI3ZDMuLjEwZjA0NTg2ODQ5YzBlNDQ3NmI4YzBiMTZlMGUx
NTUwYmY3NmU3ZGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT3Bl
cmF0aW9ucy5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPcGVyYXRpb25z
LmNwcApAQCAtNDIsNiArNDIsMTQgQEAKICNkZWZpbmUgU1lNQk9MX1NUUklORyhuYW1lKSAjbmFt
ZQogI2VuZGlmCiAKKyNpZiAoT1MoTElOVVgpIHx8IE9TKEZSRUVCU0QpKSAmJiBDUFUoWDg2XzY0
KQorI2RlZmluZSBTWU1CT0xfU1RSSU5HX1JFTE9DQVRJT04obmFtZSkgI25hbWUgIkBwbHQiCisj
ZWxpZiBDUFUoWDg2KSAmJiBDT01QSUxFUihNSU5HVykKKyNkZWZpbmUgU1lNQk9MX1NUUklOR19S
RUxPQ0FUSU9OKG5hbWUpICJAIiAjbmFtZSAiQDQiCisjZWxzZQorI2RlZmluZSBTWU1CT0xfU1RS
SU5HX1JFTE9DQVRJT04obmFtZSkgU1lNQk9MX1NUUklORyhuYW1lKQorI2VuZGlmCisKICNpZiBD
UFUoWDg2XzY0KQogCiAjZGVmaW5lIEZVTkNUSU9OX1dSQVBQRVJfV0lUSF9SRVRVUk5fQUREUkVT
UyhmdW5jdGlvbiwgcmVnaXN0ZXIpIFwKQEAgLTQ5LDcgKzU3LDcgQEAKICAgICAiLmdsb2JsICIg
U1lNQk9MX1NUUklORyhmdW5jdGlvbikgIlxuIiBcCiAgICAgU1lNQk9MX1NUUklORyhmdW5jdGlv
bikgIjoiICJcbiIgXAogICAgICAgICAibW92ICglcnNwKSwgJSIgU1RSSU5HSVpFKHJlZ2lzdGVy
KSAiXG4iIFwKLSAgICAgICAgImptcCAiIFNZTUJPTF9TVFJJTkcoZnVuY3Rpb24pICJXaXRoUmV0
dXJuQWRkcmVzcyIgIlxuIiBcCisgICAgICAgICJqbXAgIiBTWU1CT0xfU1RSSU5HX1JFTE9DQVRJ
T04oZnVuY3Rpb24jI1dpdGhSZXR1cm5BZGRyZXNzKSAiXG4iIFwKICAgICApOwogI2RlZmluZSBG
VU5DVElPTl9XUkFQUEVSX1dJVEhfUkVUVVJOX0FERFJFU1NfRShmdW5jdGlvbikgICAgRlVOQ1RJ
T05fV1JBUFBFUl9XSVRIX1JFVFVSTl9BRERSRVNTKGZ1bmN0aW9uLCByc2kpCiAjZGVmaW5lIEZV
TkNUSU9OX1dSQVBQRVJfV0lUSF9SRVRVUk5fQUREUkVTU19FQ0koZnVuY3Rpb24pICBGVU5DVElP
Tl9XUkFQUEVSX1dJVEhfUkVUVVJOX0FERFJFU1MoZnVuY3Rpb24sIHJjeCkKQEAgLTYzLDcgKzcx
LDcgQEAKICAgICBTWU1CT0xfU1RSSU5HKGZ1bmN0aW9uKSAiOiIgIlxuIiBcCiAgICAgICAgICJt
b3YgKCVlc3ApLCAlZWF4XG4iIFwKICAgICAgICAgIm1vdiAlZWF4LCAiIFNUUklOR0laRShvZmZz
ZXQpICIoJWVzcClcbiIgXAotICAgICAgICAiam1wICIgU1lNQk9MX1NUUklORyhmdW5jdGlvbikg
IldpdGhSZXR1cm5BZGRyZXNzIiAiXG4iIFwKKyAgICAgICAgImptcCAiIFNZTUJPTF9TVFJJTkdf
UkVMT0NBVElPTihmdW5jdGlvbiMjV2l0aFJldHVybkFkZHJlc3MpICJcbiIgXAogICAgICk7CiAj
ZGVmaW5lIEZVTkNUSU9OX1dSQVBQRVJfV0lUSF9SRVRVUk5fQUREUkVTU19FKGZ1bmN0aW9uKSAg
ICBGVU5DVElPTl9XUkFQUEVSX1dJVEhfUkVUVVJOX0FERFJFU1MoZnVuY3Rpb24sIDgpCiAjZGVm
aW5lIEZVTkNUSU9OX1dSQVBQRVJfV0lUSF9SRVRVUk5fQUREUkVTU19FQ0koZnVuY3Rpb24pICBG
VU5DVElPTl9XUkFQUEVSX1dJVEhfUkVUVVJOX0FERFJFU1MoZnVuY3Rpb24sIDE2KQpAQCAtNTA5
LDcgKzUxNyw3IEBAIGFzbSAoCiBTWU1CT0xfU1RSSU5HKGdldEhvc3RDYWxsUmV0dXJuVmFsdWUp
ICI6IiAiXG4iCiAgICAgIm1vdiAtNDAoJXIxMyksICVyMTNcbiIKICAgICAibW92ICVyMTMsICVy
ZGlcbiIKLSAgICAiam1wICIgU1lNQk9MX1NUUklORyhnZXRIb3N0Q2FsbFJldHVyblZhbHVlV2l0
aEV4ZWNTdGF0ZSkgIlxuIgorICAgICJqbXAgIiBTWU1CT0xfU1RSSU5HX1JFTE9DQVRJT04oZ2V0
SG9zdENhbGxSZXR1cm5WYWx1ZVdpdGhFeGVjU3RhdGUpICJcbiIKICk7CiAjZWxpZiBDUFUoWDg2
KQogYXNtICgKQEAgLTUxNyw3ICs1MjUsNyBAQCBhc20gKAogU1lNQk9MX1NUUklORyhnZXRIb3N0
Q2FsbFJldHVyblZhbHVlKSAiOiIgIlxuIgogICAgICJtb3YgLTQwKCVlZGkpLCAlZWRpXG4iCiAg
ICAgIm1vdiAlZWRpLCA0KCVlc3ApXG4iCi0gICAgImptcCAiIFNZTUJPTF9TVFJJTkcoZ2V0SG9z
dENhbGxSZXR1cm5WYWx1ZVdpdGhFeGVjU3RhdGUpICJcbiIKKyAgICAiam1wICIgU1lNQk9MX1NU
UklOR19SRUxPQ0FUSU9OKGdldEhvc3RDYWxsUmV0dXJuVmFsdWVXaXRoRXhlY1N0YXRlKSAiXG4i
CiApOwogI2VuZGlmCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklU
U3R1YnMuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRTdHVicy5jcHAKaW5kZXgg
OTMzNTE2ZTIwYjMyNzEyZDllY2E5NzAzNzFkMTcxODVkYjVjODE4Ny4uMTM5ZjYwNjllMGM1OTUy
MTk4MmRkODkwYWYyMzc3ODg1ODM1ZjI3YiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRD
b3JlL2ppdC9KSVRTdHVicy5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRT
dHVicy5jcHAKQEAgLTgyLDEyICs4MiwxMCBAQCBuYW1lc3BhY2UgSlNDIHsKIAogI2lmIChPUyhM
SU5VWCkgfHwgT1MoRlJFRUJTRCkpICYmIENQVShYODZfNjQpCiAjZGVmaW5lIFNZTUJPTF9TVFJJ
TkdfUkVMT0NBVElPTihuYW1lKSAjbmFtZSAiQHBsdCIKLSNlbGlmIE9TKERBUldJTikgfHwgKENQ
VShYODZfNjQpICYmIENPTVBJTEVSKE1JTkdXKSAmJiAhR0NDX1ZFUlNJT05fQVRfTEVBU1QoNCwg
NSwgMCkpCi0jZGVmaW5lIFNZTUJPTF9TVFJJTkdfUkVMT0NBVElPTihuYW1lKSAiXyIgI25hbWUK
ICNlbGlmIENQVShYODYpICYmIENPTVBJTEVSKE1JTkdXKQogI2RlZmluZSBTWU1CT0xfU1RSSU5H
X1JFTE9DQVRJT04obmFtZSkgIkAiICNuYW1lICJANCIKICNlbHNlCi0jZGVmaW5lIFNZTUJPTF9T
VFJJTkdfUkVMT0NBVElPTihuYW1lKSAjbmFtZQorI2RlZmluZSBTWU1CT0xfU1RSSU5HX1JFTE9D
QVRJT04obmFtZSkgU1lNQk9MX1NUUklORyhuYW1lKQogI2VuZGlmCiAKICNpZiBPUyhEQVJXSU4p
Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>