70880 2011-10-26 01:12:54 -0700 Fix editing/selection/caret-mode-paragraph-keys-navigation.html for Mac 2011-10-26 02:33:06 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa cshu eric ojan tkent tonikitoo tony webkit.review.bot xji oldest_to_newest 490644 0 rniwa 2011-10-26 01:12:54 -0700 editing/selection/caret-mode-paragraph-keys-navigation.html assumes ctrlKey enable word-boundary movement, which isn't case on Mac. We need to use altKey on Mac instead. 490646 1 112467 rniwa 2011-10-26 01:14:57 -0700 Created attachment 112467 fixes the test 490657 2 112467 eric 2011-10-26 01:25:26 -0700 Comment on attachment 112467 fixes the test OK. What about Apple Mac? 490660 3 112467 tkent 2011-10-26 01:28:51 -0700 Comment on attachment 112467 fixes the test View in context: https://bugs.webkit.org/attachment.cgi?id=112467&action=review > LayoutTests/editing/selection/caret-mode-paragraph-keys-navigation.html:43 > + var modifierForWordGranularity = navigator.platform == "MacIntel" ? "altKey" : "ctrlKey"; eventSender.keyDown() can have a single modifier name for such platform-dependent keys . We already have the followings: "addSelectionKey" (equivalent to metaKey in Mac, ctrlKey in Windows) "rangeSelectionKey" (equivalent to shiftKey in Mac and Windows) (From http://trac.webkit.org/wiki/Writing%20Layout%20Tests%20for%20DumpRenderTree) 490665 4 eric 2011-10-26 01:31:44 -0700 Why is this only failing on Chromium Mac? Is it skipped on AppleMac? 490673 5 112467 rniwa 2011-10-26 01:50:00 -0700 Comment on attachment 112467 fixes the test View in context: https://bugs.webkit.org/attachment.cgi?id=112467&action=review >> LayoutTests/editing/selection/caret-mode-paragraph-keys-navigation.html:43 >> + var modifierForWordGranularity = navigator.platform == "MacIntel" ? "altKey" : "ctrlKey"; > > eventSender.keyDown() can have a single modifier name for such platform-dependent keys . We already have the followings: > "addSelectionKey" (equivalent to metaKey in Mac, ctrlKey in Windows) > "rangeSelectionKey" (equivalent to shiftKey in Mac and Windows) > (From http://trac.webkit.org/wiki/Writing%20Layout%20Tests%20for%20DumpRenderTree) That might be a good idea. 490674 6 rniwa 2011-10-26 01:50:41 -0700 (In reply to comment #4) > Why is this only failing on Chromium Mac? Is it skipped on AppleMac? According to the comment in Skipped, Apple Mac doesn't support the DRT method. 490694 7 112467 webkit.review.bot 2011-10-26 02:33:01 -0700 Comment on attachment 112467 fixes the test Clearing flags on attachment: 112467 Committed r98457: <http://trac.webkit.org/changeset/98457> 490695 8 webkit.review.bot 2011-10-26 02:33:06 -0700 All reviewed patches have been landed. Closing bug. 112467 2011-10-26 01:14:57 -0700 2011-10-26 02:33:01 -0700 fixes the test bug-70880-20111026011456.patch text/plain 3226 rniwa SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDk4NDQ0KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMTAtMjYgIFJ5b3N1a2UgTml3YSAgPHJu aXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IGVkaXRpbmcvc2VsZWN0aW9uL2NhcmV0LW1v ZGUtcGFyYWdyYXBoLWtleXMtbmF2aWdhdGlvbi5odG1sIGZvciBNYWMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcwODgwCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlIG9wdGlvbiBrZXkgKGluc3RlYWQg b2YgY29udHJvbCBrZXkpIHRvIG1vdmUgYmV0d2VlbiB3b3JkIGJvdW5kYXJpZXMgb24gTWFjLgor CisgICAgICAgICogZWRpdGluZy9zZWxlY3Rpb24vY2FyZXQtbW9kZS1wYXJhZ3JhcGgta2V5cy1u YXZpZ2F0aW9uLmh0bWw6CisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3Rh dGlvbnMudHh0OgorCiAyMDExLTEwLTI2ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3Jn PgogCiAgICAgICAgIENsZWFudXAgQ2hyb21pdW0gdGVzdCBleHBlY3RhdGlvbi4gVGhlc2UgdGVz dHMgd2VyZSBlcnJvbmVvdXNseSBtYXJrZWQgYXMgdGltaW5nIG91dCBpbnRlcm1pdHRlbnRseQpJ bmRleDogTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vY2FyZXQtbW9kZS1wYXJhZ3JhcGgt a2V5cy1uYXZpZ2F0aW9uLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZWRpdGluZy9z ZWxlY3Rpb24vY2FyZXQtbW9kZS1wYXJhZ3JhcGgta2V5cy1uYXZpZ2F0aW9uLmh0bWwJKHJldmlz aW9uIDk4NDM3KQorKysgTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vY2FyZXQtbW9kZS1w YXJhZ3JhcGgta2V5cy1uYXZpZ2F0aW9uLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTM5LDE4ICsz OSwxOSBAQCBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CiAgIHNob3VsZEJlKCJn ZXRTZWxlY3Rpb24oKS5iYXNlT2Zmc2V0IiwgIjE1Iik7CiAgIHNob3VsZEJlKCJnZXRTZWxlY3Rp b24oKS5leHRlbnRPZmZzZXQiLCAiMTciKTsKIAotICAvLyBjaGVjayBsZWZ0L3JpZ2h0IGFycm93 cyArIEN0cmwKLSAgZXZlbnRTZW5kZXIua2V5RG93bigicmlnaHRBcnJvdyIsIFsiY3RybEtleSJd KTsKKyAgLy8gY2hlY2sgbGVmdC9yaWdodCBhcnJvd3MgKyBDdHJsL09wdGlvbgorICB2YXIgbW9k aWZpZXJGb3JXb3JkR3JhbnVsYXJpdHkgPSBuYXZpZ2F0b3IucGxhdGZvcm0gPT0gIk1hY0ludGVs IiA/ICJhbHRLZXkiIDogImN0cmxLZXkiOworICBldmVudFNlbmRlci5rZXlEb3duKCJyaWdodEFy cm93IiwgW21vZGlmaWVyRm9yV29yZEdyYW51bGFyaXR5XSk7CiAgIHNob3VsZEJlKCJnZXRTZWxl Y3Rpb24oKS5iYXNlT2Zmc2V0IiwgIjIxIik7Ci0gIGV2ZW50U2VuZGVyLmtleURvd24oImxlZnRB cnJvdyIsIFsiY3RybEtleSJdKTsKKyAgZXZlbnRTZW5kZXIua2V5RG93bigibGVmdEFycm93Iiwg W21vZGlmaWVyRm9yV29yZEdyYW51bGFyaXR5XSk7CiAgIHNob3VsZEJlKCJnZXRTZWxlY3Rpb24o KS5iYXNlT2Zmc2V0IiwgIjE2Iik7CiAKLSAgLy8gY2hlY2sgbGVmdC9yaWdodCBhcnJvd3MgKyBD dHJsICsgU2hpZnQKLSAgZXZlbnRTZW5kZXIua2V5RG93bigicmlnaHRBcnJvdyIsIFsiY3RybEtl eSIsICJzaGlmdEtleSJdKTsKLSAgZXZlbnRTZW5kZXIua2V5RG93bigicmlnaHRBcnJvdyIsIFsi Y3RybEtleSIsICJzaGlmdEtleSJdKTsKKyAgLy8gY2hlY2sgbGVmdC9yaWdodCBhcnJvd3MgKyBD dHJsL09wdGlvbiArIFNoaWZ0CisgIGV2ZW50U2VuZGVyLmtleURvd24oInJpZ2h0QXJyb3ciLCBb bW9kaWZpZXJGb3JXb3JkR3JhbnVsYXJpdHksICJzaGlmdEtleSJdKTsKKyAgZXZlbnRTZW5kZXIu a2V5RG93bigicmlnaHRBcnJvdyIsIFttb2RpZmllckZvcldvcmRHcmFudWxhcml0eSwgInNoaWZ0 S2V5Il0pOwogICBzaG91bGRCZSgiZ2V0U2VsZWN0aW9uKCkuYmFzZU9mZnNldCIsICIxNiIpOwog ICBzaG91bGRCZSgiZ2V0U2VsZWN0aW9uKCkuZXh0ZW50T2Zmc2V0IiwgIjI2Iik7Ci0gIGV2ZW50 U2VuZGVyLmtleURvd24oImxlZnRBcnJvdyIsIFsiY3RybEtleSJdKTsKKyAgZXZlbnRTZW5kZXIu a2V5RG93bigibGVmdEFycm93IiwgW21vZGlmaWVyRm9yV29yZEdyYW51bGFyaXR5XSk7CiAgIHNo b3VsZEJlKCJnZXRTZWxlY3Rpb24oKS5iYXNlT2Zmc2V0IiwgIjIyIik7CiB9CiAKSW5kZXg6IExh eW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50 eHQJKHJldmlzaW9uIDk4NDQzKQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVz dF9leHBlY3RhdGlvbnMudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0yNDgwLDcgKzI0ODAsNiBAQCBC VUdDUjY3NTQwIExJTlVYIFdJTiA6IGZhc3QvcmVwYWludC90ZXh0CiBCVUdDUjY3NDQyIExJTlVY IFdJTiA6IGZhc3QvY2FudmFzL2ZpbGxUZXh0LXNoYWRvdy5odG1sID0gVEVYVAogCiBCVUdXSzUx NzIwIERFQlVHIDogaHR0cC90ZXN0cy9pbmNyZW1lbnRhbC9zcGxpdC1oZXgtZW50aXRpZXMucGwg PSBQQVNTIENSQVNICi1CVUdDUjY3NDYzIE1BQyA6IGVkaXRpbmcvc2VsZWN0aW9uL2NhcmV0LW1v ZGUtcGFyYWdyYXBoLWtleXMtbmF2aWdhdGlvbi5odG1sID0gVEVYVAogCiBCVUdDUjY4NDM2IExJ TlVYIERFQlVHIDogZmFzdC9kb20vRE9NSW1wbGVtZW50YXRpb24vY3JlYXRlRG9jdW1lbnQtd2l0 aC11c2VkLWRvY3R5cGUuaHRtbCA9IFBBU1MgVElNRU9VVAogQlVHQ1I2ODQzNiBNQUMgV0lOIERF QlVHIDogZmFzdC9kb20vRE9NSW1wbGVtZW50YXRpb24vY3JlYXRlRG9jdW1lbnQtd2l0aC11c2Vk LWRvY3R5cGUuaHRtbCA9IFBBU1MgVElNRU9VVCBURVhUCg==