70865 2011-10-25 18:06:33 -0700 JSEventTarget.cpp has a bunch of unnessary includes 2011-10-26 10:31:52 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth abarth crogers dominicc eric webkit.review.bot oldest_to_newest 490510 0 abarth 2011-10-25 18:06:33 -0700 JSEventTarget.cpp has a bunch of unnessary includes 490511 1 112438 abarth 2011-10-25 18:08:52 -0700 Created attachment 112438 Patch 490517 2 112438 eric 2011-10-25 18:18:08 -0700 Comment on attachment 112438 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112438&action=review > Source/WebCore/webaudio/JavaScriptAudioNode.h:49 > +// FIXME: AudioNode should be introduced at the base of the inheritance hierarchy (i.e., as a base class for AudioNode). I'm not sure this makes sense? You use AudioNode twice? 490521 3 abarth 2011-10-25 18:20:35 -0700 > I'm not sure this makes sense? You use AudioNode twice? Yeah, I meant EventTarget the first time. 490525 4 112440 abarth 2011-10-25 18:27:06 -0700 Created attachment 112440 Patch for landing 490540 5 112440 webkit.review.bot 2011-10-25 20:06:07 -0700 Comment on attachment 112440 Patch for landing Clearing flags on attachment: 112440 Committed r98427: <http://trac.webkit.org/changeset/98427> 490541 6 webkit.review.bot 2011-10-25 20:06:11 -0700 All reviewed patches have been landed. Closing bug. 490551 7 crogers 2011-10-25 21:49:28 -0700 Adam, FYI, Dominic and I have been talking about making JavaScriptAudioNode *not* be an EventTarget at all. But instead use a Callback instead of EventListener 490554 8 abarth 2011-10-25 22:01:02 -0700 Even better. BTW, is it too late to rename the interface? Having "JavaScript" in an interface name doesn't make much sense. (Imagine Python bindings for the DOM.) 490988 9 crogers 2011-10-26 10:23:42 -0700 (In reply to comment #8) > Even better. > > BTW, is it too late to rename the interface? Having "JavaScript" in an interface name doesn't make much sense. (Imagine Python bindings for the DOM.) I agree that the name isn't the best. Unfortunately, JavaScriptAudioNode is one of the most common nodes people are using, so if we do change the name then I want to provide a deprecation path where the old name (as well as the new name) continues to work for a period of time. 490995 10 eric 2011-10-26 10:31:52 -0700 Deprecation path seems OK. They talk about how the future is always larger than the past. :) So seems like if we ever want to have other languages in the browser, JavaScript is a bad interface prefix. :) 112438 2011-10-25 18:08:52 -0700 2011-10-25 18:27:00 -0700 Patch bug-70865-20111025180851.patch text/plain 5311 abarth SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk4NDE3KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMTAtMjUgIEFkYW0gQmFy dGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBKU0V2ZW50VGFyZ2V0LmNwcCBoYXMg YSBidW5jaCBvZiB1bm5lc3NhcnkgaW5jbHVkZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTcwODY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgSW4gdGhlIHByb2Nlc3Mgb2YgcmVtb3ZpbmcgdGhlc2UgaW5j bHVkZXMsIEkgbm90aWNlZCB3ZSBoYWQgYSBidW5jaCBvZgorICAgICAgICBub24tYXV0b2dlbmVy YXRlZCBjb2RlIGluIHRoaXMgZmlsZSwgd2hpY2ggSSd2ZSBub3cgYXV0b2dlbmVyYXRlZC4KKwor ICAgICAgICAqIGJpbmRpbmdzL2pzL0pTRXZlbnRUYXJnZXQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6dG9FdmVudFRhcmdldCk6CisgICAgICAgICAgICAtIE9uZSBzdWJ0bHkgaGVyZSBpcyB0aGUg b3V0dGVyIHN0YXRpY19jYXN0LCB3aGljaCBpcyBjYXVzZWQgYnkgYW4KKyAgICAgICAgICAgICAg aW5oZXJpdGFuY2UgaW5mZWxpY2l0eSBpbiBKYXZhU2NyaXB0QXVkaW9Ob2RlLCB3aGljaCBJJ3Zl IG5vdGVkCisgICAgICAgICAgICAgIHdpdGggYSBGSVhNRS4gIEluIGFueSBjYXNlLCB0aGUgZXh0 cmEgc3RhdGljX2Nhc3Qgc2hvdWxkbid0IGNhdXNlCisgICAgICAgICAgICAgIGFueSB0cm91Ymxl LgorICAgICAgICAqIHdlYmF1ZGlvL0phdmFTY3JpcHRBdWRpb05vZGUuaDoKKwogMjAxMS0xMC0y NSAgTWFyayBIYWhuZW5iZXJnICA8bWhhaG5lbmJlcmdAYXBwbGUuY29tPgogCiAgICAgICAgIFJl bW92ZSBwdXRWaXJ0dWFsCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0V2ZW50 VGFyZ2V0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0V2 ZW50VGFyZ2V0LmNwcAkocmV2aXNpb24gOTg0MTApCisrKyBTb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy9qcy9KU0V2ZW50VGFyZ2V0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjYsODIgKzI2LDEwIEBA CiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiSlNFdmVudFRhcmdldC5oIgogCi0jaW5j bHVkZSAiRE9NV2luZG93LmgiCi0jaW5jbHVkZSAiRG9jdW1lbnQuaCIKICNpbmNsdWRlICJFdmVu dFRhcmdldEhlYWRlcnMuaCIKICNpbmNsdWRlICJFdmVudFRhcmdldEludGVyZmFjZXMuaCIKLSNp bmNsdWRlICJKU0RPTVdpbmRvdy5oIgogI2luY2x1ZGUgIkpTRE9NV2luZG93U2hlbGwuaCIKICNp bmNsdWRlICJKU0V2ZW50TGlzdGVuZXIuaCIKLSNpbmNsdWRlICJKU01lc3NhZ2VQb3J0LmgiCi0j aW5jbHVkZSAiSlNOb2RlLmgiCi0jaWYgRU5BQkxFKFNIQVJFRF9XT1JLRVJTKQotCi0jaW5jbHVk ZSAiSlNTaGFyZWRXb3JrZXIuaCIKLSNpbmNsdWRlICJKU1NoYXJlZFdvcmtlckNvbnRleHQuaCIK LSNlbmRpZgotCi0jaW5jbHVkZSAiSlNYTUxIdHRwUmVxdWVzdC5oIgotI2luY2x1ZGUgIkpTWE1M SHR0cFJlcXVlc3RVcGxvYWQuaCIKLSNpbmNsdWRlICJNZXNzYWdlUG9ydC5oIgotCi0jaWYgRU5B QkxFKFNIQVJFRF9XT1JLRVJTKQotI2luY2x1ZGUgIlNoYXJlZFdvcmtlci5oIgotI2luY2x1ZGUg IlNoYXJlZFdvcmtlckNvbnRleHQuaCIKLSNlbmRpZgotCi0jaW5jbHVkZSAiWE1MSHR0cFJlcXVl c3QuaCIKLSNpbmNsdWRlICJYTUxIdHRwUmVxdWVzdFVwbG9hZC5oIgotCi0jaW5jbHVkZSAiRXZl bnRTb3VyY2UuaCIKLSNpbmNsdWRlICJKU0V2ZW50U291cmNlLmgiCi0KLSNpbmNsdWRlICJET01B cHBsaWNhdGlvbkNhY2hlLmgiCi0jaW5jbHVkZSAiSlNET01BcHBsaWNhdGlvbkNhY2hlLmgiCi0K LSNpZiBFTkFCTEUoU1ZHKQotI2luY2x1ZGUgIlNWR0VsZW1lbnRJbnN0YW5jZS5oIgotI2luY2x1 ZGUgIkpTU1ZHRWxlbWVudEluc3RhbmNlLmgiCi0jZW5kaWYKLQotI2lmIEVOQUJMRShXT1JLRVJT KQotI2luY2x1ZGUgIkRlZGljYXRlZFdvcmtlckNvbnRleHQuaCIKLSNpbmNsdWRlICJKU0RlZGlj YXRlZFdvcmtlckNvbnRleHQuaCIKLSNpbmNsdWRlICJKU1dvcmtlci5oIgotI2luY2x1ZGUgIldv cmtlci5oIgotI2VuZGlmCi0KLSNpZiBFTkFCTEUoTk9USUZJQ0FUSU9OUykKLSNpbmNsdWRlICJK U05vdGlmaWNhdGlvbi5oIgotI2luY2x1ZGUgIk5vdGlmaWNhdGlvbi5oIgotI2VuZGlmCi0KLSNp ZiBFTkFCTEUoSU5ERVhFRF9EQVRBQkFTRSkKLSNpbmNsdWRlICJJREJSZXF1ZXN0LmgiCi0jaW5j bHVkZSAiSlNJREJSZXF1ZXN0LmgiCi0jZW5kaWYKLQotI2lmIEVOQUJMRShXRUJfQVVESU8pCi0j aW5jbHVkZSAiQXVkaW9Db250ZXh0LmgiCi0jaW5jbHVkZSAiSlNBdWRpb0NvbnRleHQuaCIKLSNp bmNsdWRlICJKU0phdmFTY3JpcHRBdWRpb05vZGUuaCIKLSNpbmNsdWRlICJKYXZhU2NyaXB0QXVk aW9Ob2RlLmgiCi0jZW5kaWYKLQotI2lmIEVOQUJMRShXRUJfU09DS0VUUykKLSNpbmNsdWRlICJK U1dlYlNvY2tldC5oIgotI2luY2x1ZGUgIldlYlNvY2tldC5oIgotI2VuZGlmCi0KLSNpZiBFTkFC TEUoQkxPQikKLSNpbmNsdWRlICJKU0ZpbGVSZWFkZXIuaCIKLSNpbmNsdWRlICJGaWxlUmVhZGVy LmgiCi0jZW5kaWYKLQotI2lmIEVOQUJMRShNRURJQV9TVFJFQU0pCi0jaW5jbHVkZSAiTG9jYWxN ZWRpYVN0cmVhbS5oIgotI2luY2x1ZGUgIk1lZGlhU3RyZWFtLmgiCi0jZW5kaWYKIAogdXNpbmcg bmFtZXNwYWNlIEpTQzsKIApAQCAtMTM2LDQ2ICs2NCwxOSBAQCBKU1ZhbHVlIHRvSlMoRXhlY1N0 YXRlKiBleGVjLCBKU0RPTUdsb2JhCiAKICN1bmRlZiBUUllfVE9fV1JBUF9XSVRIX0lOVEVSRkFD RQogCisjZGVmaW5lIFRSWV9UT19VTldSQVBfV0lUSF9JTlRFUkZBQ0UoaW50ZXJmYWNlTmFtZSkg XAorICAgIGlmICh2YWx1ZS5pbmhlcml0cygmSlMjI2ludGVyZmFjZU5hbWU6OnNfaW5mbykpIFwK KyAgICAgICAgcmV0dXJuIHN0YXRpY19jYXN0PGludGVyZmFjZU5hbWUqPihzdGF0aWNfY2FzdDxK UyMjaW50ZXJmYWNlTmFtZSo+KGFzT2JqZWN0KHZhbHVlKSktPmltcGwoKSk7CisKIEV2ZW50VGFy Z2V0KiB0b0V2ZW50VGFyZ2V0KEpTQzo6SlNWYWx1ZSB2YWx1ZSkKIHsKLSAgICAjZGVmaW5lIENP TlZFUlRfVE9fRVZFTlRfVEFSR0VUKHR5cGUpIFwKLSAgICAgICAgaWYgKHZhbHVlLmluaGVyaXRz KCZKUyMjdHlwZTo6c19pbmZvKSkgXAotICAgICAgICAgICAgcmV0dXJuIHN0YXRpY19jYXN0PEpT IyN0eXBlKj4oYXNPYmplY3QodmFsdWUpKS0+aW1wbCgpOwotCi0gICAgQ09OVkVSVF9UT19FVkVO VF9UQVJHRVQoTm9kZSkKLSAgICBDT05WRVJUX1RPX0VWRU5UX1RBUkdFVChYTUxIdHRwUmVxdWVz dCkKLSAgICBDT05WRVJUX1RPX0VWRU5UX1RBUkdFVChYTUxIdHRwUmVxdWVzdFVwbG9hZCkKLSAg ICBDT05WRVJUX1RPX0VWRU5UX1RBUkdFVChNZXNzYWdlUG9ydCkKLQogICAgIGlmICh2YWx1ZS5p bmhlcml0cygmSlNET01XaW5kb3dTaGVsbDo6c19pbmZvKSkKICAgICAgICAgcmV0dXJuIHN0YXRp Y19jYXN0PEpTRE9NV2luZG93U2hlbGwqPihhc09iamVjdCh2YWx1ZSkpLT5pbXBsKCk7CiAKLSAg ICBDT05WRVJUX1RPX0VWRU5UX1RBUkdFVChFdmVudFNvdXJjZSkKLSAgICBDT05WRVJUX1RPX0VW RU5UX1RBUkdFVChET01BcHBsaWNhdGlvbkNhY2hlKQotCi0jaWYgRU5BQkxFKFNWRykKLSAgICBD T05WRVJUX1RPX0VWRU5UX1RBUkdFVChTVkdFbGVtZW50SW5zdGFuY2UpCi0jZW5kaWYKLQotI2lm IEVOQUJMRShXT1JLRVJTKQotICAgIENPTlZFUlRfVE9fRVZFTlRfVEFSR0VUKFdvcmtlcikKLSAg ICBDT05WRVJUX1RPX0VWRU5UX1RBUkdFVChEZWRpY2F0ZWRXb3JrZXJDb250ZXh0KQotI2VuZGlm Ci0KLSNpZiBFTkFCTEUoU0hBUkVEX1dPUktFUlMpCi0gICAgQ09OVkVSVF9UT19FVkVOVF9UQVJH RVQoU2hhcmVkV29ya2VyKQotICAgIENPTlZFUlRfVE9fRVZFTlRfVEFSR0VUKFNoYXJlZFdvcmtl ckNvbnRleHQpCi0jZW5kaWYKLQotI2lmIEVOQUJMRShOT1RJRklDQVRJT05TKQotICAgIENPTlZF UlRfVE9fRVZFTlRfVEFSR0VUKE5vdGlmaWNhdGlvbikKLSNlbmRpZgotCi0jaWYgRU5BQkxFKFdF Ql9TT0NLRVRTKQotICAgIENPTlZFUlRfVE9fRVZFTlRfVEFSR0VUKFdlYlNvY2tldCkKLSNlbmRp ZgotCisgICAgRE9NX0VWRU5UX1RBUkdFVF9JTlRFUkZBQ0VTX0ZPUl9FQUNIKFRSWV9UT19VTldS QVBfV0lUSF9JTlRFUkZBQ0UpCiAgICAgcmV0dXJuIDA7CiB9CiAKKyN1bmRlZiBUUllfVE9fVU5X UkFQX1dJVEhfSU5URVJGQUNFCisKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL3dlYmF1ZGlvL0phdmFTY3JpcHRBdWRpb05vZGUuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS93ZWJhdWRpby9KYXZhU2NyaXB0QXVkaW9Ob2RlLmgJKHJldmlzaW9uIDk4 Mzk4KQorKysgU291cmNlL1dlYkNvcmUvd2ViYXVkaW8vSmF2YVNjcmlwdEF1ZGlvTm9kZS5oCSh3 b3JraW5nIGNvcHkpCkBAIC00Niw2ICs0Niw3IEBAIGNsYXNzIEZsb2F0MzJBcnJheTsKIC8vIFRo ZSAib25hdWRpb3Byb2Nlc3MiIGF0dHJpYnV0ZSBpcyBhbiBldmVudCBsaXN0ZW5lciB3aGljaCB3 aWxsIGdldCBjYWxsZWQgcGVyaW9kaWNhbGx5IHdpdGggYW4gQXVkaW9Qcm9jZXNzaW5nRXZlbnQg d2hpY2ggaGFzCiAvLyBBdWRpb0J1ZmZlcnMgZm9yIGVhY2ggaW5wdXQgYW5kIG91dHB1dC4KIAor Ly8gRklYTUU6IEF1ZGlvTm9kZSBzaG91bGQgYmUgaW50cm9kdWNlZCBhdCB0aGUgYmFzZSBvZiB0 aGUgaW5oZXJpdGFuY2UgaGllcmFyY2h5IChpLmUuLCBhcyBhIGJhc2UgY2xhc3MgZm9yIEF1ZGlv Tm9kZSkuCiBjbGFzcyBKYXZhU2NyaXB0QXVkaW9Ob2RlIDogcHVibGljIEF1ZGlvTm9kZSwgcHVi bGljIEV2ZW50VGFyZ2V0IHsKIHB1YmxpYzoKICAgICAvLyBidWZmZXJTaXplIG11c3QgYmUgb25l IG9mIHRoZSBmb2xsb3dpbmcgdmFsdWVzOiAyNTYsIDUxMiwgMTAyNCwgMjA0OCwgNDA5NiwgODE5 MiwgMTYzODQuCg== 112440 2011-10-25 18:27:06 -0700 2011-10-25 20:06:07 -0700 Patch for landing bug-70865-20111025182704.patch text/plain 5310 abarth SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk4NDE5KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMTAtMjUgIEFkYW0gQmFy dGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBKU0V2ZW50VGFyZ2V0LmNwcCBoYXMg YSBidW5jaCBvZiB1bm5lc3NhcnkgaW5jbHVkZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTcwODY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBT ZWlkZWwuCisKKyAgICAgICAgSW4gdGhlIHByb2Nlc3Mgb2YgcmVtb3ZpbmcgdGhlc2UgaW5jbHVk ZXMsIEkgbm90aWNlZCB3ZSBoYWQgYSBidW5jaCBvZgorICAgICAgICBub24tYXV0b2dlbmVyYXRl ZCBjb2RlIGluIHRoaXMgZmlsZSwgd2hpY2ggSSd2ZSBub3cgYXV0b2dlbmVyYXRlZC4KKworICAg ICAgICAqIGJpbmRpbmdzL2pzL0pTRXZlbnRUYXJnZXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 dG9FdmVudFRhcmdldCk6CisgICAgICAgICAgICAtIE9uZSBzdWJ0bHkgaGVyZSBpcyB0aGUgb3V0 dGVyIHN0YXRpY19jYXN0LCB3aGljaCBpcyBjYXVzZWQgYnkgYW4KKyAgICAgICAgICAgICAgaW5o ZXJpdGFuY2UgaW5mZWxpY2l0eSBpbiBKYXZhU2NyaXB0QXVkaW9Ob2RlLCB3aGljaCBJJ3ZlIG5v dGVkCisgICAgICAgICAgICAgIHdpdGggYSBGSVhNRS4gIEluIGFueSBjYXNlLCB0aGUgZXh0cmEg c3RhdGljX2Nhc3Qgc2hvdWxkbid0IGNhdXNlCisgICAgICAgICAgICAgIGFueSB0cm91YmxlLgor ICAgICAgICAqIHdlYmF1ZGlvL0phdmFTY3JpcHRBdWRpb05vZGUuaDoKKwogMjAxMS0xMC0yNSAg TWFyayBIYWhuZW5iZXJnICA8bWhhaG5lbmJlcmdAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92 ZSBwdXRWaXJ0dWFsCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0V2ZW50VGFy Z2V0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0V2ZW50 VGFyZ2V0LmNwcAkocmV2aXNpb24gOTg0MTkpCisrKyBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9q cy9KU0V2ZW50VGFyZ2V0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjYsODIgKzI2LDEwIEBACiAj aW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiSlNFdmVudFRhcmdldC5oIgogCi0jaW5jbHVk ZSAiRE9NV2luZG93LmgiCi0jaW5jbHVkZSAiRG9jdW1lbnQuaCIKICNpbmNsdWRlICJFdmVudFRh cmdldEhlYWRlcnMuaCIKICNpbmNsdWRlICJFdmVudFRhcmdldEludGVyZmFjZXMuaCIKLSNpbmNs dWRlICJKU0RPTVdpbmRvdy5oIgogI2luY2x1ZGUgIkpTRE9NV2luZG93U2hlbGwuaCIKICNpbmNs dWRlICJKU0V2ZW50TGlzdGVuZXIuaCIKLSNpbmNsdWRlICJKU01lc3NhZ2VQb3J0LmgiCi0jaW5j bHVkZSAiSlNOb2RlLmgiCi0jaWYgRU5BQkxFKFNIQVJFRF9XT1JLRVJTKQotCi0jaW5jbHVkZSAi SlNTaGFyZWRXb3JrZXIuaCIKLSNpbmNsdWRlICJKU1NoYXJlZFdvcmtlckNvbnRleHQuaCIKLSNl bmRpZgotCi0jaW5jbHVkZSAiSlNYTUxIdHRwUmVxdWVzdC5oIgotI2luY2x1ZGUgIkpTWE1MSHR0 cFJlcXVlc3RVcGxvYWQuaCIKLSNpbmNsdWRlICJNZXNzYWdlUG9ydC5oIgotCi0jaWYgRU5BQkxF KFNIQVJFRF9XT1JLRVJTKQotI2luY2x1ZGUgIlNoYXJlZFdvcmtlci5oIgotI2luY2x1ZGUgIlNo YXJlZFdvcmtlckNvbnRleHQuaCIKLSNlbmRpZgotCi0jaW5jbHVkZSAiWE1MSHR0cFJlcXVlc3Qu aCIKLSNpbmNsdWRlICJYTUxIdHRwUmVxdWVzdFVwbG9hZC5oIgotCi0jaW5jbHVkZSAiRXZlbnRT b3VyY2UuaCIKLSNpbmNsdWRlICJKU0V2ZW50U291cmNlLmgiCi0KLSNpbmNsdWRlICJET01BcHBs aWNhdGlvbkNhY2hlLmgiCi0jaW5jbHVkZSAiSlNET01BcHBsaWNhdGlvbkNhY2hlLmgiCi0KLSNp ZiBFTkFCTEUoU1ZHKQotI2luY2x1ZGUgIlNWR0VsZW1lbnRJbnN0YW5jZS5oIgotI2luY2x1ZGUg IkpTU1ZHRWxlbWVudEluc3RhbmNlLmgiCi0jZW5kaWYKLQotI2lmIEVOQUJMRShXT1JLRVJTKQot I2luY2x1ZGUgIkRlZGljYXRlZFdvcmtlckNvbnRleHQuaCIKLSNpbmNsdWRlICJKU0RlZGljYXRl ZFdvcmtlckNvbnRleHQuaCIKLSNpbmNsdWRlICJKU1dvcmtlci5oIgotI2luY2x1ZGUgIldvcmtl ci5oIgotI2VuZGlmCi0KLSNpZiBFTkFCTEUoTk9USUZJQ0FUSU9OUykKLSNpbmNsdWRlICJKU05v dGlmaWNhdGlvbi5oIgotI2luY2x1ZGUgIk5vdGlmaWNhdGlvbi5oIgotI2VuZGlmCi0KLSNpZiBF TkFCTEUoSU5ERVhFRF9EQVRBQkFTRSkKLSNpbmNsdWRlICJJREJSZXF1ZXN0LmgiCi0jaW5jbHVk ZSAiSlNJREJSZXF1ZXN0LmgiCi0jZW5kaWYKLQotI2lmIEVOQUJMRShXRUJfQVVESU8pCi0jaW5j bHVkZSAiQXVkaW9Db250ZXh0LmgiCi0jaW5jbHVkZSAiSlNBdWRpb0NvbnRleHQuaCIKLSNpbmNs dWRlICJKU0phdmFTY3JpcHRBdWRpb05vZGUuaCIKLSNpbmNsdWRlICJKYXZhU2NyaXB0QXVkaW9O b2RlLmgiCi0jZW5kaWYKLQotI2lmIEVOQUJMRShXRUJfU09DS0VUUykKLSNpbmNsdWRlICJKU1dl YlNvY2tldC5oIgotI2luY2x1ZGUgIldlYlNvY2tldC5oIgotI2VuZGlmCi0KLSNpZiBFTkFCTEUo QkxPQikKLSNpbmNsdWRlICJKU0ZpbGVSZWFkZXIuaCIKLSNpbmNsdWRlICJGaWxlUmVhZGVyLmgi Ci0jZW5kaWYKLQotI2lmIEVOQUJMRShNRURJQV9TVFJFQU0pCi0jaW5jbHVkZSAiTG9jYWxNZWRp YVN0cmVhbS5oIgotI2luY2x1ZGUgIk1lZGlhU3RyZWFtLmgiCi0jZW5kaWYKIAogdXNpbmcgbmFt ZXNwYWNlIEpTQzsKIApAQCAtMTM2LDQ2ICs2NCwxOSBAQCBKU1ZhbHVlIHRvSlMoRXhlY1N0YXRl KiBleGVjLCBKU0RPTUdsb2JhCiAKICN1bmRlZiBUUllfVE9fV1JBUF9XSVRIX0lOVEVSRkFDRQog CisjZGVmaW5lIFRSWV9UT19VTldSQVBfV0lUSF9JTlRFUkZBQ0UoaW50ZXJmYWNlTmFtZSkgXAor ICAgIGlmICh2YWx1ZS5pbmhlcml0cygmSlMjI2ludGVyZmFjZU5hbWU6OnNfaW5mbykpIFwKKyAg ICAgICAgcmV0dXJuIHN0YXRpY19jYXN0PGludGVyZmFjZU5hbWUqPihzdGF0aWNfY2FzdDxKUyMj aW50ZXJmYWNlTmFtZSo+KGFzT2JqZWN0KHZhbHVlKSktPmltcGwoKSk7CisKIEV2ZW50VGFyZ2V0 KiB0b0V2ZW50VGFyZ2V0KEpTQzo6SlNWYWx1ZSB2YWx1ZSkKIHsKLSAgICAjZGVmaW5lIENPTlZF UlRfVE9fRVZFTlRfVEFSR0VUKHR5cGUpIFwKLSAgICAgICAgaWYgKHZhbHVlLmluaGVyaXRzKCZK UyMjdHlwZTo6c19pbmZvKSkgXAotICAgICAgICAgICAgcmV0dXJuIHN0YXRpY19jYXN0PEpTIyN0 eXBlKj4oYXNPYmplY3QodmFsdWUpKS0+aW1wbCgpOwotCi0gICAgQ09OVkVSVF9UT19FVkVOVF9U QVJHRVQoTm9kZSkKLSAgICBDT05WRVJUX1RPX0VWRU5UX1RBUkdFVChYTUxIdHRwUmVxdWVzdCkK LSAgICBDT05WRVJUX1RPX0VWRU5UX1RBUkdFVChYTUxIdHRwUmVxdWVzdFVwbG9hZCkKLSAgICBD T05WRVJUX1RPX0VWRU5UX1RBUkdFVChNZXNzYWdlUG9ydCkKLQogICAgIGlmICh2YWx1ZS5pbmhl cml0cygmSlNET01XaW5kb3dTaGVsbDo6c19pbmZvKSkKICAgICAgICAgcmV0dXJuIHN0YXRpY19j YXN0PEpTRE9NV2luZG93U2hlbGwqPihhc09iamVjdCh2YWx1ZSkpLT5pbXBsKCk7CiAKLSAgICBD T05WRVJUX1RPX0VWRU5UX1RBUkdFVChFdmVudFNvdXJjZSkKLSAgICBDT05WRVJUX1RPX0VWRU5U X1RBUkdFVChET01BcHBsaWNhdGlvbkNhY2hlKQotCi0jaWYgRU5BQkxFKFNWRykKLSAgICBDT05W RVJUX1RPX0VWRU5UX1RBUkdFVChTVkdFbGVtZW50SW5zdGFuY2UpCi0jZW5kaWYKLQotI2lmIEVO QUJMRShXT1JLRVJTKQotICAgIENPTlZFUlRfVE9fRVZFTlRfVEFSR0VUKFdvcmtlcikKLSAgICBD T05WRVJUX1RPX0VWRU5UX1RBUkdFVChEZWRpY2F0ZWRXb3JrZXJDb250ZXh0KQotI2VuZGlmCi0K LSNpZiBFTkFCTEUoU0hBUkVEX1dPUktFUlMpCi0gICAgQ09OVkVSVF9UT19FVkVOVF9UQVJHRVQo U2hhcmVkV29ya2VyKQotICAgIENPTlZFUlRfVE9fRVZFTlRfVEFSR0VUKFNoYXJlZFdvcmtlckNv bnRleHQpCi0jZW5kaWYKLQotI2lmIEVOQUJMRShOT1RJRklDQVRJT05TKQotICAgIENPTlZFUlRf VE9fRVZFTlRfVEFSR0VUKE5vdGlmaWNhdGlvbikKLSNlbmRpZgotCi0jaWYgRU5BQkxFKFdFQl9T T0NLRVRTKQotICAgIENPTlZFUlRfVE9fRVZFTlRfVEFSR0VUKFdlYlNvY2tldCkKLSNlbmRpZgot CisgICAgRE9NX0VWRU5UX1RBUkdFVF9JTlRFUkZBQ0VTX0ZPUl9FQUNIKFRSWV9UT19VTldSQVBf V0lUSF9JTlRFUkZBQ0UpCiAgICAgcmV0dXJuIDA7CiB9CiAKKyN1bmRlZiBUUllfVE9fVU5XUkFQ X1dJVEhfSU5URVJGQUNFCisKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL3dlYmF1ZGlvL0phdmFTY3JpcHRBdWRpb05vZGUuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS93ZWJhdWRpby9KYXZhU2NyaXB0QXVkaW9Ob2RlLmgJKHJldmlzaW9uIDk4NDE5 KQorKysgU291cmNlL1dlYkNvcmUvd2ViYXVkaW8vSmF2YVNjcmlwdEF1ZGlvTm9kZS5oCSh3b3Jr aW5nIGNvcHkpCkBAIC00Niw2ICs0Niw3IEBAIGNsYXNzIEZsb2F0MzJBcnJheTsKIC8vIFRoZSAi b25hdWRpb3Byb2Nlc3MiIGF0dHJpYnV0ZSBpcyBhbiBldmVudCBsaXN0ZW5lciB3aGljaCB3aWxs IGdldCBjYWxsZWQgcGVyaW9kaWNhbGx5IHdpdGggYW4gQXVkaW9Qcm9jZXNzaW5nRXZlbnQgd2hp Y2ggaGFzCiAvLyBBdWRpb0J1ZmZlcnMgZm9yIGVhY2ggaW5wdXQgYW5kIG91dHB1dC4KIAorLy8g RklYTUU6IEV2ZW50VGFyZ2V0IHNob3VsZCBiZSBpbnRyb2R1Y2VkIGF0IHRoZSBiYXNlIG9mIHRo ZSBpbmhlcml0YW5jZSBoaWVyYXJjaHkgKGkuZS4sIGFzIGEgYmFzZSBjbGFzcyBmb3IgQXVkaW9O b2RlKS4KIGNsYXNzIEphdmFTY3JpcHRBdWRpb05vZGUgOiBwdWJsaWMgQXVkaW9Ob2RlLCBwdWJs aWMgRXZlbnRUYXJnZXQgewogcHVibGljOgogICAgIC8vIGJ1ZmZlclNpemUgbXVzdCBiZSBvbmUg b2YgdGhlIGZvbGxvd2luZyB2YWx1ZXM6IDI1NiwgNTEyLCAxMDI0LCAyMDQ4LCA0MDk2LCA4MTky LCAxNjM4NC4K