70855 2011-10-25 14:55:33 -0700 EventTargetFactory.in is not sorted 2011-10-25 16:42:49 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth darin dglazkov webkit.review.bot oldest_to_newest 490386 0 abarth 2011-10-25 14:55:33 -0700 EventTargetFactory.in is not sorted 490391 1 112411 abarth 2011-10-25 14:57:43 -0700 Created attachment 112411 Patch 490403 2 112411 eric 2011-10-25 15:12:33 -0700 Comment on attachment 112411 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112411&action=review > PerformanceTests/ChangeLog:8 > + Add a microbenchmark for wrapping event target. And what is the perf effect of your previous change? Any? 490404 3 abarth 2011-10-25 15:15:49 -0700 == Unsorted == abarth@quadzen:~/svn/webkit$ ./out/Release/DumpRenderTree.app/Contents/MacOS/DumpRenderTree file:///Users/abarth/svn/webkit/PerformanceTests/Bindings/event-target-wrapper.html Content-Type: text/plain Running 20 times Ignoring warm-up run (612) 602 602 599 599 599 601 600 600 600 599 598 599 599 602 605 603 605 608 610 603 avg 601.65 median 600.5 stdev 3.1666228067138023 min 598 max 610 #EOF == Sorted == abarth@quadzen:~/svn/webkit$ ./out/Release/DumpRenderTree.app/Contents/MacOS/DumpRenderTree file:///Users/abarth/svn/webkit/PerformanceTests/Bindings/event-target-wrapper.html Content-Type: text/plain Running 20 times Ignoring warm-up run (609) 603 600 599 599 598 600 599 599 599 598 601 600 602 601 599 601 600 600 601 600 avg 599.95 median 600 stdev 1.243985530462473 min 598 max 603 #EOF 490405 4 abarth 2011-10-25 15:17:17 -0700 > And what is the perf effect of your previous change? Any? Ah, that I didn't measure. I'm pretty sure it's zero though because it's doing the same thing as before (one virtual function call and one branch per interface). 490467 5 112411 webkit.review.bot 2011-10-25 16:42:45 -0700 Comment on attachment 112411 Patch Clearing flags on attachment: 112411 Committed r98412: <http://trac.webkit.org/changeset/98412> 490468 6 webkit.review.bot 2011-10-25 16:42:49 -0700 All reviewed patches have been landed. Closing bug. 112411 2011-10-25 14:57:43 -0700 2011-10-25 16:42:44 -0700 Patch bug-70855-20111025145742.patch text/plain 5224 abarth SW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFBlcmZvcm1h bmNlVGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA5ODM5OCkKKysrIFBlcmZvcm1hbmNlVGVzdHMv Q2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMTAtMjUgIEFk YW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBFdmVudFRhcmdldEZhY3Rv cnkuaW4gaXMgbm90IHNvcnRlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NzA4NTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBBZGQgYSBtaWNyb2JlbmNobWFyayBmb3Igd3JhcHBpbmcgZXZlbnQgdGFyZ2V0 LgorCisgICAgICAgICogQmluZGluZ3M6IEFkZGVkLgorICAgICAgICAqIEJpbmRpbmdzL2V2ZW50 LXRhcmdldC13cmFwcGVyLmh0bWw6IEFkZGVkLgorICAgICAgICAqIFBhcnNlci9yZXNvdXJjZXMv cnVubmVyLmpzOgorICAgICAgICAocnVuTG9vcCk6CisgICAgICAgICAgICAtIExldCB0aGUgdXNl ciBvZiB0aGUgaGFybmVzcyBnZXQgYSBjYWxsYmFjayB3aGVuIHRoZSB0ZXN0IGlzIGRvbmUuCisK IDIwMTEtMTAtMDQgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCiAgICAgICAgIFVw ZGF0ZSBodG1sNS1mdWxsLXJlbmRlci5odG1sIHRvIGxvYWQgdGhlIEhUTUw1IHNwZWMgaW5jcmVt ZW50YWxseSwgY2xvc2VyIHRvIGhvdyB0aGUgYnJvd3NlciB3b3VsZApJbmRleDogUGVyZm9ybWFu Y2VUZXN0cy9CaW5kaW5ncy9ldmVudC10YXJnZXQtd3JhcHBlci5odG1sCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFBlcmZvcm1hbmNlVGVzdHMvQmluZGluZ3MvZXZlbnQtdGFyZ2V0LXdyYXBwZXIuaHRtbAkocmV2 aXNpb24gMCkKKysrIFBlcmZvcm1hbmNlVGVzdHMvQmluZGluZ3MvZXZlbnQtdGFyZ2V0LXdyYXBw ZXIuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw0MCBAQAorPCFET0NUWVBFIGh0bWw+Cis8 Ym9keT4KKzxwcmUgaWQ9ImxvZyI+PC9wcmU+Cis8c2NyaXB0IHNyYz0iLi4vUGFyc2VyL3Jlc291 cmNlcy9ydW5uZXIuanMiPjwvc2NyaXB0PgorPGEgaHJlZj0iIyI+Q2xpY2sgaGVyZSB0byBzdGFy dDwvYT4KKzxzY3JpcHQ+Cit2YXIgbGluayA9IGRvY3VtZW50LmdldEVsZW1lbnRzQnlUYWdOYW1l KCdhJylbMF07Cit2YXIgZXZ0ID0gbnVsbDsKK3ZhciBrSXRlcmF0b25zUGVyVGVzdCA9IDEwMDAw MDA7CisKK2xpbmsuYWRkRXZlbnRMaXN0ZW5lcignY2xpY2snLCBmdW5jdGlvbihldmVudCkgewor ICAgIGxpbmsudGV4dENvbnRlbnQgPSAnJzsKKyAgICB3aW5kb3cuZXZ0ID0gZXZlbnQ7CisgICAg ZXZlbnQucHJldmVudERlZmF1bHQoKTsKKworICAgIHN0YXJ0KDIwLCBmdW5jdGlvbigpIHsKKyAg ICAgICAgdmFyIGUgPSB3aW5kb3cuZXZ0OworICAgICAgICBmb3IgKHZhciB4ID0gMDsgeCA8IGtJ dGVyYXRvbnNQZXJUZXN0OyB4KyspIHsKKyAgICAgICAgICAgIGUudGFyZ2V0OworICAgICAgICB9 CisgICAgfSwgMTAsIGZ1bmN0aW9uKCkgeworICAgICAgICBpZiAod2luZG93LmxheW91dFRlc3RD b250cm9sbGVyKQorICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgp OworICAgIH0pOworCisgICAgcmV0dXJuIGZhbHNlOworfSwgZmFsc2UpOworCitpZiAod2luZG93 LmxheW91dFRlc3RDb250cm9sbGVyKSB7CisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIud2FpdFVu dGlsRG9uZSgpOworICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKK30KKwor aWYgKHdpbmRvdy5ldmVudFNlbmRlcikgeworICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKGxp bmsub2Zmc2V0TGVmdCArIDUsIGxpbmsub2Zmc2V0VG9wICsgNSk7CisgICAgZXZlbnRTZW5kZXIu bW91c2VEb3duKCk7CisgICAgZXZlbnRTZW5kZXIubW91c2VVcCgpOworfQorPC9zY3JpcHQ+Cis8 L2JvZHk+CkluZGV4OiBQZXJmb3JtYW5jZVRlc3RzL1BhcnNlci9yZXNvdXJjZXMvcnVubmVyLmpz Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFBlcmZvcm1hbmNlVGVzdHMvUGFyc2VyL3Jlc291cmNlcy9ydW5uZXIu anMJKHJldmlzaW9uIDk4MzkwKQorKysgUGVyZm9ybWFuY2VUZXN0cy9QYXJzZXIvcmVzb3VyY2Vz L3J1bm5lci5qcwkod29ya2luZyBjb3B5KQpAQCAtNzMsNiArNzMsNyBAQCBmdW5jdGlvbiBydW5M b29wKCkKICAgICAgICAgd2luZG93LnNldFRpbWVvdXQocnVuLCAwKTsKICAgICB9IGVsc2Ugewog ICAgICAgICBsb2dTdGF0aXN0aWNzKHRpbWVzKTsKKyAgICAgICAgd2luZG93LmRvbmVGdW5jdGlv bigpOwogICAgIH0KIH0KIApAQCAtOTEsMTAgKzkyLDExIEBAIGZ1bmN0aW9uIHJ1bigpIHsKICAg ICBydW5Mb29wKCkKIH0KIAotZnVuY3Rpb24gc3RhcnQocnVuQ291bnQsIHJ1bkZ1bmN0aW9uLCBs b29wc1BlclJ1bikgeworZnVuY3Rpb24gc3RhcnQocnVuQ291bnQsIHJ1bkZ1bmN0aW9uLCBsb29w c1BlclJ1biwgZG9uZUZ1bmN0aW9uKSB7CiAgICAgd2luZG93LnJ1bkNvdW50ID0gcnVuQ291bnQ7 CiAgICAgd2luZG93LnJ1bkZ1bmN0aW9uID0gcnVuRnVuY3Rpb247CiAgICAgd2luZG93Lmxvb3Bz UGVyUnVuID0gbG9vcHNQZXJSdW4gfHwgMTA7CisgICAgd2luZG93LmRvbmVGdW5jdGlvbiA9IGRv bmVGdW5jdGlvbiB8fCBmdW5jdGlvbigpIHt9OwogCiAgICAgbG9nKCJSdW5uaW5nICIgKyBydW5D b3VudCArICIgdGltZXMiKTsKICAgICBydW5Mb29wKCk7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCShyZXZpc2lv biA5ODM5OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAt MSwzICsxLDE1IEBACisyMDExLTEwLTI1ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+ CisKKyAgICAgICAgRXZlbnRUYXJnZXRGYWN0b3J5LmluIGlzIG5vdCBzb3J0ZWQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcwODU1CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCBzb3J0cyB0 aGUgZmlsZS4gIEkgd2FzIG5vdCBhYmxlIHRvIG1lYXN1cmUgYSBwZXJmb3JtYW5jZQorICAgICAg ICBkaWZmZXJlbmNlIHVzaW5nIHRoZSBtaWNyb2JlbmNobWFyayBpbmNsdWRlZCB3aXRoIHRoaXMg cGF0Y2guCisKKyAgICAgICAgKiBkb20vRXZlbnRUYXJnZXRGYWN0b3J5LmluOgorCiAyMDExLTEw LTI1ICBNaWNoYWwgTW9jbnkgIDxtbW9jbnlAZ29vZ2xlLmNvbT4KIAogICAgICAgICBMYXllclJl bmRlcmVyQ2hyb21pdW06OnNldFZpc2libGUgY2FsbGVkIG5lZWRsZXNzbHkgd2l0aG91dCBhIHZp c2liaWxpdHkgY2hhbmdlCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9kb20vRXZlbnRUYXJnZXRGYWN0 b3J5LmluCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9FdmVudFRhcmdldEZhY3Rv cnkuaW4JKHJldmlzaW9uIDk4MzkwKQorKysgU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50VGFyZ2V0 RmFjdG9yeS5pbgkod29ya2luZyBjb3B5KQpAQCAtMSwyNyArMSwyNyBAQAogbmFtZXNwYWNlPSJF dmVudFRhcmdldCIKIAotRXZlbnRTb3VyY2UKLU1lc3NhZ2VQb3J0Ci1Ob2RlCi1ET01XaW5kb3cK LVhNTEh0dHBSZXF1ZXN0Ci1YTUxIdHRwUmVxdWVzdFVwbG9hZAotRE9NQXBwbGljYXRpb25DYWNo ZQotU1ZHRWxlbWVudEluc3RhbmNlIGNvbmRpdGlvbmFsPVNWRwotV29ya2VyIGNvbmRpdGlvbmFs PVdPUktFUlMKLURlZGljYXRlZFdvcmtlckNvbnRleHQgY29uZGl0aW9uYWw9V09SS0VSUwotU2hh cmVkV29ya2VyIGNvbmRpdGlvbmFsPVNIQVJFRF9XT1JLRVJTCi1TaGFyZWRXb3JrZXJDb250ZXh0 IGNvbmRpdGlvbmFsPVNIQVJFRF9XT1JLRVJTCiBBdWRpb0NvbnRleHQgY29uZGl0aW9uYWw9V0VC X0FVRElPCi1KYXZhU2NyaXB0QXVkaW9Ob2RlIGNvbmRpdGlvbmFsPVdFQl9BVURJTwotV2ViU29j a2V0IGNvbmRpdGlvbmFsPVdFQl9TT0NLRVRTCi1Ob3RpZmljYXRpb24gY29uZGl0aW9uYWw9Tk9U SUZJQ0FUSU9OUworRGVkaWNhdGVkV29ya2VyQ29udGV4dCBjb25kaXRpb25hbD1XT1JLRVJTCitE T01BcHBsaWNhdGlvbkNhY2hlCitET01XaW5kb3cKK0V2ZW50U291cmNlCiBGaWxlUmVhZGVyIGNv bmRpdGlvbmFsPUJMT0IKIEZpbGVXcml0ZXIgY29uZGl0aW9uYWw9RklMRV9TWVNURU0KIElEQkRh dGFiYXNlIGNvbmRpdGlvbmFsPUlOREVYRURfREFUQUJBU0UKIElEQlJlcXVlc3QgY29uZGl0aW9u YWw9SU5ERVhFRF9EQVRBQkFTRQogSURCVHJhbnNhY3Rpb24gY29uZGl0aW9uYWw9SU5ERVhFRF9E QVRBQkFTRQogSURCVmVyc2lvbkNoYW5nZVJlcXVlc3QgY29uZGl0aW9uYWw9SU5ERVhFRF9EQVRB QkFTRQotTWVkaWFTdHJlYW0gY29uZGl0aW9uYWw9TUVESUFfU1RSRUFNCitKYXZhU2NyaXB0QXVk aW9Ob2RlIGNvbmRpdGlvbmFsPVdFQl9BVURJTwogTG9jYWxNZWRpYVN0cmVhbSBjb25kaXRpb25h bD1NRURJQV9TVFJFQU0KK01lZGlhU3RyZWFtIGNvbmRpdGlvbmFsPU1FRElBX1NUUkVBTQorTWVz c2FnZVBvcnQKK05vZGUKK05vdGlmaWNhdGlvbiBjb25kaXRpb25hbD1OT1RJRklDQVRJT05TCiBQ ZWVyQ29ubmVjdGlvbiBjb25kaXRpb25hbD1NRURJQV9TVFJFQU0KK1NoYXJlZFdvcmtlciBjb25k aXRpb25hbD1TSEFSRURfV09SS0VSUworU2hhcmVkV29ya2VyQ29udGV4dCBjb25kaXRpb25hbD1T SEFSRURfV09SS0VSUworU1ZHRWxlbWVudEluc3RhbmNlIGNvbmRpdGlvbmFsPVNWRworV2ViU29j a2V0IGNvbmRpdGlvbmFsPVdFQl9TT0NLRVRTCitXb3JrZXIgY29uZGl0aW9uYWw9V09SS0VSUwor WE1MSHR0cFJlcXVlc3QKK1hNTEh0dHBSZXF1ZXN0VXBsb2FkCg==