70853 2011-10-25 14:38:10 -0700 Make MutationObserverEntry a class instead of a struct to fix clang build 2011-10-25 15:55:03 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 adamk adamk ojan rafaelw rniwa webkit.review.bot oldest_to_newest 490369 0 adamk 2011-10-25 14:38:10 -0700 Make MutationObserverEntry a class instead of a struct to fix clang build 490370 1 112406 adamk 2011-10-25 14:39:36 -0700 Created attachment 112406 Patch 490376 2 112406 rniwa 2011-10-25 14:45:52 -0700 Comment on attachment 112406 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112406&action=review > Source/WebCore/dom/NodeRareData.h:93 > +class MutationObserverEntry { > +public: We should probably make observer and options private if we're making this a class. 490379 3 112406 adamk 2011-10-25 14:50:23 -0700 Comment on attachment 112406 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112406&action=review >> Source/WebCore/dom/NodeRareData.h:93 >> +public: > > We should probably make observer and options private if we're making this a class. We're "making it a class" only in the sense that we're using the keyword "class" here to quiet the compiler. It's still logically a struct with a few helper methods. If you'd rather I change the forward-declaration I can do that too; I mainly didn't do that because I didn't know how to sort it with the rest of the forward decls there :) 490395 4 rniwa 2011-10-25 15:00:11 -0700 (In reply to comment #3) > If you'd rather I change the forward-declaration I can do that too; I mainly didn't do that because I didn't know how to sort it with the rest of the forward decls there :) Okay, then I'd prefer that. Structs should probably appear after classes. 490399 5 112413 adamk 2011-10-25 15:06:24 -0700 Created attachment 112413 Patch 490432 6 112413 webkit.review.bot 2011-10-25 15:54:58 -0700 Comment on attachment 112413 Patch Clearing flags on attachment: 112413 Committed r98402: <http://trac.webkit.org/changeset/98402> 490433 7 webkit.review.bot 2011-10-25 15:55:03 -0700 All reviewed patches have been landed. Closing bug. 112406 2011-10-25 14:39:36 -0700 2011-10-25 15:06:21 -0700 Patch bug-70853-20111025143935.patch text/plain 1401 adamk U3VidmVyc2lvbiBSZXZpc2lvbjogOTgyODQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAyMzZjZmY0YTMxZDg3NDdj NDAzN2NlZTc5ZTY1MzM4YjAyZjE0MDViLi44NzBhYmY1OGQzODM1ZTNhNzRiOWI3YTNjOTlhYTJm N2I3ZDFjZGQyIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMTAtMjUgIEFkYW0g S2xlaW4gIDxhZGFta0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgTWFrZSBNdXRhdGlvbk9ic2Vy dmVyRW50cnkgYSBjbGFzcyBpbnN0ZWFkIG9mIGEgc3RydWN0IHRvIGZpeCBjbGFuZyBidWlsZAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzA4NTMKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBOb2RlLmggZm9y d2FyZCBkZWNsYXJlcyBNdXRhdGlvbk9ic2VydmVyRW50cnkgYXMgYSBjbGFzcywgYW5kIGNsYW5n CisgICAgICAgIGNvbXBsYWlucyBpZiB0aGUgdHdvIGRlY2xhcmF0aW9ucyBkb24ndCBtYXRjaC4g RmlndXJlZCB0aGF0ICJjbGFzcyIKKyAgICAgICAgaXMgZWFzaWVyIHRvIHJlbWVtYmVyLCBzbyBJ IGNob3NlIHRoYXQuCisKKyAgICAgICAgKiBkb20vTm9kZVJhcmVEYXRhLmg6CisKIDIwMTEtMTAt MjEgIE5hdCBEdWNhICA8bmR1Y2FAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0g QWRkIGlzVHJhY2VFdmVudEVuYWJsZWQgdG8gUGxhdGZvcm1TdXBwb3J0LgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvZG9tL05vZGVSYXJlRGF0YS5oIGIvU291cmNlL1dlYkNvcmUvZG9tL05v ZGVSYXJlRGF0YS5oCmluZGV4IDUwMmI2NThmYzA0YmVhNjg3OTE3MTc1NTA1ZThjOGExNzAyNzQ5 OGIuLjFhOGNhZjZlMzE4NWYyZTVhMDdlZGRkOGQwODg3NGM1ODhiNWJkN2QgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlUmFyZURhdGEuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9k b20vTm9kZVJhcmVEYXRhLmgKQEAgLTg5LDcgKzg5LDggQEAgcHJpdmF0ZToKIH07CiAKICNpZiBF TkFCTEUoTVVUQVRJT05fT0JTRVJWRVJTKQotc3RydWN0IE11dGF0aW9uT2JzZXJ2ZXJFbnRyeSB7 CitjbGFzcyBNdXRhdGlvbk9ic2VydmVyRW50cnkgeworcHVibGljOgogICAgIE11dGF0aW9uT2Jz ZXJ2ZXJFbnRyeShQYXNzUmVmUHRyPFdlYktpdE11dGF0aW9uT2JzZXJ2ZXI+IG9ic2VydmVyLCBN dXRhdGlvbk9ic2VydmVyT3B0aW9ucyBvcHRpb25zKQogICAgICAgICA6IG9ic2VydmVyKG9ic2Vy dmVyKQogICAgICAgICAsIG9wdGlvbnMob3B0aW9ucykK 112413 2011-10-25 15:06:24 -0700 2011-10-25 15:54:58 -0700 Patch bug-70853-20111025150623.patch text/plain 1351 adamk U3VidmVyc2lvbiBSZXZpc2lvbjogOTgyODQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAyMzZjZmY0YTMxZDg3NDdj NDAzN2NlZTc5ZTY1MzM4YjAyZjE0MDViLi44NTE1MTkxMTE1M2VjNTkzZmIzNDg4OTkwN2JiMTFh OWI2OGNhZmVhIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMTAtMjUgIEFkYW0g S2xlaW4gIDxhZGFta0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgRm9yd2FyZCBkZWNsYXJlIE11 dGF0aW9uT2JzZXJ2ZXJFbnRyeSBhcyBhIHN0cnVjdCB0byBmaXggY2xhbmcgYnVpbGQKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcwODUzCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm9kZS5oIGZvcndhcmQg ZGVjbGFyZWQgTXV0YXRpb25PYnNlcnZlckVudHJ5IGFzIGEgY2xhc3MsIGFuZCBjbGFuZworICAg ICAgICBjb21wbGFpbnMgaWYgdGhlIHR3byBkZWNsYXJhdGlvbnMgZG9uJ3QgbWF0Y2guCisKKyAg ICAgICAgKiBkb20vTm9kZS5oOgorCiAyMDExLTEwLTIxICBOYXQgRHVjYSAgPG5kdWNhQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIEFkZCBpc1RyYWNlRXZlbnRFbmFibGVkIHRv IFBsYXRmb3JtU3VwcG9ydC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmgg Yi9Tb3VyY2UvV2ViQ29yZS9kb20vTm9kZS5oCmluZGV4IGNmNTc2NTEwZmVhNjUxOTA3OWFjMTA2 MjQ5YjlhM2ViYzM4M2EzMmQuLjQ3Y2EyNTJmY2RkMzQyZTA1ODA1OTgyZGY5Mzk5OWQzMDkxZWM0 MWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmgKKysrIGIvU291cmNlL1dl YkNvcmUvZG9tL05vZGUuaApAQCAtNTksNyArNTksNiBAQCBjbGFzcyBGcmFtZTsKIGNsYXNzIEhU TUxJbnB1dEVsZW1lbnQ7CiBjbGFzcyBJbnRSZWN0OwogY2xhc3MgS2V5Ym9hcmRFdmVudDsKLWNs YXNzIE11dGF0aW9uT2JzZXJ2ZXJFbnRyeTsKIGNsYXNzIE5TUmVzb2x2ZXI7CiBjbGFzcyBOYW1l ZE5vZGVNYXA7CiBjbGFzcyBOYW1lTm9kZUxpc3Q7CkBAIC04Miw2ICs4MSw4IEBAIGNsYXNzIFNW R1VzZUVsZW1lbnQ7CiBjbGFzcyBUYWdOb2RlTGlzdDsKIGNsYXNzIFRyZWVTY29wZTsKIAorc3Ry dWN0IE11dGF0aW9uT2JzZXJ2ZXJFbnRyeTsKKwogdHlwZWRlZiBpbnQgRXhjZXB0aW9uQ29kZTsK IAogY29uc3QgaW50IG5vZGVTdHlsZUNoYW5nZVNoaWZ0ID0gMjU7Cg==