70851 2011-10-25 14:15:38 -0700 Caret can be positioned or repainted incorrectly in flipped-blocks multi-column blocks 2011-10-25 15:45:08 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mitz mitz oldest_to_newest 490352 0 mitz 2011-10-25 14:15:38 -0700 Caret can be positioned or repainted incorrectly in flipped-blocks multi-column blocks 490358 1 112402 mitz 2011-10-25 14:22:13 -0700 Created attachment 112402 Moved flipped-blocks adjustments from adjustForColumns() into offsetFromContainer() 490421 2 112402 hyatt 2011-10-25 15:37:31 -0700 Comment on attachment 112402 Moved flipped-blocks adjustments from adjustForColumns() into offsetFromContainer() r=me 490425 3 mitz 2011-10-25 15:45:08 -0700 Fixed in <http://trac.webkit.org/r98400>. 112402 2011-10-25 14:22:13 -0700 2011-10-25 15:37:31 -0700 Moved flipped-blocks adjustments from adjustForColumns() into offsetFromContainer() bug-70851-20111025142212.patch text/plain 4728 mitz SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk4Mzk1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMTAtMjUgIERhbiBCZXJu c3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KKworICAgICAgICBDYXJldCBjYW4gYmUgcG9zaXRpb25l ZCBvciByZXBhaW50ZWQgaW5jb3JyZWN0bHkgaW4gZmxpcHBlZC1ibG9ja3MgbXVsdGktY29sdW1u IGJsb2NrcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NzA4NTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IG1hbnVhbC10ZXN0cy9jYXJldC1pbi1jb2x1bW5zLWZsaXBwZWQuaHRtbDogQWRkZWQuCisgICAg ICAgICogcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRl ckJsb2NrOjphZGp1c3RGb3JDb2x1bW5zKTogUmVtb3ZlZCBmbGlwcGVkLWJsb2NrcyB3cml0aW5n IG1vZGUgY29uc2lkZXJhdGlvbnMKKyAgICAgICAgZnJvbSB0aGlzIGZ1bmN0aW9uLCBzaW5jZSBu b3QgYWxsIGNhbGxlcnMgd2VyZSBleHBlY3RpbmcgaXQgdG8gYWNjb3VudCBmb3IgZmxpcHBlZG5l c3MuIFRoaXMgbWFrZXMKKyAgICAgICAgaXQgc2ltaWxhciB0byBhZGp1c3RSZWN0Rm9yQ29sdW1u cygpIGluIG5vdCBhZGp1c3RpbmcgZm9yIGZsaXBwZWRuZXNzLgorICAgICAgICAqIHJlbmRlcmlu Zy9SZW5kZXJCb3guY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQm94OjpvZmZzZXRGcm9t Q29udGFpbmVyKTogSW4gdGhlIGNvbHVtbnMgY2FzZSwgYWNjb3VudCBmb3IgZmxpcHBlZC1ibG9j a3MgbW9kZXMKKyAgICAgICAgYnkgZmlyc3QgbWFwcGluZyB0aGUgcG9pbnQgYW5kIHRoZSBvZmZz ZXQgdG8gbm9uLWZsaXBwZWQsIG5vbi1jb2x1bW5zIHNwYWNlLCB0aGVuIGFkanVzdGluZyBmb3IK KyAgICAgICAgY29sdW1ucywgdGhlbiBmbGlwcGluZy4KKwogMjAxMS0xMC0yNSAgTWljaGFsIE1v Y255ICA8bW1vY255QGdvb2dsZS5jb20+CiAKICAgICAgICAgTGF5ZXJSZW5kZXJlckNocm9taXVt OjpzZXRWaXNpYmxlIGNhbGxlZCBuZWVkbGVzc2x5IHdpdGhvdXQgYSB2aXNpYmlsaXR5IGNoYW5n ZQpJbmRleDogU291cmNlL1dlYkNvcmUvbWFudWFsLXRlc3RzL2NhcmV0LWluLWNvbHVtbnMtZmxp cHBlZC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL21hbnVhbC10ZXN0cy9jYXJl dC1pbi1jb2x1bW5zLWZsaXBwZWQuaHRtbAkocmV2aXNpb24gMCkKKysrIFNvdXJjZS9XZWJDb3Jl L21hbnVhbC10ZXN0cy9jYXJldC1pbi1jb2x1bW5zLWZsaXBwZWQuaHRtbAkocmV2aXNpb24gMCkK QEAgLTAsMCArMSwyNSBAQAorPHA+CisgICAgKFJlYWQgZnJvbSBib3R0b20gdG8gdG9wKQorPC9w PgorPGRpdiBpZD0idGFyZ2V0IiBzdHlsZT0iCisgICAgbWFyZ2luOiAxMDBweDsKKyAgICAtd2Vi a2l0LWNvbHVtbnM6IDM7CisgICAgd2lkdGg6IDMwMHB4OworICAgIGhlaWdodDogMTAwcHg7Cisg ICAgLXdlYmtpdC11c2VyLW1vZGlmeTogcmVhZC13cml0ZTsKKyAgICAtd2Via2l0LXdyaXRpbmct bW9kZTogaG9yaXpvbnRhbC1idDsKKyAgICBvdXRsaW5lOiBub25lOworIj4KKyAgICA8YnI+Cisg ICAgPGJyPgorICAgIDxicj4KKyAgICA8YnI+CisgICAgPGJyPgorICAgIDxicj4KKyAgICBUaGUg YmxpbmtpbmcgaW5zZXJ0aW9uIHBvaW50IHNob3VsZCBiZSBoZXJlICZyYXJyOworPC9kaXY+Cis8 c2NyaXB0PgorICAgIHZhciB0YXJnZXQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgidGFyZ2V0 Iik7CisgICAgdGFyZ2V0LmZvY3VzKCk7CisgICAgZ2V0U2VsZWN0aW9uKCkubW9kaWZ5KCJtb3Zl IiwgImZvcndhcmQiLCAiZG9jdW1lbnRib3VuZGFyeSIpOworPC9zY3JpcHQ+CkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAJKHJldmlzaW9uIDk4MzUxKQorKysg U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAkod29ya2luZyBjb3B5KQpA QCAtNDc1NywxMCArNDc1Nyw3IEBAIHZvaWQgUmVuZGVyQmxvY2s6OmFkanVzdEZvckNvbHVtbnMo TGF5b3UKICAgICAgICAgaWYgKCFpc0hvcml6b250YWxXcml0aW5nTW9kZSgpKQogICAgICAgICAg ICAgc2xpY2VSZWN0ID0gc2xpY2VSZWN0LnRyYW5zcG9zZWRSZWN0KCk7CiAgICAgICAgIAotICAg ICAgICAvLyBJZiB3ZSBoYXZlIGEgZmxpcHBlZCBibG9ja3Mgd3JpdGluZyBtb2RlLCB0aGVuIGNv bnZlcnQgdGhlIGNvbHVtbiBzbyB0aGF0IGl0J3MgY29taW5nIGZyb20gdGhlIGFmdGVyIGVkZ2Ug KGVpdGhlciB0b3Agb3IgbGVmdCBlZGdlKS4KLSAgICAgICAgYWRqdXN0U3RhcnRFZGdlRm9yV3Jp dGluZ01vZGVJbmNsdWRpbmdDb2x1bW5zKHNsaWNlUmVjdCk7Ci0gICAgICAgIAotICAgICAgICBM YXlvdXRVbml0IGxvZ2ljYWxPZmZzZXQgPSBzdHlsZSgpLT5pc0ZsaXBwZWRCbG9ja3NXcml0aW5n TW9kZSgpID8gKGNvbENvdW50IC0gMSAtIGkpICogY29sTG9naWNhbEhlaWdodCA6IGkgKiBjb2xM b2dpY2FsSGVpZ2h0OworICAgICAgICBMYXlvdXRVbml0IGxvZ2ljYWxPZmZzZXQgPSBpICogY29s TG9naWNhbEhlaWdodDsKIAogICAgICAgICAvLyBOb3cgd2UncmUgaW4gdGhlIHNhbWUgY29vcmRp bmF0ZSBzcGFjZSBhcyB0aGUgcG9pbnQuICBTZWUgaWYgaXQgaXMgaW5zaWRlIHRoZSByZWN0YW5n bGUuCiAgICAgICAgIGlmIChpc0hvcml6b250YWxXcml0aW5nTW9kZSgpKSB7CkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcAkocmV2aXNpb24gOTgzNTEpCisrKyBTb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTQy MiwxNSArMTQyMiwxNSBAQCBMYXlvdXRTaXplIFJlbmRlckJveDo6b2Zmc2V0RnJvbUNvbnRhaW5l CiAgICAgICAgIG9mZnNldCArPSByZWxhdGl2ZVBvc2l0aW9uT2Zmc2V0KCk7CiAKICAgICBpZiAo IWlzSW5saW5lKCkgfHwgaXNSZXBsYWNlZCgpKSB7Ci0gICAgICAgIGlmIChzdHlsZSgpLT5wb3Np dGlvbigpICE9IEFic29sdXRlUG9zaXRpb24gJiYgc3R5bGUoKS0+cG9zaXRpb24oKSAhPSBGaXhl ZFBvc2l0aW9uKSB7Ci0gICAgICAgICAgICBpZiAoby0+aGFzQ29sdW1ucygpKSB7Ci0gICAgICAg ICAgICAgICAgTGF5b3V0UmVjdCBjb2x1bW5SZWN0KGZyYW1lUmVjdCgpKTsKLSAgICAgICAgICAg ICAgICB0b1JlbmRlckJsb2NrKG8pLT5hZGp1c3RTdGFydEVkZ2VGb3JXcml0aW5nTW9kZUluY2x1 ZGluZ0NvbHVtbnMoY29sdW1uUmVjdCk7Ci0gICAgICAgICAgICAgICAgb2Zmc2V0ICs9IExheW91 dFNpemUoY29sdW1uUmVjdC5sb2NhdGlvbigpLngoKSwgY29sdW1uUmVjdC5sb2NhdGlvbigpLnko KSk7Ci0gICAgICAgICAgICAgICAgY29sdW1uUmVjdC5tb3ZlQnkocG9pbnQpOwotICAgICAgICAg ICAgICAgIG8tPmFkanVzdEZvckNvbHVtbnMob2Zmc2V0LCBjb2x1bW5SZWN0LmxvY2F0aW9uKCkp OwotICAgICAgICAgICAgfSBlbHNlCi0gICAgICAgICAgICAgICAgb2Zmc2V0ICs9IHRvcExlZnRM b2NhdGlvbk9mZnNldCgpOworICAgICAgICBpZiAoc3R5bGUoKS0+cG9zaXRpb24oKSAhPSBBYnNv bHV0ZVBvc2l0aW9uICYmIHN0eWxlKCktPnBvc2l0aW9uKCkgIT0gRml4ZWRQb3NpdGlvbiAmJiBv LT5oYXNDb2x1bW5zKCkpIHsKKyAgICAgICAgICAgIFJlbmRlckJsb2NrKiBibG9jayA9IHRvUmVu ZGVyQmxvY2sobyk7CisgICAgICAgICAgICBMYXlvdXRSZWN0IGNvbHVtblJlY3QoZnJhbWVSZWN0 KCkpOworICAgICAgICAgICAgYmxvY2stPmFkanVzdFN0YXJ0RWRnZUZvcldyaXRpbmdNb2RlSW5j bHVkaW5nQ29sdW1ucyhjb2x1bW5SZWN0KTsKKyAgICAgICAgICAgIG9mZnNldCArPSB0b1NpemUo Y29sdW1uUmVjdC5sb2NhdGlvbigpKTsKKyAgICAgICAgICAgIEludFBvaW50IGNvbHVtblBvaW50 ID0gYmxvY2stPmZsaXBGb3JXcml0aW5nTW9kZUluY2x1ZGluZ0NvbHVtbnMocG9pbnQgKyBvZmZz ZXQpOworICAgICAgICAgICAgb2Zmc2V0ID0gdG9TaXplKGJsb2NrLT5mbGlwRm9yV3JpdGluZ01v ZGVJbmNsdWRpbmdDb2x1bW5zKExheW91dFBvaW50KG9mZnNldCkpKTsKKyAgICAgICAgICAgIG8t PmFkanVzdEZvckNvbHVtbnMob2Zmc2V0LCBjb2x1bW5Qb2ludCk7CisgICAgICAgICAgICBvZmZz ZXQgPSBibG9jay0+ZmxpcEZvcldyaXRpbmdNb2RlKG9mZnNldCk7CiAgICAgICAgIH0gZWxzZQog ICAgICAgICAgICAgb2Zmc2V0ICs9IHRvcExlZnRMb2NhdGlvbk9mZnNldCgpOwogICAgIH0K