70834 2011-10-25 12:01:45 -0700 build-webkit --clean should only clean build directory for CMake-based ports 2011-10-25 12:36:20 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dbates dbates gyuyoung.kim leandro paroga oldest_to_newest 490204 0 dbates 2011-10-25 12:01:45 -0700 Currently for CMake-based ports build-webkit --clean will both clean the build directory and build WebKit. Instead, the --clean argument should only clean the build directory as per its description in the usage message of build-webkit. 490211 1 112371 dbates 2011-10-25 12:10:51 -0700 Created attachment 112371 Patch 490227 2 112371 leandro 2011-10-25 12:22:42 -0700 Comment on attachment 112371 Patch LGTM. 490230 3 112371 tonikitoo 2011-10-25 12:24:36 -0700 Comment on attachment 112371 Patch <tonikitoo> acidx, leandro would you mind? https://bugs.webkit.org/show_bug.cgi?id=70834 (...) <acidx> tonikitoo: LGTM. 490246 4 dbates 2011-10-25 12:36:20 -0700 Committed r98377: <http://trac.webkit.org/changeset/98377> 112371 2011-10-25 12:10:51 -0700 2011-10-25 12:24:36 -0700 Patch bug-70834-20111025120816.patch text/plain 1616 dbates SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDk4MzY5KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTcgQEAKKzIwMTEtMTAtMjUgIERhbmllbCBCYXRlcyAgPGRiYXRlc0B3ZWJraXQub3JnPgor CisgICAgICAgIGJ1aWxkLXdlYmtpdCAtLWNsZWFuIHNob3VsZCBvbmx5IGNsZWFuIGJ1aWxkIGRp cmVjdG9yeSBmb3IgQ01ha2UtYmFzZWQgcG9ydHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTcwODM0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQ3VycmVudGx5IGJ1aWxkLXdlYmtpdCAtLWNsZWFuIGJvdGgg Y2xlYW5zIHRoZSBidWlsZCBkaXJlY3RvcnkgYW5kIGJ1aWxkcyBXZWJLaXQgZm9yCisgICAgICAg IENNYWtlLWJhc2VkIHBvcnRzLiBJbnN0ZWFkLCBidWlsZC13ZWJraXQgLS1jbGVhbiBzaG91bGQg b25seSBjbGVhbiB1cCB0aGUgYnVpbGQgZGlyZWN0b3J5CisgICAgICAgIGFzIHBlciBpdHMgZGVz Y3JpcHRpb24gaW4gdGhlIHVzYWdlIG1lc3NhZ2Ugb2YgYnVpbGQtd2Via2l0LgorCisgICAgICAg ICogU2NyaXB0cy93ZWJraXRkaXJzLnBtOgorICAgICAgICAoYnVpbGRDTWFrZVByb2plY3RPckV4 aXQpOgorCiAyMDExLTEwLTI1ICBBbm5hIENhdmVuZGVyICA8YW5uYWNjQGNocm9taXVtLm9yZz4K IAogICAgICAgICBFbmFibGUgcnVubmluZyBvZiB0cmFjayBsYXlvdXQgdGVzdHMgZm9yIENocm9t aXVtCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9v bHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCShyZXZpc2lvbiA5ODM2OCkKKysrIFRvb2xzL1Njcmlw dHMvd2Via2l0ZGlycy5wbQkod29ya2luZyBjb3B5KQpAQCAtMTY2NCwxMCArMTY2NCw5IEBAIHN1 YiBidWlsZENNYWtlUHJvamVjdE9yRXhpdCgkJCQkQCkKIHsKICAgICBteSAoJGNsZWFuLCAkcG9y dCwgJHByZWZpeFBhdGgsICRtYWtlQXJncywgQGNtYWtlQXJncykgPSBAXzsKICAgICBteSAkcmV0 dXJuQ29kZTsKLSAgICBpZiAoJGNsZWFuKSB7Ci0gICAgICAgICRyZXR1cm5Db2RlID0gZXhpdFN0 YXR1cyhjbGVhbkNNYWtlR2VuZXJhdGVkUHJvamVjdCgpKTsKLSAgICAgICAgZXhpdCgkcmV0dXJu Q29kZSkgaWYgJHJldHVybkNvZGU7Ci0gICAgfQorCisgICAgZXhpdChleGl0U3RhdHVzKGNsZWFu Q01ha2VHZW5lcmF0ZWRQcm9qZWN0KCkpKSBpZiAkY2xlYW47CisKICAgICAkcmV0dXJuQ29kZSA9 IGV4aXRTdGF0dXMoZ2VuZXJhdGVCdWlsZFN5c3RlbUZyb21DTWFrZVByb2plY3QoJHBvcnQsICRw cmVmaXhQYXRoLCBAY21ha2VBcmdzKSk7CiAgICAgZXhpdCgkcmV0dXJuQ29kZSkgaWYgJHJldHVy bkNvZGU7CiAgICAgJHJldHVybkNvZGUgPSBleGl0U3RhdHVzKGJ1aWxkQ01ha2VHZW5lcmF0ZWRQ cm9qZWN0KCRtYWtlQXJncykpOwo=