70828 2011-10-25 10:43:03 -0700 “Open with” item missing from PDF context menu in some cases 2011-10-25 10:54:58 -0700 1 1 1 Unclassified WebKit PDF 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED InRadar P2 Normal --- 1 sullivan sullivan oldest_to_newest 490134 0 sullivan 2011-10-25 10:43:03 -0700 This is in radar as 10034302. To reproduce: 1. In Snow Leopard, load a PDF page in Safari. 2. Control-click or right-click on a blank area of the page (not on text) to bring up a context menu. The context menu does not include an “Open With” item. (If in step 2 you click on text instead of background, the “Open With” item is present.) 490140 1 112358 sullivan 2011-10-25 10:48:16 -0700 Created attachment 112358 Patch to insert the Open With item at the top of the menu if no Copy item is present. 490144 2 sullivan 2011-10-25 10:54:58 -0700 Fixed in 98362. 112358 2011-10-25 10:48:16 -0700 2011-10-25 10:52:40 -0700 Patch to insert the Open With item at the top of the menu if no Copy item is present. OpenWith_patch.txt text/plain 4534 sullivan SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDk4MzU5KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMTAtMjUgIEpvaG4gU3Vs bGl2YW4gIDxzdWxsaXZhbkBhcHBsZS5jb20+CisKKyAgICAgICAgIk9wZW4gd2l0aCIgaXRlbSBt aXNzaW5nIGZyb20gUERGIGNvbnRleHQgbWVudSBpbiBzb21lIGNhc2VzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MDgyOAorICAgICAgICA8cmRhcjov L3Byb2JsZW0vMTAwMzQzMDI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL21hYy9QREZWaWV3Q29udHJvbGxlci5tbToKKyAg ICAgICAgKGluc2VydE9wZW5XaXRoRGVmYXVsdFBERk1lbnVJdGVtKToKKyAgICAgICAgTmV3IGhl bHBlciBmdW5jdGlvbiwgZXh0cmFjdGVkIGZyb20gLW1lbnVGb3JFdmVudDouIElkZW50aWNhbCB0 byBvcmlnaW5hbCBjb2RlIGV4Y2VwdAorICAgICAgICB0aGF0IGl0IGluc2VydHMgdGhlIGl0ZW0g YXQgYSBzcGVjaWZpZWQgaW5kZXgsIHJhdGhlciB0aGFuIGFsd2F5cyBhdCB0aGUgZW5kLgorICAg ICAgICAoLVtXS1BERlZpZXcgbWVudUZvckV2ZW50Ol0pOgorICAgICAgICBOb3cga2VlcHMgdHJh Y2sgb2Ygd2hldGhlciB0aGUgT3BlbiBXaXRoIGl0ZW0gaGFzIGJlZW4gaW5zZXJ0ZWQgd2hpbGUg aXRlcmF0aW5nIHRocm91Z2gKKyAgICAgICAgdGhlIFBERktpdC1zdXBwbGllZCBtZW51IGl0ZW1z IGxvb2tpbmcgZm9yIGEgIkNvcHkiIGl0ZW0uIElmIGEgIkNvcHkiIGl0ZW0gaXMgbm90IGZvdW5k LAorICAgICAgICBpbnNlcnRzIHRoZSBPcGVuIFdpdGggaXRlbSBhdCB0aGUgdG9wIG9mIHRoZSBj b250ZXh0IG1lbnUuCisKIDIwMTEtMTAtMjUgIFplbm8gQWxiaXNzZXIgIDx6ZW5vLmFsYmlzc2Vy QG5va2lhLmNvbT4KIAogICAgICAgICBbUXRdW1dLMl0gUURlc2t0b3BXZWJWaWV3IGFuZCBRVG91 Y2hXZWJWaWV3IHNob3VsZCBiZSBkZWNsYXJlZCBpbiB0aGUgbWV0YSB0eXBlIHN5c3RlbS4KSW5k ZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1BERlZpZXdDb250cm9sbGVyLm1t Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1BERlZpZXdD b250cm9sbGVyLm1tCShyZXZpc2lvbiA5ODM1MSkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvbWFjL1BERlZpZXdDb250cm9sbGVyLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0yOTcsMzcg KzI5Nyw1NSBAQCAtIChOU1ZpZXcgKiloaXRUZXN0OihOU1BvaW50KXBvaW50CiAgICAgcmV0dXJu IFtzdXBlciBoaXRUZXN0OnBvaW50XTsKIH0KIAorc3RhdGljIHZvaWQgaW5zZXJ0T3BlbldpdGhE ZWZhdWx0UERGTWVudUl0ZW0oTlNNZW51ICptZW51LCBOU1VJbnRlZ2VyIGluZGV4KQoreworICAg IC8vIEFkZCBpbiBhbiAiT3BlbiB3aXRoIDxkZWZhdWx0IFBERiB2aWV3ZXI+IiBpdGVtCisgICAg TlNTdHJpbmcgKmFwcE5hbWUgPSBuaWw7CisgICAgTlNJbWFnZSAqYXBwSWNvbiA9IG5pbDsKKyAg ICAKKyAgICBfYXBwbGljYXRpb25JbmZvRm9yTUlNRVR5cGUoQCJhcHBsaWNhdGlvbi9wZGYiLCAm YXBwTmFtZSwgJmFwcEljb24pOworICAgIGlmICghYXBwTmFtZSkKKyAgICAgICAgYXBwTmFtZSA9 IFdFQl9VSV9TVFJJTkcoIkZpbmRlciIsICJEZWZhdWx0IGFwcGxpY2F0aW9uIG5hbWUgZm9yIE9w ZW4gV2l0aCBjb250ZXh0IG1lbnUiKTsKKyAgICAKKyAgICAvLyBUbyBtYXRjaCB0aGUgUERGS2l0 IHN0eWxlLCB3ZSdsbCBhZGQgT3BlbiB3aXRoIFByZXZpZXcgZXZlbiB3aGVuIHRoZXJlJ3Mgbm8g ZG9jdW1lbnQgeWV0IHRvIHZpZXcsIGFuZAorICAgIC8vIGRpc2FibGUgaXQgdXNpbmcgdmFsaWRh dGVVc2VySW50ZXJmYWNlSXRlbS4KKyAgICBOU1N0cmluZyAqdGl0bGUgPSBbTlNTdHJpbmcgc3Ry aW5nV2l0aEZvcm1hdDpXRUJfVUlfU1RSSU5HKCJPcGVuIHdpdGggJUAiLCAiY29udGV4dCBtZW51 IGl0ZW0gZm9yIFBERiIpLCBhcHBOYW1lXTsKKyAgICAKKyAgICBOU01lbnVJdGVtICppdGVtID0g W1tOU01lbnVJdGVtIGFsbG9jXSBpbml0V2l0aFRpdGxlOnRpdGxlIGFjdGlvbjpAc2VsZWN0b3Io X29wZW5XaXRoRmluZGVyOikga2V5RXF1aXZhbGVudDpAIiJdOworICAgIGlmIChhcHBJY29uKQor ICAgICAgICBbaXRlbSBzZXRJbWFnZTphcHBJY29uXTsKKyAgICBbbWVudSBpbnNlcnRJdGVtOml0 ZW0gYXRJbmRleDppbmRleF07CisgICAgW2l0ZW0gcmVsZWFzZV07Cit9CisKIC0gKE5TTWVudSAq KW1lbnVGb3JFdmVudDooTlNFdmVudCAqKXRoZUV2ZW50CiB7CiAgICAgTlNNZW51ICptZW51ID0g W1tOU01lbnUgYWxsb2NdIGluaXRXaXRoVGl0bGU6QCIiXTsKIAorICAgIGJvb2wgaW5zZXJ0ZWRP cGVuV2l0aEl0ZW0gPSBmYWxzZTsKKyAgICAKICAgICBOU0VudW1lcmF0b3IgKm1lbnVJdGVtRW51 bWVyYXRvciA9IFtbW19wZGZWaWV3IG1lbnVGb3JFdmVudDp0aGVFdmVudF0gaXRlbUFycmF5XSBv YmplY3RFbnVtZXJhdG9yXTsKICAgICB3aGlsZSAoTlNNZW51SXRlbSAqaXRlbSA9IFttZW51SXRl bUVudW1lcmF0b3IgbmV4dE9iamVjdF0pIHsKICAgICAgICAgTlNNZW51SXRlbSAqaXRlbUNvcHkg PSBbaXRlbSBjb3B5XTsKICAgICAgICAgW21lbnUgYWRkSXRlbTppdGVtQ29weV07CiAgICAgICAg IFtpdGVtQ29weSByZWxlYXNlXTsKIAorICAgICAgICBpZiAoaW5zZXJ0ZWRPcGVuV2l0aEl0ZW0p CisgICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAgCisgICAgICAgIC8vIElmIGEgIkNvcHki IGl0ZW0gaXMgcHJlc2VudCwgcGxhY2UgdGhlICJPcGVuIFdpdGgiIGl0ZW0ganVzdCBhZnRlciBp dCwgd2l0aCBhbiBpbnRlcnZlbmluZyBzZXBhcmF0b3IuCiAgICAgICAgIGlmIChbaXRlbSBhY3Rp b25dICE9IEBzZWxlY3Rvcihjb3B5OikpCiAgICAgICAgICAgICBjb250aW51ZTsKLQotICAgICAg ICAvLyBBZGQgaW4gYW4gIk9wZW4gd2l0aCA8ZGVmYXVsdCBQREYgdmlld2VyPiIgaXRlbQotICAg ICAgICBOU1N0cmluZyAqYXBwTmFtZSA9IG5pbDsKLSAgICAgICAgTlNJbWFnZSAqYXBwSWNvbiA9 IG5pbDsKLQotICAgICAgICBfYXBwbGljYXRpb25JbmZvRm9yTUlNRVR5cGUoQCJhcHBsaWNhdGlv bi9wZGYiLCAmYXBwTmFtZSwgJmFwcEljb24pOwotICAgICAgICBpZiAoIWFwcE5hbWUpCi0gICAg ICAgICAgICBhcHBOYW1lID0gV0VCX1VJX1NUUklORygiRmluZGVyIiwgIkRlZmF1bHQgYXBwbGlj YXRpb24gbmFtZSBmb3IgT3BlbiBXaXRoIGNvbnRleHQgbWVudSIpOwotCi0gICAgICAgIC8vIFRv IG1hdGNoIHRoZSBQREZLaXQgc3R5bGUsIHdlJ2xsIGFkZCBPcGVuIHdpdGggUHJldmlldyBldmVu IHdoZW4gdGhlcmUncyBubyBkb2N1bWVudCB5ZXQgdG8gdmlldywgYW5kCi0gICAgICAgIC8vIGRp c2FibGUgaXQgdXNpbmcgdmFsaWRhdGVVc2VySW50ZXJmYWNlSXRlbS4KLSAgICAgICAgTlNTdHJp bmcgKnRpdGxlID0gW05TU3RyaW5nIHN0cmluZ1dpdGhGb3JtYXQ6V0VCX1VJX1NUUklORygiT3Bl biB3aXRoICVAIiwgImNvbnRleHQgbWVudSBpdGVtIGZvciBQREYiKSwgYXBwTmFtZV07Ci0KLSAg ICAgICAgaXRlbSA9IFtbTlNNZW51SXRlbSBhbGxvY10gaW5pdFdpdGhUaXRsZTp0aXRsZSBhY3Rp b246QHNlbGVjdG9yKF9vcGVuV2l0aEZpbmRlcjopIGtleUVxdWl2YWxlbnQ6QCIiXTsKLSAgICAg ICAgaWYgKGFwcEljb24pCi0gICAgICAgICAgICBbaXRlbSBzZXRJbWFnZTphcHBJY29uXTsKKyAg ICAgICAgCiAgICAgICAgIFttZW51IGFkZEl0ZW06W05TTWVudUl0ZW0gc2VwYXJhdG9ySXRlbV1d OwotICAgICAgICBbbWVudSBhZGRJdGVtOml0ZW1dOwotICAgICAgICBbaXRlbSByZWxlYXNlXTsK KyAgICAgICAgaW5zZXJ0T3BlbldpdGhEZWZhdWx0UERGTWVudUl0ZW0obWVudSwgW21lbnUgbnVt YmVyT2ZJdGVtc10pOworICAgICAgICBpbnNlcnRlZE9wZW5XaXRoSXRlbSA9IHRydWU7CisgICAg fQorICAgIAorICAgIGlmICghaW5zZXJ0ZWRPcGVuV2l0aEl0ZW0pIHsKKyAgICAgICAgLy8gTm8g IkNvcHkiIGl0ZW0gd2FzIGZvdW5kOyBwbGFjZSB0aGUgIk9wZW4gV2l0aCIgaXRlbSBhdCB0aGUg dG9wIG9mIHRoZSBtZW51LCB3aXRoIGEgdHJhaWxpbmcgc2VwYXJhdG9yLgorICAgICAgICBpbnNl cnRPcGVuV2l0aERlZmF1bHRQREZNZW51SXRlbShtZW51LCAwKTsKKyAgICAgICAgW21lbnUgaW5z ZXJ0SXRlbTpbTlNNZW51SXRlbSBzZXBhcmF0b3JJdGVtXSBhdEluZGV4OjFdOwogICAgIH0KIAog ICAgIHJldHVybiBbbWVudSBhdXRvcmVsZWFzZV07Cg==