70812 2011-10-25 05:02:59 -0700 Web Inspector: JS exception in JavaScriptSourceFrame.onShowPopover/showObjectPopover() 2011-10-25 06:02:53 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED Regression P2 Normal --- 1 caseq caseq apavlov bweinstein joepeck keishi loislo pfeldman pmuellr podivilov rik timothy yurys oldest_to_newest 489966 0 caseq 2011-10-25 05:02:59 -0700 There's a race condition in showObjectPopover() -- sometimes, popover may be hidden while a popover expression is being evaluated in the inspected page. In this case, _highlightElement becomes undefined and this._highlightElement.addStyleClass() call in showObjectPopover() results in an exception. 489967 1 112323 caseq 2011-10-25 05:05:05 -0700 Created attachment 112323 patch 489987 2 caseq 2011-10-25 06:02:53 -0700 A variation of the patch landed manually as r98333: http://trac.webkit.org/changeset/98333 112323 2011-10-25 05:05:05 -0700 2011-10-25 05:25:39 -0700 patch object-popover-npe.diff text/plain 1546 caseq ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0YmM0MTJhLi41MGQ5ZDY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMTAtMjUgIEFuZHJleSBLb3N5YWtvdiAgPGNhc2VxQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBKUyBleGNlcHRpb24gaW4gSmF2YVNjcmlwdFNvdXJjZUZy YW1lLm9uU2hvd1BvcG92ZXIvc2hvd09iamVjdFBvcG92ZXIoKQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzA4MTIKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGVjayBpZiBoaWdobGlnaHRlZCBlbGVtZW50 IGlzIHByZXNlbnQgd2hpbGUgZGlzcGxheWluZyBvYmplY3QgcG9wb3Zlci4KKworICAgICAgICAq IGluc3BlY3Rvci9mcm9udC1lbmQvSmF2YVNjcmlwdFNvdXJjZUZyYW1lLmpzOgorICAgICAgICAo V2ViSW5zcGVjdG9yLkphdmFTY3JpcHRTb3VyY2VGcmFtZS5wcm90b3R5cGUub25TaG93UG9wb3Zl ci5zaG93T2JqZWN0UG9wb3Zlcik6CisgICAgICAgIChXZWJJbnNwZWN0b3IuSmF2YVNjcmlwdFNv dXJjZUZyYW1lLnByb3RvdHlwZS5vblNob3dQb3BvdmVyKToKKwogMjAxMS0xMC0yMSAgTmF0IER1 Y2EgIDxuZHVjYUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBSb3V0ZSBDb25z b2xlOjp0aW1lIGFuZCBDb25zb2xlOjp0aW1lRW5kIHRvIHRyYWNlX2V2ZW50CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0phdmFTY3JpcHRTb3VyY2VGcmFt ZS5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSmF2YVNjcmlwdFNvdXJj ZUZyYW1lLmpzCmluZGV4IDFkOTU2ZjYuLjlhZjk5OTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSmF2YVNjcmlwdFNvdXJjZUZyYW1lLmpzCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSmF2YVNjcmlwdFNvdXJjZUZyYW1lLmpz CkBAIC03Miw2ICs3Miw5IEBAIFdlYkluc3BlY3Rvci5KYXZhU2NyaXB0U291cmNlRnJhbWUucHJv dG90eXBlID0gewogCiAgICAgICAgIGZ1bmN0aW9uIHNob3dPYmplY3RQb3BvdmVyKHJlc3VsdCwg d2FzVGhyb3duKQogICAgICAgICB7CisgICAgICAgICAgICAvLyBQb3BvdmVyIG1heSBoYXZlIGJl ZW4gcmVtb3ZlZCB3aGlsZSB3ZSB3ZXJlIGV2YWx1YXRpbmcgdGhlIGV4cHJlc3Npb24uCisgICAg ICAgICAgICBpZiAoIXRoaXMuX2hpZ2hsaWdodEVsZW1lbnQpCisgICAgICAgICAgICAgICAgcmV0 dXJuOwogICAgICAgICAgICAgaWYgKCF0aGlzLl9tb2RlbC5wYXVzZWQpIHsKICAgICAgICAgICAg ICAgICB0aGlzLnBvcG92ZXJIZWxwZXIuaGlkZVBvcG92ZXIoKTsKICAgICAgICAgICAgICAgICBy ZXR1cm47Cg==