70805 2011-10-25 01:13:27 -0700 [EFL] Make cache flush when max size of cache has been changed 2011-10-31 15:31:36 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 t.morawski webkit-unassigned gyuyoung.kim leandro lucas.de.marchi rakuco rniwa webkit.review.bot oldest_to_newest 489911 0 t.morawski 2011-10-25 01:13:27 -0700 Calls the ewk_tile_unused_cache_auto_flush function after changing max size of cache when ewk_tile_unused_cache_max_set is called. 489912 1 112304 t.morawski 2011-10-25 01:15:08 -0700 Created attachment 112304 Make cache flush when max size of cache has been changed 489965 2 rakuco 2011-10-25 05:02:33 -0700 Looks OK, but it'd be good to explain what problems are being fixed by the patch. 489969 3 t.morawski 2011-10-25 05:17:59 -0700 (In reply to comment #2) > Looks OK, but it'd be good to explain what problems are being fixed by the patch. OK. Which out of this patch when ewk_tile_unused_cache_max_set was called and max set is lower that old one value. The cache may use more memory than set max value and this is not expected by user of this class. 489976 4 rakuco 2011-10-25 05:28:56 -0700 I see. Could you add this explanation to the ChangeLog? Informal r+ from my side after that. 489998 5 112329 t.morawski 2011-10-25 06:28:53 -0700 Created attachment 112329 Changlog file updated 492265 6 112329 rniwa 2011-10-27 23:30:40 -0700 Comment on attachment 112329 Changlog file updated View in context: https://bugs.webkit.org/attachment.cgi?id=112329&action=review I'm confused. How does this help? ewk_tile_unused_cache_auto_flush has an early exit: if (tileUnusedCache->memory.used <= tileUnusedCache->memory.max) return; so it seems like calling ewk_tile_unused_cache_auto_flush here does't do anything. > Source/WebKit/efl/ewk/ewk_tiled_model.cpp:636 > + size_t oldSize = tileUnusedCache->memory.max; I'd prefer calling it oldMax instead. 492277 7 t.morawski 2011-10-27 23:56:48 -0700 (In reply to comment #6) For example we have a cache that currently store 20MB of data * the tileUnusedCache->memory.used = 20MB and max value is set 40MB tileUnusedCache->memory.max= 40MB Now, a user calls: ewk_tile_unused_cache_max_set(tuc, 10MB) the cache after calling of this function should use only 10MB. Due to that I call ewk_tile_unused_cache_auto_flush to release some memory. The value of used and max will be: > ewk_tile_unused_cache_auto_flush has an early exit: if (tileUnusedCache->memory.used(20MB) <= tileUnusedCache->memory.max(10MB)) return; the "if" condition is false in that situation, so the early exit it not occured in this case and the memory form cache will be released. 493205 8 rniwa 2011-10-31 01:32:20 -0700 (In reply to comment #7) > (In reply to comment #6) > For example we have a cache that currently store 20MB of data > * the tileUnusedCache->memory.used = 20MB > and max value is set 40MB > tileUnusedCache->memory.max= 40MB > > Now, a user calls: > ewk_tile_unused_cache_max_set(tuc, 10MB) > the cache after calling of this function should use only 10MB. Due to that > I call ewk_tile_unused_cache_auto_flush to release some memory. > > The value of used and max will be: > > ewk_tile_unused_cache_auto_flush has an early exit: > if (tileUnusedCache->memory.used(20MB) <= tileUnusedCache->memory.max(10MB)) > return; > > the "if" condition is false in that situation, so the early exit it not occured in this case and the memory form cache will be released. Makes sense. But I'd still prefer calling that variable oldMax than oldSize unless it's really the old size. 493235 9 113031 t.morawski 2011-10-31 03:53:00 -0700 Created attachment 113031 Updated: changed oldSize to oldMax Updated: changed oldSize to oldMax 493539 10 113031 webkit.review.bot 2011-10-31 15:31:31 -0700 Comment on attachment 113031 Updated: changed oldSize to oldMax Clearing flags on attachment: 113031 Committed r98890: <http://trac.webkit.org/changeset/98890> 493540 11 webkit.review.bot 2011-10-31 15:31:36 -0700 All reviewed patches have been landed. Closing bug. 112304 2011-10-25 01:15:08 -0700 2011-10-25 06:28:53 -0700 Make cache flush when max size of cache has been changed max.patch text/plain 1556 t.morawski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCBhMTk4OTIyLi44OTdjOTU5IDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTEtMTAtMjQgIFRvbWFzeiBNb3Jhd3NraSAgPHQubW9yYXdza2lA c2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gTWFrZSBjYWNoZSBmbHVzaCB3aGVuIG1heCBz aXplIG9mIGNhY2hlIGhhcyBiZWVuIGNoYW5nZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTcwODA1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQ2FsbHMgdGhlIGV3a190aWxlX3VudXNlZF9jYWNoZV9hdXRv X2ZsdXNoIGZ1bmN0aW9uIGFmdGVyIGNoYW5naW5nCisgICAgICAgIG1heCBzaXplIG9mIGNhY2hl IHdoZW4gZXdrX3RpbGVfdW51c2VkX2NhY2hlX21heF9zZXQgaXMgY2FsbGVkLgorCisgICAgICAg ICogZXdrL2V3a190aWxlZF9tb2RlbC5jcHA6CisgICAgICAgIChld2tfdGlsZV91bnVzZWRfY2Fj aGVfbWF4X3NldCk6CisKIDIwMTEtMTAtMjQgIEl2YW4gQnJpYW5vICA8aXZhbkBwcm9mdXNpb24u bW9iaT4KIAogICAgICAgICBbRUZMXSBCdWlsZCBmaXguIFJlbmFtZSBhbGwgaW5zdGFuY2VzIG9m IGEgdmFyaWFibGUgd2hlbiBpdCBnZXRzIGNoYW5nZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvZWZsL2V3ay9ld2tfdGlsZWRfbW9kZWwuY3BwIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3 a190aWxlZF9tb2RlbC5jcHAKaW5kZXggZGQ1ZjBkNS4uMmExZmRlYSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9lZmwvZXdrL2V3a190aWxlZF9tb2RlbC5jcHAKKysrIGIvU291cmNlL1dlYktp dC9lZmwvZXdrL2V3a190aWxlZF9tb2RlbC5jcHAKQEAgLTYzMyw3ICs2MzMsMTEgQEAgdm9pZCBl d2tfdGlsZV91bnVzZWRfY2FjaGVfdW5yZWYoRXdrX1RpbGVfVW51c2VkX0NhY2hlKiB0aWxlVW51 c2VkQ2FjaGUpCiB2b2lkIGV3a190aWxlX3VudXNlZF9jYWNoZV9tYXhfc2V0KEV3a19UaWxlX1Vu dXNlZF9DYWNoZSogdGlsZVVudXNlZENhY2hlLCBzaXplX3QgbWF4KQogewogICAgIEVJTkFfU0FG RVRZX09OX05VTExfUkVUVVJOKHRpbGVVbnVzZWRDYWNoZSk7CisgICAgc2l6ZV90IG9sZFNpemUg PSB0aWxlVW51c2VkQ2FjaGUtPm1lbW9yeS5tYXg7CiAgICAgdGlsZVVudXNlZENhY2hlLT5tZW1v cnkubWF4ID0gbWF4OworICAgIC8qIENhY2hlIGZsdXNoIHdoZW4gbmV3IG1heCBpcyBsb3dlciB0 aGVuIG9sZCBvbmUgKi8KKyAgICBpZiAob2xkU2l6ZSA+IG1heCkKKyAgICAgICAgZXdrX3RpbGVf dW51c2VkX2NhY2hlX2F1dG9fZmx1c2godGlsZVVudXNlZENhY2hlKTsKIH0KIAogc2l6ZV90IGV3 a190aWxlX3VudXNlZF9jYWNoZV9tYXhfZ2V0KGNvbnN0IEV3a19UaWxlX1VudXNlZF9DYWNoZSog dGlsZVVudXNlZENhY2hlKQo= 112329 2011-10-25 06:28:53 -0700 2011-10-31 03:53:00 -0700 Changlog file updated patch2.patch text/plain 1738 t.morawski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCBhMTk4OTIyLi4wZTgyYWJmIDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTEtMTAtMjQgIFRvbWFzeiBNb3Jhd3NraSAgPHQubW9yYXdza2lA c2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gTWFrZSBjYWNoZSBmbHVzaCB3aGVuIG1heCBz aXplIG9mIGNhY2hlIGhhcyBiZWVuIGNoYW5nZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTcwODA1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQ2FsbHMgdGhlIGV3a190aWxlX3VudXNlZF9jYWNoZV9hdXRv X2ZsdXNoIGZ1bmN0aW9uIGFmdGVyIGNoYW5naW5nIG1heAorICAgICAgICBzaXplIG9mIGNhY2hl IHdoZW4gZXdrX3RpbGVfdW51c2VkX2NhY2hlX21heF9zZXQgaXMgY2FsbGVkLiBXaXRob3V0Cisg ICAgICAgIHRoaXMgY2hhbmdlIHdoZW4gbmV3IHZhbHVlIGlzIGxvd2VyIHRoYW4gdGhlIG9sZCBv bmUgdGhlIGNhY2hlIG1heSB1c2UKKyAgICAgICAgbW9yZSBtZW1vcnkgdGhhbiBtYXggdmFsdWUg c2V0LiBUaGlzIHNpdHVhdGlvbiBpcyBub3QgZXhwZWN0ZWQgYnkgdGhlCisgICAgICAgIHVzZXIu CisKKyAgICAgICAgKiBld2svZXdrX3RpbGVkX21vZGVsLmNwcDoKKyAgICAgICAgKGV3a190aWxl X3VudXNlZF9jYWNoZV9tYXhfc2V0KToKKwogMjAxMS0xMC0yNCAgSXZhbiBCcmlhbm8gIDxpdmFu QHByb2Z1c2lvbi5tb2JpPgogCiAgICAgICAgIFtFRkxdIEJ1aWxkIGZpeC4gUmVuYW1lIGFsbCBp bnN0YW5jZXMgb2YgYSB2YXJpYWJsZSB3aGVuIGl0IGdldHMgY2hhbmdlZApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9lZmwvZXdrL2V3a190aWxlZF9tb2RlbC5jcHAgYi9Tb3VyY2UvV2ViS2l0 L2VmbC9ld2svZXdrX3RpbGVkX21vZGVsLmNwcAppbmRleCBkZDVmMGQ1Li4yYTFmZGVhIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3RpbGVkX21vZGVsLmNwcAorKysgYi9T b3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3RpbGVkX21vZGVsLmNwcApAQCAtNjMzLDcgKzYzMywx MSBAQCB2b2lkIGV3a190aWxlX3VudXNlZF9jYWNoZV91bnJlZihFd2tfVGlsZV9VbnVzZWRfQ2Fj aGUqIHRpbGVVbnVzZWRDYWNoZSkKIHZvaWQgZXdrX3RpbGVfdW51c2VkX2NhY2hlX21heF9zZXQo RXdrX1RpbGVfVW51c2VkX0NhY2hlKiB0aWxlVW51c2VkQ2FjaGUsIHNpemVfdCBtYXgpCiB7CiAg ICAgRUlOQV9TQUZFVFlfT05fTlVMTF9SRVRVUk4odGlsZVVudXNlZENhY2hlKTsKKyAgICBzaXpl X3Qgb2xkU2l6ZSA9IHRpbGVVbnVzZWRDYWNoZS0+bWVtb3J5Lm1heDsKICAgICB0aWxlVW51c2Vk Q2FjaGUtPm1lbW9yeS5tYXggPSBtYXg7CisgICAgLyogQ2FjaGUgZmx1c2ggd2hlbiBuZXcgbWF4 IGlzIGxvd2VyIHRoZW4gb2xkIG9uZSAqLworICAgIGlmIChvbGRTaXplID4gbWF4KQorICAgICAg ICBld2tfdGlsZV91bnVzZWRfY2FjaGVfYXV0b19mbHVzaCh0aWxlVW51c2VkQ2FjaGUpOwogfQog CiBzaXplX3QgZXdrX3RpbGVfdW51c2VkX2NhY2hlX21heF9nZXQoY29uc3QgRXdrX1RpbGVfVW51 c2VkX0NhY2hlKiB0aWxlVW51c2VkQ2FjaGUpCg== 113031 2011-10-31 03:53:00 -0700 2011-10-31 15:31:31 -0700 Updated: changed oldSize to oldMax newpatch.patch text/plain 1739 t.morawski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCBiZDU5ZmMxLi45MmVhNWZhIDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTEtMTAtMzEgIFRvbWFzeiBNb3Jhd3NraSAgPHQubW9yYXdza2lA c2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gTWFrZSBjYWNoZSBmbHVzaCB3aGVuIG1heCBz aXplIG9mIGNhY2hlIGhhcyBiZWVuIGNoYW5nZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTcwODA1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQ2FsbHMgdGhlIGV3a190aWxlX3VudXNlZF9jYWNoZV9hdXRv X2ZsdXNoIGZ1bmN0aW9uIGFmdGVyIGNoYW5naW5nIG1heAorICAgICAgICBzaXplIG9mIGNhY2hl IHdoZW4gZXdrX3RpbGVfdW51c2VkX2NhY2hlX21heF9zZXQgaXMgY2FsbGVkLiBXaXRob3V0Cisg ICAgICAgIHRoaXMgY2hhbmdlIHdoZW4gbmV3IHZhbHVlIGlzIGxvd2VyIHRoYW4gdGhlIG9sZCBv bmUgdGhlIGNhY2hlIG1heSB1c2UKKyAgICAgICAgbW9yZSBtZW1vcnkgdGhhbiBtYXggdmFsdWUg c2V0LiBUaGlzIHNpdHVhdGlvbiBpcyBub3QgZXhwZWN0ZWQgYnkgdGhlCisgICAgICAgIHVzZXIu CisKKyAgICAgICAgKiBld2svZXdrX3RpbGVkX21vZGVsLmNwcDoKKyAgICAgICAgKGV3a190aWxl X3VudXNlZF9jYWNoZV9tYXhfc2V0KToKKwogMjAxMS0xMC0yOCAgSm9jaGVuIEVpc2luZ2VyICA8 am9jaGVuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZW5hbWUgYSBudW1iZXIgb2YgbWV0aG9k cyBtZW50aW9uaW5nIEphdmFTY3JpcHQgdG8ganVzdCBTY3JpcHQgaW5zdGVhZApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a190aWxlZF9tb2RlbC5jcHAgYi9Tb3VyY2UvV2Vi S2l0L2VmbC9ld2svZXdrX3RpbGVkX21vZGVsLmNwcAppbmRleCBkZDVmMGQ1Li5hNzQ3YzkwIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3RpbGVkX21vZGVsLmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3RpbGVkX21vZGVsLmNwcApAQCAtNjMzLDcgKzYz MywxMSBAQCB2b2lkIGV3a190aWxlX3VudXNlZF9jYWNoZV91bnJlZihFd2tfVGlsZV9VbnVzZWRf Q2FjaGUqIHRpbGVVbnVzZWRDYWNoZSkKIHZvaWQgZXdrX3RpbGVfdW51c2VkX2NhY2hlX21heF9z ZXQoRXdrX1RpbGVfVW51c2VkX0NhY2hlKiB0aWxlVW51c2VkQ2FjaGUsIHNpemVfdCBtYXgpCiB7 CiAgICAgRUlOQV9TQUZFVFlfT05fTlVMTF9SRVRVUk4odGlsZVVudXNlZENhY2hlKTsKKyAgICBz aXplX3Qgb2xkTWF4ID0gdGlsZVVudXNlZENhY2hlLT5tZW1vcnkubWF4OwogICAgIHRpbGVVbnVz ZWRDYWNoZS0+bWVtb3J5Lm1heCA9IG1heDsKKyAgICAvKiBDYWNoZSBmbHVzaCB3aGVuIG5ldyBt YXggaXMgbG93ZXIgdGhlbiBvbGQgb25lICovCisgICAgaWYgKG9sZE1heCA+IG1heCkKKyAgICAg ICAgZXdrX3RpbGVfdW51c2VkX2NhY2hlX2F1dG9fZmx1c2godGlsZVVudXNlZENhY2hlKTsKIH0K IAogc2l6ZV90IGV3a190aWxlX3VudXNlZF9jYWNoZV9tYXhfZ2V0KGNvbnN0IEV3a19UaWxlX1Vu dXNlZF9DYWNoZSogdGlsZVVudXNlZENhY2hlKQo=